Skip to content

The agent engineering platform.

langchain[patch]: Allow async indexing code to work for vectorstores that only defined sync delete (#30869)

Shkarupa Alex671e4fd114b3
diff --git a/libs/core/langchain_core/indexing/api.py b/libs/core/langchain_core/indexing/api.py
index 66c4343bb6..7e7b2c3deb 100644
--- a/libs/core/langchain_core/indexing/api.py
+++ b/libs/core/langchain_core/indexing/api.py
@@ -646,10 +646,13 @@ async def aindex(
)
raise ValueError(msg)
- if type(destination).adelete == VectorStore.adelete:
- # Checking if the vectorstore has overridden the default delete method
- # implementation which just raises a NotImplementedError
- msg = "Vectorstore has not implemented the delete method"
+ if (
+ type(destination).adelete == VectorStore.adelete
+ and type(destination).delete == VectorStore.delete
+ ):
+ # Checking if the vectorstore has overridden the default adelete or delete
+ # methods implementation which just raises a NotImplementedError
+ msg = "Vectorstore has not implemented the adelete or delete method"
raise ValueError(msg)
elif isinstance(destination, DocumentIndex):
pass