Skip to content

The agent engineering platform.

docs(infra): add note about `check_diff.py` running on seemingly unrelated PRs (#33323)

Mason Daugherty690b620b7fe4
diff --git a/.github/scripts/check_diff.py b/.github/scripts/check_diff.py
index 5b03c7550e..e57b715166 100644
--- a/.github/scripts/check_diff.py
+++ b/.github/scripts/check_diff.py
@@ -257,7 +257,15 @@ if __name__ == "__main__":
".github/scripts/check_diff.py",
)
):
- # add all LANGCHAIN_DIRS for infra changes
+ # Infrastructure changes (workflows, actions, CI scripts) trigger tests on
+ # all core packages as a safety measure. This ensures that changes to CI/CD
+ # infrastructure don't inadvertently break package testing, even if the change
+ # appears unrelated (e.g., documentation build workflows). This is intentionally
+ # conservative to catch unexpected side effects from workflow modifications.
+ #
+ # Example: A PR modifying .github/workflows/api_doc_build.yml will trigger
+ # lint/test jobs for libs/core, libs/text-splitters, libs/langchain, and
+ # libs/langchain_v1, even though the workflow may only affect documentation.
dirs_to_run["extended-test"].update(LANGCHAIN_DIRS)
if file.startswith("libs/core"):