Skip to content

The agent engineering platform.

core: dont mutate tool_kwargs during tool run (#28824)

Erick Friis6a37899b39fb
diff --git a/libs/core/langchain_core/tools/base.py b/libs/core/langchain_core/tools/base.py
index cf75528461..625d532da3 100644
--- a/libs/core/langchain_core/tools/base.py
+++ b/libs/core/langchain_core/tools/base.py
@@ -687,9 +687,9 @@ class ChildTool(BaseTool):
context.run(_set_config_context, child_config)
tool_args, tool_kwargs = self._to_args_and_kwargs(tool_input, tool_call_id)
if signature(self._run).parameters.get("run_manager"):
- tool_kwargs["run_manager"] = run_manager
+ tool_kwargs = tool_kwargs | {"run_manager": run_manager}
if config_param := _get_runnable_config_param(self._run):
- tool_kwargs[config_param] = config
+ tool_kwargs = tool_kwargs | {config_param: config}
response = context.run(self._run, *tool_args, **tool_kwargs)
if self.response_format == "content_and_artifact":
if not isinstance(response, tuple) or len(response) != 2:
diff --git a/libs/core/tests/unit_tests/test_tools.py b/libs/core/tests/unit_tests/test_tools.py
index b21fc139a2..c0d8c962dd 100644
--- a/libs/core/tests/unit_tests/test_tools.py
+++ b/libs/core/tests/unit_tests/test_tools.py
@@ -2268,3 +2268,20 @@ def test_tool_return_output_mixin() -> None:
assert foo.invoke(
{"type": "tool_call", "args": {"x": 0}, "name": "foo", "id": "bar"}
) == Bar(x=0)
+
+
+def test_tool_mutate_input() -> None:
+ class MyTool(BaseTool):
+ name: str = "MyTool"
+ description: str = "a tool"
+
+ def _run(
+ self,
+ x: str,
+ run_manager: Optional[CallbackManagerForToolRun] = None,
+ ) -> str:
+ return "hi"
+
+ my_input = {"x": "hi"}
+ MyTool().invoke(my_input)
+ assert my_input == {"x": "hi"}