The agent engineering platform.
Python agentsaiai-agentsanthropicchatgptdeepagentsenterpriseframeworkgeminigenerative-ailangchainlanggraphllmmultiagentopen-sourceopenaipydanticpythonragtypescript
core: Add ruff rules S110 and S112 (#30599)
Christophe Bornet768e4f695a5f
diff --git a/libs/core/langchain_core/load/serializable.py b/libs/core/langchain_core/load/serializable.pyindex a9a031823e..9da23152f6 100644--- a/libs/core/langchain_core/load/serializable.py+++ b/libs/core/langchain_core/load/serializable.py@@ -1,6 +1,7 @@"""Serializable base class."""import contextlib+import loggingfrom abc import ABCfrom typing import (Any,@@ -15,6 +16,8 @@ from pydantic import BaseModel, ConfigDictfrom pydantic.fields import FieldInfofrom typing_extensions import NotRequired, override+logger = logging.getLogger(__name__)+class BaseSerialized(TypedDict):"""Base class for serialized objects.@@ -359,7 +362,7 @@ def to_json_not_implemented(obj: object) -> SerializedNotImplemented:elif hasattr(obj, "__class__"):_id = [*obj.__class__.__module__.split("."), obj.__class__.__name__]except Exception:- pass+ logger.debug("Failed to serialize object", exc_info=True)result: SerializedNotImplemented = {"lc": 1,diff --git a/libs/core/langchain_core/messages/ai.py b/libs/core/langchain_core/messages/ai.pyindex 46c838ab48..46e14bf757 100644--- a/libs/core/langchain_core/messages/ai.py+++ b/libs/core/langchain_core/messages/ai.py@@ -1,6 +1,7 @@"""AI message."""import json+import loggingimport operatorfrom typing import Any, Literal, Optional, Union, cast@@ -32,6 +33,8 @@ from langchain_core.utils._merge import merge_dicts, merge_listsfrom langchain_core.utils.json import parse_partial_jsonfrom langchain_core.utils.usage import _dict_int_op+logger = logging.getLogger(__name__)+class InputTokenDetails(TypedDict, total=False):"""Breakdown of input token counts.@@ -210,7 +213,7 @@ class AIMessage(BaseMessage):values["tool_calls"] = parsed_tool_callsvalues["invalid_tool_calls"] = parsed_invalid_tool_callsexcept Exception:- pass+ logger.debug("Failed to parse tool calls", exc_info=True)# Ensure "type" is properly set on all tool call-like dicts.if tool_calls := values.get("tool_calls"):diff --git a/libs/core/langchain_core/sys_info.py b/libs/core/langchain_core/sys_info.pyindex 6520e0b99d..38d53e159b 100644--- a/libs/core/langchain_core/sys_info.py+++ b/libs/core/langchain_core/sys_info.py@@ -20,11 +20,7 @@ def _get_sub_deps(packages: Sequence[str]) -> list[str]:continuefor req in required:- try:- cleaned_req = req.split(" ")[0]- except Exception: # In case parsing of requirement spec fails- continue-+ cleaned_req = req.split(" ")[0]if cleaned_req.replace("-", "_") not in _underscored_packages:sub_deps.add(cleaned_req)diff --git a/libs/core/pyproject.toml b/libs/core/pyproject.tomlindex 93f3494d99..28557c31c3 100644--- a/libs/core/pyproject.toml+++ b/libs/core/pyproject.toml@@ -107,8 +107,6 @@ ignore = ["PYI","RET","RUF",- "S110",- "S112","SLF","TD",]