Skip to content

The agent engineering platform.

[Core] Add more interops tests (#26841)

William FH82b5b77940e9
diff --git a/libs/core/langchain_core/callbacks/manager.py b/libs/core/langchain_core/callbacks/manager.py
index 1f1c2cd8f4..c3214ea112 100644
--- a/libs/core/langchain_core/callbacks/manager.py
+++ b/libs/core/langchain_core/callbacks/manager.py
@@ -2333,7 +2333,11 @@ def _configure(
try:
handler = LangChainTracer(
project_name=tracer_project,
- client=run_tree.client if run_tree is not None else None,
+ client=(
+ run_tree.client
+ if run_tree is not None
+ else tracing_context["client"]
+ ),
)
callback_manager.add_handler(handler, True)
except Exception as e:
diff --git a/libs/core/langchain_core/tracers/core.py b/libs/core/langchain_core/tracers/core.py
index f4d7bbdccb..0cadbf44ba 100644
--- a/libs/core/langchain_core/tracers/core.py
+++ b/libs/core/langchain_core/tracers/core.py
@@ -118,7 +118,7 @@ class _TracerCore(ABC):
self._add_child_run(parent_run, run)
else:
if self.log_missing_parent:
- logger.warning(
+ logger.debug(
f"Parent run {run.parent_run_id} not found for run {run.id}."
" Treating as a root run."
)
diff --git a/libs/core/langchain_core/tracers/langchain.py b/libs/core/langchain_core/tracers/langchain.py
index 09c053f9bc..e04fccaa10 100644
--- a/libs/core/langchain_core/tracers/langchain.py
+++ b/libs/core/langchain_core/tracers/langchain.py
@@ -123,7 +123,7 @@ class LangChainTracer(BaseTracer):
super()._start_trace(run)
if run._client is None:
- run._client = self.client
+ run._client = self.client # type: ignore
def on_chat_model_start(
self,
diff --git a/libs/core/tests/unit_tests/runnables/test_tracing_interops.py b/libs/core/tests/unit_tests/runnables/test_tracing_interops.py
index b6318ef5b3..3054b04f89 100644
--- a/libs/core/tests/unit_tests/runnables/test_tracing_interops.py
+++ b/libs/core/tests/unit_tests/runnables/test_tracing_interops.py
@@ -10,6 +10,7 @@ from langsmith import Client, get_current_run_tree, traceable
from langsmith.run_helpers import tracing_context
from langsmith.run_trees import RunTree
from langsmith.utils import get_env_var
+from typing_extensions import Literal
from langchain_core.runnables.base import RunnableLambda, RunnableParallel
from langchain_core.tracers.langchain import LangChainTracer
@@ -361,7 +362,8 @@ async def test_runnable_sequence_parallel_trace_nesting(method: str) -> None:
assert dotted_order.split(".")[0] == dotted_order
-def test_tree_is_constructed() -> None:
[email protected]("parent_type", ("ls", "lc"))
+def test_tree_is_constructed(parent_type: Literal["ls", "lc"]) -> None:
mock_session = MagicMock()
mock_client_ = Client(
session=mock_session, api_key="test", auto_batch_tracing=False
@@ -379,27 +381,39 @@ def test_tree_is_constructed() -> None:
def child(x: str) -> str:
return grandchild.invoke(x)
- @traceable
- def parent() -> str:
- return child.invoke("foo")
-
- collected: dict[str, RunTree] = {} # noqa
-
- def collect_run(run: RunTree) -> None:
- collected[str(run.id)] = run
-
rid = uuid.uuid4()
-
with tracing_context(
client=mock_client_,
enabled=True,
metadata={"some_foo": "some_bar"},
tags=["afoo"],
):
- assert parent(langsmith_extra={"on_end": collect_run, "run_id": rid}) == "foo"
+ if parent_type == "ls":
+ collected: dict[str, RunTree] = {} # noqa
+
+ def collect_run(run: RunTree) -> None:
+ collected[str(run.id)] = run
+
+ @traceable
+ def parent() -> str:
+ return child.invoke("foo")
+
+ assert (
+ parent(langsmith_extra={"on_end": collect_run, "run_id": rid}) == "foo"
+ )
+ assert collected
+ run = collected.get(str(rid))
+
+ else:
+
+ @RunnableLambda
+ def parent(_) -> str: # type: ignore
+ return child.invoke("foo")
+
+ tracer = LangChainTracer()
+ assert parent.invoke(..., {"run_id": rid, "callbacks": [tracer]}) == "foo" # type: ignore
+ run = tracer.latest_run
- assert collected
- run = collected.get(str(rid))
assert run is not None
assert run.name == "parent"
assert run.child_runs
diff --git a/libs/core/tests/unit_tests/tracers/test_langchain.py b/libs/core/tests/unit_tests/tracers/test_langchain.py
index a8c897615a..7e03717bd0 100644
--- a/libs/core/tests/unit_tests/tracers/test_langchain.py
+++ b/libs/core/tests/unit_tests/tracers/test_langchain.py
@@ -65,7 +65,7 @@ def test_example_id_assignment_threadsafe() -> None:
def test_tracer_with_run_tree_parent() -> None:
mock_session = unittest.mock.MagicMock()
client = Client(session=mock_session, api_key="test")
- parent = RunTree(name="parent", inputs={"input": "foo"}, _client=client)
+ parent = RunTree(name="parent", inputs={"input": "foo"}, _client=client) # type: ignore
run_id = uuid.uuid4()
tracer = LangChainTracer(client=client)
tracer.order_map[parent.id] = (parent.trace_id, parent.dotted_order)