Skip to content

The agent engineering platform.

style(langchain): fix some ruff preview rules (#34504)

Christophe Bornet88b5f22f1c69
diff --git a/libs/langchain_v1/langchain/agents/factory.py b/libs/langchain_v1/langchain/agents/factory.py
index ddc5a9d89a..757519317b 100644
--- a/libs/langchain_v1/langchain/agents/factory.py
+++ b/libs/langchain_v1/langchain/agents/factory.py
@@ -314,7 +314,7 @@ def _resolve_schema(schemas: set[type], schema_name: str, omit_flag: str | None
def _extract_metadata(type_: type) -> list:
"""Extract metadata from a field type, handling Required/NotRequired and Annotated wrappers."""
# Handle Required[Annotated[...]] or NotRequired[Annotated[...]]
- if get_origin(type_) in (Required, NotRequired):
+ if get_origin(type_) in {Required, NotRequired}:
inner_type = get_args(type_)[0]
if get_origin(inner_type) is Annotated:
return list(get_args(inner_type)[1:])
@@ -937,8 +937,7 @@ def create_agent(
tool_message_content = (
effective_response_format.tool_message_content
- if effective_response_format.tool_message_content
- else f"Returning structured response: {structured_response}"
+ or f"Returning structured response: {structured_response}"
)
return {
diff --git a/libs/langchain_v1/langchain/agents/middleware/_redaction.py b/libs/langchain_v1/langchain/agents/middleware/_redaction.py
index c2d2c95971..50a0b5e35d 100644
--- a/libs/langchain_v1/langchain/agents/middleware/_redaction.py
+++ b/libs/langchain_v1/langchain/agents/middleware/_redaction.py
@@ -4,6 +4,7 @@ from __future__ import annotations
import hashlib
import ipaddress
+import operator
import re
from collections.abc import Callable, Sequence
from dataclasses import dataclass
@@ -127,7 +128,7 @@ def detect_url(content: str) -> list[PIIMatch]:
for match in re.finditer(scheme_pattern, content):
url = match.group()
result = urlparse(url)
- if result.scheme in ("http", "https") and result.netloc:
+ if result.scheme in {"http", "https"} and result.netloc:
matches.append(
PIIMatch(
type="url",
@@ -202,7 +203,7 @@ def _passes_luhn(card_number: str) -> bool:
def _apply_redact_strategy(content: str, matches: list[PIIMatch]) -> str:
result = content
- for match in sorted(matches, key=lambda item: item["start"], reverse=True):
+ for match in sorted(matches, key=operator.itemgetter("start"), reverse=True):
replacement = f"[REDACTED_{match['type'].upper()}]"
result = result[: match["start"]] + replacement + result[match["end"] :]
return result
@@ -214,7 +215,7 @@ _IPV4_PARTS_NUMBER = 4
def _apply_mask_strategy(content: str, matches: list[PIIMatch]) -> str:
result = content
- for match in sorted(matches, key=lambda item: item["start"], reverse=True):
+ for match in sorted(matches, key=operator.itemgetter("start"), reverse=True):
value = match["value"]
pii_type = match["type"]
if pii_type == "email":
@@ -260,7 +261,7 @@ def _apply_mask_strategy(content: str, matches: list[PIIMatch]) -> str:
def _apply_hash_strategy(content: str, matches: list[PIIMatch]) -> str:
result = content
- for match in sorted(matches, key=lambda item: item["start"], reverse=True):
+ for match in sorted(matches, key=operator.itemgetter("start"), reverse=True):
digest = hashlib.sha256(match["value"].encode()).hexdigest()[:8]
replacement = f"<{match['type']}_hash:{digest}>"
result = result[: match["start"]] + replacement + result[match["end"] :]
diff --git a/libs/langchain_v1/langchain/agents/middleware/_retry.py b/libs/langchain_v1/langchain/agents/middleware/_retry.py
index 6139abb0bb..961d00813a 100644
--- a/libs/langchain_v1/langchain/agents/middleware/_retry.py
+++ b/libs/langchain_v1/langchain/agents/middleware/_retry.py
@@ -116,7 +116,7 @@ def calculate_delay(
if jitter and delay > 0:
jitter_amount = delay * 0.25 # ±25% jitter
- delay = delay + random.uniform(-jitter_amount, jitter_amount) # noqa: S311
+ delay += random.uniform(-jitter_amount, jitter_amount) # noqa: S311
# Ensure delay is not negative after jitter
delay = max(0, delay)
diff --git a/libs/langchain_v1/langchain/agents/middleware/model_call_limit.py b/libs/langchain_v1/langchain/agents/middleware/model_call_limit.py
index cb7810e53f..2085045a98 100644
--- a/libs/langchain_v1/langchain/agents/middleware/model_call_limit.py
+++ b/libs/langchain_v1/langchain/agents/middleware/model_call_limit.py
@@ -148,7 +148,7 @@ class ModelCallLimitMiddleware(AgentMiddleware[ModelCallLimitState, Any]):
msg = "At least one limit must be specified (thread_limit or run_limit)"
raise ValueError(msg)
- if exit_behavior not in ("end", "error"):
+ if exit_behavior not in {"end", "error"}:
msg = f"Invalid exit_behavior: {exit_behavior}. Must be 'end' or 'error'"
raise ValueError(msg)
diff --git a/libs/langchain_v1/langchain/agents/middleware/shell_tool.py b/libs/langchain_v1/langchain/agents/middleware/shell_tool.py
index 7efe48c719..15f561127c 100644
--- a/libs/langchain_v1/langchain/agents/middleware/shell_tool.py
+++ b/libs/langchain_v1/langchain/agents/middleware/shell_tool.py
@@ -605,7 +605,7 @@ class ShellToolMiddleware(AgentMiddleware[ShellToolState, Any]):
return
for command in self._startup_commands:
result = session.execute(command, timeout=self._execution_policy.startup_timeout)
- if result.timed_out or (result.exit_code not in (0, None)):
+ if result.timed_out or (result.exit_code not in {0, None}):
msg = f"Startup command '{command}' failed with exit code {result.exit_code}"
raise RuntimeError(msg)
@@ -617,7 +617,7 @@ class ShellToolMiddleware(AgentMiddleware[ShellToolState, Any]):
result = session.execute(command, timeout=self._execution_policy.command_timeout)
if result.timed_out:
LOGGER.warning("Shutdown command '%s' timed out.", command)
- elif result.exit_code not in (0, None):
+ elif result.exit_code not in {0, None}:
LOGGER.warning(
"Shutdown command '%s' exited with %s.", command, result.exit_code
)
@@ -708,7 +708,7 @@ class ShellToolMiddleware(AgentMiddleware[ShellToolState, Any]):
f"(observed {result.total_bytes})."
)
- if result.exit_code not in (0, None):
+ if result.exit_code not in {0, None}:
sanitized_output = f"{sanitized_output.rstrip()}\n\nExit code: {result.exit_code}"
final_status: Literal["success", "error"] = "error"
else:
diff --git a/libs/langchain_v1/langchain/agents/middleware/tool_call_limit.py b/libs/langchain_v1/langchain/agents/middleware/tool_call_limit.py
index 749d0e5eaf..3df165be5c 100644
--- a/libs/langchain_v1/langchain/agents/middleware/tool_call_limit.py
+++ b/libs/langchain_v1/langchain/agents/middleware/tool_call_limit.py
@@ -361,7 +361,7 @@ class ToolCallLimitMiddleware(
return None
# Get the count key for this middleware instance
- count_key = self.tool_name if self.tool_name else "__all__"
+ count_key = self.tool_name or "__all__"
# Get current counts
thread_counts = state.get("thread_tool_call_count", {}).copy()
diff --git a/libs/langchain_v1/langchain/agents/middleware/types.py b/libs/langchain_v1/langchain/agents/middleware/types.py
index eefdb7c457..b1ec4320e4 100644
--- a/libs/langchain_v1/langchain/agents/middleware/types.py
+++ b/libs/langchain_v1/langchain/agents/middleware/types.py
@@ -270,7 +270,7 @@ class ModelResponse:
# Type alias for middleware return type - allows returning either full response or just AIMessage
-ModelCallResult: TypeAlias = "ModelResponse | AIMessage"
+ModelCallResult: TypeAlias = ModelResponse | AIMessage
"""`TypeAlias` for model call handler return value.
Middleware can return either:
@@ -1228,7 +1228,10 @@ def before_agent(
async def notify_start(state: AgentState, runtime: Runtime) -> None:
'''Notify user that agent is starting.'''
runtime.stream_writer(
- {"type": "status", "message": "Initializing agent session..."}
+ {
+ "type": "status",
+ "message": "Initializing agent session...",
+ }
)
# Perform prerequisite tasks here
runtime.stream_writer({"type": "status", "message": "Agent ready!"})
diff --git a/libs/langchain_v1/langchain/chat_models/base.py b/libs/langchain_v1/langchain/chat_models/base.py
index f8eb3dd87f..fb653de3b5 100644
--- a/libs/langchain_v1/langchain/chat_models/base.py
+++ b/libs/langchain_v1/langchain/chat_models/base.py
@@ -554,8 +554,12 @@ def _attempt_infer_model_provider(model_name: str) -> str | None:
def _parse_model(model: str, model_provider: str | None) -> tuple[str, str]:
"""Parse model name and provider, inferring provider if necessary."""
# Handle provider:model format
- if not model_provider and ":" in model and model.split(":")[0] in _SUPPORTED_PROVIDERS:
- model_provider = model.split(":")[0]
+ if (
+ not model_provider
+ and ":" in model
+ and model.split(":", maxsplit=1)[0] in _SUPPORTED_PROVIDERS
+ ):
+ model_provider = model.split(":", maxsplit=1)[0]
model = ":".join(model.split(":")[1:])
# Attempt to infer provider if not specified
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_framework.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_framework.py
index 418742b9af..5c904188b3 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_framework.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_framework.py
@@ -441,7 +441,10 @@ agent = create_agent(
def test_injected_state_in_middleware_agent() -> None:
"""Test that custom state is properly injected into tools when using middleware."""
result = agent.invoke(
- {"custom_state": "I love pizza", "messages": [HumanMessage("Call the test state tool")]}
+ {
+ "custom_state": "I love pizza",
+ "messages": [HumanMessage("Call the test state tool")],
+ }
)
messages = result["messages"]
@@ -777,6 +780,7 @@ class TestAgentMiddlewareHooks:
execution_log.append(f"{hook_type}_agent_called")
execution_log.append(f"message_count: {len(state['messages'])}")
return None
+
else:
@after_agent
@@ -784,6 +788,7 @@ class TestAgentMiddlewareHooks:
execution_log.append(f"{hook_type}_agent_called")
execution_log.append(f"message_count: {len(state['messages'])}")
return None
+
elif hook_type == "before":
@before_agent
@@ -791,6 +796,7 @@ class TestAgentMiddlewareHooks:
execution_log.append(f"{hook_type}_agent_called")
execution_log.append(f"message_count: {len(state['messages'])}")
return None
+
else:
@after_agent
@@ -828,6 +834,7 @@ class TestAgentMiddlewareHooks:
if hook_type == "after":
execution_log.append("hook_called")
return None
+
else:
class CustomMiddleware(AgentMiddleware):
@@ -870,6 +877,7 @@ class TestAgentHooksCombined:
@after_agent
async def log_after(state: AgentState, runtime) -> None:
execution_log.append("after")
+
else:
@before_agent
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_tools.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_tools.py
index 08486d04d9..4a22a34ae1 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_tools.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_tools.py
@@ -79,7 +79,7 @@ def test_middleware_can_modify_tools() -> None:
handler: Callable[[ModelRequest], AIMessage],
) -> AIMessage:
# Only allow tool_a and tool_b
- filtered_tools = [t for t in request.tools if t.name in ["tool_a", "tool_b"]]
+ filtered_tools = [t for t in request.tools if t.name in {"tool_a", "tool_b"}]
return handler(request.override(tools=filtered_tools))
# Model will try to call tool_a
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_context_editing.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_context_editing.py
index 900cf6978b..e6349ebfcd 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_context_editing.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_context_editing.py
@@ -162,13 +162,15 @@ def test_respects_keep_last_tool_results() -> None:
]
for call_id, text in edits:
- conversation.append(
- AIMessage(
- content="",
- tool_calls=[{"id": call_id, "name": "tool", "args": {"input": call_id}}],
+ conversation.extend(
+ (
+ AIMessage(
+ content="",
+ tool_calls=[{"id": call_id, "name": "tool", "args": {"input": call_id}}],
+ ),
+ ToolMessage(content=text, tool_call_id=call_id),
)
)
- conversation.append(ToolMessage(content=text, tool_call_id=call_id))
_state, request = _make_state_and_request(conversation)
@@ -355,13 +357,15 @@ async def test_respects_keep_last_tool_results_async() -> None:
]
for call_id, text in edits:
- conversation.append(
- AIMessage(
- content="",
- tool_calls=[{"id": call_id, "name": "tool", "args": {"input": call_id}}],
+ conversation.extend(
+ (
+ AIMessage(
+ content="",
+ tool_calls=[{"id": call_id, "name": "tool", "args": {"input": call_id}}],
+ ),
+ ToolMessage(content=text, tool_call_id=call_id),
)
)
- conversation.append(ToolMessage(content=text, tool_call_id=call_id))
_state, request = _make_state_and_request(conversation)
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_summarization.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_summarization.py
index d501f38201..ce5ff5c1ee 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_summarization.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_summarization.py
@@ -168,7 +168,7 @@ def test_summarization_middleware_trim_limit_none_keeps_all_messages() -> None:
model=MockChatModel(),
trim_tokens_to_summarize=None,
)
- middleware.token_counter = lambda msgs: len(msgs)
+ middleware.token_counter = len
trimmed = middleware._trim_messages_for_summary(messages)
assert trimmed is messages