Skip to content

The agent engineering platform.

fix(core): compat with pydantic 2.14 (#39328)

ccurme9f738f5297d1
diff --git a/libs/core/langchain_core/load/serializable.py b/libs/core/langchain_core/load/serializable.py
index 4764282655..753e9feb82 100644
--- a/libs/core/langchain_core/load/serializable.py
+++ b/libs/core/langchain_core/load/serializable.py
@@ -12,6 +12,7 @@ from typing import (
from pydantic import BaseModel, ConfigDict
from pydantic.fields import FieldInfo
+from pydantic_core import PydanticUndefined
from typing_extensions import NotRequired, override
logger = logging.getLogger(__name__)
@@ -70,14 +71,31 @@ def try_neq_default(value: Any, key: str, model: BaseModel) -> bool:
return _try_neq_default(value, field)
+def _get_field_default(field: FieldInfo) -> Any:
+ # Pydantic 2.14+ returns ``PydanticUndefined`` (rather than ``None``) from
+ # ``get_default()`` for an un-called ``default_factory``. Restore the historical
+ # ``None`` so a factory-defaulted field at its default is still treated as
+ # unchanged. The factory is intentionally not called: ``get_default()`` keeps
+ # ``call_default_factory=False`` precisely because factories may have side effects.
+ default = field.get_default()
+ if default is PydanticUndefined and field.default_factory is not None:
+ return None
+ return default
+
+
def _try_neq_default(value: Any, field: FieldInfo) -> bool:
# Handle edge case: inequality of two objects does not evaluate to a bool (e.g. two
# Pandas DataFrames).
try:
- return bool(field.get_default() != value)
+ default = _get_field_default(field)
+ except Exception as _:
+ # A raising default_factory means we cannot compare; treat as non-default.
+ return True
+ try:
+ return bool(default != value)
except Exception as _:
try:
- return all(field.get_default() != value)
+ return all(default != value)
except Exception as _:
try:
return value is not field.default
diff --git a/libs/core/tests/unit_tests/load/test_serializable.py b/libs/core/tests/unit_tests/load/test_serializable.py
index 4e4b08f2fc..00cb1c3454 100644
--- a/libs/core/tests/unit_tests/load/test_serializable.py
+++ b/libs/core/tests/unit_tests/load/test_serializable.py
@@ -5,6 +5,8 @@ from typing import Any
import pytest
from pydantic import BaseModel, ConfigDict, Field, SecretStr
+from pydantic.fields import FieldInfo
+from pydantic_core import PydanticUndefined
from langchain_core._api import LangChainDeprecationWarning
from langchain_core._api.deprecation import LangChainPendingDeprecationWarning
@@ -13,7 +15,7 @@ from langchain_core.load import InitValidator, Serializable, dumpd, dumps, load,
from langchain_core.load.load import (
_get_default_allowed_class_paths,
)
-from langchain_core.load.serializable import _is_field_useful
+from langchain_core.load.serializable import _is_field_useful, _try_neq_default
from langchain_core.messages import AIMessage
from langchain_core.outputs import ChatGeneration, Generation
from langchain_core.prompts import (
@@ -23,6 +25,7 @@ from langchain_core.prompts import (
)
from langchain_core.runnables.history import RunnableWithMessageHistory
from langchain_core.tracers import log_stream
+from langchain_core.utils import from_env
OPENAI_TEST_MODEL = "gpt-5.5"
@@ -144,6 +147,62 @@ def test__is_field_useful() -> None:
assert not _is_field_useful(foo, "y", foo.y)
+def test_try_neq_default_none_factory(monkeypatch: pytest.MonkeyPatch) -> None:
+ """An env-backed `default_factory` at its `None` default is not flagged as changed.
+
+ Mirrors the real `output_version` field on chat models
+ (`Field(default_factory=from_env(..., default=None))`). Regression test for issue
+ #39157.
+ """
+ monkeypatch.delenv("LC_TEST_OUTPUT_VERSION", raising=False)
+
+ class Model(BaseModel):
+ none_factory: str | None = Field(
+ default_factory=from_env("LC_TEST_OUTPUT_VERSION", default=None)
+ )
+
+ field = Model.model_fields["none_factory"]
+ assert not _try_neq_default(None, field)
+ assert _try_neq_default("set", field)
+
+
+def test_try_neq_default_simulating_pydantic_2_14(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ """A `None`-factory default is still recognized when `get_default()` is undefined.
+
+ Pydantic 2.14+ returns `PydanticUndefined` (instead of `None`) for an un-called
+ `default_factory`; this forces that behavior on the current pydantic. The factory
+ must not be invoked, so the sentinel is mapped back to `None` for comparison.
+ """
+ monkeypatch.delenv("LC_TEST_OUTPUT_VERSION", raising=False)
+
+ called = False
+
+ def _factory() -> None:
+ nonlocal called
+ called = True
+
+ class Model(BaseModel):
+ none_factory: str | None = Field(default_factory=_factory)
+
+ real_get_default = FieldInfo.get_default
+
+ def fake_get_default(self: FieldInfo, **kwargs: Any) -> Any:
+ if self.default_factory is not None and not kwargs.get("call_default_factory"):
+ return PydanticUndefined
+ return real_get_default(self, **kwargs)
+
+ monkeypatch.setattr(FieldInfo, "get_default", fake_get_default)
+
+ field = Model.model_fields["none_factory"]
+ assert field.get_default() is PydanticUndefined
+ assert not _try_neq_default(None, field)
+ assert _try_neq_default("set", field)
+ # The factory must never be re-executed during comparison (possible side effects).
+ assert called is False
+
+
class Foo(Serializable):
bar: int
baz: str