Skip to content

The agent engineering platform.

fix(core): override streaming callback if streaming attribute is set (#33351)

ccurmea3e4f4c2e38b
diff --git a/libs/core/langchain_core/language_models/chat_models.py b/libs/core/langchain_core/language_models/chat_models.py
index 16ce918baa..091d785fad 100644
--- a/libs/core/langchain_core/language_models/chat_models.py
+++ b/libs/core/langchain_core/language_models/chat_models.py
@@ -470,8 +470,10 @@ class BaseChatModel(BaseLanguageModel[AIMessage], ABC):
if "stream" in kwargs:
return kwargs["stream"]
- if getattr(self, "streaming", False):
- return True
+ if "streaming" in self.model_fields_set:
+ streaming_value = getattr(self, "streaming", None)
+ if isinstance(streaming_value, bool):
+ return streaming_value
# Check if any streaming callback handlers have been passed in.
handlers = run_manager.handlers if run_manager else []
diff --git a/libs/core/tests/unit_tests/language_models/chat_models/test_base.py b/libs/core/tests/unit_tests/language_models/chat_models/test_base.py
index cdcc0fa637..3d8e03b5e7 100644
--- a/libs/core/tests/unit_tests/language_models/chat_models/test_base.py
+++ b/libs/core/tests/unit_tests/language_models/chat_models/test_base.py
@@ -364,6 +364,8 @@ class NoStreamingModel(BaseChatModel):
class StreamingModel(NoStreamingModel):
+ streaming: bool = False
+
@override
def _stream(
self,
@@ -427,6 +429,13 @@ async def test_disable_streaming_async(
).content == expected
+async def test_streaming_attribute_overrides_streaming_callback() -> None:
+ model = StreamingModel(streaming=False)
+ assert (
+ await model.ainvoke([], config={"callbacks": [_AstreamEventsCallbackHandler()]})
+ ).content == "invoke"
+
+
@pytest.mark.parametrize("disable_streaming", [True, False, "tool_calling"])
def test_disable_streaming_no_streaming_model(
*,