The agent engineering platform.
Python agentsaiai-agentsanthropicchatgptdeepagentsenterpriseframeworkgeminigenerative-ailangchainlanggraphllmmultiagentopen-sourceopenaipydanticpythonragtypescript
langchain-prompty[patch]: Add ruff bandit rules to linter (#31814)
Mason Daughertyb03e32623169
diff --git a/libs/partners/prompty/langchain_prompty/core.py b/libs/partners/prompty/langchain_prompty/core.pyindex 7dc1910e1a..6b9f2f40ed 100644--- a/libs/partners/prompty/langchain_prompty/core.py+++ b/libs/partners/prompty/langchain_prompty/core.py@@ -55,7 +55,7 @@ class TemplateSettings(BaseModel):class Prompty(BaseModel):"""Base Prompty model."""- # metadata+ # Metadataname: str = Field(default="")description: str = Field(default="")authors: list[str] = Field(default=[])@@ -63,17 +63,18 @@ class Prompty(BaseModel):version: str = Field(default="")base: str = Field(default="")basePrompty: Optional[Prompty] = Field(default=None)- # model++ # Modelmodel: ModelSettings = Field(default_factory=ModelSettings)- # sample+ # Samplesample: dict = Field(default={})- # input / output+ # Input / outputinputs: dict[str, PropertySettings] = Field(default={})outputs: dict[str, PropertySettings] = Field(default={})- # template+ # Templatetemplate: TemplateSettingsfile: FilePath = Field(default="") # type: ignore[assignment]@@ -96,14 +97,14 @@ class Prompty(BaseModel):else self.file)elif k == "basePrompty":- # no need to serialize basePrompty+ # No need to serialize basePromptycontinueelse:d[k] = vreturn d- # generate json representation of the prompty+ # Generate json representation of the promptydef to_safe_json(self) -> str:d = self.to_safe_dict()return json.dumps(d)@@ -307,9 +308,9 @@ class Frontmatter:"""Returns dict with separated frontmatter from string.Returned dict keys:- attributes -- extracted YAML attributes in dict form.- body -- string contents below the YAML separators- frontmatter -- string representation of YAML+ - attributes: extracted YAML attributes in dict form.+ - body: string contents below the YAML separators+ - frontmatter: string representation of YAML"""fmatter = ""body = ""@@ -319,7 +320,7 @@ class Frontmatter:fmatter = result.group(1)body = result.group(2)return {- "attributes": yaml.load(fmatter, Loader=yaml.FullLoader),+ "attributes": yaml.safe_load(fmatter),"body": body,"frontmatter": fmatter,}diff --git a/libs/partners/prompty/langchain_prompty/parsers.py b/libs/partners/prompty/langchain_prompty/parsers.pyindex ec94d4ac01..85e6cf0b45 100644--- a/libs/partners/prompty/langchain_prompty/parsers.py+++ b/libs/partners/prompty/langchain_prompty/parsers.py@@ -102,7 +102,8 @@ class PromptyChatParser(Invoker):return contentdef invoke(self, data: BaseModel) -> BaseModel:- assert isinstance(data, SimpleModel)+ if not isinstance(data, SimpleModel):+ raise ValueError("data must be an instance of SimpleModel")messages = []separator = r"(?i)^\s*#?\s*(" + "|".join(self.roles) + r")\s*:\s*\n"diff --git a/libs/partners/prompty/langchain_prompty/renderers.py b/libs/partners/prompty/langchain_prompty/renderers.pyindex b04a309316..3a94a6cea8 100644--- a/libs/partners/prompty/langchain_prompty/renderers.py+++ b/libs/partners/prompty/langchain_prompty/renderers.py@@ -11,6 +11,7 @@ class MustacheRenderer(Invoker):self.prompty = promptydef invoke(self, data: BaseModel) -> BaseModel:- assert isinstance(data, SimpleModel)+ if not isinstance(data, SimpleModel):+ raise ValueError("Expected data to be an instance of SimpleModel")generated = mustache.render(self.prompty.content, data.item)return SimpleModel[str](item=generated)diff --git a/libs/partners/prompty/pyproject.toml b/libs/partners/prompty/pyproject.tomlindex 273d5827fa..c13801588e 100644--- a/libs/partners/prompty/pyproject.toml+++ b/libs/partners/prompty/pyproject.toml@@ -49,7 +49,7 @@ langchain = { path = "../../langchain", editable = true }target-version = "py39"[tool.ruff.lint]-select = ["E", "F", "I", "T201", "UP"]+select = ["E", "F", "I", "T201", "UP", "S"]ignore = [ "UP007", ][tool.mypy]@@ -65,3 +65,9 @@ markers = ["compile: mark placeholder test used to compile integration tests without running them",]asyncio_mode = "auto"++[tool.ruff.lint.extend-per-file-ignores]+"tests/**/*.py" = [+ "S101", # Tests need assertions+ "S311", # Standard pseudo-random generators are not suitable for cryptographic purposes+]\ No newline at end of file