Skip to content

The agent engineering platform.

feat(core): allow overriding `ls_model_name` from kwargs (#32541)

Matthew Lapointeb1f08467cd06
diff --git a/libs/core/langchain_core/language_models/chat_models.py b/libs/core/langchain_core/language_models/chat_models.py
index 81ce5cbc50..3bfa38449a 100644
--- a/libs/core/langchain_core/language_models/chat_models.py
+++ b/libs/core/langchain_core/language_models/chat_models.py
@@ -720,7 +720,9 @@ class BaseChatModel(BaseLanguageModel[BaseMessage], ABC):
ls_params["ls_stop"] = stop
# model
- if hasattr(self, "model") and isinstance(self.model, str):
+ if "model" in kwargs and isinstance(kwargs["model"], str):
+ ls_params["ls_model_name"] = kwargs["model"]
+ elif hasattr(self, "model") and isinstance(self.model, str):
ls_params["ls_model_name"] = self.model
elif hasattr(self, "model_name") and isinstance(self.model_name, str):
ls_params["ls_model_name"] = self.model_name
diff --git a/libs/core/langchain_core/language_models/llms.py b/libs/core/langchain_core/language_models/llms.py
index 9516b115d8..39bf896c66 100644
--- a/libs/core/langchain_core/language_models/llms.py
+++ b/libs/core/langchain_core/language_models/llms.py
@@ -357,7 +357,9 @@ class BaseLLM(BaseLanguageModel[str], ABC):
ls_params["ls_stop"] = stop
# model
- if hasattr(self, "model") and isinstance(self.model, str):
+ if "model" in kwargs and isinstance(kwargs["model"], str):
+ ls_params["ls_model_name"] = kwargs["model"]
+ elif hasattr(self, "model") and isinstance(self.model, str):
ls_params["ls_model_name"] = self.model
elif hasattr(self, "model_name") and isinstance(self.model_name, str):
ls_params["ls_model_name"] = self.model_name
diff --git a/libs/core/tests/unit_tests/language_models/chat_models/test_base.py b/libs/core/tests/unit_tests/language_models/chat_models/test_base.py
index 37b05ed825..7ea574bc50 100644
--- a/libs/core/tests/unit_tests/language_models/chat_models/test_base.py
+++ b/libs/core/tests/unit_tests/language_models/chat_models/test_base.py
@@ -654,3 +654,57 @@ def test_normalize_messages_edge_cases() -> None:
)
]
assert messages == _normalize_messages(messages)
+
+
+def test_get_ls_params() -> None:
+ class LSParamsModel(BaseChatModel):
+ model: str = "foo"
+ temperature: float = 0.1
+ max_tokens: int = 1024
+
+ def _generate(
+ self,
+ messages: list[BaseMessage],
+ stop: Optional[list[str]] = None,
+ run_manager: Optional[CallbackManagerForLLMRun] = None,
+ **kwargs: Any,
+ ) -> ChatResult:
+ raise NotImplementedError
+
+ @override
+ def _stream(
+ self,
+ messages: list[BaseMessage],
+ stop: Optional[list[str]] = None,
+ run_manager: Optional[CallbackManagerForLLMRun] = None,
+ **kwargs: Any,
+ ) -> Iterator[ChatGenerationChunk]:
+ raise NotImplementedError
+
+ @property
+ def _llm_type(self) -> str:
+ return "fake-chat-model"
+
+ llm = LSParamsModel()
+
+ # Test standard tracing params
+ ls_params = llm._get_ls_params()
+ assert ls_params == {
+ "ls_provider": "lsparamsmodel",
+ "ls_model_type": "chat",
+ "ls_model_name": "foo",
+ "ls_temperature": 0.1,
+ "ls_max_tokens": 1024,
+ }
+
+ ls_params = llm._get_ls_params(model="bar")
+ assert ls_params["ls_model_name"] == "bar"
+
+ ls_params = llm._get_ls_params(temperature=0.2)
+ assert ls_params["ls_temperature"] == 0.2
+
+ ls_params = llm._get_ls_params(max_tokens=2048)
+ assert ls_params["ls_max_tokens"] == 2048
+
+ ls_params = llm._get_ls_params(stop=["stop"])
+ assert ls_params["ls_stop"] == ["stop"]
diff --git a/libs/core/tests/unit_tests/language_models/llms/test_base.py b/libs/core/tests/unit_tests/language_models/llms/test_base.py
index 438580eafb..8cf260b987 100644
--- a/libs/core/tests/unit_tests/language_models/llms/test_base.py
+++ b/libs/core/tests/unit_tests/language_models/llms/test_base.py
@@ -232,3 +232,48 @@ async def test_astream_implementation_uses_astream() -> None:
model = ModelWithAsyncStream()
chunks = [chunk async for chunk in model.astream("anything")]
assert chunks == ["a", "b"]
+
+
+def test_get_ls_params() -> None:
+ class LSParamsModel(BaseLLM):
+ model: str = "foo"
+ temperature: float = 0.1
+ max_tokens: int = 1024
+
+ @override
+ def _generate(
+ self,
+ prompts: list[str],
+ stop: Optional[list[str]] = None,
+ run_manager: Optional[CallbackManagerForLLMRun] = None,
+ **kwargs: Any,
+ ) -> LLMResult:
+ raise NotImplementedError
+
+ @property
+ def _llm_type(self) -> str:
+ return "fake-model"
+
+ llm = LSParamsModel()
+
+ # Test standard tracing params
+ ls_params = llm._get_ls_params()
+ assert ls_params == {
+ "ls_provider": "lsparamsmodel",
+ "ls_model_type": "llm",
+ "ls_model_name": "foo",
+ "ls_temperature": 0.1,
+ "ls_max_tokens": 1024,
+ }
+
+ ls_params = llm._get_ls_params(model="bar")
+ assert ls_params["ls_model_name"] == "bar"
+
+ ls_params = llm._get_ls_params(temperature=0.2)
+ assert ls_params["ls_temperature"] == 0.2
+
+ ls_params = llm._get_ls_params(max_tokens=2048)
+ assert ls_params["ls_max_tokens"] == 2048
+
+ ls_params = llm._get_ls_params(stop=["stop"])
+ assert ls_params["ls_stop"] == ["stop"]
diff --git a/libs/partners/anthropic/langchain_anthropic/chat_models.py b/libs/partners/anthropic/langchain_anthropic/chat_models.py
index ae2b440c58..c5d6a6c323 100644
--- a/libs/partners/anthropic/langchain_anthropic/chat_models.py
+++ b/libs/partners/anthropic/langchain_anthropic/chat_models.py
@@ -1376,7 +1376,7 @@ class ChatAnthropic(BaseChatModel):
params = self._get_invocation_params(stop=stop, **kwargs)
ls_params = LangSmithParams(
ls_provider="anthropic",
- ls_model_name=self.model,
+ ls_model_name=params.get("model", self.model),
ls_model_type="chat",
ls_temperature=params.get("temperature", self.temperature),
)
diff --git a/libs/partners/anthropic/tests/unit_tests/test_chat_models.py b/libs/partners/anthropic/tests/unit_tests/test_chat_models.py
index a2b56dce77..3aad9c4f26 100644
--- a/libs/partners/anthropic/tests/unit_tests/test_chat_models.py
+++ b/libs/partners/anthropic/tests/unit_tests/test_chat_models.py
@@ -1215,6 +1215,22 @@ def test_cache_control_kwarg() -> None:
]
+def test_anthropic_model_params() -> None:
+ llm = ChatAnthropic(model="claude-3-5-haiku-latest")
+
+ ls_params = llm._get_ls_params()
+ assert ls_params == {
+ "ls_provider": "anthropic",
+ "ls_model_type": "chat",
+ "ls_model_name": "claude-3-5-haiku-latest",
+ "ls_max_tokens": 1024,
+ "ls_temperature": None,
+ }
+
+ ls_params = llm._get_ls_params(model="claude-opus-4-1-20250805")
+ assert ls_params["ls_model_name"] == "claude-opus-4-1-20250805"
+
+
def test_streaming_cache_token_reporting() -> None:
"""Test that cache tokens are properly reported in streaming events."""
from unittest.mock import MagicMock
diff --git a/libs/partners/fireworks/langchain_fireworks/chat_models.py b/libs/partners/fireworks/langchain_fireworks/chat_models.py
index a8ec09960b..949c88ec77 100644
--- a/libs/partners/fireworks/langchain_fireworks/chat_models.py
+++ b/libs/partners/fireworks/langchain_fireworks/chat_models.py
@@ -413,7 +413,7 @@ class ChatFireworks(BaseChatModel):
params = self._get_invocation_params(stop=stop, **kwargs)
ls_params = LangSmithParams(
ls_provider="fireworks",
- ls_model_name=self.model_name,
+ ls_model_name=params.get("model", self.model_name),
ls_model_type="chat",
ls_temperature=params.get("temperature", self.temperature),
)
diff --git a/libs/partners/groq/langchain_groq/chat_models.py b/libs/partners/groq/langchain_groq/chat_models.py
index 6992326169..c254a6ffbc 100644
--- a/libs/partners/groq/langchain_groq/chat_models.py
+++ b/libs/partners/groq/langchain_groq/chat_models.py
@@ -480,7 +480,7 @@ class ChatGroq(BaseChatModel):
params = self._get_invocation_params(stop=stop, **kwargs)
ls_params = LangSmithParams(
ls_provider="groq",
- ls_model_name=self.model_name,
+ ls_model_name=params.get("model", self.model_name),
ls_model_type="chat",
ls_temperature=params.get("temperature", self.temperature),
)
diff --git a/libs/partners/mistralai/langchain_mistralai/chat_models.py b/libs/partners/mistralai/langchain_mistralai/chat_models.py
index 03ec678e5f..971b79eb1d 100644
--- a/libs/partners/mistralai/langchain_mistralai/chat_models.py
+++ b/libs/partners/mistralai/langchain_mistralai/chat_models.py
@@ -448,7 +448,7 @@ class ChatMistralAI(BaseChatModel):
params = self._get_invocation_params(stop=stop, **kwargs)
ls_params = LangSmithParams(
ls_provider="mistral",
- ls_model_name=self.model,
+ ls_model_name=params.get("model", self.model),
ls_model_type="chat",
ls_temperature=params.get("temperature", self.temperature),
)
diff --git a/libs/partners/openai/langchain_openai/chat_models/base.py b/libs/partners/openai/langchain_openai/chat_models/base.py
index 1cc33ca007..bf2fe87746 100644
--- a/libs/partners/openai/langchain_openai/chat_models/base.py
+++ b/libs/partners/openai/langchain_openai/chat_models/base.py
@@ -1471,7 +1471,7 @@ class BaseChatOpenAI(BaseChatModel):
params = self._get_invocation_params(stop=stop, **kwargs)
ls_params = LangSmithParams(
ls_provider="openai",
- ls_model_name=self.model_name,
+ ls_model_name=params.get("model", self.model_name),
ls_model_type="chat",
ls_temperature=params.get("temperature", self.temperature),
)
diff --git a/libs/partners/openai/tests/unit_tests/llms/test_base.py b/libs/partners/openai/tests/unit_tests/llms/test_base.py
index a249fd3b0b..404c49a491 100644
--- a/libs/partners/openai/tests/unit_tests/llms/test_base.py
+++ b/libs/partners/openai/tests/unit_tests/llms/test_base.py
@@ -25,6 +25,9 @@ def test_openai_model_param() -> None:
"ls_max_tokens": 256,
}
+ ls_params = llm._get_ls_params(model="bar")
+ assert ls_params["ls_model_name"] == "bar"
+
def test_openai_model_kwargs() -> None:
llm = OpenAI(model_kwargs={"foo": "bar"})