Skip to content

The agent engineering platform.

fix(core): prevent async task garbage collection (RUF006) (#34238)

Paulba6c2590ae55
diff --git a/libs/core/langchain_core/language_models/llms.py b/libs/core/langchain_core/language_models/llms.py
index 813ae7b21b..a3853e4136 100644
--- a/libs/core/langchain_core/language_models/llms.py
+++ b/libs/core/langchain_core/language_models/llms.py
@@ -61,6 +61,8 @@ if TYPE_CHECKING:
logger = logging.getLogger(__name__)
+_background_tasks: set[asyncio.Task] = set()
+
@functools.lru_cache
def _log_error_once(msg: str) -> None:
@@ -100,9 +102,9 @@ def create_base_retry_decorator(
asyncio.run(coro)
else:
if loop.is_running():
- # TODO: Fix RUF006 - this task should have a reference
- # and be awaited somewhere
- loop.create_task(coro) # noqa: RUF006
+ task = loop.create_task(coro)
+ _background_tasks.add(task)
+ task.add_done_callback(_background_tasks.discard)
else:
asyncio.run(coro)
except Exception as e: