Skip to content

The agent engineering platform.

community: Fix KeyError in NotionDB loader when 'name' is missing (#24224)

BottlePumpkinbfc59c1d2611
diff --git a/libs/community/langchain_community/document_loaders/notiondb.py b/libs/community/langchain_community/document_loaders/notiondb.py
index 76215727bd..d5c03da16d 100644
--- a/libs/community/langchain_community/document_loaders/notiondb.py
+++ b/libs/community/langchain_community/document_loaders/notiondb.py
@@ -1,3 +1,4 @@
+import logging
from typing import Any, Dict, List, Optional
import requests
@@ -10,6 +11,10 @@ DATABASE_URL = NOTION_BASE_URL + "/databases/{database_id}/query"
PAGE_URL = NOTION_BASE_URL + "/pages/{page_id}"
BLOCK_URL = NOTION_BASE_URL + "/blocks/{block_id}/children"
+# Configure logging
+logging.basicConfig(level=logging.WARNING)
+logger = logging.getLogger(__name__)
+
class NotionDBLoader(BaseLoader):
"""Load from `Notion DB`.
@@ -63,7 +68,6 @@ class NotionDBLoader(BaseLoader):
List[Document]: List of documents.
"""
page_summaries = self._retrieve_page_summaries()
-
return list(self.load_page(page_summary) for page_summary in page_summaries)
def _retrieve_page_summaries(
@@ -133,11 +137,16 @@ class NotionDBLoader(BaseLoader):
elif prop_type == "status":
value = prop_data["status"]["name"] if prop_data["status"] else None
elif prop_type == "people":
- value = (
- [item["name"] for item in prop_data["people"]]
- if prop_data["people"]
- else []
- )
+ value = []
+ if prop_data["people"]:
+ for item in prop_data["people"]:
+ name = item.get("name")
+ if not name:
+ logger.warning(
+ "Missing 'name' in 'people' property "
+ f"for page {page_id}"
+ )
+ value.append(name)
elif prop_type == "date":
value = prop_data["date"] if prop_data["date"] else None
elif prop_type == "last_edited_time":