The agent engineering platform.
Python agentsaiai-agentsanthropicchatgptdeepagentsenterpriseframeworkgeminigenerative-ailangchainlanggraphllmmultiagentopen-sourceopenaipydanticpythonragtypescript
chore(langchain): fix types in `test_tool_selection` and `test_tool_emulator` (#34499)
Christophe Bornetcb0d227d8aff
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_tool_emulator.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_tool_emulator.pyindex e6bd57e637..50e03f3928 100644--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_tool_emulator.py+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_tool_emulator.py@@ -1,6 +1,5 @@"""Unit tests for tool emulator middleware."""-import typingfrom collections.abc import Callable, Sequencefrom itertools import cyclefrom typing import Any, Literal@@ -47,9 +46,9 @@ class FakeModel(GenericFakeChatModel):def bind_tools(self,- tools: typing.Sequence[dict[str, Any] | type[BaseModel] | Callable | BaseTool],- **kwargs: Any,- ) -> Runnable[LanguageModelInput, BaseMessage]:+ tools: Sequence[dict[str, Any] | type[BaseModel] | Callable[..., Any] | BaseTool],+ **_kwargs: Any,+ ) -> Runnable[LanguageModelInput, AIMessage]:if len(tools) == 0:msg = "Must provide at least one tool"raise ValueError(msg)diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_tool_selection.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_tool_selection.pyindex abc2484a9d..2c5768e7f9 100644--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_tool_selection.py+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_tool_selection.py@@ -1,19 +1,24 @@"""Unit tests for LLM tool selection middleware."""-import typing+from collections.abc import Callable, Sequencefrom itertools import cyclefrom typing import Any, Literalimport pytestfrom langchain_core.language_models import LanguageModelInputfrom langchain_core.language_models.fake_chat_models import GenericFakeChatModel-from langchain_core.messages import BaseMessage, HumanMessage+from langchain_core.messages import HumanMessagefrom langchain_core.runnables import Runnablefrom langchain_core.tools import BaseTool, toolfrom pydantic import BaseModelfrom langchain.agents import create_agent-from langchain.agents.middleware import LLMToolSelectorMiddleware, wrap_model_call+from langchain.agents.middleware import (+ LLMToolSelectorMiddleware,+ ModelRequest,+ ModelResponse,+ wrap_model_call,+)from langchain.agents.middleware.tool_selection import _create_tool_selection_responsefrom langchain.messages import AIMessage@@ -53,9 +58,9 @@ class FakeModel(GenericFakeChatModel):def bind_tools(self,- tools: typing.Sequence[dict[str, Any] | type[BaseModel] | typing.Callable | BaseTool],- **kwargs: Any,- ) -> Runnable[LanguageModelInput, BaseMessage]:+ tools: Sequence[dict[str, Any] | type[BaseModel] | Callable[..., Any] | BaseTool],+ **_kwargs: Any,+ ) -> Runnable[LanguageModelInput, AIMessage]:if len(tools) == 0:msg = "Must provide at least one tool"raise ValueError(msg)@@ -100,7 +105,9 @@ class TestLLMToolSelectorBasic:model_requests = []@wrap_model_call- def trace_model_requests(request, handler):+ def trace_model_requests(+ request: ModelRequest, handler: Callable[[ModelRequest], ModelResponse]+ ) -> ModelResponse:"""Middleware to select relevant tools based on state/context."""# Select a small, relevant subset of tools based on state/contextmodel_requests.append(request)@@ -150,7 +157,10 @@ class TestLLMToolSelectorBasic:assert isinstance(response["messages"][-1], AIMessage)for request in model_requests:- selected_tool_names = [tool.name for tool in request.tools] if request.tools else []+ selected_tool_names = []+ for tool_ in request.tools:+ assert isinstance(tool_, BaseTool)+ selected_tool_names.append(tool_.name)assert selected_tool_names == ["get_weather", "calculate"]async def test_async_basic_selection(self) -> None:@@ -205,7 +215,9 @@ class TestMaxToolsLimiting:model_requests = []@wrap_model_call- def trace_model_requests(request, handler):+ def trace_model_requests(+ request: ModelRequest, handler: Callable[[ModelRequest], ModelResponse]+ ) -> ModelResponse:model_requests.append(request)return handler(request)@@ -251,7 +263,10 @@ class TestMaxToolsLimiting:assert len(model_requests) > 0for request in model_requests:assert len(request.tools) == 2- tool_names = [tool.name for tool in request.tools]+ tool_names = []+ for tool_ in request.tools:+ assert isinstance(tool_, BaseTool)+ tool_names.append(tool_.name)# Should be first 2 from the selectionassert tool_names == ["get_weather", "search_web"]@@ -260,7 +275,9 @@ class TestMaxToolsLimiting:model_requests = []@wrap_model_call- def trace_model_requests(request, handler):+ def trace_model_requests(+ request: ModelRequest, handler: Callable[[ModelRequest], ModelResponse]+ ) -> ModelResponse:model_requests.append(request)return handler(request)@@ -305,7 +322,10 @@ class TestMaxToolsLimiting:assert len(model_requests) > 0for request in model_requests:assert len(request.tools) == 4- tool_names = [tool.name for tool in request.tools]+ tool_names = []+ for tool_ in request.tools:+ assert isinstance(tool_, BaseTool)+ tool_names.append(tool_.name)assert set(tool_names) == {"get_weather","search_web",@@ -322,7 +342,9 @@ class TestAlwaysInclude:model_requests = []@wrap_model_call- def trace_model_requests(request, handler):+ def trace_model_requests(+ request: ModelRequest, handler: Callable[[ModelRequest], ModelResponse]+ ) -> ModelResponse:model_requests.append(request)return handler(request)@@ -362,7 +384,10 @@ class TestAlwaysInclude:# Both selected and always_include tools should be presentassert len(model_requests) > 0for request in model_requests:- tool_names = [tool.name for tool in request.tools]+ tool_names = []+ for tool_ in request.tools:+ assert isinstance(tool_, BaseTool)+ tool_names.append(tool_.name)assert "search_web" in tool_namesassert "send_email" in tool_namesassert len(tool_names) == 2@@ -372,7 +397,9 @@ class TestAlwaysInclude:model_requests = []@wrap_model_call- def trace_model_requests(request, handler):+ def trace_model_requests(+ request: ModelRequest, handler: Callable[[ModelRequest], ModelResponse]+ ) -> ModelResponse:model_requests.append(request)return handler(request)@@ -415,7 +442,10 @@ class TestAlwaysInclude:assert len(model_requests) > 0for request in model_requests:assert len(request.tools) == 4- tool_names = [tool.name for tool in request.tools]+ tool_names = []+ for tool_ in request.tools:+ assert isinstance(tool_, BaseTool)+ tool_names.append(tool_.name)assert "get_weather" in tool_namesassert "search_web" in tool_namesassert "send_email" in tool_names@@ -426,7 +456,9 @@ class TestAlwaysInclude:model_requests = []@wrap_model_call- def trace_model_requests(request, handler):+ def trace_model_requests(+ request: ModelRequest, handler: Callable[[ModelRequest], ModelResponse]+ ) -> ModelResponse:model_requests.append(request)return handler(request)@@ -468,7 +500,10 @@ class TestAlwaysInclude:assert len(model_requests) > 0for request in model_requests:assert len(request.tools) == 4- tool_names = [tool.name for tool in request.tools]+ tool_names = []+ for tool_ in request.tools:+ assert isinstance(tool_, BaseTool)+ tool_names.append(tool_.name)assert "get_weather" in tool_namesassert "send_email" in tool_namesassert "calculate" in tool_names@@ -483,7 +518,9 @@ class TestDuplicateAndInvalidTools:model_requests = []@wrap_model_call- def trace_model_requests(request, handler):+ def trace_model_requests(+ request: ModelRequest, handler: Callable[[ModelRequest], ModelResponse]+ ) -> ModelResponse:model_requests.append(request)return handler(request)@@ -527,16 +564,21 @@ class TestDuplicateAndInvalidTools:# Duplicates should be removedassert len(model_requests) > 0for request in model_requests:- tool_names = [tool.name for tool in request.tools]+ tool_names = []+ for tool_ in request.tools:+ assert isinstance(tool_, BaseTool)+ tool_names.append(tool_.name)assert tool_names == ["get_weather", "search_web"]assert len(tool_names) == 2def test_max_tools_with_duplicates(self) -> None:"""Test that max_tools works correctly with duplicate selections."""- model_requests = []+ model_requests: list[ModelRequest] = []@wrap_model_call- def trace_model_requests(request, handler):+ def trace_model_requests(+ request: ModelRequest, handler: Callable[[ModelRequest], ModelResponse]+ ) -> ModelResponse:model_requests.append(request)return handler(request)@@ -581,7 +623,10 @@ class TestDuplicateAndInvalidTools:# Should deduplicate and respect max_toolsassert len(model_requests) > 0for request in model_requests:- tool_names = [tool.name for tool in request.tools]+ tool_names = []+ for tool_ in request.tools:+ assert isinstance(tool_, BaseTool)+ tool_names.append(tool_.name)assert len(tool_names) == 2assert "get_weather" in tool_namesassert "search_web" in tool_names