The agent engineering platform.
Python agentsaiai-agentsanthropicchatgptdeepagentsenterpriseframeworkgeminigenerative-ailangchainlanggraphllmmultiagentopen-sourceopenaipydanticpythonragtypescript
fix(langchain): sort glob_search results by mtime (newest first) (#37462)
Blut-agentd328d84b7823
diff --git a/libs/langchain_v1/langchain/agents/middleware/file_search.py b/libs/langchain_v1/langchain/agents/middleware/file_search.pyindex ffbf3c61ee..c05bfde7f9 100644--- a/libs/langchain_v1/langchain/agents/middleware/file_search.py+++ b/libs/langchain_v1/langchain/agents/middleware/file_search.py@@ -170,6 +170,7 @@ class FilesystemFileSearchMiddleware(AgentMiddleware[AgentState[ResponseT], Contif not matching:return "No files found"+ matching.sort(key=lambda item: item[1], reverse=True)file_paths = [p for p, _ in matching]return "\n".join(file_paths)diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_file_search.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_file_search.pyindex 69e3d58d03..dac5829b3b 100644--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_file_search.py+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_file_search.py@@ -1,5 +1,6 @@"""Unit tests for file search middleware."""+import osfrom pathlib import Pathfrom typing import Any@@ -210,6 +211,33 @@ class TestFilesystemGlobSearch:assert result == "No files found"+ def test_glob_results_sorted_by_mtime_desc(self, tmp_path: Path) -> None:+ """Results must be ordered newest-first, as documented."""+ # Create files in alphabetical order opposite to mtime order so the+ # default Path.glob() ordering cannot coincidentally pass the assertion.+ oldest = tmp_path / "a_oldest.txt"+ middle = tmp_path / "b_middle.txt"+ newest = tmp_path / "c_newest.txt"+ for p in (oldest, middle, newest):+ p.write_text("x", encoding="utf-8")++ # Explicit mtimes (seconds since epoch) — deterministic, no sleeps.+ os.utime(oldest, (1_000_000, 1_000_000))+ os.utime(middle, (2_000_000, 2_000_000))+ os.utime(newest, (3_000_000, 3_000_000))++ middleware = FilesystemFileSearchMiddleware(root_path=str(tmp_path))++ assert isinstance(middleware.glob_search, StructuredTool)+ assert middleware.glob_search.func is not None+ result = middleware.glob_search.func(pattern="*.txt")++ assert result.splitlines() == [+ "/c_newest.txt",+ "/b_middle.txt",+ "/a_oldest.txt",+ ]+class TestPathTraversalSecurity:"""Security tests for path traversal protection."""