The agent engineering platform.
Python agentsaiai-agentsanthropicchatgptdeepagentsenterpriseframeworkgeminigenerative-ailangchainlanggraphllmmultiagentopen-sourceopenaipydanticpythonragtypescript
fix(langchain-classic): validate ensemble retriever weights (#35078)
Mohammed Yaseen Ahmed Khand41dedae978d
diff --git a/libs/langchain/langchain_classic/retrievers/ensemble.py b/libs/langchain/langchain_classic/retrievers/ensemble.pyindex 2e0ea312f1..1306708b48 100644--- a/libs/langchain/langchain_classic/retrievers/ensemble.py+++ b/libs/langchain/langchain_classic/retrievers/ensemble.py@@ -80,9 +80,25 @@ class EnsembleRetriever(BaseRetriever):@model_validator(mode="before")@classmethoddef _set_weights(cls, values: dict[str, Any]) -> Any:- if not values.get("weights"):+ weights = values.get("weights")++ if not weights:n_retrievers = len(values["retrievers"])values["weights"] = [1 / n_retrievers] * n_retrievers+ return values++ retrievers = values["retrievers"]+ if len(weights) != len(retrievers):+ msg = (+ "Length of weights must match number of retrievers "+ f"(got {len(weights)} weights for {len(retrievers)} retrievers)."+ )+ raise ValueError(msg)++ if not any(w > 0 for w in weights):+ msg = "At least one ensemble weight must be greater than zero."+ raise ValueError(msg)+return values@override