Skip to content

The agent engineering platform.

fix(exa): handle missing optional result metadata (#39171)

Ali Satwat Khand616af71dd9f
diff --git a/libs/partners/exa/langchain_exa/retrievers.py b/libs/partners/exa/langchain_exa/retrievers.py
index f50196aa5e..eaa6bc375f 100644
--- a/libs/partners/exa/langchain_exa/retrievers.py
+++ b/libs/partners/exa/langchain_exa/retrievers.py
@@ -27,12 +27,9 @@ def _get_metadata(result: Any) -> dict[str, Any]:
"published_date": result.published_date,
"author": result.author,
}
- if getattr(result, "highlights"):
- metadata["highlights"] = result.highlights
- if getattr(result, "highlight_scores"):
- metadata["highlight_scores"] = result.highlight_scores
- if getattr(result, "summary"):
- metadata["summary"] = result.summary
+ for attribute in ("highlights", "highlight_scores", "summary"):
+ if value := getattr(result, attribute, None):
+ metadata[attribute] = value
return metadata
diff --git a/libs/partners/exa/tests/unit_tests/test_retrievers.py b/libs/partners/exa/tests/unit_tests/test_retrievers.py
new file mode 100644
index 0000000000..3d807d86bb
--- /dev/null
+++ b/libs/partners/exa/tests/unit_tests/test_retrievers.py
@@ -0,0 +1,41 @@
+"""Unit tests for the Exa retriever."""
+
+from types import SimpleNamespace
+from typing import Any
+
+from langchain_exa.retrievers import _get_metadata
+
+
+def _make_result(**optional_metadata: Any) -> SimpleNamespace:
+ return SimpleNamespace(
+ title="Example",
+ url="https://example.com",
+ id="result-1",
+ score=0.95,
+ published_date="2024-01-01",
+ author="Author",
+ **optional_metadata,
+ )
+
+
+def test_get_metadata_omits_missing_optional_attributes() -> None:
+ """Test that missing optional result attributes are omitted."""
+ assert _get_metadata(_make_result()) == {
+ "title": "Example",
+ "url": "https://example.com",
+ "id": "result-1",
+ "score": 0.95,
+ "published_date": "2024-01-01",
+ "author": "Author",
+ }
+
+
+def test_get_metadata_includes_available_optional_attributes() -> None:
+ """Test that available optional attributes are retained independently."""
+ metadata = _get_metadata(
+ _make_result(highlights=["Excerpt"], summary="A short summary")
+ )
+
+ assert metadata["highlights"] == ["Excerpt"]
+ assert metadata["summary"] == "A short summary"
+ assert "highlight_scores" not in metadata