Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Fix no-null-render: TestResultActions.tsx (#17219)

Ben Bachem017490fcc8f5
diff --git a/web/src/features/evals/v2/components/EvaluatorTestPanel/components/TestSection/components/TestResultActions/TestResultActions.tsx b/web/src/features/evals/v2/components/EvaluatorTestPanel/components/TestSection/components/TestResultActions/TestResultActions.tsx
index 60e17328bc..a10b049125 100644
--- a/web/src/features/evals/v2/components/EvaluatorTestPanel/components/TestSection/components/TestResultActions/TestResultActions.tsx
+++ b/web/src/features/evals/v2/components/EvaluatorTestPanel/components/TestSection/components/TestResultActions/TestResultActions.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @repo/no-null-render */
import { DropdownMenuTrigger } from "@/src/components/ui/dropdown-menu";
import {
TestResultTraceActions,
@@ -9,10 +8,10 @@ export function TestResultActions({
executionTraceId,
onOpenExecutionTrace,
}: {
- executionTraceId: string | null;
+ executionTraceId: string;
onOpenExecutionTrace: (traceId: string) => void;
}) {
- return executionTraceId ? (
+ return (
<TestResultTraceActions
executionTraceId={executionTraceId}
onOpenExecutionTrace={onOpenExecutionTrace}
@@ -21,5 +20,5 @@ export function TestResultActions({
<TestResultTraceActionsTrigger />
</DropdownMenuTrigger>
</TestResultTraceActions>
- ) : null;
+ );
}
diff --git a/web/src/features/evals/v2/components/EvaluatorTestPanel/components/TestSection/components/TestSectionContainer/TestSectionContainer.tsx b/web/src/features/evals/v2/components/EvaluatorTestPanel/components/TestSection/components/TestSectionContainer/TestSectionContainer.tsx
index 73f8d91486..3889c87092 100644
--- a/web/src/features/evals/v2/components/EvaluatorTestPanel/components/TestSection/components/TestSectionContainer/TestSectionContainer.tsx
+++ b/web/src/features/evals/v2/components/EvaluatorTestPanel/components/TestSection/components/TestSectionContainer/TestSectionContainer.tsx
@@ -64,10 +64,12 @@ export function TestSectionContainer({
rawOpen={rawResultOpen}
onRawOpenChange={onRawResultOpenChange}
traceActions={
- <TestResultActions
- executionTraceId={executionTraceId}
- onOpenExecutionTrace={onOpenExecutionTrace}
- />
+ executionTraceId ? (
+ <TestResultActions
+ executionTraceId={executionTraceId}
+ onOpenExecutionTrace={onOpenExecutionTrace}
+ />
+ ) : undefined
}
rerunAction={
<TestRerunAction