Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(web): wait for widget route params before project-scoped queries (#17393)

cursor[bot]0c876a2b4aad
diff --git a/web/src/__tests__/detail-page-route-params.clienttest.tsx b/web/src/__tests__/detail-page-route-params.clienttest.tsx
index fe2ff9b678..7505386c6c 100644
--- a/web/src/__tests__/detail-page-route-params.clienttest.tsx
+++ b/web/src/__tests__/detail-page-route-params.clienttest.tsx
@@ -1,4 +1,5 @@
import { render, screen } from "@testing-library/react";
+import type { ReactNode } from "react";
import type { Mock } from "vitest";
import { useRouter } from "next/router";
@@ -22,7 +23,46 @@ vi.mock("@/src/features/sessions/SessionPages", () => ({
}));
vi.mock("@/src/features/events/hooks/useReadPath", () => ({
- useReadPath: () => ({ isV4: false }),
+ useReadPath: () => ({ isV4: false, isResolved: true }),
+}));
+
+vi.mock("@/src/features/widgets", () => ({
+ WidgetForm: ({ projectId }: { projectId: string }) => (
+ <div data-testid="widget-form">{projectId}</div>
+ ),
+}));
+
+vi.mock("@/src/features/widgets/utils", () => ({
+ getDefaultView: () => "traces",
+}));
+
+vi.mock("@/src/features/dashboard/components/SelectDashboardDialog", () => ({
+ SelectDashboardDialog: () => null,
+}));
+
+vi.mock("@/src/utils/api", () => ({
+ api: {
+ dashboardWidgets: {
+ create: {
+ useMutation: () => ({ mutate: vi.fn(), isPending: false }),
+ },
+ },
+ dashboard: {
+ allDashboards: {
+ useQuery: () => ({ data: undefined, refetch: vi.fn() }),
+ },
+ },
+ },
+}));
+
+vi.mock("@/src/features/posthog-analytics/usePostHogClientCapture", () => ({
+ usePostHogClientCapture: () => vi.fn(),
+}));
+
+vi.mock("@/src/components/layouts/page", () => ({
+ default: ({ children }: { children: ReactNode }) => (
+ <div data-testid="page">{children}</div>
+ ),
}));
vi.mock(
@@ -67,8 +107,9 @@ import SessionPageRoute from "@/src/features/sessions/SessionDetailPage";
import AnnotationQueueItemRoute from "@/src/pages/project/[projectId]/annotation-queues/[queueId]/items/[itemId]";
import AnnotationQueueItemsIndexRoute from "@/src/pages/project/[projectId]/annotation-queues/[queueId]/index";
import DatasetExperimentsRoute from "@/src/pages/project/[projectId]/datasets/[datasetId]/experiments/index";
+import NewWidgetRoute from "@/src/pages/project/[projectId]/widgets/new";
-function mockRouterQuery(query: Record<string, string | undefined>) {
+function mockRouterQuery(query: Record<string, string | string[] | undefined>) {
(useRouter as Mock).mockReturnValue({
query,
isReady: Object.keys(query).length > 0,
@@ -132,4 +173,22 @@ describe("detail page deep-link route params", () => {
expect(screen.queryByTestId("dataset-runs-table")).toBeNull();
expect(screen.queryByTestId("experiments-table")).toBeNull();
});
+
+ test("new widget does not mount the form while router.query is empty", () => {
+ mockRouterQuery({});
+ render(<NewWidgetRoute />);
+ expect(screen.queryByTestId("widget-form")).toBeNull();
+ });
+
+ test("new widget mounts the form once projectId is a string", () => {
+ mockRouterQuery({ projectId: "p1" });
+ render(<NewWidgetRoute />);
+ expect(screen.getByTestId("widget-form")).toHaveTextContent("p1");
+ });
+
+ test("new widget does not mount the form when projectId is a duplicate query array", () => {
+ mockRouterQuery({ projectId: ["p1", "p1"] });
+ render(<NewWidgetRoute />);
+ expect(screen.queryByTestId("widget-form")).toBeNull();
+ });
});
diff --git a/web/src/features/widgets/NewWidgetPage.tsx b/web/src/features/widgets/NewWidgetPage.tsx
index 7b834722cf..67b4f0aa19 100644
--- a/web/src/features/widgets/NewWidgetPage.tsx
+++ b/web/src/features/widgets/NewWidgetPage.tsx
@@ -13,13 +13,21 @@ import { useReadPath } from "@/src/features/events/hooks/useReadPath";
import { getDefaultView } from "@/src/features/widgets/utils";
import { NoDataOrLoading } from "@/src/components/NoDataOrLoading";
import { usePostHogClientCapture } from "@/src/features/posthog-analytics/usePostHogClientCapture";
+import {
+ asSingleQueryParam,
+ RouteParamsPendingFallback,
+ useReadyRouteParams,
+} from "@/src/hooks/useReadyRouteParams";
export default function NewWidgetPage() {
+ const route = useReadyRouteParams(["projectId"]);
+ if (!route.ready) return <RouteParamsPendingFallback />;
+ return <NewWidgetView projectId={route.params.projectId} />;
+}
+
+function NewWidgetView({ projectId }: { projectId: string }) {
const router = useRouter();
- const { projectId, dashboardId } = router.query as {
- projectId: string;
- dashboardId?: string;
- };
+ const dashboardId = asSingleQueryParam(router.query.dashboardId);
const { isV4, isResolved } = useReadPath();
const capture = usePostHogClientCapture();