Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(web): segmented toggles get an even inset and a raised selected pill (#18282)

Trang Nguyen0ce349140608
diff --git a/web/src/components/design-system/Tabs/Tabs.tsx b/web/src/components/design-system/Tabs/Tabs.tsx
index 2a95ef96bc..c123d1c7e9 100644
--- a/web/src/components/design-system/Tabs/Tabs.tsx
+++ b/web/src/components/design-system/Tabs/Tabs.tsx
@@ -8,11 +8,11 @@ import { type LucideIcon } from "lucide-react";
import { cn } from "@/src/utils/tailwind";
const tabsListVariants = cva(
- "text-muted-foreground items-center justify-center [&>:not([role=tab])]:flex [&>:not([role=tab])>[role=tab]]:w-full",
+ "text-foreground-tertiary items-center justify-center [&>:not([role=tab])]:flex [&>:not([role=tab])>[role=tab]]:w-full",
{
variants: {
variant: {
- default: "bg-muted rounded-md",
+ default: "bg-control-track/60 rounded-md",
underline: "rounded-none border-b bg-transparent",
outline: "bg-background rounded-md border",
},
@@ -34,14 +34,14 @@ const tabsListVariants = cva(
},
},
compoundVariants: [
- { variant: "default", size: "default", class: "h-8 p-1" },
- { variant: "default", size: "md", class: "h-7 p-1" },
+ { variant: "default", size: "default", class: "h-8 p-0.5" },
+ { variant: "default", size: "md", class: "h-7 p-0.5" },
{ variant: "default", size: "sm", class: "h-6 p-0.5" },
- { variant: "default", size: "auto", class: "h-auto p-1" },
- { variant: "outline", size: "default", class: "h-8 p-1" },
- { variant: "outline", size: "md", class: "h-7 p-1" },
+ { variant: "default", size: "auto", class: "h-auto p-0.5" },
+ { variant: "outline", size: "default", class: "h-8 p-0.5" },
+ { variant: "outline", size: "md", class: "h-7 p-0.5" },
{ variant: "outline", size: "sm", class: "h-6 p-0.5" },
- { variant: "outline", size: "auto", class: "h-auto p-1" },
+ { variant: "outline", size: "auto", class: "h-auto p-0.5" },
{ variant: "underline", size: "default", class: "h-auto p-0" },
{ variant: "underline", size: "md", class: "h-auto p-0" },
{ variant: "underline", size: "sm", class: "h-auto p-0" },
@@ -62,14 +62,14 @@ const tabsTriggerVariants = cva(
variants: {
variant: {
default:
- "rounded-sm data-[state=active]:bg-background data-[state=active]:shadow-xs",
+ "rounded-sm data-[state=active]:bg-background data-[state=active]:shadow-sm",
underline:
"rounded-none border-b-2 border-transparent bg-transparent text-muted-foreground shadow-none data-[state=active]:border-primary-accent data-[state=active]:bg-transparent data-[state=active]:shadow-none",
},
size: {
- default: "h-6 px-2 py-0.5 text-sm",
+ default: "h-6 px-4 py-0.5 text-sm",
lg: "h-7 px-1 text-xs",
- sm: "h-5 px-1 text-xs",
+ sm: "h-5 px-2 text-xs",
},
},
compoundVariants: [
@@ -236,8 +236,8 @@ function TabsList({
data-tabs-indicator=""
aria-hidden="true"
className={cn(
- "pointer-events-none absolute inset-y-1 left-0 z-0 rounded-sm opacity-0 data-[ready=true]:transition-[width,transform] data-[ready=true]:duration-200 data-[ready=true]:ease-out motion-reduce:transition-none",
- variant === "outline" ? "bg-muted" : "bg-background shadow-xs",
+ "pointer-events-none absolute inset-y-0.5 left-0 z-0 rounded-sm opacity-0 data-[ready=true]:transition-[width,transform] data-[ready=true]:duration-200 data-[ready=true]:ease-out motion-reduce:transition-none",
+ variant === "outline" ? "bg-muted" : "bg-background shadow-sm",
)}
/>
) : null}
diff --git a/web/src/features/trace-graph-view/components/GraphViewModeSwitch.tsx b/web/src/features/trace-graph-view/components/GraphViewModeSwitch.tsx
index 0d67ef1f72..0b07236f67 100644
--- a/web/src/features/trace-graph-view/components/GraphViewModeSwitch.tsx
+++ b/web/src/features/trace-graph-view/components/GraphViewModeSwitch.tsx
@@ -1,13 +1,11 @@
import React from "react";
import { Combine, Route, type LucideIcon } from "lucide-react";
-import { cn } from "@/src/utils/tailwind";
+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
import { type GraphViewMode } from "../types";
/**
- * Segmented mode switch overlaid on the graph canvas. Mirrors the Tree/Timeline
- * ViewModeSwitch styling (TracePanelNavigationHeader) so the trace view's mode
- * switches read as one family.
+ * Segmented mode switch overlaid on the graph canvas.
*/
const MODES: {
mode: GraphViewMode;
@@ -37,28 +35,22 @@ export function GraphViewModeSwitch({
onChange: (mode: GraphViewMode) => void;
}) {
return (
- <div className="bg-background/80 inline-flex h-7 items-center rounded-md border p-0.5 backdrop-blur">
- {MODES.map(({ mode, icon: Icon, label, title }) => (
- <button
- key={mode}
- type="button"
- onClick={() => onChange(mode)}
- aria-pressed={value === mode}
- aria-label={label}
- title={title}
- className={cn(
- "flex h-6 items-center gap-1.5 rounded-md px-2 text-xs font-bold transition-colors",
- value === mode
- ? "bg-primary text-primary-foreground shadow-sm"
- : "text-muted-foreground hover:text-foreground",
- )}
- >
- <Icon className="h-3.5 w-3.5 shrink-0" />
- {/* Collapse to icons on narrow canvases (mirrors the nav header's
- switch) so the pill never collides with the zoom stack. */}
- <span className="@max-[340px]/graphcanvas:hidden">{label}</span>
- </button>
- ))}
+ <div className="bg-background/80 rounded-md backdrop-blur">
+ <Tabs
+ value={value}
+ onValueChange={(mode) => onChange(mode as GraphViewMode)}
+ >
+ <Tabs.List size="md" aria-label="Graph mode">
+ {MODES.map(({ mode, icon: Icon, label, title }) => (
+ <Tabs.Trigger key={mode} value={mode} title={title}>
+ <Icon aria-hidden="true" className="size-3.5 shrink-0" />
+ {/* Icons only on narrow canvases so the switch never collides
+ with the zoom stack. */}
+ <span className="@max-[340px]/graphcanvas:sr-only">{label}</span>
+ </Tabs.Trigger>
+ ))}
+ </Tabs.List>
+ </Tabs>
</div>
);
}