Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(evals): resolve media previews in variable mapper (#16944)

Tobias Wochinger0ea6b1106db9
diff --git a/web/src/components/MediaTag/MediaTag.clienttest.tsx b/web/src/components/MediaTag/MediaTag.clienttest.tsx
index ac5c580530..e895ab5008 100644
--- a/web/src/components/MediaTag/MediaTag.clienttest.tsx
+++ b/web/src/components/MediaTag/MediaTag.clienttest.tsx
@@ -32,6 +32,25 @@ describe("MediaTag", () => {
);
});
+ it("stops portaled preview actions from triggering parent clicks", () => {
+ const onParentClick = vi.fn();
+
+ render(
+ <div onClick={onParentClick}>
+ <MediaTag
+ contentType="image/png"
+ status="ready"
+ url="data:image/png;base64,"
+ open
+ />
+ </div>,
+ );
+
+ fireEvent.click(screen.getByRole("link", { name: "Open in new tab" }));
+
+ expect(onParentClick).not.toHaveBeenCalled();
+ });
+
it("opens the preview on click", async () => {
const onOpenChange = vi.fn();
diff --git a/web/src/components/MediaTag/MediaTag.tsx b/web/src/components/MediaTag/MediaTag.tsx
index ca6d5206e9..e0f48048c3 100644
--- a/web/src/components/MediaTag/MediaTag.tsx
+++ b/web/src/components/MediaTag/MediaTag.tsx
@@ -290,6 +290,7 @@ export const MediaTag = React.forwardRef<HTMLButtonElement, MediaTagProps>(
<HoverCardContent
align="start"
className="ph-no-capture flex w-auto max-w-sm flex-col gap-2 p-2"
+ onClick={(event) => event.stopPropagation()}
>
<div className="flex items-center justify-between gap-4">
<div className="text-muted-foreground flex min-w-0 items-center gap-1.5 text-xs">
diff --git a/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.clienttest.tsx b/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.clienttest.tsx
index 02ef998bb7..38dcf8a906 100644
--- a/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.clienttest.tsx
+++ b/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.clienttest.tsx
@@ -1,38 +1,73 @@
-import { render, screen } from "@testing-library/react";
+import { fireEvent, render, screen } from "@testing-library/react";
import { EditableVariableMapping } from "./EditableVariableMapping";
-vi.mock("@/src/components/MediaTag/MediaTag", () => ({
- MediaTag: ({ contentType }: { contentType: string }) => (
- <span data-testid="media-tag">{contentType}</span>
+vi.mock("@/src/components/ui/media/MediaReferenceTag", () => ({
+ MediaReferenceTag: ({
+ descriptor,
+ }: {
+ descriptor: { kind: string; mediaId?: string; contentType: string };
+ }) => (
+ <button type="button" data-media-tag="" data-testid="resolved-media-tag">
+ {descriptor.kind}:{descriptor.mediaId}:{descriptor.contentType}
+ </button>
),
}));
+const reference = "@@@langfuseMedia:type=image/png|id=media-1|source=bytes@@@";
+
+const renderMapping = (
+ state: "preview" | "editing",
+ onActiveMappingChange = vi.fn(),
+) =>
+ render(
+ <EditableVariableMapping
+ mappings={[
+ {
+ variable: "input",
+ fieldState: { selectedColumnId: "input", jsonSelector: null },
+ },
+ ]}
+ activeMapping={{ variable: "input", state }}
+ onActiveMappingChange={onActiveMappingChange}
+ onChangeField={vi.fn()}
+ sourceObject={{ input: reference }}
+ hasMatchingObservations
+ />,
+ );
+
describe("EditableVariableMapping", () => {
- it("renders a mapped Langfuse media reference as an aligned media tag", () => {
- const reference =
- "@@@langfuseMedia:type=image/png|id=media-1|source=bytes@@@";
-
- render(
- <EditableVariableMapping
- mappings={[
- {
- variable: "input",
- fieldState: { selectedColumnId: "input", jsonSelector: null },
- },
- ]}
- activeMapping={{ variable: "input", state: "preview" }}
- onActiveMappingChange={vi.fn()}
- onChangeField={vi.fn()}
- sourceObject={{ input: reference }}
- hasMatchingObservations
- />,
- );
+ it("resolves a mapped Langfuse media reference in the value preview", () => {
+ renderMapping("preview");
- expect(screen.getByTestId("media-tag")).toHaveTextContent("image/png");
+ expect(screen.getByTestId("resolved-media-tag")).toHaveTextContent(
+ "langfuseRef:media-1:image/png",
+ );
expect(screen.queryByText(reference)).not.toBeInTheDocument();
expect(screen.getByTestId("mapped-media-preview")).toHaveClass(
"items-center",
);
});
+
+ it("does not enter editing when the mapped media trigger is used", () => {
+ const onActiveMappingChange = vi.fn();
+ renderMapping("preview", onActiveMappingChange);
+
+ const mediaTag = screen.getByTestId("resolved-media-tag");
+ fireEvent.click(mediaTag);
+ fireEvent.keyDown(mediaTag, { key: "Enter" });
+
+ expect(onActiveMappingChange).not.toHaveBeenCalled();
+ });
+
+ it("resolves a Langfuse media reference in the sample data tree", () => {
+ renderMapping("editing");
+
+ const mediaTag = screen.getByTestId("resolved-media-tag");
+ expect(mediaTag).toHaveTextContent("langfuseRef:media-1:image/png");
+ expect(mediaTag.closest("[title]")).toBeNull();
+ expect(
+ mediaTag.closest("div")?.querySelector("button"),
+ ).not.toHaveAttribute("title");
+ });
});
diff --git a/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.stories.tsx b/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.stories.tsx
index 5d1bd2e737..1e5aff50ae 100644
--- a/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.stories.tsx
+++ b/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.stories.tsx
@@ -43,7 +43,7 @@ export const MappedMediaValue = meta.story({
attachments: [
{
media:
- "@@@langfuseMedia:type=image/png|id=cc48838a-3da8-4ca4-a007-2cf8df930e69|source=bytes@@@",
+ "data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///ywAAAAAAQABAAACAUwAOw==",
},
],
},
diff --git a/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.tsx b/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.tsx
index df690f8387..aa71473dda 100644
--- a/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.tsx
+++ b/web/src/features/evals/v2/components/VariableMapping/components/EditableVariableMapping/EditableVariableMapping.tsx
@@ -1,8 +1,8 @@
import { useMemo, useState, type ReactNode } from "react";
import { TriangleAlert } from "lucide-react";
-import { MediaTag } from "@/src/components/MediaTag/MediaTag";
import { PrettyJsonView } from "@/src/components/ui/PrettyJsonView";
+import { MediaReferenceTag } from "@/src/components/ui/media/MediaReferenceTag";
import {
classifyMediaValue,
splitStringByMediaReferences,
@@ -72,10 +72,7 @@ function MappedValuePreview({ value }: { value: string }) {
>
{mediaSegments.map((segment, index) =>
segment.type === "media" ? (
- <MediaTag
- key={index}
- contentType={segment.descriptor.contentType}
- />
+ <MediaReferenceTag key={index} descriptor={segment.descriptor} />
) : (
<span key={index} className="break-words whitespace-pre-wrap">
{segment.value}
@@ -108,8 +105,22 @@ function MappingPreviewSurface({
aria-label={`Change mapping for {{${variable}}}`}
title={`Change mapping for {{${variable}}}`}
className="hover:bg-muted/50 focus-visible:ring-ring cursor-pointer rounded-b-md transition-colors focus-visible:ring-2 focus-visible:outline-hidden focus-visible:ring-inset"
- onClick={onEdit}
+ onClick={(event) => {
+ if (
+ event.target instanceof Element &&
+ event.target.closest("[data-media-tag]")
+ ) {
+ return;
+ }
+ onEdit();
+ }}
onKeyDown={(event) => {
+ if (
+ event.target instanceof Element &&
+ event.target.closest("[data-media-tag]")
+ ) {
+ return;
+ }
if (event.key === "Enter" || event.key === " ") {
event.preventDefault();
onEdit();
diff --git a/web/src/features/evals/v2/components/VariableMapping/components/SampleDataTreeSelector/SampleDataTreeSelector.stories.tsx b/web/src/features/evals/v2/components/VariableMapping/components/SampleDataTreeSelector/SampleDataTreeSelector.stories.tsx
index deaef536ac..06d158b20b 100644
--- a/web/src/features/evals/v2/components/VariableMapping/components/SampleDataTreeSelector/SampleDataTreeSelector.stories.tsx
+++ b/web/src/features/evals/v2/components/VariableMapping/components/SampleDataTreeSelector/SampleDataTreeSelector.stories.tsx
@@ -58,7 +58,7 @@ export const MediaReference = meta.story({
filename: "cache-hit-ratio.png",
content_type: "image/png",
media:
- "@@@langfuseMedia:type=image/png|id=cc48838a-3da8-4ca4-a007-2cf8df930e69|source=bytes@@@",
+ "data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///ywAAAAAAQABAAACAUwAOw==",
},
],
},
diff --git a/web/src/features/evals/v2/components/VariableMapping/components/SampleDataTreeSelector/SampleDataTreeSelector.tsx b/web/src/features/evals/v2/components/VariableMapping/components/SampleDataTreeSelector/SampleDataTreeSelector.tsx
index c20832537b..b3194c38d0 100644
--- a/web/src/features/evals/v2/components/VariableMapping/components/SampleDataTreeSelector/SampleDataTreeSelector.tsx
+++ b/web/src/features/evals/v2/components/VariableMapping/components/SampleDataTreeSelector/SampleDataTreeSelector.tsx
@@ -11,7 +11,7 @@ import {
WILDCARD,
type PathSegment,
} from "@/src/features/evals/v2/fns/variableMapping/segmentsToJsonPath";
-import { MediaTag } from "@/src/components/MediaTag/MediaTag";
+import { MediaReferenceTag } from "@/src/components/ui/media/MediaReferenceTag";
import {
classifyMediaValue,
splitStringByMediaReferences,
@@ -59,7 +59,6 @@ function MediaAwarePreview({
"text-muted-foreground flex min-w-0 flex-1 items-baseline gap-0.5 overflow-hidden text-xs leading-4",
directDescriptor && "self-center",
)}
- title={preview}
>
{segments.map((segment, index) =>
segment.type === "media" ? (
@@ -68,7 +67,7 @@ function MediaAwarePreview({
data-tree-row-action=""
className="inline-flex shrink-0 self-center"
>
- <MediaTag contentType={segment.descriptor.contentType} />
+ <MediaReferenceTag descriptor={segment.descriptor} />
</span>
) : (
<span
@@ -182,7 +181,13 @@ function TreeRow({
"flex min-w-0 cursor-pointer items-baseline gap-2 text-left",
hasMedia ? "shrink-0" : "flex-1",
)}
- title={expandable ? preview : `Pull {{${variable}}} from here`}
+ title={
+ hasMedia
+ ? undefined
+ : expandable
+ ? preview
+ : `Pull {{${variable}}} from here`
+ }
>
{expandable ? (
<ChevronDown