Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix: remove score chart style prop overrides (#16403)

Tobias Wochinger11cf12cfa93e
diff --git a/web/src/features/scores-chart-view/components/ScoreChartViewPanel/ScoreChartViewPanel.stories.tsx b/web/src/features/scores-chart-view/components/ScoreChartViewPanel/ScoreChartViewPanel.stories.tsx
index a9930285c6..f8c8bc4eb8 100644
--- a/web/src/features/scores-chart-view/components/ScoreChartViewPanel/ScoreChartViewPanel.stories.tsx
+++ b/web/src/features/scores-chart-view/components/ScoreChartViewPanel/ScoreChartViewPanel.stories.tsx
@@ -47,11 +47,6 @@ const meta = preview.meta({
config: CONFIG,
data: DATA,
onConfigChange: fn(),
- // In production the panel fills a bounded-height flex ancestor (`flex-1`
- // inside `ScoresChartView`); standalone it needs an explicit height. Give it
- // one through the component's own `className` prop rather than a layout
- // decorator (Storybook guide: render the component as it is).
- className: "h-[420px]",
},
});
diff --git a/web/src/features/scores-chart-view/components/ScoreChartViewPanel/ScoreChartViewPanel.tsx b/web/src/features/scores-chart-view/components/ScoreChartViewPanel/ScoreChartViewPanel.tsx
index db09c5f287..63632710fa 100644
--- a/web/src/features/scores-chart-view/components/ScoreChartViewPanel/ScoreChartViewPanel.tsx
+++ b/web/src/features/scores-chart-view/components/ScoreChartViewPanel/ScoreChartViewPanel.tsx
@@ -1,10 +1,8 @@
-/* eslint-disable @repo/no-style-props */
import React, { useCallback, useState } from "react";
import { AlertCircle, ChevronLeft, ChevronRight, Loader2 } from "lucide-react";
import { type DashboardWidgetChartType } from "@langfuse/shared/src/db";
import { type DataPoint } from "@/src/features/widgets/chart-library/chart-props";
import { Button } from "@/src/components/ui/button";
-import { cn } from "@/src/utils/tailwind";
// Chart type picker is view-agnostic (only depends on `DashboardWidgetChartType`),
// so it's reused as-is rather than duplicated.
import { ChartTypePicker } from "@/src/features/chart-view/components/ConfigControls";
@@ -44,7 +42,6 @@ export const ScoreChartViewPanel = React.memo(function ScoreChartViewPanel({
error = null,
emptyMessage,
chartActions,
- className,
}: {
config: ScoreChartViewConfig;
onConfigChange: (patch: Partial<ScoreChartViewConfig>) => void;
@@ -54,7 +51,6 @@ export const ScoreChartViewPanel = React.memo(function ScoreChartViewPanel({
emptyMessage?: string;
/** Right-aligned actions next to the chart subtitle (e.g. "Add to dashboard"). */
chartActions?: React.ReactNode;
- className?: string;
}) {
const [open, setOpen] = useState(true);
const metric = getScoreMetric(config.metric, config.dataset);
@@ -81,7 +77,7 @@ export const ScoreChartViewPanel = React.memo(function ScoreChartViewPanel({
);
return (
- <div className={cn("flex min-h-0 flex-1 flex-col md:flex-row", className)}>
+ <div className="flex min-h-0 flex-1 flex-col md:flex-row">
<div className="flex min-h-64 min-w-0 flex-1 flex-col gap-1 p-3 md:min-h-0">
<div className="flex items-center justify-between gap-2">
<div
diff --git a/web/src/features/scores-chart-view/components/ScoreOutlierBarStrip/ScoreOutlierBarStrip.tsx b/web/src/features/scores-chart-view/components/ScoreOutlierBarStrip/ScoreOutlierBarStrip.tsx
index b774e835a8..f19a59ab72 100644
--- a/web/src/features/scores-chart-view/components/ScoreOutlierBarStrip/ScoreOutlierBarStrip.tsx
+++ b/web/src/features/scores-chart-view/components/ScoreOutlierBarStrip/ScoreOutlierBarStrip.tsx
@@ -1,6 +1,4 @@
-/* eslint-disable @repo/no-style-props */
import { useCallback, useMemo, useRef, useState } from "react";
-import { cn } from "@/src/utils/tailwind";
import { X } from "lucide-react";
import { Button } from "@/src/components/ui/button";
import { Layer } from "@/src/components/ui/layer";
@@ -63,7 +61,6 @@ export type ScoreOutlierBarStripProps = {
onSelectionChange?: (range: { fromMs: number; toMs: number } | null) => void;
/** Why the chart cannot represent the current table state. */
disabledReason?: string;
- className?: string;
};
export function ScoreOutlierBarStrip({
@@ -82,7 +79,6 @@ export function ScoreOutlierBarStrip({
selection = null,
onSelectionChange,
disabledReason,
- className,
}: ScoreOutlierBarStripProps) {
const [hoverIndex, setHoverIndex] = useState<number | null>(null);
const [mouse, setMouse] = useState<{ x: number; y: number } | null>(null);
@@ -296,10 +292,7 @@ export function ScoreOutlierBarStrip({
if (disabledReason) {
return (
<div
- className={cn(
- "text-muted-foreground bg-muted/30 flex items-center justify-center rounded text-[11px]",
- className,
- )}
+ className="text-muted-foreground bg-muted/30 mt-1.5 flex items-center justify-center rounded text-[11px]"
style={{ width: widthPx, height: heightPx + labelHeight }}
aria-disabled="true"
>
@@ -309,7 +302,7 @@ export function ScoreOutlierBarStrip({
}
return (
- <div className={cn("relative", className)} style={{ width: widthPx }}>
+ <div className="relative mt-1.5" style={{ width: widthPx }}>
<svg
width={widthPx}
height={heightPx + labelHeight}
diff --git a/web/src/features/scores-chart-view/components/ScoresOutlierStrip.tsx b/web/src/features/scores-chart-view/components/ScoresOutlierStrip.tsx
index 552111c20a..12b1664a8a 100644
--- a/web/src/features/scores-chart-view/components/ScoresOutlierStrip.tsx
+++ b/web/src/features/scores-chart-view/components/ScoresOutlierStrip.tsx
@@ -301,7 +301,6 @@ export function ScoresOutlierStrip({
onAggregationChange={setAggregation}
/>
<ScoreOutlierBarStrip
- className="mt-1.5"
dense={[]}
maxValue={0}
ticks={[]}
@@ -335,7 +334,6 @@ export function ScoresOutlierStrip({
onAggregationChange={setAggregation}
/>
<ScoreOutlierBarStrip
- className="mt-1.5"
dense={series.dense}
maxValue={series.maxValue}
ticks={series.ticks}