Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(web): trace page title is the trace id (#17710)

Trang Nguyen11fe5cca6d63
diff --git a/web/src/components/table/peek/README.md b/web/src/components/table/peek/README.md
index 221f5d8793..d104a3577a 100644
--- a/web/src/components/table/peek/README.md
+++ b/web/src/components/table/peek/README.md
@@ -77,9 +77,9 @@ The full-page trace view keeps its own share-based, per-tab layout.
The peek and the standalone trace page already share one beta-aware fetch
([`../../trace/useTraceDetailData.ts`](../../../features/traces)), one
-body + title
+body
([`../../trace/TraceDetailBody.tsx`](../../../features/traces) →
-`TraceDetailBody` / `traceDetailTitle`), and one action set
+`TraceDetailBody`), and one action set
([`../../trace/TraceDetailActions.tsx`](../../../features/traces) —
star / publish / delete) — `usePeekData` is now a thin wrapper over the shared
hook. **Next slice:** collapse the `<Trace context>` branching and fold these
diff --git a/web/src/components/table/peek/peek-observation-detail.tsx b/web/src/components/table/peek/peek-observation-detail.tsx
index 2dd0f5d153..da6e3fa103 100644
--- a/web/src/components/table/peek/peek-observation-detail.tsx
+++ b/web/src/components/table/peek/peek-observation-detail.tsx
@@ -3,11 +3,7 @@ import {
shouldClosePeekAfterDelete,
} from "@/src/components/table/peek";
import { usePeekData } from "@/src/components/table/peek/hooks/usePeekData";
-import {
- TraceDetailActions,
- TraceDetailBody,
- traceDetailTitle,
-} from "@/src/features/traces";
+import { TraceDetailActions, TraceDetailBody } from "@/src/features/traces";
import { resolvePeekTraceParams } from "@/src/components/table/peek/resolvePeekTraceParams";
import { buildTracePath } from "@langfuse/shared";
import { useRouter } from "next/router";
@@ -72,7 +68,7 @@ export const TablePeekViewObservationDetail = (
return (
<TablePeekView
{...props}
- title={traceDetailTitle(trace.data, traceId)}
+ title={traceId}
actions={
actionProps ? <TraceDetailActions {...actionProps} /> : undefined
}
diff --git a/web/src/components/table/peek/peek-trace-detail.tsx b/web/src/components/table/peek/peek-trace-detail.tsx
index 8c9251373f..fa41bb6406 100644
--- a/web/src/components/table/peek/peek-trace-detail.tsx
+++ b/web/src/components/table/peek/peek-trace-detail.tsx
@@ -3,7 +3,6 @@ import { useRouter } from "next/router";
import { useRef } from "react";
import { TraceDetailActions } from "@/src/features/traces/components/TraceDetailActions";
import { TraceDetailBody } from "@/src/features/traces/components/TraceDetailBody";
-import { traceDetailTitle } from "@/src/features/traces/fns/traceDetailTitle";
import {
TablePeekView,
shouldClosePeekAfterDelete,
@@ -65,7 +64,7 @@ export const TablePeekViewTraceDetail = (
return (
<TablePeekView
{...tablePeekViewProps}
- title={traceDetailTitle(trace.data, traceId)}
+ title={traceId}
actions={
actionProps ? <TraceDetailActions {...actionProps} /> : undefined
}
diff --git a/web/src/features/traces/TracePage.tsx b/web/src/features/traces/TracePage.tsx
index 1ae5162485..4cbe3dac34 100644
--- a/web/src/features/traces/TracePage.tsx
+++ b/web/src/features/traces/TracePage.tsx
@@ -6,7 +6,6 @@ import { TraceDetailActions } from "@/src/features/traces/components/TraceDetail
import { useTraceDetailData } from "@/src/features/traces/hooks/useTraceDetailData";
import Page from "@/src/components/layouts/page";
import { TraceDetailBody } from "@/src/features/traces/components/TraceDetailBody";
-import { traceDetailTitle } from "@/src/features/traces/fns/traceDetailTitle";
import { useSession } from "next-auth/react";
import { useIsAuthenticatedAndProjectMember } from "@/src/features/auth";
import { Button } from "@/src/components/ui/button";
@@ -93,7 +92,7 @@ export function TracePage({
return (
<Page
headerProps={{
- title: traceDetailTitle(trace.data) ?? trace.data.id,
+ title: trace.data.id,
itemType: "TRACE",
breadcrumb: [
{
diff --git a/web/src/features/traces/fns/traceDetailTitle.ts b/web/src/features/traces/fns/traceDetailTitle.ts
deleted file mode 100644
index 2088706876..0000000000
--- a/web/src/features/traces/fns/traceDetailTitle.ts
+++ /dev/null
@@ -1,8 +0,0 @@
-/** Detail-view title (`name: id`, or just the id), shared by the peek + page. */
-export function traceDetailTitle(
- trace: { name?: string | null; id: string } | undefined,
- fallback?: string,
-): string | undefined {
- if (!trace) return fallback;
- return trace.name ? `${trace.name}: ${trace.id}` : trace.id;
-}
diff --git a/web/src/features/traces/index.ts b/web/src/features/traces/index.ts
index d29a6c6b70..947dd90c6d 100644
--- a/web/src/features/traces/index.ts
+++ b/web/src/features/traces/index.ts
@@ -13,7 +13,6 @@
export { Trace } from "@/src/features/traces/components/Trace";
export { TraceDetailActions } from "@/src/features/traces/components/TraceDetailActions";
export { TraceDetailBody } from "@/src/features/traces/components/TraceDetailBody";
-export { traceDetailTitle } from "@/src/features/traces/fns/traceDetailTitle";
export { useTraceDetailData } from "@/src/features/traces/hooks/useTraceDetailData";
export { BreakdownTooltip } from "@/src/features/traces/components/BreakdownTooltip";