Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor: Autofix nested ternary issues (#17780)

Ben Bachem147f3315b3ef
diff --git a/packages/shared/clickhouse/scripts/prepare-migrations.mjs b/packages/shared/clickhouse/scripts/prepare-migrations.mjs
index b5e9b0d1eb..0afe6bd7da 100644
--- a/packages/shared/clickhouse/scripts/prepare-migrations.mjs
+++ b/packages/shared/clickhouse/scripts/prepare-migrations.mjs
@@ -1,6 +1,4 @@
#!/usr/bin/env node
-/* eslint-disable no-nested-ternary */
-
import {
cpSync,
existsSync,
@@ -88,12 +86,15 @@ function renderMigration(
);
}
- const clusterClause =
- mode === "clustered"
- ? clusterName === "default"
- ? "ON CLUSTER default"
- : `ON CLUSTER ${quoteClickHouseString(clusterName)}`
- : "";
+ const clusterClause = (() => {
+ if (mode === "clustered") {
+ if (clusterName === "default") {
+ return "ON CLUSTER default";
+ }
+ return `ON CLUSTER ${quoteClickHouseString(clusterName)}`;
+ }
+ return "";
+ })();
const replicationPrefix = mode === "clustered" ? "Replicated" : "";
let rendered = source
diff --git a/packages/shared/scripts/seeder/cli-main.ts b/packages/shared/scripts/seeder/cli-main.ts
index 9476500e85..29189a191e 100644
--- a/packages/shared/scripts/seeder/cli-main.ts
+++ b/packages/shared/scripts/seeder/cli-main.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/**
* Langfuse seed CLI — one-shot local test data for humans and coding agents.
*
@@ -154,12 +153,15 @@ const printDoctor = (
return;
}
for (const check of result.checks) {
- const icon =
- check.status === "pass"
- ? "PASS"
- : check.status === "warn"
- ? "WARN"
- : "FAIL";
+ const icon = (() => {
+ if (check.status === "pass") {
+ return "PASS";
+ }
+ if (check.status === "warn") {
+ return "WARN";
+ }
+ return "FAIL";
+ })();
console.log(`${icon} ${check.name.padEnd(22)} ${check.detail}`);
if (check.fix && check.status !== "pass") {
console.log(` fix: ${check.fix}`);
diff --git a/packages/shared/scripts/seeder/scenarios/long-session.ts b/packages/shared/scripts/seeder/scenarios/long-session.ts
index a7aada348a..ecf370863a 100644
--- a/packages/shared/scripts/seeder/scenarios/long-session.ts
+++ b/packages/shared/scripts/seeder/scenarios/long-session.ts
@@ -129,12 +129,15 @@ const run = async (
const isHuge = t > 0 && t % 17 === 0;
const style: PayloadStyle =
t % 7 === 3 ? "unicode" : rng.bool(0.6) ? "json" : "text";
- const name =
- t % 9 === 4
- ? `${rng.pick(TRACE_NAMES)}-with-a-very-long-descriptive-name-${"y".repeat(120)}`
- : t % 7 === 3
- ? `多言語サポート ${rng.pick(TRACE_NAMES)}`
- : rng.pick(TRACE_NAMES);
+ const name = (() => {
+ if (t % 9 === 4) {
+ return `${rng.pick(TRACE_NAMES)}-with-a-very-long-descriptive-name-${"y".repeat(120)}`;
+ }
+ if (t % 7 === 3) {
+ return `多言語サポート ${rng.pick(TRACE_NAMES)}`;
+ }
+ return rng.pick(TRACE_NAMES);
+ })();
const trace = createTrace({
id: traceId,
diff --git a/packages/shared/scripts/seeder/scenarios/outlier-traffic.ts b/packages/shared/scripts/seeder/scenarios/outlier-traffic.ts
index 76a2d2a93d..bee9c36b41 100644
--- a/packages/shared/scripts/seeder/scenarios/outlier-traffic.ts
+++ b/packages/shared/scripts/seeder/scenarios/outlier-traffic.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import {
createTrace,
createObservation,
@@ -189,15 +188,36 @@ const run = async (
const latencyOutlier = g % 71 === 3;
const tokenOutlier = g % 113 === 7;
- const usageScale = costOutlier || megaCost ? 30 : tokenOutlier ? 25 : 1;
- const rateMultiplier = megaCost
- ? 12 * 4
- : costOutlier
- ? 4
- : tokenOutlier
- ? 0.05
- : 1;
- const durationScale = latencyOutlier ? 35 : isIncident ? 8 : 1;
+ const usageScale = (() => {
+ if (costOutlier || megaCost) {
+ return 30;
+ }
+ if (tokenOutlier) {
+ return 25;
+ }
+ return 1;
+ })();
+ const rateMultiplier = (() => {
+ if (megaCost) {
+ return 12 * 4;
+ }
+ if (costOutlier) {
+ return 4;
+ }
+ if (tokenOutlier) {
+ return 0.05;
+ }
+ return 1;
+ })();
+ const durationScale = (() => {
+ if (latencyOutlier) {
+ return 35;
+ }
+ if (isIncident) {
+ return 8;
+ }
+ return 1;
+ })();
const usageInput =
(200 + jitter(ctx.seed, g * 17 + 3, 5000)) * usageScale;
diff --git a/packages/shared/scripts/seeder/scenarios/session-shapes.ts b/packages/shared/scripts/seeder/scenarios/session-shapes.ts
index 255fd40e45..8a1fe5234f 100644
--- a/packages/shared/scripts/seeder/scenarios/session-shapes.ts
+++ b/packages/shared/scripts/seeder/scenarios/session-shapes.ts
@@ -543,21 +543,25 @@ const buildMediaTrace = (
image_url: { url: fixtures.image.referenceString },
};
- const userContent =
- variant === "bare-refs"
- ? [fixtures.image.referenceString, fixtures.pdf.referenceString]
- : variant === "collapsed-prompt"
- ? prompt.user
- : variant === "inline-image"
- ? [{ type: "text", text: prompt.user }, imagePart]
- : [
- { type: "text", text: prompt.user },
- imagePart,
- {
- type: "input_audio",
- input_audio: { data: fixtures.audio.referenceString },
- },
- ];
+ const userContent = (() => {
+ if (variant === "bare-refs") {
+ return [fixtures.image.referenceString, fixtures.pdf.referenceString];
+ }
+ if (variant === "collapsed-prompt") {
+ return prompt.user;
+ }
+ if (variant === "inline-image") {
+ return [{ type: "text", text: prompt.user }, imagePart];
+ }
+ return [
+ { type: "text", text: prompt.user },
+ imagePart,
+ {
+ type: "input_audio",
+ input_audio: { data: fixtures.audio.referenceString },
+ },
+ ];
+ })();
// collapsed-prompt hangs the attachment off the long SYSTEM message, which is
// the message the UI collapses by default.
diff --git a/packages/shared/scripts/seeder/scenarios/trace-tree.ts b/packages/shared/scripts/seeder/scenarios/trace-tree.ts
index 1667e1c99c..f1aed2a3cb 100644
--- a/packages/shared/scripts/seeder/scenarios/trace-tree.ts
+++ b/packages/shared/scripts/seeder/scenarios/trace-tree.ts
@@ -101,12 +101,15 @@ const buildTreeShape = (
// jitter() not rng for kinds: observation `type` is the 2nd v3 ORDER BY
// column, and stream-position randomness would re-key rows when flags
// that shift rng consumption change between same-prefix re-runs.
- const kindAt = (index: number): ObservationType =>
- index < kinds.length
- ? kinds[index]
- : jitter(seed, index * 5 + 3, 9) < 4
- ? "GENERATION"
- : kinds[jitter(seed, index * 5 + 4, kinds.length - 1)];
+ const kindAt = (index: number): ObservationType => {
+ if (index < kinds.length) {
+ return kinds[index];
+ }
+ if (jitter(seed, index * 5 + 3, 9) < 4) {
+ return "GENERATION";
+ }
+ return kinds[jitter(seed, index * 5 + 4, kinds.length - 1)];
+ };
for (let i = 0; i < count; i++) {
if (i === 0) {
@@ -361,11 +364,15 @@ const run = async (
const longName = node.index % 37 === 11;
const baseName = rng.pick(NAME_BY_KIND[node.kind]);
- const name = longName
- ? `${baseName}-with-an-extremely-long-name-${"x".repeat(140)}`
- : isFailedToolRetryPair
- ? `${baseName}-retry`
- : baseName;
+ const name = (() => {
+ if (longName) {
+ return `${baseName}-with-an-extremely-long-name-${"x".repeat(140)}`;
+ }
+ if (isFailedToolRetryPair) {
+ return `${baseName}-retry`;
+ }
+ return baseName;
+ })();
const payloadForNode = (): string | null => {
if (node.index === 0) return rootInput;
@@ -375,16 +382,22 @@ const run = async (
if (isGeneration) {
// Mostly long system prompts (collapse behavior), some name-bearing
// (title shows the name, not the role), a few short (no collapse).
- const systemMessage =
- node.index % 5 === 0
- ? { role: "system", content: "You are a helpful support agent." }
- : node.index % 3 === 1
- ? {
- role: "system",
- name: "support-agent-instructions",
- content: LONG_SYSTEM_PROMPT,
- }
- : { role: "system", content: LONG_SYSTEM_PROMPT };
+ const systemMessage = (() => {
+ if (node.index % 5 === 0) {
+ return {
+ role: "system",
+ content: "You are a helpful support agent.",
+ };
+ }
+ if (node.index % 3 === 1) {
+ return {
+ role: "system",
+ name: "support-agent-instructions",
+ content: LONG_SYSTEM_PROMPT,
+ };
+ }
+ return { role: "system", content: LONG_SYSTEM_PROMPT };
+ })();
return JSON.stringify({
messages: [
systemMessage,
diff --git a/packages/shared/scripts/seeder/utils/data-generators.ts b/packages/shared/scripts/seeder/utils/data-generators.ts
index 9455d43cb0..7b0d00a6dd 100644
--- a/packages/shared/scripts/seeder/utils/data-generators.ts
+++ b/packages/shared/scripts/seeder/utils/data-generators.ts
@@ -387,11 +387,15 @@ export class DataGenerator {
for (const evalJobConfiguration of SEED_EVALUATOR_CONFIGS) {
traces.forEach((trace, traceIndex) => {
for (let i = 0; i < observationsPerTrace; i++) {
- const obsType = this.randomBoolean(0.47)
- ? "GENERATION"
- : this.randomBoolean(0.94)
- ? "SPAN"
- : "EVENT";
+ const obsType = (() => {
+ if (this.randomBoolean(0.47)) {
+ return "GENERATION";
+ }
+ if (this.randomBoolean(0.94)) {
+ return "SPAN";
+ }
+ return "EVENT";
+ })();
const observation: ObservationRecordInsertType = createObservation({
id: generateEvalObservationId(
diff --git a/packages/shared/scripts/seeder/utils/framework-traces/framework-trace-loader.ts b/packages/shared/scripts/seeder/utils/framework-traces/framework-trace-loader.ts
index 9315b0011d..c21eea22c7 100644
--- a/packages/shared/scripts/seeder/utils/framework-traces/framework-trace-loader.ts
+++ b/packages/shared/scripts/seeder/utils/framework-traces/framework-trace-loader.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { readFileSync, readdirSync } from "fs";
import path from "path";
import {
@@ -146,27 +145,33 @@ export class FrameworkTraceLoader {
}
// Use usage/cost details from JSON if present, otherwise reconstruct from flat fields
- const usageDetails =
- obs.usageDetails && Object.keys(obs.usageDetails).length > 0
- ? obs.usageDetails
- : obs.totalUsage > 0
- ? {
- input: obs.inputUsage,
- output: obs.outputUsage,
- total: obs.totalUsage,
- }
- : undefined;
-
- const costDetails =
- obs.costDetails && Object.keys(obs.costDetails).length > 0
- ? obs.costDetails
- : obs.totalCost > 0
- ? {
- input: (obs.totalCost * obs.inputUsage) / obs.totalUsage,
- output: (obs.totalCost * obs.outputUsage) / obs.totalUsage,
- total: obs.totalCost,
- }
- : undefined;
+ const usageDetails = (() => {
+ if (obs.usageDetails && Object.keys(obs.usageDetails).length > 0) {
+ return obs.usageDetails;
+ }
+ if (obs.totalUsage > 0) {
+ return {
+ input: obs.inputUsage,
+ output: obs.outputUsage,
+ total: obs.totalUsage,
+ };
+ }
+ return undefined;
+ })();
+
+ const costDetails = (() => {
+ if (obs.costDetails && Object.keys(obs.costDetails).length > 0) {
+ return obs.costDetails;
+ }
+ if (obs.totalCost > 0) {
+ return {
+ input: (obs.totalCost * obs.inputUsage) / obs.totalUsage,
+ output: (obs.totalCost * obs.outputUsage) / obs.totalUsage,
+ total: obs.totalCost,
+ };
+ }
+ return undefined;
+ })();
observations.push(
createObservation({
diff --git a/packages/shared/src/in-app-agent/server/runLifecycle.ts b/packages/shared/src/in-app-agent/server/runLifecycle.ts
index bd0bd48c4a..d35a27a21d 100644
--- a/packages/shared/src/in-app-agent/server/runLifecycle.ts
+++ b/packages/shared/src/in-app-agent/server/runLifecycle.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { LangfuseConflictError } from "../../index";
import {
InAppAgentRunErrorCode,
@@ -520,18 +519,21 @@ async function cancelRunInTransaction(params: {
runId: string;
runStatus: InAppAgentRunStatus;
}): Promise<CancelRunResult> {
- const immediateCancel =
- params.runStatus === InAppAgentRunStatus.QUEUED
- ? {
- errorCode: InAppAgentRunErrorCode.CANCELLED,
- errorMessage: "Cancelled before a worker picked the run up",
- }
- : params.runStatus === InAppAgentRunStatus.AWAITING_APPROVAL
- ? {
- errorCode: InAppAgentRunErrorCode.APPROVAL_CANCELLED,
- errorMessage: "Approval cancelled",
- }
- : null;
+ const immediateCancel = (() => {
+ if (params.runStatus === InAppAgentRunStatus.QUEUED) {
+ return {
+ errorCode: InAppAgentRunErrorCode.CANCELLED,
+ errorMessage: "Cancelled before a worker picked the run up",
+ };
+ }
+ if (params.runStatus === InAppAgentRunStatus.AWAITING_APPROVAL) {
+ return {
+ errorCode: InAppAgentRunErrorCode.APPROVAL_CANCELLED,
+ errorMessage: "Approval cancelled",
+ };
+ }
+ return null;
+ })();
if (immediateCancel) {
const { count } = await params.tx.inAppAgentRun.updateMany({
diff --git a/packages/shared/src/server/filterToPrisma.ts b/packages/shared/src/server/filterToPrisma.ts
index a6e846c29d..83bb383719 100644
--- a/packages/shared/src/server/filterToPrisma.ts
+++ b/packages/shared/src/server/filterToPrisma.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { Prisma } from "@prisma/client";
import { ColumnDefinition, type TableNames } from "../tableDefinitions";
import { FilterState } from "../types";
@@ -68,20 +67,23 @@ export function tableColumnsToSqlFilter(
const statements = internalFilters.map((filterAndColumn) => {
const filter = filterAndColumn.condition;
- const operatorPrisma =
- filter.type === "arrayOptions"
- ? Prisma.raw(
- arrayOperatorReplacements[
- filter.operator as keyof typeof arrayOperatorReplacements
- ],
- )
- : filter.operator in operatorReplacements
- ? Prisma.raw(
- operatorReplacements[
- filter.operator as keyof typeof operatorReplacements
- ],
- )
- : Prisma.raw(filter.operator); //checked by zod
+ const operatorPrisma = (() => {
+ if (filter.type === "arrayOptions") {
+ return Prisma.raw(
+ arrayOperatorReplacements[
+ filter.operator as keyof typeof arrayOperatorReplacements
+ ],
+ );
+ }
+ if (filter.operator in operatorReplacements) {
+ return Prisma.raw(
+ operatorReplacements[
+ filter.operator as keyof typeof operatorReplacements
+ ],
+ );
+ }
+ return Prisma.raw(filter.operator);
+ })(); //checked by zod
// Get prisma value
let valuePrisma: Prisma.Sql;
@@ -215,15 +217,20 @@ export const datetimeFilterToPrismaSql = (
export const datetimeFilterToPrisma = (
timestampFilter: z.infer<typeof timeFilter>,
) => {
- const prismaTimestampFilter =
- timestampFilter.operator === ">="
- ? { gte: timestampFilter.value }
- : timestampFilter.operator === ">"
- ? { gt: timestampFilter.value }
- : timestampFilter.operator === "<="
- ? { lte: timestampFilter.value }
- : timestampFilter.operator === "<"
- ? { lt: timestampFilter.value }
- : {};
+ const prismaTimestampFilter = (() => {
+ if (timestampFilter.operator === ">=") {
+ return { gte: timestampFilter.value };
+ }
+ if (timestampFilter.operator === ">") {
+ return { gt: timestampFilter.value };
+ }
+ if (timestampFilter.operator === "<=") {
+ return { lte: timestampFilter.value };
+ }
+ if (timestampFilter.operator === "<") {
+ return { lt: timestampFilter.value };
+ }
+ return {};
+ })();
return prismaTimestampFilter;
};
diff --git a/packages/shared/src/server/llm/errors.ts b/packages/shared/src/server/llm/errors.ts
index 4ce2ebf422..833afda9e9 100644
--- a/packages/shared/src/server/llm/errors.ts
+++ b/packages/shared/src/server/llm/errors.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-exotic-operators */
import { AISDKError, APICallError, RetryError } from "ai";
@@ -115,11 +114,15 @@ export function getLLMErrorInfo(error: unknown): LLMErrorInfo | null {
};
}
- const aiSdkError = AISDKError.isInstance(resolvedError)
- ? resolvedError
- : AISDKError.isInstance(error)
- ? error
- : undefined;
+ const aiSdkError = (() => {
+ if (AISDKError.isInstance(resolvedError)) {
+ return resolvedError;
+ }
+ if (AISDKError.isInstance(error)) {
+ return error;
+ }
+ return undefined;
+ })();
if (aiSdkError) {
return {
kind: "ai-sdk",
diff --git a/packages/shared/src/server/media/MediaPayloadProcessor.ts b/packages/shared/src/server/media/MediaPayloadProcessor.ts
index 2dd1a3807c..866ca4fa37 100644
--- a/packages/shared/src/server/media/MediaPayloadProcessor.ts
+++ b/packages/shared/src/server/media/MediaPayloadProcessor.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-exotic-operators */
import { isMediaContentType, type MediaContentType } from "../../domain/media";
@@ -580,12 +579,15 @@ function matchStructuredMedia(
}
if (value.type === "file" && typeof value.mediaType === "string") {
- const property =
- typeof value.data === "string"
- ? "data"
- : typeof value.image === "string"
- ? "image"
- : undefined;
+ const property = (() => {
+ if (typeof value.data === "string") {
+ return "data";
+ }
+ if (typeof value.image === "string") {
+ return "image";
+ }
+ return undefined;
+ })();
if (property) {
return {
target: value,
diff --git a/packages/shared/src/server/queries/clickhouse-sql/clickhouse-filter.ts b/packages/shared/src/server/queries/clickhouse-sql/clickhouse-filter.ts
index dae050a76c..28c35306e2 100644
--- a/packages/shared/src/server/queries/clickhouse-sql/clickhouse-filter.ts
+++ b/packages/shared/src/server/queries/clickhouse-sql/clickhouse-filter.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import {
FTS_MATCH_OPERATOR,
type FtsMatchOperator,
@@ -324,12 +323,15 @@ export class StringOptionsFilter implements Filter {
ngramConjunct = `lower(${fieldWithPrefix}) IN ({${loweredVar}: Array(String)}) AND `;
}
- let query =
- this.operator === "any of"
- ? ngramConjunct
- ? `(${ngramConjunct}${fieldWithPrefix} IN ({${varName}: Array(String)}))`
- : `${fieldWithPrefix} IN ({${varName}: Array(String)})`
- : `${fieldWithPrefix} NOT IN ({${varName}: Array(String)})`;
+ let query = (() => {
+ if (this.operator === "any of") {
+ if (ngramConjunct) {
+ return `(${ngramConjunct}${fieldWithPrefix} IN ({${varName}: Array(String)}))`;
+ }
+ return `${fieldWithPrefix} IN ({${varName}: Array(String)})`;
+ }
+ return `${fieldWithPrefix} NOT IN ({${varName}: Array(String)})`;
+ })();
if (hasEmpty && this.operator === "any of") {
// '' ≡ NULL: also match NULL when '' is in the list
diff --git a/packages/shared/src/server/queries/clickhouse-sql/event-filter-options.ts b/packages/shared/src/server/queries/clickhouse-sql/event-filter-options.ts
index 18b3fd7feb..cce72aafd2 100644
--- a/packages/shared/src/server/queries/clickhouse-sql/event-filter-options.ts
+++ b/packages/shared/src/server/queries/clickhouse-sql/event-filter-options.ts
@@ -373,12 +373,15 @@ const optionRowsArrayExpression = (column: EventFilterOptionColumn) => {
const topAlias = optionTopAlias(column);
// Alpha facets use a constant sort key; the final ORDER BY value tie-breaker
// below provides alphabetical ordering within the top-k candidate set.
- const sortKeyExpression =
- definition.sort === "countDesc"
- ? "-toInt64(tupleElement(option, 2))"
- : definition.sort === "booleanAsc"
- ? "if(tupleElement(option, 1) = 'true', toInt64(1), toInt64(0))"
- : "toInt64(0)";
+ const sortKeyExpression = (() => {
+ if (definition.sort === "countDesc") {
+ return "-toInt64(tupleElement(option, 2))";
+ }
+ if (definition.sort === "booleanAsc") {
+ return "if(tupleElement(option, 1) = 'true', toInt64(1), toInt64(0))";
+ }
+ return "toInt64(0)";
+ })();
// labeledScalar top-k entries nest (value, label) in element 1; scalar/array/
// boolean entries put the value directly in element 1 and carry no label.
const isLabeled = definition.kind === "labeledScalar";
@@ -450,12 +453,15 @@ export const buildEventsFilterOptionColumnQuery = (params: {
),
);
- const valueExpression =
- definition.kind === "scalar" || definition.kind === "labeledScalar"
- ? `toString(${definition.expression})`
- : definition.kind === "boolean"
- ? `if(${definition.expression}, 'true', 'false')`
- : `arrayJoin(${optionValuesArrayExpression(definition)})`;
+ const valueExpression = (() => {
+ if (definition.kind === "scalar" || definition.kind === "labeledScalar") {
+ return `toString(${definition.expression})`;
+ }
+ if (definition.kind === "boolean") {
+ return `if(${definition.expression}, 'true', 'false')`;
+ }
+ return `arrayJoin(${optionValuesArrayExpression(definition)})`;
+ })();
const queryBuilder = new EventsAggQueryBuilder({
projectId: params.projectId,
@@ -634,12 +640,15 @@ const exactOptionRowsArrayExpression = (
// key = value (scalar / array / boolean)
// key = (value, label) (labeledScalar)
// Output row is cast to the named EVENTS_FILTER_OPTION_ROW_TUPLE_TYPE.
- const sortKeyExpression =
- definition.sort === "countDesc"
- ? "-toInt64(tupleElement(option, 2))"
- : definition.sort === "booleanAsc"
- ? "if(tupleElement(option, 1) = 'true', toInt64(1), toInt64(0))"
- : "toInt64(0)";
+ const sortKeyExpression = (() => {
+ if (definition.sort === "countDesc") {
+ return "-toInt64(tupleElement(option, 2))";
+ }
+ if (definition.sort === "booleanAsc") {
+ return "if(tupleElement(option, 1) = 'true', toInt64(1), toInt64(0))";
+ }
+ return "toInt64(0)";
+ })();
const valueExpression = isLabeled
? "tupleElement(tupleElement(option, 1), 1)"
: "tupleElement(option, 1)";
diff --git a/packages/shared/src/server/queries/clickhouse-sql/query-fragments.ts b/packages/shared/src/server/queries/clickhouse-sql/query-fragments.ts
index 1f9803de94..73030a85d7 100644
--- a/packages/shared/src/server/queries/clickhouse-sql/query-fragments.ts
+++ b/packages/shared/src/server/queries/clickhouse-sql/query-fragments.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/**
* Reusable ClickHouse query fragments and CTEs
*/
@@ -609,12 +608,15 @@ export const buildScoresCTE = (params: ScoresCTEParams): CTEWithSchema => {
queryParams.startTimeFrom = params.startTimeFrom;
}
- const observationFilter =
- params.level === "any"
- ? ""
- : params.level === "trace"
- ? "AND observation_id IS NULL"
- : "AND observation_id IS NOT NULL";
+ const observationFilter = (() => {
+ if (params.level === "any") {
+ return "";
+ }
+ if (params.level === "trace") {
+ return "AND observation_id IS NULL";
+ }
+ return "AND observation_id IS NOT NULL";
+ })();
const query = `
SELECT
diff --git a/packages/shared/src/server/redis/redis.ts b/packages/shared/src/server/redis/redis.ts
index 3ca72d8ea0..783dfaf095 100644
--- a/packages/shared/src/server/redis/redis.ts
+++ b/packages/shared/src/server/redis/redis.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import Redis, { RedisOptions, Cluster, ClusterOptions } from "ioredis";
import type { QueueBaseOptions } from "bullmq";
import fs from "fs";
@@ -314,23 +313,27 @@ export const createNewRedisInstance = (
const tlsOptions = buildTlsOptions();
- const instance = env.REDIS_CONNECTION_STRING
- ? new Redis(env.REDIS_CONNECTION_STRING, {
+ const instance = (() => {
+ if (env.REDIS_CONNECTION_STRING) {
+ return new Redis(env.REDIS_CONNECTION_STRING, {
...defaultRedisOptions,
...additionalOptions,
...tlsOptions,
- })
- : env.REDIS_HOST
- ? new Redis({
- host: String(env.REDIS_HOST),
- port: Number(env.REDIS_PORT),
- username: env.REDIS_USERNAME || undefined,
- password: env.REDIS_AUTH || undefined,
- ...defaultRedisOptions,
- ...additionalOptions,
- ...tlsOptions,
- })
- : null;
+ });
+ }
+ if (env.REDIS_HOST) {
+ return new Redis({
+ host: String(env.REDIS_HOST),
+ port: Number(env.REDIS_PORT),
+ username: env.REDIS_USERNAME || undefined,
+ password: env.REDIS_AUTH || undefined,
+ ...defaultRedisOptions,
+ ...additionalOptions,
+ ...tlsOptions,
+ });
+ }
+ return null;
+ })();
instance?.on("error", (error) => {
logRedisError("Redis error", error);
diff --git a/packages/shared/src/server/repositories/events.ts b/packages/shared/src/server/repositories/events.ts
index 077764b214..92edbb0fa5 100644
--- a/packages/shared/src/server/repositories/events.ts
+++ b/packages/shared/src/server/repositories/events.ts
@@ -852,12 +852,15 @@ async function getObservationsFromEventsTableInternal<T>(
const key = positionFilter.key;
const isFromEnd = key === "last" || key === "nthFromEnd";
const direction = isFromEnd ? "DESC" : "ASC";
- const position =
- key === "last" || key === "first" || key === "root"
- ? 1
- : typeof positionFilter.value === "number"
- ? positionFilter.value
- : 1;
+ const position = (() => {
+ if (key === "last" || key === "first" || key === "root") {
+ return 1;
+ }
+ if (typeof positionFilter.value === "number") {
+ return positionFilter.value;
+ }
+ return 1;
+ })();
// Build observation-only filter for CTE (no s.* or t.* references)
const nativeFilter = new FilterList(
@@ -902,11 +905,13 @@ async function getObservationsFromEventsTableInternal<T>(
: []),
]);
- return isTraceDeleteCursorSelect
- ? cursorOrderedBuilder.limitBy("e.trace_id", "e.project_id")
- : opts.dedupeBySpanId
- ? cursorOrderedBuilder.limitBy("e.span_id", "e.project_id")
- : cursorOrderedBuilder;
+ if (isTraceDeleteCursorSelect) {
+ return cursorOrderedBuilder.limitBy("e.trace_id", "e.project_id");
+ }
+ if (opts.dedupeBySpanId) {
+ return cursorOrderedBuilder.limitBy("e.span_id", "e.project_id");
+ }
+ return cursorOrderedBuilder;
})
.when(
!isCursorPagination &&
@@ -3886,11 +3891,15 @@ ORDER BY last_seen DESC
const hasAttribution =
row.ingestion_sdk_name &&
row.ingestion_sdk_name !== UNKNOWN_INGESTION_SDK_VALUE;
- const version = hasAttribution
- ? row.ingestion_sdk_version !== UNKNOWN_INGESTION_SDK_VALUE
- ? row.ingestion_sdk_version
- : ""
- : undefined;
+ const version = (() => {
+ if (hasAttribution) {
+ if (row.ingestion_sdk_version !== UNKNOWN_INGESTION_SDK_VALUE) {
+ return row.ingestion_sdk_version;
+ }
+ return "";
+ }
+ return undefined;
+ })();
return {
isOtel: true,
diff --git a/packages/shared/src/server/repositories/experiments.ts b/packages/shared/src/server/repositories/experiments.ts
index 939ad9bbd4..c1f15172c3 100644
--- a/packages/shared/src/server/repositories/experiments.ts
+++ b/packages/shared/src/server/repositories/experiments.ts
@@ -146,12 +146,15 @@ const experimentScoreCTE = (params: {
// The agnostic arrays carry the canonical column names the level-agnostic
// filters target; the trace-only mode keeps its prefix so legacy
// `trace_*` filters still resolve against a trace-only aggregate.
- const prefix =
- params.level === "any"
- ? ""
- : params.level === "observation"
- ? "obs_"
- : "trace_";
+ const prefix = (() => {
+ if (params.level === "any") {
+ return "";
+ }
+ if (params.level === "observation") {
+ return "obs_";
+ }
+ return "trace_";
+ })();
const joinedEventScores = new CTEQueryBuilder()
.withCTE("event_keys", {
diff --git a/packages/shared/src/server/repositories/scores.ts b/packages/shared/src/server/repositories/scores.ts
index fe382f076b..f7774b1957 100644
--- a/packages/shared/src/server/repositories/scores.ts
+++ b/packages/shared/src/server/repositories/scores.ts
@@ -515,12 +515,15 @@ const getScoresForTracesInternal = async <
} = props;
const select = formatMetadataSelect(excludeMetadata, includeHasMetadata);
- const levelFilter =
- level === "trace"
- ? "AND s.observation_id IS NULL"
- : level === "observation"
- ? "AND s.observation_id IS NOT NULL"
- : "";
+ const levelFilter = (() => {
+ if (level === "trace") {
+ return "AND s.observation_id IS NULL";
+ }
+ if (level === "observation") {
+ return "AND s.observation_id IS NOT NULL";
+ }
+ return "";
+ })();
const query = `
select
@@ -1598,11 +1601,15 @@ const getScoresUiGenericFromEvents = async <T>(props: {
// Inner join when trace filters are active (exclude scores without matching traces)
// Left join when only sorting (keep all scores)
- const eventsJoin = needsTracesCTE
- ? traceFilterState.length > 0
- ? `ANY JOIN traces e ON s.trace_id = e.id`
- : `LEFT ANY JOIN traces e ON s.trace_id = e.id`
- : "";
+ const eventsJoin = (() => {
+ if (needsTracesCTE) {
+ if (traceFilterState.length > 0) {
+ return `ANY JOIN traces e ON s.trace_id = e.id`;
+ }
+ return `LEFT ANY JOIN traces e ON s.trace_id = e.id`;
+ }
+ return "";
+ })();
// id and name are aliased because the traces CTE (joined as `e`) also exposes
// id and name: without the alias ClickHouse qualifies the output columns as
diff --git a/packages/shared/src/server/repositories/traces.ts b/packages/shared/src/server/repositories/traces.ts
index 1aeb5e08e5..0012a164d6 100644
--- a/packages/shared/src/server/repositories/traces.ts
+++ b/packages/shared/src/server/repositories/traces.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import {
commandClickhouse,
parseClickhouseUTCDateTimeFormat,
@@ -503,16 +502,24 @@ export const getTraceByIdFromTracesTable = async ({
tags: { projectId },
};
- const inputColumn = excludeInputOutput
- ? "''"
- : renderingProps.truncated
- ? `leftUTF8(input, ${env.LANGFUSE_SERVER_SIDE_IO_CHAR_LIMIT})`
- : "input";
- const outputColumn = excludeInputOutput
- ? "''"
- : renderingProps.truncated
- ? `leftUTF8(output, ${env.LANGFUSE_SERVER_SIDE_IO_CHAR_LIMIT})`
- : "output";
+ const inputColumn = (() => {
+ if (excludeInputOutput) {
+ return "''";
+ }
+ if (renderingProps.truncated) {
+ return `leftUTF8(input, ${env.LANGFUSE_SERVER_SIDE_IO_CHAR_LIMIT})`;
+ }
+ return "input";
+ })();
+ const outputColumn = (() => {
+ if (excludeInputOutput) {
+ return "''";
+ }
+ if (renderingProps.truncated) {
+ return `leftUTF8(output, ${env.LANGFUSE_SERVER_SIDE_IO_CHAR_LIMIT})`;
+ }
+ return "output";
+ })();
// map() (not a '{}' string literal) so the excluded column keeps the
// Map type and converts to an empty object in the domain model.
const metadataColumn = excludeMetadata ? "map()" : "metadata";
diff --git a/packages/shared/src/server/services/DatasetService/DatasetItemValidator.ts b/packages/shared/src/server/services/DatasetService/DatasetItemValidator.ts
index dd63a654e2..68c9eaaf88 100644
--- a/packages/shared/src/server/services/DatasetService/DatasetItemValidator.ts
+++ b/packages/shared/src/server/services/DatasetService/DatasetItemValidator.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { Prisma } from "../../../db";
import { FieldValidationError } from "../../../utils/jsonSchemaValidation";
import { parseJsonPrioritised } from "../../../utils/json";
@@ -163,17 +162,28 @@ export class DatasetItemValidator {
normalizeUndefinedToNull?: boolean;
}): ValidateItemResult {
// 1. Normalize IO for validation
- const inputToValidate = params.normalizeUndefinedToNull
- ? params.input === undefined || params.input === null
- ? null
- : params.input
- : params.input;
+ const inputToValidate = (() => {
+ if (params.normalizeUndefinedToNull) {
+ if (params.input === undefined || params.input === null) {
+ return null;
+ }
+ return params.input;
+ }
+ return params.input;
+ })();
- const outputToValidate = params.normalizeUndefinedToNull
- ? params.expectedOutput === undefined || params.expectedOutput === null
- ? null
- : params.expectedOutput
- : params.expectedOutput;
+ const outputToValidate = (() => {
+ if (params.normalizeUndefinedToNull) {
+ if (
+ params.expectedOutput === undefined ||
+ params.expectedOutput === null
+ ) {
+ return null;
+ }
+ return params.expectedOutput;
+ }
+ return params.expectedOutput;
+ })();
// 2. Validate IO against schema
return this.validator.validateItem({
diff --git a/packages/shared/src/server/services/InMemoryFilterService.ts b/packages/shared/src/server/services/InMemoryFilterService.ts
index 000ba306fd..e68acb9a8c 100644
--- a/packages/shared/src/server/services/InMemoryFilterService.ts
+++ b/packages/shared/src/server/services/InMemoryFilterService.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { FilterCondition, FilterState } from "../../types";
import { logger } from "../logger";
import { encodeBooleanScoreEntry } from "../queries/clickhouse-sql/clickhouse-filter";
@@ -375,12 +374,15 @@ export class InMemoryFilterService {
// null ("" via `null?.toString()` vs. the stored "null"), arrays ("1,2"
// vs. the stored "[1,2]"), and plain objects ("[object Object]" vs. the
// stored '{"a":1}').
- const stringValue =
- typeof objectValue === "string"
- ? objectValue
- : objectValue === undefined
- ? ""
- : JSON.stringify(objectValue);
+ const stringValue = (() => {
+ if (typeof objectValue === "string") {
+ return objectValue;
+ }
+ if (objectValue === undefined) {
+ return "";
+ }
+ return JSON.stringify(objectValue);
+ })();
return this.evaluateStringFilter(stringValue, filterValue, operator);
}
diff --git a/packages/shared/src/server/services/StorageService.ts b/packages/shared/src/server/services/StorageService.ts
index 43398c4fbb..8c4385ae71 100644
--- a/packages/shared/src/server/services/StorageService.ts
+++ b/packages/shared/src/server/services/StorageService.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { Readable } from "stream";
import { pipeline } from "stream/promises";
import {
@@ -1588,21 +1587,28 @@ class OCIObjectStorageService implements StorageService {
// UploadManager in the OCI SDK expects content shaped as one of:
// { blob }, { filePath }, or { stream }.
// To work reliably in Node, always provide { stream }.
- const stream =
- typeof data === "string"
- ? Readable.from([data])
- : data instanceof Readable
- ? data
- : Buffer.isBuffer(data as any)
- ? Readable.from([data as any])
- : Readable.from([String(data)]);
-
- const contentLength =
- typeof data === "string"
- ? Buffer.byteLength(data)
- : Buffer.isBuffer(data as any)
- ? (data as any).byteLength
- : undefined;
+ const stream = (() => {
+ if (typeof data === "string") {
+ return Readable.from([data]);
+ }
+ if (data instanceof Readable) {
+ return data;
+ }
+ if (Buffer.isBuffer(data as any)) {
+ return Readable.from([data as any]);
+ }
+ return Readable.from([String(data)]);
+ })();
+
+ const contentLength = (() => {
+ if (typeof data === "string") {
+ return Buffer.byteLength(data);
+ }
+ if (Buffer.isBuffer(data as any)) {
+ return (data as any).byteLength;
+ }
+ return undefined;
+ })();
await uploadManager.upload({
requestDetails: {
diff --git a/packages/shared/src/server/services/traces-ui-table-service.ts b/packages/shared/src/server/services/traces-ui-table-service.ts
index c7a47a7079..8954a59a05 100644
--- a/packages/shared/src/server/services/traces-ui-table-service.ts
+++ b/packages/shared/src/server/services/traces-ui-table-service.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { OrderByState } from "../../interfaces/orderBy";
import { scoreBooleansAggregation } from "../queries/clickhouse-sql/query-fragments";
import { tracesTableUiColumnDefinitions } from "../tableMappings";
@@ -483,12 +482,15 @@ async function getTracesTableGeneric(props: FetchTracesTableProps) {
usesNonFinalTraceReadPath
? "LIMIT 1 BY id, project_id"
: "";
- const limitClause =
- limit !== undefined && traceDeleteCursorOrder
- ? "LIMIT {limit: Int32}"
- : limit !== undefined && page !== undefined
- ? "LIMIT {limit: Int32} OFFSET {offset: Int32}"
- : "";
+ const limitClause = (() => {
+ if (limit !== undefined && traceDeleteCursorOrder) {
+ return "LIMIT {limit: Int32}";
+ }
+ if (limit !== undefined && page !== undefined) {
+ return "LIMIT {limit: Int32} OFFSET {offset: Int32}";
+ }
+ return "";
+ })();
// complex query ahead:
// - we only join scores and observations if we really need them to speed up default views
diff --git a/packages/shared/src/utils/chatml/adapters/microsoft-agent.ts b/packages/shared/src/utils/chatml/adapters/microsoft-agent.ts
index c6b3da975f..42658db650 100644
--- a/packages/shared/src/utils/chatml/adapters/microsoft-agent.ts
+++ b/packages/shared/src/utils/chatml/adapters/microsoft-agent.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import type { NormalizerContext, ProviderAdapter } from "../types";
import {
parseMetadata,
@@ -38,13 +37,18 @@ function isRecord(value: unknown): value is Record<string, unknown> {
}
function hasPydanticAiMessageMarkers(data: unknown): boolean {
- const messages = Array.isArray(data)
- ? data
- : isRecord(data) && Array.isArray(data.messages)
- ? data.messages
- : isRecord(data)
- ? [data]
- : [];
+ const messages = (() => {
+ if (Array.isArray(data)) {
+ return data;
+ }
+ if (isRecord(data) && Array.isArray(data.messages)) {
+ return data.messages;
+ }
+ if (isRecord(data)) {
+ return [data];
+ }
+ return [];
+ })();
return messages.some((msg) => {
if (!isRecord(msg)) return false;
diff --git a/packages/shared/src/utils/chatml/adapters/pydantic-ai.ts b/packages/shared/src/utils/chatml/adapters/pydantic-ai.ts
index 465d533411..e87c7a8fd2 100644
--- a/packages/shared/src/utils/chatml/adapters/pydantic-ai.ts
+++ b/packages/shared/src/utils/chatml/adapters/pydantic-ai.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import type { NormalizerContext, ProviderAdapter } from "../types";
import {
removeNullFields,
@@ -67,12 +66,15 @@ function extractFromParts(parts: unknown[]): {
textParts.push(p.content);
} else if (p.type === "thinking") {
// Handle thinking parts - content can be in 'content' or 'thinking' field
- const thinkingContent =
- typeof p.content === "string"
- ? p.content
- : typeof p.thinking === "string"
- ? p.thinking
- : "";
+ const thinkingContent = (() => {
+ if (typeof p.content === "string") {
+ return p.content;
+ }
+ if (typeof p.thinking === "string") {
+ return p.thinking;
+ }
+ return "";
+ })();
if (thinkingContent) {
thinkingParts.push({
content: thinkingContent,
diff --git a/packages/shared/src/utils/normalized-io/core/accumulator/collect.ts b/packages/shared/src/utils/normalized-io/core/accumulator/collect.ts
index 7fc4a86c58..ef0b699c6c 100644
--- a/packages/shared/src/utils/normalized-io/core/accumulator/collect.ts
+++ b/packages/shared/src/utils/normalized-io/core/accumulator/collect.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { registeredProviders } from "../../conventions";
import type { MessageSource } from "../../conventions/io-convention";
import {
@@ -61,11 +60,15 @@ function collectRootToolDefinitions(
]) {
const parsed = parseIfString(root[key]);
const candidate = parseRecord(parsed);
- const values = Array.isArray(parsed)
- ? parsed
- : candidate
- ? [candidate]
- : [];
+ const values = (() => {
+ if (Array.isArray(parsed)) {
+ return parsed;
+ }
+ if (candidate) {
+ return [candidate];
+ }
+ return [];
+ })();
for (const value of values) {
const record = asRecord(value);
if (!record) continue;
diff --git a/packages/shared/src/utils/normalized-io/core/normalize/message.ts b/packages/shared/src/utils/normalized-io/core/normalize/message.ts
index d4004d2bde..a2ef555810 100644
--- a/packages/shared/src/utils/normalized-io/core/normalize/message.ts
+++ b/packages/shared/src/utils/normalized-io/core/normalize/message.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import type {
MessageEnvelopeContext,
PartHandlerContext,
@@ -22,13 +21,18 @@ function normalizeMessageContent(
nestedContent: Record<string, unknown> | undefined,
parserContext: ParserContext,
): NormalizedMessagePart[] {
- const rawParts = Array.isArray(value.parts)
- ? value.parts
- : Array.isArray(value.content)
- ? value.content
- : Array.isArray(nestedContent?.parts)
- ? nestedContent.parts
- : undefined;
+ const rawParts = (() => {
+ if (Array.isArray(value.parts)) {
+ return value.parts;
+ }
+ if (Array.isArray(value.content)) {
+ return value.content;
+ }
+ if (Array.isArray(nestedContent?.parts)) {
+ return nestedContent.parts;
+ }
+ return undefined;
+ })();
if (rawParts) return normalizePartList(rawParts, parserContext);
if (typeof value.content === "string" && value.content.length > 0) {
diff --git a/web/scripts/structure/move.mjs b/web/scripts/structure/move.mjs
index 429f9040cd..a10f35d3e3 100644
--- a/web/scripts/structure/move.mjs
+++ b/web/scripts/structure/move.mjs
@@ -1,5 +1,4 @@
#!/usr/bin/env node
-/* eslint-disable no-nested-ternary */
// structure:move — move files/folders and rewrite every importer, the way an
// IDE does: TypeScript's own LanguageService.getEditsForFileRename over
// web/tsconfig.json, so `@/src/...` aliases, extension-less specifiers, index
@@ -360,12 +359,15 @@ const scriptFileNames = new Set(parsed.fileNames.map(norm));
let projectVersion = 0;
/** @type {(p: string) => string | undefined} */
-const currentText = (p) =>
- overlay.has(p)
- ? overlay.get(p)
- : removed.has(p)
- ? undefined
- : ts.sys.readFile(p);
+const currentText = (p) => {
+ if (overlay.has(p)) {
+ return overlay.get(p);
+ }
+ if (removed.has(p)) {
+ return undefined;
+ }
+ return ts.sys.readFile(p);
+};
/** @type {(p: string, text: string) => void} */
const setText = (p, text) => {
overlay.set(p, text);
diff --git a/web/scripts/structure/stats.mjs b/web/scripts/structure/stats.mjs
index 7c72f00c45..84410d543a 100644
--- a/web/scripts/structure/stats.mjs
+++ b/web/scripts/structure/stats.mjs
@@ -1,5 +1,4 @@
#!/usr/bin/env node
-/* eslint-disable no-nested-ternary */
// Structure stats — violations per project-structure-RFC rule over web/src.
//
// pnpm structure:stats per-rule counts (+ Δ vs baseline)
@@ -353,8 +352,15 @@ if (flag("json")) {
}
/** @type {(delta: number) => string} */
-const fmtDelta = (delta) =>
- delta === 0 ? dim("±0") : delta < 0 ? green(String(delta)) : red(`+${delta}`);
+const fmtDelta = (delta) => {
+ if (delta === 0) {
+ return dim("±0");
+ }
+ if (delta < 0) {
+ return green(String(delta));
+ }
+ return red(`+${delta}`);
+};
if (ruleFilter) {
const id = Number(ruleFilter);
diff --git a/web/src/__tests__/server/dashboard-v1-v2-consistency.servertest.ts b/web/src/__tests__/server/dashboard-v1-v2-consistency.servertest.ts
index 5a5e5f26f2..1b8db99c22 100644
--- a/web/src/__tests__/server/dashboard-v1-v2-consistency.servertest.ts
+++ b/web/src/__tests__/server/dashboard-v1-v2-consistency.servertest.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { testFeatureFlags } from "@/src/__tests__/fixtures/feature-flags";
import { v4 } from "uuid";
import { executeQuery } from "@langfuse/shared/query/server";
@@ -550,7 +549,15 @@ describe("dashboard v1 vs v2 consistency", () => {
/** Assert v2 count is within a relative tolerance of v1 count. */
function expectWithinFactor(v1Val: number, v2Val: number, maxFactor: number) {
- const ratio = v1Val > 0 ? v2Val / v1Val : v2Val === 0 ? 1 : Infinity;
+ const ratio = (() => {
+ if (v1Val > 0) {
+ return v2Val / v1Val;
+ }
+ if (v2Val === 0) {
+ return 1;
+ }
+ return Infinity;
+ })();
expect(ratio).toBeGreaterThan(1 / maxFactor);
expect(ratio).toBeLessThan(maxFactor);
}
diff --git a/web/src/__tests__/server/observation-api.servertest.ts b/web/src/__tests__/server/observation-api.servertest.ts
index 087e653f34..46d51ef4ff 100644
--- a/web/src/__tests__/server/observation-api.servertest.ts
+++ b/web/src/__tests__/server/observation-api.servertest.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import {
createEvent,
createObservation,
@@ -152,13 +151,18 @@ describe("/api/public/observations API Endpoint", () => {
`/api/public/observations/${observationId}?useEventsTable=${useEventsTable}`,
);
- const expectedModelId = useEventsTable
- ? "model_id" in observation
- ? observation.model_id
- : undefined
- : "internal_model_id" in observation
- ? observation.internal_model_id
- : undefined;
+ const expectedModelId = (() => {
+ if (useEventsTable) {
+ if ("model_id" in observation) {
+ return observation.model_id;
+ }
+ return undefined;
+ }
+ if ("internal_model_id" in observation) {
+ return observation.internal_model_id;
+ }
+ return undefined;
+ })();
expect(getEventRes.body).toMatchObject({
id: observationId,
diff --git a/web/src/__tests__/server/unit/v4TransitionRouter.servertest.ts b/web/src/__tests__/server/unit/v4TransitionRouter.servertest.ts
index a174f92606..6a49987c66 100644
--- a/web/src/__tests__/server/unit/v4TransitionRouter.servertest.ts
+++ b/web/src/__tests__/server/unit/v4TransitionRouter.servertest.ts
@@ -131,13 +131,21 @@ const sharedServerMock = vi.hoisted(() => ({
};
}
- const canonicalSdkName =
- normalizedSdkName === "python" || normalizedSdkName === "langfuse-python"
- ? "python"
- : normalizedSdkName === "javascript" ||
- normalizedSdkName.startsWith("@langfuse/")
- ? "javascript"
- : null;
+ const canonicalSdkName = (() => {
+ if (
+ normalizedSdkName === "python" ||
+ normalizedSdkName === "langfuse-python"
+ ) {
+ return "python";
+ }
+ if (
+ normalizedSdkName === "javascript" ||
+ normalizedSdkName.startsWith("@langfuse/")
+ ) {
+ return "javascript";
+ }
+ return null;
+ })();
if (!canonicalSdkName) {
return {
@@ -261,14 +269,18 @@ const mockSdkUsageRow = (overrides: {
overrides.deliveryMode ?? (source === "otel" ? "realtime" : "delayed");
const sdkName = overrides.sdkName ?? "python";
const sdkVersion = overrides.sdkVersion ?? "4.7.0";
- const canonicalSdkName =
- overrides.canonicalSdkName !== undefined
- ? overrides.canonicalSdkName
- : sdkName === "python" || sdkName === "langfuse-python"
- ? ("python" as const)
- : sdkName === "javascript" || sdkName.startsWith("@langfuse/")
- ? ("javascript" as const)
- : null;
+ const canonicalSdkName = (() => {
+ if (overrides.canonicalSdkName !== undefined) {
+ return overrides.canonicalSdkName;
+ }
+ if (sdkName === "python" || sdkName === "langfuse-python") {
+ return "python" as const;
+ }
+ if (sdkName === "javascript" || sdkName.startsWith("@langfuse/")) {
+ return "javascript" as const;
+ }
+ return null;
+ })();
const sdkVersionMajor =
overrides.sdkVersionMajor !== undefined
? overrides.sdkVersionMajor
@@ -276,12 +288,15 @@ const mockSdkUsageRow = (overrides: {
const resolvedMajor = Number.isFinite(Number(sdkVersionMajor))
? Number(sdkVersionMajor)
: null;
- const latestMajor =
- canonicalSdkName === "python"
- ? 4
- : canonicalSdkName === "javascript"
- ? 5
- : null;
+ const latestMajor = (() => {
+ if (canonicalSdkName === "python") {
+ return 4;
+ }
+ if (canonicalSdkName === "javascript") {
+ return 5;
+ }
+ return null;
+ })();
const v4MigrationStatus =
overrides.v4MigrationStatus ??
(canonicalSdkName === null || resolvedMajor === null
diff --git a/web/src/__tests__/test-utils.ts b/web/src/__tests__/test-utils.ts
index d94c72671f..059f6a3897 100644
--- a/web/src/__tests__/test-utils.ts
+++ b/web/src/__tests__/test-utils.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import {
CodeEvalExecutionQueue,
EvalExecutionQueue,
@@ -42,52 +41,59 @@ const getQueues = () => {
.filter(
(queueName) => !listOfQueuesToIgnore.includes(queueName as QueueName),
)
- .map((queueName) =>
- queueName.startsWith(QueueName.IngestionQueue)
- ? IngestionQueue.getInstance({ shardName: queueName })
- : queueName.startsWith(QueueName.IngestionSecondaryQueue)
- ? SecondaryIngestionQueue.getInstance({ shardName: queueName })
- : queueName.startsWith(QueueName.EvaluationExecution)
- ? EvalExecutionQueue.getInstance({ shardName: queueName })
- : queueName.startsWith(QueueName.EvaluationExecutionSecondaryQueue)
- ? SecondaryEvalExecutionQueue.getInstance({
- shardName: queueName,
- })
- : queueName.startsWith(QueueName.LLMAsJudgeExecution)
- ? LLMAsJudgeExecutionQueue.getInstance({
- shardName: queueName,
- })
- : queueName.startsWith(QueueName.CodeEvalExecution)
- ? CodeEvalExecutionQueue.getInstance({
- shardName: queueName,
- })
- : queueName.startsWith(QueueName.TraceUpsert)
- ? TraceUpsertQueue.getInstance({ shardName: queueName })
- : queueName.startsWith(
- QueueName.OtelIngestionSecondaryQueue,
- )
- ? SecondaryOtelIngestionQueue.getInstance({
- shardName: queueName,
- })
- : queueName.startsWith(QueueName.OtelIngestionQueue)
- ? OtelIngestionQueue.getInstance({
- shardName: queueName,
- })
- : getQueue(
- queueName as Exclude<
- QueueName,
- | QueueName.IngestionQueue
- | QueueName.IngestionSecondaryQueue
- | QueueName.EvaluationExecution
- | QueueName.EvaluationExecutionSecondaryQueue
- | QueueName.LLMAsJudgeExecution
- | QueueName.CodeEvalExecution
- | QueueName.TraceUpsert
- | QueueName.OtelIngestionQueue
- | QueueName.OtelIngestionSecondaryQueue
- >,
- ),
- );
+ .map((queueName) => {
+ if (queueName.startsWith(QueueName.IngestionQueue)) {
+ return IngestionQueue.getInstance({ shardName: queueName });
+ }
+ if (queueName.startsWith(QueueName.IngestionSecondaryQueue)) {
+ return SecondaryIngestionQueue.getInstance({ shardName: queueName });
+ }
+ if (queueName.startsWith(QueueName.EvaluationExecution)) {
+ return EvalExecutionQueue.getInstance({ shardName: queueName });
+ }
+ if (queueName.startsWith(QueueName.EvaluationExecutionSecondaryQueue)) {
+ return SecondaryEvalExecutionQueue.getInstance({
+ shardName: queueName,
+ });
+ }
+ if (queueName.startsWith(QueueName.LLMAsJudgeExecution)) {
+ return LLMAsJudgeExecutionQueue.getInstance({
+ shardName: queueName,
+ });
+ }
+ if (queueName.startsWith(QueueName.CodeEvalExecution)) {
+ return CodeEvalExecutionQueue.getInstance({
+ shardName: queueName,
+ });
+ }
+ if (queueName.startsWith(QueueName.TraceUpsert)) {
+ return TraceUpsertQueue.getInstance({ shardName: queueName });
+ }
+ if (queueName.startsWith(QueueName.OtelIngestionSecondaryQueue)) {
+ return SecondaryOtelIngestionQueue.getInstance({
+ shardName: queueName,
+ });
+ }
+ if (queueName.startsWith(QueueName.OtelIngestionQueue)) {
+ return OtelIngestionQueue.getInstance({
+ shardName: queueName,
+ });
+ }
+ return getQueue(
+ queueName as Exclude<
+ QueueName,
+ | QueueName.IngestionQueue
+ | QueueName.IngestionSecondaryQueue
+ | QueueName.EvaluationExecution
+ | QueueName.EvaluationExecutionSecondaryQueue
+ | QueueName.LLMAsJudgeExecution
+ | QueueName.CodeEvalExecution
+ | QueueName.TraceUpsert
+ | QueueName.OtelIngestionQueue
+ | QueueName.OtelIngestionSecondaryQueue
+ >,
+ );
+ });
};
export const disconnectQueues = async (disconnectTimeoutMs = 2_000) => {
diff --git a/web/src/components/PagedSettingsContainer.tsx b/web/src/components/PagedSettingsContainer.tsx
index c78fa4807a..65d8402795 100644
--- a/web/src/components/PagedSettingsContainer.tsx
+++ b/web/src/components/PagedSettingsContainer.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { cn } from "@/src/utils/tailwind";
import { ArrowUpRight } from "lucide-react";
import Link from "next/link";
@@ -33,13 +32,15 @@ export const PagedSettingsContainer = ({
fullHeight = false,
}: SettingsProps) => {
const router = useRouter();
- const availablePages = pages.filter((page) =>
- "show" in page
- ? typeof page.show === "function"
- ? page.show()
- : page.show
- : true,
- );
+ const availablePages = pages.filter((page) => {
+ if ("show" in page) {
+ if (typeof page.show === "function") {
+ return page.show();
+ }
+ return page.show;
+ }
+ return true;
+ });
const currentPage =
availablePages.find((page) => page.slug === activeSlug) ??
diff --git a/web/src/components/date-picker.tsx b/web/src/components/date-picker.tsx
index 1d6379efdc..b8b327527e 100644
--- a/web/src/components/date-picker.tsx
+++ b/web/src/components/date-picker.tsx
@@ -382,11 +382,15 @@ export function TimeRangePicker({
if (typeof disabled === "boolean") return disabled;
- const disabledArray = disabled
- ? Array.isArray(disabled)
- ? disabled
- : [disabled]
- : [];
+ const disabledArray = (() => {
+ if (disabled) {
+ if (Array.isArray(disabled)) {
+ return disabled;
+ }
+ return [disabled];
+ }
+ return [];
+ })();
const maxRangeDisabled =
maxRangeMs !== undefined &&
internalDateRange?.from &&
diff --git a/web/src/components/layouts/app-layout/right-drawer/AppContentWithRightDrawer.tsx b/web/src/components/layouts/app-layout/right-drawer/AppContentWithRightDrawer.tsx
index 5f00375b26..1fcd4eeffb 100644
--- a/web/src/components/layouts/app-layout/right-drawer/AppContentWithRightDrawer.tsx
+++ b/web/src/components/layouts/app-layout/right-drawer/AppContentWithRightDrawer.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { useSupportDrawer } from "@/src/features/support-chat";
import { useV4MigrationPanel } from "@/src/features/v4-migration/V4MigrationPanelProvider";
import { type PropsWithChildren } from "react";
@@ -58,11 +57,15 @@ export function AppContentWithRightDrawer({ children }: PropsWithChildren) {
const { open: supportOpen } = useSupportDrawer();
const { open: migrationOpen } = useV4MigrationPanel();
- const rightDrawerContent = supportOpen ? (
- <DynamicSupportDrawer />
- ) : migrationOpen ? (
- <DynamicV4MigrationPanel />
- ) : null;
+ const rightDrawerContent = (() => {
+ if (supportOpen) {
+ return <DynamicSupportDrawer />;
+ }
+ if (migrationOpen) {
+ return <DynamicV4MigrationPanel />;
+ }
+ return null;
+ })();
return (
<>
diff --git a/web/src/components/movable-resizable-panel.tsx b/web/src/components/movable-resizable-panel.tsx
index 322c07c3f5..321842931b 100644
--- a/web/src/components/movable-resizable-panel.tsx
+++ b/web/src/components/movable-resizable-panel.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-style-props */
"use client";
import {
@@ -396,32 +395,40 @@ function getResizedPanel(
const deltaY = clientY - interaction.startClientY;
const nextPosition = { ...interaction.startPosition };
const nextSize = { ...interaction.startSize };
- const maxWidth = interaction.direction.includes("left")
- ? Math.min(
+ const maxWidth = (() => {
+ if (interaction.direction.includes("left")) {
+ return Math.min(
constraints.maxWidth,
interaction.startPosition.left +
interaction.startSize.width -
bounds.minLeft,
- )
- : interaction.direction.includes("right")
- ? Math.min(
- constraints.maxWidth,
- bounds.maxRight - interaction.startPosition.left,
- )
- : constraints.maxWidth;
- const maxHeight = interaction.direction.includes("top")
- ? Math.min(
+ );
+ }
+ if (interaction.direction.includes("right")) {
+ return Math.min(
+ constraints.maxWidth,
+ bounds.maxRight - interaction.startPosition.left,
+ );
+ }
+ return constraints.maxWidth;
+ })();
+ const maxHeight = (() => {
+ if (interaction.direction.includes("top")) {
+ return Math.min(
constraints.maxHeight,
interaction.startPosition.top +
interaction.startSize.height -
bounds.minTop,
- )
- : interaction.direction.includes("bottom")
- ? Math.min(
- constraints.maxHeight,
- bounds.maxBottom - interaction.startPosition.top,
- )
- : constraints.maxHeight;
+ );
+ }
+ if (interaction.direction.includes("bottom")) {
+ return Math.min(
+ constraints.maxHeight,
+ bounds.maxBottom - interaction.startPosition.top,
+ );
+ }
+ return constraints.maxHeight;
+ })();
if (interaction.direction.includes("right")) {
nextSize.width = clamp(
diff --git a/web/src/components/score-tag.tsx b/web/src/components/score-tag.tsx
index 2241fc7c52..707ba30ba9 100644
--- a/web/src/components/score-tag.tsx
+++ b/web/src/components/score-tag.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { cva } from "class-variance-authority";
import { Tooltip } from "@/src/components/design-system/Tooltip/Tooltip";
@@ -43,16 +42,21 @@ export const scoreLevelFromScore = (score: {
traceId?: string | null;
sessionId?: string | null;
datasetRunId?: string | null;
-}): ScoreLevel =>
- score.observationId != null
- ? "observation"
- : score.traceId != null
- ? "trace"
- : score.sessionId != null
- ? "session"
- : score.datasetRunId != null
- ? "experiment"
- : "trace";
+}): ScoreLevel => {
+ if (score.observationId != null) {
+ return "observation";
+ }
+ if (score.traceId != null) {
+ return "trace";
+ }
+ if (score.sessionId != null) {
+ return "session";
+ }
+ if (score.datasetRunId != null) {
+ return "experiment";
+ }
+ return "trace";
+};
// The global score-level color coding: one hue per level, used identically on
// every surface. Hue pairs live in the design-system Badge and globals.css:
diff --git a/web/src/components/table/DataTable.stories.tsx b/web/src/components/table/DataTable.stories.tsx
index 5bb12942a9..560b4632b0 100644
--- a/web/src/components/table/DataTable.stories.tsx
+++ b/web/src/components/table/DataTable.stories.tsx
@@ -569,24 +569,27 @@ function useAsyncPagedData<TRow>({
const lastPageIndex = Math.ceil(totalCount / pagination.pageSize) - 1;
const hasNextPage = pagination.pageIndex < lastPageIndex;
- const paginationProp =
- mode === "none"
- ? undefined
- : mode === "offset"
- ? {
- totalCount,
- onChange,
- state: pagination,
- options: [10, 20, 50],
- }
- : {
- totalCount: null,
- hasNextPage,
- canJumpPages: false,
- onChange,
- state: pagination,
- options: [10, 20, 50],
- };
+ const paginationProp = (() => {
+ if (mode === "none") {
+ return undefined;
+ }
+ if (mode === "offset") {
+ return {
+ totalCount,
+ onChange,
+ state: pagination,
+ options: [10, 20, 50],
+ };
+ }
+ return {
+ totalCount: null,
+ hasNextPage,
+ canJumpPages: false,
+ onChange,
+ state: pagination,
+ options: [10, 20, 50],
+ };
+ })();
return { data, paginationProp, pagination };
}
diff --git a/web/src/components/table/ValueCell.tsx b/web/src/components/table/ValueCell.tsx
index dc0be3f028..682d62fa0c 100644
--- a/web/src/components/table/ValueCell.tsx
+++ b/web/src/components/table/ValueCell.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { memo, type JSX, useState } from "react";
import { useRouter } from "next/router";
import { type Row } from "@tanstack/react-table";
@@ -534,16 +533,20 @@ export const ValueCell = memo(
<DropdownMenuController
align="end"
maxWidth="320px"
- renderMenu={() =>
- rowActions ? (
- rowActions(row)
- ) : metadataActions ? (
- <ValueCellActionsMenuContent
- row={row}
- metadataActions={metadataActions}
- />
- ) : null
- }
+ renderMenu={() => {
+ if (rowActions) {
+ return rowActions(row);
+ }
+ if (metadataActions) {
+ return (
+ <ValueCellActionsMenuContent
+ row={row}
+ metadataActions={metadataActions}
+ />
+ );
+ }
+ return null;
+ }}
>
{({ isOpen, Trigger }) => (
<Trigger asChild>
diff --git a/web/src/components/table/data-table.tsx b/web/src/components/table/data-table.tsx
index c3422390c9..38746e126c 100644
--- a/web/src/components/table/data-table.tsx
+++ b/web/src/components/table/data-table.tsx
@@ -475,14 +475,20 @@ export function DataTable<TData extends object, TValue>({
const sortingEnabled = columnDef.enableSorting;
// if the header id does not translate to a valid css variable name, default to 150px as width
// may only happen for dynamic columns, as column names are user defined
- const width = columnDef.isFlexWidth
- ? "auto"
- : isValidCssVariableName({
- name: header.id,
- includesHyphens: false,
- })
- ? `calc(var(--header-${header.id}-size) * 1px)`
- : 150;
+ const width = (() => {
+ if (columnDef.isFlexWidth) {
+ return "auto";
+ }
+ if (
+ isValidCssVariableName({
+ name: header.id,
+ includesHyphens: false,
+ })
+ ) {
+ return `calc(var(--header-${header.id}-size) * 1px)`;
+ }
+ return 150;
+ })();
return header.column.getIsVisible() ? (
<TableHead
diff --git a/web/src/components/table/peek/peek-evaluator-config-detail.tsx b/web/src/components/table/peek/peek-evaluator-config-detail.tsx
index 0c1378c763..c12baaf425 100644
--- a/web/src/components/table/peek/peek-evaluator-config-detail.tsx
+++ b/web/src/components/table/peek/peek-evaluator-config-detail.tsx
@@ -82,11 +82,15 @@ const PeekViewEvaluatorConfigDetail = ({
isLegacyEvalTarget(evalConfig.targetObject) &&
(readOnly || legacyEditingDisabled);
const editModeDisabled = readOnly || !hasAccess || legacyEditingDisabled;
- const editModeDisabledReason = readOnly
- ? "This legacy evaluator is inactive and can only be viewed or deleted"
- : legacyEditingDisabled
- ? "Deprecated evaluators are only available in read-only mode"
- : undefined;
+ const editModeDisabledReason = (() => {
+ if (readOnly) {
+ return "This legacy evaluator is inactive and can only be viewed or deleted";
+ }
+ if (legacyEditingDisabled) {
+ return "Deprecated evaluators are only available in read-only mode";
+ }
+ return undefined;
+ })();
return (
<div className="grid h-full flex-1 grid-rows-[auto_auto_1fr] gap-2 overflow-hidden p-3 contain-layout">
diff --git a/web/src/components/ui/LangfuseMediaView.tsx b/web/src/components/ui/LangfuseMediaView.tsx
index d62a129433..bf940d5c4b 100644
--- a/web/src/components/ui/LangfuseMediaView.tsx
+++ b/web/src/components/ui/LangfuseMediaView.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-null-render */
import { api } from "@/src/utils/api";
import { cn } from "@/src/utils/tailwind";
@@ -203,20 +202,27 @@ function FileViewer({
image.src = src;
};
- const previewContent = isImage ? (
- <ResizableImage
- src={src}
- alt={fileName}
- isDefaultVisible={true}
- shouldValidateImageSource={false}
- fitContent
- compactWidth={compactImageWidth}
- />
- ) : isAudio ? (
- <AudioPlayer src={src} />
- ) : isVideo ? (
- <VideoPlayer src={src} />
- ) : null;
+ const previewContent = (() => {
+ if (isImage) {
+ return (
+ <ResizableImage
+ src={src}
+ alt={fileName}
+ isDefaultVisible={true}
+ shouldValidateImageSource={false}
+ fitContent
+ compactWidth={compactImageWidth}
+ />
+ );
+ }
+ if (isAudio) {
+ return <AudioPlayer src={src} />;
+ }
+ if (isVideo) {
+ return <VideoPlayer src={src} />;
+ }
+ return null;
+ })();
return (
<div
diff --git a/web/src/components/ui/MarkdownViewer.tsx b/web/src/components/ui/MarkdownViewer.tsx
index 7901e75cc2..56eb9495a4 100644
--- a/web/src/components/ui/MarkdownViewer.tsx
+++ b/web/src/components/ui/MarkdownViewer.tsx
@@ -676,13 +676,19 @@ export function MarkdownView({
? getSafeImageUrl(imageUrl)
: null;
- return safeImageUrl ? (
- <div key={index}>
- <ResizableImage src={safeImageUrl} />
- </div>
- ) : MediaReferenceStringSchema.safeParse(imageUrl).success ? (
- <LangfuseMediaView key={index} mediaReferenceString={imageUrl} />
- ) : (
+ if (safeImageUrl) {
+ return (
+ <div key={index}>
+ <ResizableImage src={safeImageUrl} />
+ </div>
+ );
+ }
+ if (MediaReferenceStringSchema.safeParse(imageUrl).success) {
+ return (
+ <LangfuseMediaView key={index} mediaReferenceString={imageUrl} />
+ );
+ }
+ return (
<div
key={index}
className="grid grid-cols-[auto_1fr] items-center gap-2"
diff --git a/web/src/components/ui/PromptReferences.tsx b/web/src/components/ui/PromptReferences.tsx
index 03de90e727..20282d18de 100644
--- a/web/src/components/ui/PromptReferences.tsx
+++ b/web/src/components/ui/PromptReferences.tsx
@@ -163,12 +163,15 @@ export const PromptReferenceButton = ({
);
}
- const promptRefSuffix =
- promptRef.type === "version"
- ? ` (v${promptRef.version})`
- : promptRef.label
- ? ` (${promptRef.label})`
- : "";
+ const promptRefSuffix = (() => {
+ if (promptRef.type === "version") {
+ return ` (v${promptRef.version})`;
+ }
+ if (promptRef.label) {
+ return ` (${promptRef.label})`;
+ }
+ return "";
+ })();
const promptRefTitle = `${promptRef.name}${promptRefSuffix}`;
diff --git a/web/src/components/ui/drawer.tsx b/web/src/components/ui/drawer.tsx
index da5d6879e6..6df617ffbf 100644
--- a/web/src/components/ui/drawer.tsx
+++ b/web/src/components/ui/drawer.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-style-props, @repo/no-margin-on-root-elements */
"use client";
@@ -90,16 +89,21 @@ const Drawer = ({
const isMediumScreen = useMediaQuery({
query: `(min-width: ${TAILWIND_MD_MEDIA_QUERY}px)`,
});
- const direction =
- forceDirection === "responsive"
- ? isMediumScreen
- ? "right"
- : "bottom"
- : forceDirection === "responsive-left"
- ? isMediumScreen
- ? "left"
- : "bottom"
- : forceDirection;
+ const direction = (() => {
+ if (forceDirection === "responsive") {
+ if (isMediumScreen) {
+ return "right";
+ }
+ return "bottom";
+ }
+ if (forceDirection === "responsive-left") {
+ if (isMediumScreen) {
+ return "left";
+ }
+ return "bottom";
+ }
+ return forceDirection;
+ })();
return (
<DrawerContext.Provider value={{ blockTextSelection, direction }}>
diff --git a/web/src/components/ui/resizable-split-layout.tsx b/web/src/components/ui/resizable-split-layout.tsx
index 52ae56aaac..8f493c2ad9 100644
--- a/web/src/components/ui/resizable-split-layout.tsx
+++ b/web/src/components/ui/resizable-split-layout.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-style-props */
import { type ReactNode, useCallback, useId, useLayoutEffect } from "react";
import {
@@ -82,11 +81,15 @@ export function ResizableSplitLayout({
: NOOP_LAYOUT_STORAGE;
const renderSecondaryPanel = keepSecondaryMounted || open;
- const panelIds = renderSecondaryPanel
- ? secondaryPosition === "left"
- ? [SECONDARY_PANEL_ID, PRIMARY_PANEL_ID]
- : [PRIMARY_PANEL_ID, SECONDARY_PANEL_ID]
- : [PRIMARY_PANEL_ID];
+ const panelIds = (() => {
+ if (renderSecondaryPanel) {
+ if (secondaryPosition === "left") {
+ return [SECONDARY_PANEL_ID, PRIMARY_PANEL_ID];
+ }
+ return [PRIMARY_PANEL_ID, SECONDARY_PANEL_ID];
+ }
+ return [PRIMARY_PANEL_ID];
+ })();
const secondaryPanelRef = usePanelRef();
diff --git a/web/src/ee/features/audit-log-viewer/AuditLogsSettingsPage.tsx b/web/src/ee/features/audit-log-viewer/AuditLogsSettingsPage.tsx
index ad3f716a03..d9010711a4 100644
--- a/web/src/ee/features/audit-log-viewer/AuditLogsSettingsPage.tsx
+++ b/web/src/ee/features/audit-log-viewer/AuditLogsSettingsPage.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import Header from "@/src/components/layouts/header";
import { Alert } from "@/src/components/design-system/Alert/Alert";
import { ConnectedAuditLogsTable } from "@/src/ee/features/audit-log-viewer/AuditLogsTable/ConnectedAuditLogsTable";
@@ -12,21 +11,29 @@ export function AuditLogsSettingsPage(props: { projectId: string }) {
});
const hasEntitlement = useHasEntitlement("audit-logs");
- const body = !hasEntitlement ? (
- <p className="text-muted-foreground text-sm">
- Audit logs are an Enterprise feature. Upgrade your plan to track all
- changes made to your project.
- </p>
- ) : !hasAccess ? (
- <Alert>
- <Alert.Title>Access Denied</Alert.Title>
- <Alert.Description>
- Contact your project administrator to request access.
- </Alert.Description>
- </Alert>
- ) : (
- <ConnectedAuditLogsTable scope="project" projectId={props.projectId} />
- );
+ const body = (() => {
+ if (!hasEntitlement) {
+ return (
+ <p className="text-muted-foreground text-sm">
+ Audit logs are an Enterprise feature. Upgrade your plan to track all
+ changes made to your project.
+ </p>
+ );
+ }
+ if (!hasAccess) {
+ return (
+ <Alert>
+ <Alert.Title>Access Denied</Alert.Title>
+ <Alert.Description>
+ Contact your project administrator to request access.
+ </Alert.Description>
+ </Alert>
+ );
+ }
+ return (
+ <ConnectedAuditLogsTable scope="project" projectId={props.projectId} />
+ );
+ })();
return (
<>
diff --git a/web/src/ee/features/audit-log-viewer/OrgAuditLogsSettingsPage.tsx b/web/src/ee/features/audit-log-viewer/OrgAuditLogsSettingsPage.tsx
index 105a0d0465..79b75ba302 100644
--- a/web/src/ee/features/audit-log-viewer/OrgAuditLogsSettingsPage.tsx
+++ b/web/src/ee/features/audit-log-viewer/OrgAuditLogsSettingsPage.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import Header from "@/src/components/layouts/header";
import { Alert } from "@/src/components/design-system/Alert/Alert";
import { ConnectedAuditLogsTable } from "@/src/ee/features/audit-log-viewer/AuditLogsTable/ConnectedAuditLogsTable";
@@ -12,21 +11,27 @@ export function OrgAuditLogsSettingsPage(props: { orgId: string }) {
});
const hasEntitlement = useHasEntitlement("audit-logs");
- const body = !hasEntitlement ? (
- <p className="text-muted-foreground text-sm">
- Audit logs are an Enterprise feature. Upgrade your plan to track all
- changes made to your organization.
- </p>
- ) : !hasAccess ? (
- <Alert>
- <Alert.Title>Access Denied</Alert.Title>
- <Alert.Description>
- Contact your organization administrator to request access.
- </Alert.Description>
- </Alert>
- ) : (
- <ConnectedAuditLogsTable scope="organization" orgId={props.orgId} />
- );
+ const body = (() => {
+ if (!hasEntitlement) {
+ return (
+ <p className="text-muted-foreground text-sm">
+ Audit logs are an Enterprise feature. Upgrade your plan to track all
+ changes made to your organization.
+ </p>
+ );
+ }
+ if (!hasAccess) {
+ return (
+ <Alert>
+ <Alert.Title>Access Denied</Alert.Title>
+ <Alert.Description>
+ Contact your organization administrator to request access.
+ </Alert.Description>
+ </Alert>
+ );
+ }
+ return <ConnectedAuditLogsTable scope="organization" orgId={props.orgId} />;
+ })();
return (
<>
diff --git a/web/src/features/ai-gateway/components/GatewayProvidersPage/components/GatewayProvidersView/GatewayProvidersView.tsx b/web/src/features/ai-gateway/components/GatewayProvidersPage/components/GatewayProvidersView/GatewayProvidersView.tsx
index 938a36628f..188490f225 100644
--- a/web/src/features/ai-gateway/components/GatewayProvidersPage/components/GatewayProvidersView/GatewayProvidersView.tsx
+++ b/web/src/features/ai-gateway/components/GatewayProvidersPage/components/GatewayProvidersView/GatewayProvidersView.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import {
createContext,
useCallback,
@@ -454,14 +453,15 @@ function ModelCount({
}
function ProviderName({ provider }: { provider: GatewayProvider }) {
- const icon =
- provider === "OPENAI" ? (
- <SiOpenai className="size-4" aria-hidden="true" />
- ) : provider === "ANTHROPIC" ? (
- <SiAnthropic className="size-4" aria-hidden="true" />
- ) : (
- <Route className="size-4" aria-hidden="true" />
- );
+ const icon = (() => {
+ if (provider === "OPENAI") {
+ return <SiOpenai className="size-4" aria-hidden="true" />;
+ }
+ if (provider === "ANTHROPIC") {
+ return <SiAnthropic className="size-4" aria-hidden="true" />;
+ }
+ return <Route className="size-4" aria-hidden="true" />;
+ })();
return (
<div className="flex items-center gap-2">
@@ -478,11 +478,14 @@ function ConnectionStatus({
}: {
status: GatewayConnectionRow["status"];
}) {
- const variant =
- status === "ENABLED"
- ? "success"
- : status === "ERROR"
- ? "error"
- : "secondary";
+ const variant = (() => {
+ if (status === "ENABLED") {
+ return "success";
+ }
+ if (status === "ERROR") {
+ return "error";
+ }
+ return "secondary";
+ })();
return <Badge variant={variant}>{status.toLowerCase()}</Badge>;
}
diff --git a/web/src/features/ai-gateway/server/provider/models/gatewayModelsService.ts b/web/src/features/ai-gateway/server/provider/models/gatewayModelsService.ts
index cc9f93179d..4964157366 100644
--- a/web/src/features/ai-gateway/server/provider/models/gatewayModelsService.ts
+++ b/web/src/features/ai-gateway/server/provider/models/gatewayModelsService.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import type { GatewayProvider, PrismaClient } from "@langfuse/shared/src/db";
import { redis as defaultRedis } from "@langfuse/shared/src/server";
import type { Cluster, Redis } from "ioredis";
@@ -75,5 +74,11 @@ function compareModels(
left: GatewayModelCatalogEntry,
right: GatewayModelCatalogEntry,
) {
- return left.id < right.id ? -1 : left.id > right.id ? 1 : 0;
+ if (left.id < right.id) {
+ return -1;
+ }
+ if (left.id > right.id) {
+ return 1;
+ }
+ return 0;
}
diff --git a/web/src/features/annotation-queues/components/AddTracesToAnnotationQueueDialogController.tsx b/web/src/features/annotation-queues/components/AddTracesToAnnotationQueueDialogController.tsx
index e4259e4811..4225fa788a 100644
--- a/web/src/features/annotation-queues/components/AddTracesToAnnotationQueueDialogController.tsx
+++ b/web/src/features/annotation-queues/components/AddTracesToAnnotationQueueDialogController.tsx
@@ -94,17 +94,21 @@ export function AddTracesToAnnotationQueueDialogController({
typeof queueCountQuery.data === "number" &&
queueCountQuery.data >= queueLimit;
- const createQueueState = !hasQueueAccess
- ? ({
+ const createQueueState = (() => {
+ if (!hasQueueAccess) {
+ return {
status: "disabled",
reason: "You don't have permission to create annotation queues.",
- } as const)
- : atQueueLimit
- ? ({
- status: "disabled",
- reason: "Maximum number of annotation queues reached for your plan.",
- } as const)
- : ({ status: "enabled" } as const);
+ } as const;
+ }
+ if (atQueueLimit) {
+ return {
+ status: "disabled",
+ reason: "Maximum number of annotation queues reached for your plan.",
+ } as const;
+ }
+ return { status: "enabled" } as const;
+ })();
const handleSelectSubmit = async (targetId: string) => {
await onAddToQueue({ projectId, targetId });
diff --git a/web/src/features/batch-actions/components/RunEvaluationDialog/index.tsx b/web/src/features/batch-actions/components/RunEvaluationDialog/index.tsx
index 32b3cabd4e..8e13989ba9 100644
--- a/web/src/features/batch-actions/components/RunEvaluationDialog/index.tsx
+++ b/web/src/features/batch-actions/components/RunEvaluationDialog/index.tsx
@@ -230,12 +230,15 @@ export function RunEvaluationDialog(props: RunEvaluationDialogProps) {
displayCount,
sourceTable,
});
- const mappingRunDisabledReason =
- selectedCount === 0
- ? "Attach at least one evaluator."
- : mappingsComplete
- ? null
- : "Map every evaluator variable to a source column before running.";
+ const mappingRunDisabledReason = (() => {
+ if (selectedCount === 0) {
+ return "Attach at least one evaluator.";
+ }
+ if (mappingsComplete) {
+ return null;
+ }
+ return "Map every evaluator variable to a source column before running.";
+ })();
const toggleEvaluatorSelection = (evaluatorId: string) => {
setSelectedEvaluators((previous) => {
diff --git a/web/src/features/blobstorage-integration/blobstorage-integration-router.ts b/web/src/features/blobstorage-integration/blobstorage-integration-router.ts
index 499e298fe4..c6f587caa0 100644
--- a/web/src/features/blobstorage-integration/blobstorage-integration-router.ts
+++ b/web/src/features/blobstorage-integration/blobstorage-integration-router.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { z } from "zod";
import { auditLog } from "@/src/features/audit-logs/server";
@@ -35,12 +34,15 @@ import {
InvalidRequestError,
} from "@langfuse/shared";
-const getAuditLogErrorType = (error: unknown) =>
- error instanceof TRPCError
- ? error.code
- : error instanceof Error
- ? error.name
- : "UnknownError";
+const getAuditLogErrorType = (error: unknown) => {
+ if (error instanceof TRPCError) {
+ return error.code;
+ }
+ if (error instanceof Error) {
+ return error.name;
+ }
+ return "UnknownError";
+};
const formatRootCause = (err: Error): string => {
// SDK errors (e.g. S3, GCS) carry a descriptive name like
diff --git a/web/src/features/chart-view/EventsChartView.tsx b/web/src/features/chart-view/EventsChartView.tsx
index 0d2e85d07c..9de1c00193 100644
--- a/web/src/features/chart-view/EventsChartView.tsx
+++ b/web/src/features/chart-view/EventsChartView.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import React, { useMemo } from "react";
import { type FilterState } from "@langfuse/shared";
import { api } from "@/src/utils/api";
@@ -61,12 +60,18 @@ export function EventsChartView({
[queryResult.data, config],
);
- const error = !validRange
- ? "Pick a wider time range to chart."
- : queryResult.isError
- ? (queryResult.error?.message ??
- "Couldn't build a chart for the current view.")
- : null;
+ const error = (() => {
+ if (!validRange) {
+ return "Pick a wider time range to chart.";
+ }
+ if (queryResult.isError) {
+ return (
+ queryResult.error?.message ??
+ "Couldn't build a chart for the current view."
+ );
+ }
+ return null;
+ })();
const widgetInput = useMemo(
() => chartConfigToWidgetInput({ config, filters }),
diff --git a/web/src/features/chart-view/lib/buildChartQuery.ts b/web/src/features/chart-view/lib/buildChartQuery.ts
index 82d7aadd95..343646ba3c 100644
--- a/web/src/features/chart-view/lib/buildChartQuery.ts
+++ b/web/src/features/chart-view/lib/buildChartQuery.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { type FilterState, type QueryType } from "@langfuse/shared";
import {
type DataPoint,
@@ -118,19 +117,27 @@ export function rowsToDataPoints(
}
}
- const dim = hasBreakdown
- ? dimensionValue(row[dimension.field as string])
- : isNumber
- ? undefined
- : metric.label;
+ const dim = (() => {
+ if (hasBreakdown) {
+ return dimensionValue(row[dimension.field as string]);
+ }
+ if (isNumber) {
+ return undefined;
+ }
+ return metric.label;
+ })();
// Preserve an explicit null on a time series as a GAP — never coerce it to
// 0 (the DataPoint contract, chart-props.ts: "null means measured nothing").
// Categorical/number charts still floor a missing value.
- const metricValue = Array.isArray(value)
- ? value
- : isTimeSeries && value == null
- ? null
- : Number(value ?? 0);
+ const metricValue = (() => {
+ if (Array.isArray(value)) {
+ return value;
+ }
+ if (isTimeSeries && value == null) {
+ return null;
+ }
+ return Number(value ?? 0);
+ })();
return { time_dimension, dimension: dim, metric: metricValue };
});
}
diff --git a/web/src/features/evals/components/code-eval-template-form-body.tsx b/web/src/features/evals/components/code-eval-template-form-body.tsx
index a34f830c22..b3e918b668 100644
--- a/web/src/features/evals/components/code-eval-template-form-body.tsx
+++ b/web/src/features/evals/components/code-eval-template-form-body.tsx
@@ -242,12 +242,15 @@ export function CodeEvalTemplateFormBody({
const shouldShowFormatButton = editable;
const canFormat =
editable && validationResult !== null && !validationResult.hasErrors;
- const formatDisabledReason =
- validationResult === null
- ? "Wait for code validation to finish before formatting."
- : validationResult.hasErrors
- ? "Fix the code validation errors before formatting."
- : null;
+ const formatDisabledReason = (() => {
+ if (validationResult === null) {
+ return "Wait for code validation to finish before formatting.";
+ }
+ if (validationResult.hasErrors) {
+ return "Fix the code validation errors before formatting.";
+ }
+ return null;
+ })();
// `onSourceCodeChange` comes from a react-hook-form render prop and changes
// identity as the field updates. Keep CodeMirror's handler stable so it does
// not reconfigure the editor on every keystroke. The refs are synced in an
diff --git a/web/src/features/evals/components/eval-templates-table.tsx b/web/src/features/evals/components/eval-templates-table.tsx
index 9f86d9d1dc..85957da4fc 100644
--- a/web/src/features/evals/components/eval-templates-table.tsx
+++ b/web/src/features/evals/components/eval-templates-table.tsx
@@ -75,12 +75,15 @@ const getMaintainerLabel = (maintainer: string) =>
const getCodeEvalLanguageLabel = (
sourceCodeLanguage?: EvalTemplate["sourceCodeLanguage"],
-) =>
- sourceCodeLanguage === EvalTemplateSourceCodeLanguage.PYTHON
- ? "Python"
- : sourceCodeLanguage === EvalTemplateSourceCodeLanguage.TYPESCRIPT
- ? "TypeScript"
- : "Code";
+) => {
+ if (sourceCodeLanguage === EvalTemplateSourceCodeLanguage.PYTHON) {
+ return "Python";
+ }
+ if (sourceCodeLanguage === EvalTemplateSourceCodeLanguage.TYPESCRIPT) {
+ return "TypeScript";
+ }
+ return "Code";
+};
const TemplateTypeBadge = ({
type,
@@ -91,12 +94,15 @@ const TemplateTypeBadge = ({
}) => {
if (type === EvalTemplateType.CODE) {
const label = getCodeEvalLanguageLabel(sourceCodeLanguage);
- const Icon =
- sourceCodeLanguage === EvalTemplateSourceCodeLanguage.PYTHON
- ? SiPython
- : sourceCodeLanguage === EvalTemplateSourceCodeLanguage.TYPESCRIPT
- ? SiTypescript
- : null;
+ const Icon = (() => {
+ if (sourceCodeLanguage === EvalTemplateSourceCodeLanguage.PYTHON) {
+ return SiPython;
+ }
+ if (sourceCodeLanguage === EvalTemplateSourceCodeLanguage.TYPESCRIPT) {
+ return SiTypescript;
+ }
+ return null;
+ })();
return (
<Badge className="w-fit gap-1.5" variant="outline-solid">
diff --git a/web/src/features/evals/components/evaluator-selector.tsx b/web/src/features/evals/components/evaluator-selector.tsx
index 122948b2d4..da9bd7930e 100644
--- a/web/src/features/evals/components/evaluator-selector.tsx
+++ b/web/src/features/evals/components/evaluator-selector.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-null-render */
import {
EvalTemplateSourceCodeLanguage,
@@ -35,12 +34,15 @@ const CodeTemplateLanguageIcon = ({
}: {
sourceCodeLanguage: EvalTemplate["sourceCodeLanguage"];
}) => {
- const language =
- sourceCodeLanguage === EvalTemplateSourceCodeLanguage.TYPESCRIPT
- ? { Icon: SiTypescript, title: "TypeScript" }
- : sourceCodeLanguage === EvalTemplateSourceCodeLanguage.PYTHON
- ? { Icon: SiPython, title: "Python" }
- : null;
+ const language = (() => {
+ if (sourceCodeLanguage === EvalTemplateSourceCodeLanguage.TYPESCRIPT) {
+ return { Icon: SiTypescript, title: "TypeScript" };
+ }
+ if (sourceCodeLanguage === EvalTemplateSourceCodeLanguage.PYTHON) {
+ return { Icon: SiPython, title: "Python" };
+ }
+ return null;
+ })();
if (!language) return null;
@@ -59,12 +61,15 @@ const CodeTemplateLanguageIcon = ({
const getCodeTemplateLanguageTitle = (
sourceCodeLanguage: EvalTemplate["sourceCodeLanguage"],
-) =>
- sourceCodeLanguage === EvalTemplateSourceCodeLanguage.PYTHON
- ? "Python"
- : sourceCodeLanguage === EvalTemplateSourceCodeLanguage.TYPESCRIPT
- ? "TypeScript"
- : "Code";
+) => {
+ if (sourceCodeLanguage === EvalTemplateSourceCodeLanguage.PYTHON) {
+ return "Python";
+ }
+ if (sourceCodeLanguage === EvalTemplateSourceCodeLanguage.TYPESCRIPT) {
+ return "TypeScript";
+ }
+ return "Code";
+};
const TemplatePreviewTooltipContent = ({
template,
diff --git a/web/src/features/evals/components/inner-evaluator-form.tsx b/web/src/features/evals/components/inner-evaluator-form.tsx
index 7ca7af4e7f..3d461213cb 100644
--- a/web/src/features/evals/components/inner-evaluator-form.tsx
+++ b/web/src/features/evals/components/inner-evaluator-form.tsx
@@ -689,11 +689,15 @@ export const InnerEvaluatorForm = (props: {
// For modern targets, derive status from runOnLive
const isModern = !isLegacyEvalTarget(values.target);
- const status = isModern
- ? values.runOnLive
- ? JobConfigState.ACTIVE
- : JobConfigState.INACTIVE
- : undefined;
+ const status = (() => {
+ if (isModern) {
+ if (values.runOnLive) {
+ return JobConfigState.ACTIVE;
+ }
+ return JobConfigState.INACTIVE;
+ }
+ return undefined;
+ })();
(props.mode === "edit" && props.existingEvaluator?.id
? updateJobMutation.mutateAsync({
diff --git a/web/src/features/evals/pages/new-evaluator.tsx b/web/src/features/evals/pages/new-evaluator.tsx
index 8fa4846d41..0f8ed191b8 100644
--- a/web/src/features/evals/pages/new-evaluator.tsx
+++ b/web/src/features/evals/pages/new-evaluator.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import Page from "@/src/components/layouts/page";
import {
BreadcrumbSeparator,
@@ -144,13 +143,18 @@ export default function NewEvaluatorPage() {
!hasDefaultModel &&
!isCheckingDefaultModel,
);
- const step = !evaluatorId
- ? "select"
- : isCheckingDefaultModel
- ? "loading"
- : shouldSetupDefaultModel
- ? "defaultModel"
- : "run";
+ const step = (() => {
+ if (!evaluatorId) {
+ return "select";
+ }
+ if (isCheckingDefaultModel) {
+ return "loading";
+ }
+ if (shouldSetupDefaultModel) {
+ return "defaultModel";
+ }
+ return "run";
+ })();
const selectedTemplateIsLlm = Boolean(
currentTemplate && !isCodeEvalTemplate(currentTemplate),
);
diff --git a/web/src/features/evals/server/codeEvalTestRun.ts b/web/src/features/evals/server/codeEvalTestRun.ts
index 8385f2b522..9f4a4befa0 100644
--- a/web/src/features/evals/server/codeEvalTestRun.ts
+++ b/web/src/features/evals/server/codeEvalTestRun.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import {
applyCommentFilters,
buildEvalExecutionData,
@@ -150,24 +149,27 @@ async function runCodeEvalTestForObservation(params: {
},
include: { evaluator: true },
});
- const codeTemplate =
- managedTemplate?.evaluator.type === EvalTemplateType.CODE
- ? {
- id: params.evalTemplateId,
- name: managedTemplate.name,
- version: 1,
- sourceCode: managedTemplate.evaluator.source,
- sourceCodeLanguage: managedTemplate.evaluator.language,
- }
- : storedVersion?.sourceCode && storedVersion.sourceCodeLanguage
- ? {
- id: storedVersion.evaluator.id,
- name: storedVersion.evaluator.name,
- version: storedVersion.version,
- sourceCode: storedVersion.sourceCode,
- sourceCodeLanguage: storedVersion.sourceCodeLanguage,
- }
- : null;
+ const codeTemplate = (() => {
+ if (managedTemplate?.evaluator.type === EvalTemplateType.CODE) {
+ return {
+ id: params.evalTemplateId,
+ name: managedTemplate.name,
+ version: 1,
+ sourceCode: managedTemplate.evaluator.source,
+ sourceCodeLanguage: managedTemplate.evaluator.language,
+ };
+ }
+ if (storedVersion?.sourceCode && storedVersion.sourceCodeLanguage) {
+ return {
+ id: storedVersion.evaluator.id,
+ name: storedVersion.evaluator.name,
+ version: storedVersion.version,
+ sourceCode: storedVersion.sourceCode,
+ sourceCodeLanguage: storedVersion.sourceCodeLanguage,
+ };
+ }
+ return null;
+ })();
if (!codeTemplate) {
throw new CodeEvalTestRunSetupError(
diff --git a/web/src/features/evals/server/router.ts b/web/src/features/evals/server/router.ts
index f7cc78f367..23f7bc0aab 100644
--- a/web/src/features/evals/server/router.ts
+++ b/web/src/features/evals/server/router.ts
@@ -237,14 +237,21 @@ const validateVariableMappingForTarget = ({
targetObject: string;
mapping: unknown;
}) => {
- const result =
- targetObject === EvalTargetObject.EVENT ||
- targetObject === EvalTargetObject.EXPERIMENT
- ? z.array(observationVariableMapping).safeParse(mapping)
- : targetObject === EvalTargetObject.TRACE ||
- targetObject === EvalTargetObject.DATASET
- ? z.array(variableMapping).safeParse(mapping)
- : null;
+ const result = (() => {
+ if (
+ targetObject === EvalTargetObject.EVENT ||
+ targetObject === EvalTargetObject.EXPERIMENT
+ ) {
+ return z.array(observationVariableMapping).safeParse(mapping);
+ }
+ if (
+ targetObject === EvalTargetObject.TRACE ||
+ targetObject === EvalTargetObject.DATASET
+ ) {
+ return z.array(variableMapping).safeParse(mapping);
+ }
+ return null;
+ })();
if (!result?.success) {
throw new TRPCError({
diff --git a/web/src/features/evals/utils/code-eval-template-completions.ts b/web/src/features/evals/utils/code-eval-template-completions.ts
index 11ebda3a13..45f8d361aa 100644
--- a/web/src/features/evals/utils/code-eval-template-completions.ts
+++ b/web/src/features/evals/utils/code-eval-template-completions.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import {
autocompletion,
type Completion,
@@ -876,12 +875,15 @@ function getPythonDataTypeValueCompletion(
return null;
}
- const operator =
- argument.name === "AssignOp"
- ? argument
- : argument.prevSibling?.name === "AssignOp"
- ? argument.prevSibling
- : null;
+ const operator = (() => {
+ if (argument.name === "AssignOp") {
+ return argument;
+ }
+ if (argument.prevSibling?.name === "AssignOp") {
+ return argument.prevSibling;
+ }
+ return null;
+ })();
const parameter = operator?.prevSibling;
if (
parameter?.name !== "VariableName" ||
diff --git a/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialog/EvaluatorSavedCostSummary.tsx b/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialog/EvaluatorSavedCostSummary.tsx
index 285f945d48..17f6a84bdb 100644
--- a/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialog/EvaluatorSavedCostSummary.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialog/EvaluatorSavedCostSummary.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { type EvalTemplateType, EvalTemplateTypeEnum } from "@langfuse/shared";
import { InfoTooltip } from "@/src/components/ui/InfoTooltip/InfoTooltip";
import { Skeleton } from "@/src/components/ui/skeleton";
@@ -41,12 +40,15 @@ export function EvaluatorSavedCostSummary({
}) {
const estimate = estimates[0];
const sampledObservations = Math.round(matchingObservations * sampling);
- const estimatedCostUsd =
- matchingObservations === 0
- ? 0
- : estimate
- ? estimate.matchingObservations * sampling * estimate.testRunCostUsd
- : null;
+ const estimatedCostUsd = (() => {
+ if (matchingObservations === 0) {
+ return 0;
+ }
+ if (estimate) {
+ return estimate.matchingObservations * sampling * estimate.testRunCostUsd;
+ }
+ return null;
+ })();
const backfillObservationCount = backfill.enabled
? Math.min(backfill.matchingObservations, backfill.maxItems)
: 0;
diff --git a/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialogContainer/EvaluatorSavedDialogContainer.tsx b/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialogContainer/EvaluatorSavedDialogContainer.tsx
index 7eb7c1d46a..ea651c7d6b 100644
--- a/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialogContainer/EvaluatorSavedDialogContainer.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialogContainer/EvaluatorSavedDialogContainer.tsx
@@ -395,12 +395,15 @@ export function EvaluatorSavedDialogContainer({
}
};
- const currentBackfillScope =
- mode === "test-filters"
- ? { filter: supportedRuleFilters, sampling: testFilterSampling }
- : selectedRule
- ? { filter: selectedRule.filter, sampling: selectedRule.sampling }
- : null;
+ const currentBackfillScope = (() => {
+ if (mode === "test-filters") {
+ return { filter: supportedRuleFilters, sampling: testFilterSampling };
+ }
+ if (selectedRule) {
+ return { filter: selectedRule.filter, sampling: selectedRule.sampling };
+ }
+ return null;
+ })();
const handlePrimaryAction = () => {
if (mode === "test-filters") {
@@ -568,59 +571,65 @@ export function EvaluatorSavedDialogContainer({
</div>
) : null;
- return dialogPhase === "saved" || dialogPhase === "closing-saved" ? (
- <EvaluatorSavedDialog
- open={dialogPhase === "saved"}
- mode={mode}
- modeContentByMode={modeContentByMode}
- backfillContent={backfillContent}
- costSummary={costSummary}
- canSubmit={
- !isEstimating &&
- !isCompleting &&
- (!backfill.enabled || !backfill.isEstimating) &&
- (!backfill.enabled || historicEvaluationLimit.isSuccess) &&
- (mode === "test-filters" || selectedRuleId !== undefined)
- }
- isSubmitting={
- attach.isPending ||
- createOrAttachFromEvaluatorFilters.isPending ||
- backfill.isScheduling ||
- isCompleting
- }
- primaryActionLabel={
- mode === "test-filters"
- ? "Execute"
- : selectedRule
+ if (dialogPhase === "saved" || dialogPhase === "closing-saved") {
+ return (
+ <EvaluatorSavedDialog
+ open={dialogPhase === "saved"}
+ mode={mode}
+ modeContentByMode={modeContentByMode}
+ backfillContent={backfillContent}
+ costSummary={costSummary}
+ canSubmit={
+ !isEstimating &&
+ !isCompleting &&
+ (!backfill.enabled || !backfill.isEstimating) &&
+ (!backfill.enabled || historicEvaluationLimit.isSuccess) &&
+ (mode === "test-filters" || selectedRuleId !== undefined)
+ }
+ isSubmitting={
+ attach.isPending ||
+ createOrAttachFromEvaluatorFilters.isPending ||
+ backfill.isScheduling ||
+ isCompleting
+ }
+ primaryActionLabel={
+ mode === "test-filters"
? "Execute"
- : "Open rule editor"
- }
- onModeChange={handleModeChange}
- onOpenAutoFocus={requestInitialEstimate}
- onDismiss={() => {
- createRuleHandoffPending.current = false;
- setDialogPhase("closed");
- onDismiss().catch(trpcErrorToast);
- }}
- onSecondaryAction={() => {
- setDialogPhase("closed");
- finish().catch(trpcErrorToast);
- }}
- onPrimaryAction={handlePrimaryAction}
- onCloseAnimationEnd={completeCreateRuleHandoff}
- />
- ) : dialogPhase === "create-rule" ? (
- <CreateRuleDialog
- projectId={projectId}
- open
- onOpenChange={(open) => {
- if (!open) {
- setDialogPhase("closed");
- finish().catch(() => undefined);
+ : selectedRule
+ ? "Execute"
+ : "Open rule editor"
}
- }}
- initialEvaluator={{ ...evaluator, initialVariableMapping: null }}
- successNotification="none"
- />
- ) : null;
+ onModeChange={handleModeChange}
+ onOpenAutoFocus={requestInitialEstimate}
+ onDismiss={() => {
+ createRuleHandoffPending.current = false;
+ setDialogPhase("closed");
+ onDismiss().catch(trpcErrorToast);
+ }}
+ onSecondaryAction={() => {
+ setDialogPhase("closed");
+ finish().catch(trpcErrorToast);
+ }}
+ onPrimaryAction={handlePrimaryAction}
+ onCloseAnimationEnd={completeCreateRuleHandoff}
+ />
+ );
+ }
+ if (dialogPhase === "create-rule") {
+ return (
+ <CreateRuleDialog
+ projectId={projectId}
+ open
+ onOpenChange={(open) => {
+ if (!open) {
+ setDialogPhase("closed");
+ finish().catch(() => undefined);
+ }
+ }}
+ initialEvaluator={{ ...evaluator, initialVariableMapping: null }}
+ successNotification="none"
+ />
+ );
+ }
+ return null;
}
diff --git a/web/src/features/evals/v2/components/Evaluators/EvaluatorSetupFooter/EvaluatorSetupFooter.tsx b/web/src/features/evals/v2/components/Evaluators/EvaluatorSetupFooter/EvaluatorSetupFooter.tsx
index 5ab7993d5e..a3cbdd1939 100644
--- a/web/src/features/evals/v2/components/Evaluators/EvaluatorSetupFooter/EvaluatorSetupFooter.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/EvaluatorSetupFooter/EvaluatorSetupFooter.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { useStore } from "zustand";
import { useShallow } from "zustand/react/shallow";
import { prepareEvaluatorDraft } from "@/src/features/evals/v2/fns/evaluators/prepareEvaluatorDraft";
@@ -62,18 +61,25 @@ export function EvaluatorSetupFooter({
}),
);
const hasUnsavedChanges = currentSnapshot !== initialSnapshot;
- const disabledReason =
- nameMissing && !nameAIAssistanceAvailable
- ? "Add an evaluator name before saving."
- : promptMessagesReason
- ? promptMessagesReason
- : scoreOutputReason
- ? scoreOutputReason
- : codeValidation &&
- !codeValidation.isPending &&
- !codeValidation.isValid
- ? "Fix the code validation errors before saving."
- : null;
+ const disabledReason = (() => {
+ if (nameMissing && !nameAIAssistanceAvailable) {
+ return "Add an evaluator name before saving.";
+ }
+ if (promptMessagesReason) {
+ return promptMessagesReason;
+ }
+ if (scoreOutputReason) {
+ return scoreOutputReason;
+ }
+ if (
+ codeValidation &&
+ !codeValidation.isPending &&
+ !codeValidation.isValid
+ ) {
+ return "Fix the code validation errors before saving.";
+ }
+ return null;
+ })();
const saveDisabled =
!canSubmit ||
Boolean(
diff --git a/web/src/features/evals/v2/components/Evaluators/Judges/PromptVariableEditor/PromptVariableEditor.tsx b/web/src/features/evals/v2/components/Evaluators/Judges/PromptVariableEditor/PromptVariableEditor.tsx
index 8f108540d8..0379bcfc8d 100644
--- a/web/src/features/evals/v2/components/Evaluators/Judges/PromptVariableEditor/PromptVariableEditor.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/Judges/PromptVariableEditor/PromptVariableEditor.tsx
@@ -86,11 +86,15 @@ function createVariableHighlighter(
: undefined));
const invalid = status?.status === "invalid";
const label = truncateEnd(mappingLabel || "map data", MAX_LABEL_LENGTH);
- const title = invalid
- ? (status.message ?? "Not connected to the sample data")
- : mappingLabel
- ? `Pulls from ${label}`
- : undefined;
+ const title = (() => {
+ if (invalid) {
+ return status.message ?? "Not connected to the sample data";
+ }
+ if (mappingLabel) {
+ return `Pulls from ${label}`;
+ }
+ return undefined;
+ })();
add(
from,
to,
diff --git a/web/src/features/evals/v2/components/Evaluators/Judges/ScoreOutputConfiguration/components/ScoreOutputSection/ScoreOutputSection.tsx b/web/src/features/evals/v2/components/Evaluators/Judges/ScoreOutputConfiguration/components/ScoreOutputSection/ScoreOutputSection.tsx
index cc8bea0adb..3a896f4be5 100644
--- a/web/src/features/evals/v2/components/Evaluators/Judges/ScoreOutputConfiguration/components/ScoreOutputSection/ScoreOutputSection.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/Judges/ScoreOutputConfiguration/components/ScoreOutputSection/ScoreOutputSection.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { useId, useState, type ReactNode } from "react";
import { ChevronDown, Plus, TriangleAlert } from "lucide-react";
@@ -142,14 +141,18 @@ export function ScoreOutputSection({
const minimum = state.minValue.trim();
const maximum = state.maxValue.trim();
- const numericBoundsLabel =
- minimum && maximum
- ? `between ${minimum} and ${maximum}`
- : minimum
- ? `of at least ${minimum}`
- : maximum
- ? `of at most ${maximum}`
- : "without limits";
+ const numericBoundsLabel = (() => {
+ if (minimum && maximum) {
+ return `between ${minimum} and ${maximum}`;
+ }
+ if (minimum) {
+ return `of at least ${minimum}`;
+ }
+ if (maximum) {
+ return `of at most ${maximum}`;
+ }
+ return "without limits";
+ })();
return (
<div className="flex flex-col gap-2">
diff --git a/web/src/features/evals/v2/components/Rules/ActivationConfirmationDialog/components/ActivationCostEstimateDetails/ActivationCostEstimateDetails.tsx b/web/src/features/evals/v2/components/Rules/ActivationConfirmationDialog/components/ActivationCostEstimateDetails/ActivationCostEstimateDetails.tsx
index 9917c21883..d4f1e539c3 100644
--- a/web/src/features/evals/v2/components/Rules/ActivationConfirmationDialog/components/ActivationCostEstimateDetails/ActivationCostEstimateDetails.tsx
+++ b/web/src/features/evals/v2/components/Rules/ActivationConfirmationDialog/components/ActivationCostEstimateDetails/ActivationCostEstimateDetails.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { Slider } from "@/src/components/ui/slider";
import { InfoTooltip } from "@/src/components/ui/InfoTooltip/InfoTooltip";
import {
@@ -34,11 +33,15 @@ export function ActivationCostEstimateDetails({
estimatedCostUsd:
estimate.matchingObservations * sampling * estimate.testRunCostUsd,
}));
- const description = hasNoMatchingObservations
- ? "No observations matched this rule in the last 7 days, so there is nothing to estimate yet. It will evaluate matching observations as they arrive."
- : hasOnlyUnavailableEstimates
- ? "Activating this rule may incur costs. Are you sure you want to continue?"
- : `${compactNumberFormatter(matchingObservations, 1)} observations matched this rule in the last 7 days.`;
+ const description = (() => {
+ if (hasNoMatchingObservations) {
+ return "No observations matched this rule in the last 7 days, so there is nothing to estimate yet. It will evaluate matching observations as they arrive.";
+ }
+ if (hasOnlyUnavailableEstimates) {
+ return "Activating this rule may incur costs. Are you sure you want to continue?";
+ }
+ return `${compactNumberFormatter(matchingObservations, 1)} observations matched this rule in the last 7 days.`;
+ })();
return (
<div className="flex flex-col gap-4">
diff --git a/web/src/features/evals/v2/fns/evaluatorTesting/buildCodeEvalContextSnippet.ts b/web/src/features/evals/v2/fns/evaluatorTesting/buildCodeEvalContextSnippet.ts
index 9babff0eef..3542f11c2b 100644
--- a/web/src/features/evals/v2/fns/evaluatorTesting/buildCodeEvalContextSnippet.ts
+++ b/web/src/features/evals/v2/fns/evaluatorTesting/buildCodeEvalContextSnippet.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import {
EvalTemplateSourceCodeLanguageEnum,
type EvalTemplateSourceCodeLanguage,
@@ -29,11 +28,13 @@ function serializeValue(
}
if (typeof value === "string") return JSON.stringify(truncate(value));
if (typeof value === "boolean") {
- return language === EvalTemplateSourceCodeLanguageEnum.PYTHON
- ? value
- ? "True"
- : "False"
- : String(value);
+ if (language === EvalTemplateSourceCodeLanguageEnum.PYTHON) {
+ if (value) {
+ return "True";
+ }
+ return "False";
+ }
+ return String(value);
}
if (typeof value === "number") return String(value);
if (Array.isArray(value)) {
diff --git a/web/src/features/evals/v2/fns/evaluators/prepareEvaluatorDraft.ts b/web/src/features/evals/v2/fns/evaluators/prepareEvaluatorDraft.ts
index aa10f81246..90eaf5b229 100644
--- a/web/src/features/evals/v2/fns/evaluators/prepareEvaluatorDraft.ts
+++ b/web/src/features/evals/v2/fns/evaluators/prepareEvaluatorDraft.ts
@@ -27,18 +27,21 @@ export function prepareEvaluatorDraft(params: EvaluatorSetupDraftState) {
const outputDefinition = buildScoreOutputDefinition(params.scoreOutput);
const promptMessagesValid =
getPromptMessagesValidationError(params.promptMessages) === null;
- const mappings =
- params.type === "LLM_AS_JUDGE"
- ? buildEvaluatorVariableMappings({
- promptMessages: params.promptMessages,
- variableFields: params.variableFields,
- })
- : params.type === "DECISION_MODEL"
- ? buildDecisionModelStateFields({
- stateKeys: params.stateKeys,
- variableFields: params.variableFields,
- })
- : [];
+ const mappings = (() => {
+ if (params.type === "LLM_AS_JUDGE") {
+ return buildEvaluatorVariableMappings({
+ promptMessages: params.promptMessages,
+ variableFields: params.variableFields,
+ });
+ }
+ if (params.type === "DECISION_MODEL") {
+ return buildDecisionModelStateFields({
+ stateKeys: params.stateKeys,
+ variableFields: params.variableFields,
+ });
+ }
+ return [];
+ })();
if (params.type === "DECISION_MODEL") {
const questions = draftsToQuestions(params.questions);
diff --git a/web/src/features/evals/v2/fns/scoreOutput/getScoreOutputValidation.ts b/web/src/features/evals/v2/fns/scoreOutput/getScoreOutputValidation.ts
index 63962a283c..add3171c55 100644
--- a/web/src/features/evals/v2/fns/scoreOutput/getScoreOutputValidation.ts
+++ b/web/src/features/evals/v2/fns/scoreOutput/getScoreOutputValidation.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import {
getMinimumCategoricalCategoriesMessage,
ScoreDataTypeEnum,
@@ -22,13 +21,15 @@ export function getScoreOutputValidation(state: ScoreOutputSelectorState) {
state.choices.map(({ label }) => label),
),
);
- const categoryWarnings = state.choices.map(({ label }, index) =>
- !label.trim()
- ? EMPTY_CATEGORY_NAME_MESSAGE
- : duplicateIndexes.has(index)
- ? DUPLICATE_CATEGORY_NAMES_MESSAGE
- : null,
- );
+ const categoryWarnings = state.choices.map(({ label }, index) => {
+ if (!label.trim()) {
+ return EMPTY_CATEGORY_NAME_MESSAGE;
+ }
+ if (duplicateIndexes.has(index)) {
+ return DUPLICATE_CATEGORY_NAMES_MESSAGE;
+ }
+ return null;
+ });
return {
categoryWarnings,
diff --git a/web/src/features/evals/v2/fns/variableMapping/segmentsToJsonPath.ts b/web/src/features/evals/v2/fns/variableMapping/segmentsToJsonPath.ts
index 992a4f98f4..2f36ea9a07 100644
--- a/web/src/features/evals/v2/fns/variableMapping/segmentsToJsonPath.ts
+++ b/web/src/features/evals/v2/fns/variableMapping/segmentsToJsonPath.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/**
* The drill-down JSONPath grammar shared between the prompt pills and the
* mapping panel: plain keys, numeric indices, the every-entry wildcard, and
@@ -85,13 +84,16 @@ export function jsonPathToSegments(path: string): PathSegment[] | null {
}
export function crumbLabel(segment: PathSegment): string {
- return segment === WILDCARD
- ? "[*]"
- : segment === LAST
- ? "[last]"
- : typeof segment === "number"
- ? `[${segment}]`
- : segment;
+ if (segment === WILDCARD) {
+ return "[*]";
+ }
+ if (segment === LAST) {
+ return "[last]";
+ }
+ if (typeof segment === "number") {
+ return `[${segment}]`;
+ }
+ return segment;
}
export function truncateEnd(label: string, max: number): string {
diff --git a/web/src/features/evals/v2/hooks/useEvalTemplate.ts b/web/src/features/evals/v2/hooks/useEvalTemplate.ts
index 777a17bf0a..bd45b12283 100644
--- a/web/src/features/evals/v2/hooks/useEvalTemplate.ts
+++ b/web/src/features/evals/v2/hooks/useEvalTemplate.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { evaluatorToEvaluatorSetupDraft } from "@/src/features/evals/v2/fns/templateGallery/evaluatorToEvaluatorSetupDraft";
import { managedEvaluatorTemplateService } from "@/src/features/evals/v2/fns/templateGallery/managedEvaluatorTemplateService";
import { managedTemplateToEvaluatorSetupDraft } from "@/src/features/evals/v2/fns/templateGallery/managedTemplateToEvaluatorSetupDraft";
@@ -22,11 +21,15 @@ export function useEvalTemplate({
const managedTemplate = templateKey
? managedEvaluatorTemplateService.get(templateKey)
: null;
- const draft = managedTemplate
- ? managedTemplateToEvaluatorSetupDraft(managedTemplate)
- : projectEvaluator.data
- ? evaluatorToEvaluatorSetupDraft(projectEvaluator.data)
- : null;
+ const draft = (() => {
+ if (managedTemplate) {
+ return managedTemplateToEvaluatorSetupDraft(managedTemplate);
+ }
+ if (projectEvaluator.data) {
+ return evaluatorToEvaluatorSetupDraft(projectEvaluator.data);
+ }
+ return null;
+ })();
return {
draft:
diff --git a/web/src/features/evals/v2/hooks/useEvaluatorTestAvailability.ts b/web/src/features/evals/v2/hooks/useEvaluatorTestAvailability.ts
index 9438e310c1..ea7cfd09d1 100644
--- a/web/src/features/evals/v2/hooks/useEvaluatorTestAvailability.ts
+++ b/web/src/features/evals/v2/hooks/useEvaluatorTestAvailability.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { useStore } from "zustand";
import { prepareEvaluatorDraft } from "@/src/features/evals/v2/fns/evaluators/prepareEvaluatorDraft";
@@ -34,15 +33,20 @@ export function useEvaluatorTestAvailability({
: null,
);
- return scoreOutputReason
- ? scoreOutputReason
- : modelReason
- ? modelReason
- : !definitionAvailable
- ? "Complete the evaluator before running a test."
- : !selectedObservation
- ? "Select a sample observation first."
- : !sampleObject
- ? "Loading the selected sample."
- : null;
+ if (scoreOutputReason) {
+ return scoreOutputReason;
+ }
+ if (modelReason) {
+ return modelReason;
+ }
+ if (!definitionAvailable) {
+ return "Complete the evaluator before running a test.";
+ }
+ if (!selectedObservation) {
+ return "Select a sample observation first.";
+ }
+ if (!sampleObject) {
+ return "Loading the selected sample.";
+ }
+ return null;
}
diff --git a/web/src/features/evals/v2/pages/EvaluatorSetupPage.tsx b/web/src/features/evals/v2/pages/EvaluatorSetupPage.tsx
index 5d5c52784b..2979bbfc0f 100644
--- a/web/src/features/evals/v2/pages/EvaluatorSetupPage.tsx
+++ b/web/src/features/evals/v2/pages/EvaluatorSetupPage.tsx
@@ -199,15 +199,19 @@ export function EvaluatorSetupPage(
projectId,
evaluatorId: initialEvaluator?.id ?? null,
});
- const scoreDataType =
- initialEvaluator?.definition.type === "CODE"
- ? getFirstCodeEvaluatorScoreDataType(
- initialEvaluator.definition.sourceCode,
- )
- : initialEvaluator?.definition.type === "LLM_AS_JUDGE"
- ? toScoreOutputFormState(initialEvaluator.definition.outputDefinition)
- .dataType
- : undefined;
+ const scoreDataType = (() => {
+ if (initialEvaluator?.definition.type === "CODE") {
+ return getFirstCodeEvaluatorScoreDataType(
+ initialEvaluator.definition.sourceCode,
+ );
+ }
+ if (initialEvaluator?.definition.type === "LLM_AS_JUDGE") {
+ return toScoreOutputFormState(
+ initialEvaluator.definition.outputDefinition,
+ ).dataType;
+ }
+ return undefined;
+ })();
const projectDefaultModel = useProjectDefaultModel({
projectId,
source: "editor",
diff --git a/web/src/features/evals/v2/pages/NewEvaluatorPage.tsx b/web/src/features/evals/v2/pages/NewEvaluatorPage.tsx
index beb64a5f35..82730bef21 100644
--- a/web/src/features/evals/v2/pages/NewEvaluatorPage.tsx
+++ b/web/src/features/evals/v2/pages/NewEvaluatorPage.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { useRouter } from "next/router";
import { EvalTemplateTypeEnum } from "@langfuse/shared";
@@ -7,11 +6,13 @@ import { useEvalTemplate } from "@/src/features/evals/v2/hooks/useEvalTemplate";
import { EvaluatorSetupPage } from "./EvaluatorSetupPage";
function requestedEvaluatorType(value: string | string[] | undefined) {
- return value === EvalTemplateTypeEnum.CODE
- ? EvalTemplateTypeEnum.CODE
- : value === EvalTemplateTypeEnum.DECISION_MODEL
- ? EvalTemplateTypeEnum.DECISION_MODEL
- : EvalTemplateTypeEnum.LLM_AS_JUDGE;
+ if (value === EvalTemplateTypeEnum.CODE) {
+ return EvalTemplateTypeEnum.CODE;
+ }
+ if (value === EvalTemplateTypeEnum.DECISION_MODEL) {
+ return EvalTemplateTypeEnum.DECISION_MODEL;
+ }
+ return EvalTemplateTypeEnum.LLM_AS_JUDGE;
}
export default function NewEvaluatorPage() {
@@ -39,11 +40,15 @@ export default function NewEvaluatorPage() {
}
const initialType = requestedEvaluatorType(router.query.type);
- const creationSource = templateKey
- ? { type: "managed" as const, templateKey }
- : evaluatorId
- ? { type: "custom" as const }
- : { type: "scratch" as const };
+ const creationSource = (() => {
+ if (templateKey) {
+ return { type: "managed" as const, templateKey };
+ }
+ if (evaluatorId) {
+ return { type: "custom" as const };
+ }
+ return { type: "scratch" as const };
+ })();
return (
<EvaluatorSetupPage
diff --git a/web/src/features/evals/v2/server/evaluators/evaluatorRepository.ts b/web/src/features/evals/v2/server/evaluators/evaluatorRepository.ts
index fa16130e65..67f016ece9 100644
--- a/web/src/features/evals/v2/server/evaluators/evaluatorRepository.ts
+++ b/web/src/features/evals/v2/server/evaluators/evaluatorRepository.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import {
EvalTemplateType,
Prisma,
@@ -235,28 +234,31 @@ async function evaluatorWhere(params: {
status: {
stringOptions: (filter) => {
const statuses: Prisma.EvaluatorWhereInput[] = filter.value.map(
- (status) =>
- status === "BLOCKED"
- ? { blockedAt: { not: null } }
- : status === "ACTIVE"
- ? {
- blockedAt: null,
- assignments: {
- some: {
- projectId: params.projectId,
- evaluationRule: { status: "ACTIVE" },
- },
- },
- }
- : {
- blockedAt: null,
- assignments: {
- none: {
- projectId: params.projectId,
- evaluationRule: { status: "ACTIVE" },
- },
- },
+ (status) => {
+ if (status === "BLOCKED") {
+ return { blockedAt: { not: null } };
+ }
+ if (status === "ACTIVE") {
+ return {
+ blockedAt: null,
+ assignments: {
+ some: {
+ projectId: params.projectId,
+ evaluationRule: { status: "ACTIVE" },
},
+ },
+ };
+ }
+ return {
+ blockedAt: null,
+ assignments: {
+ none: {
+ projectId: params.projectId,
+ evaluationRule: { status: "ACTIVE" },
+ },
+ },
+ };
+ },
);
return filter.operator === "any of"
? { OR: statuses }
diff --git a/web/src/features/events/components/EventsTable.tsx b/web/src/features/events/components/EventsTable.tsx
index 4695210d9f..9901c978bf 100644
--- a/web/src/features/events/components/EventsTable.tsx
+++ b/web/src/features/events/components/EventsTable.tsx
@@ -1134,11 +1134,15 @@ export default function ObservationsEventsTable({
);
const isSelectAllCountUnavailable = isTotalCountLoading || isTotalCountError;
- const selectAllCountUnavailableReason = isTotalCountLoading
- ? "Counting selected observations."
- : isTotalCountError
- ? "Could not count selected observations. Clear selection and try again."
- : undefined;
+ const selectAllCountUnavailableReason = (() => {
+ if (isTotalCountLoading) {
+ return "Counting selected observations.";
+ }
+ if (isTotalCountError) {
+ return "Could not count selected observations. Clear selection and try again.";
+ }
+ return undefined;
+ })();
const tableActions: TableAction[] = [
...(hasTraceDeletionEntitlement
? [
diff --git a/web/src/features/events/components/outlier-strip/lib/fixtures.ts b/web/src/features/events/components/outlier-strip/lib/fixtures.ts
index ca13cbbec8..9705b9188d 100644
--- a/web/src/features/events/components/outlier-strip/lib/fixtures.ts
+++ b/web/src/features/events/components/outlier-strip/lib/fixtures.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-exotic-operators */
import {
prepareOutlierSeries,
@@ -56,12 +55,15 @@ function makeFixtureBins(params: {
present = daytime ? rand() < 0.9 : rand() < 0.15;
if (!present) continue;
- const outlier =
- params.profile === "spiky" || params.profile === "bursty"
- ? rand() < 0.04
- ? 10 + rand() * 30
- : 1
- : 1;
+ const outlier = (() => {
+ if (params.profile === "spiky" || params.profile === "bursty") {
+ if (rand() < 0.04) {
+ return 10 + rand() * 30;
+ }
+ return 1;
+ }
+ return 1;
+ })();
const base = 0.5 + rand() * 0.8;
const count = Math.max(1, Math.round(rand() * 40 * (daytime ? 1 : 0.3)));
diff --git a/web/src/features/events/server/eventsService.ts b/web/src/features/events/server/eventsService.ts
index 88c0d81eaa..7d0141f62e 100644
--- a/web/src/features/events/server/eventsService.ts
+++ b/web/src/features/events/server/eventsService.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-exotic-operators */
import { type z } from "zod";
import {
@@ -837,12 +836,15 @@ export async function getEventFilterOptions(
score: { name: string; dataType: string },
level: "observation" | "trace",
): void => {
- const typeClass =
- score.dataType === "NUMERIC"
- ? "numeric"
- : score.dataType === "BOOLEAN"
- ? "boolean"
- : "categorical"; // CATEGORICAL + TEXT
+ const typeClass = (() => {
+ if (score.dataType === "NUMERIC") {
+ return "numeric";
+ }
+ if (score.dataType === "BOOLEAN") {
+ return "boolean";
+ }
+ return "categorical";
+ })(); // CATEGORICAL + TEXT
const levels = (scoreNameLevelsByType[typeClass][score.name] ??= []);
if (!levels.includes(level)) levels.push(level);
};
diff --git a/web/src/features/experiments/components/CreateExperimentsForm.tsx b/web/src/features/experiments/components/CreateExperimentsForm.tsx
index dbcf73024b..12f784e776 100644
--- a/web/src/features/experiments/components/CreateExperimentsForm.tsx
+++ b/web/src/features/experiments/components/CreateExperimentsForm.tsx
@@ -131,11 +131,15 @@ export const CreateExperimentsForm = ({
const hasRemoteExperiment = !!existingRemoteExperiment.data;
const isRemoteExperimentEnabled =
existingRemoteExperiment.data?.enabled !== false;
- const webhookActionLabel = isRemoteExperimentLoading
- ? "Loading..."
- : hasRemoteExperiment
- ? "Run"
- : "Configure";
+ const webhookActionLabel = (() => {
+ if (isRemoteExperimentLoading) {
+ return "Loading...";
+ }
+ if (hasRemoteExperiment) {
+ return "Run";
+ }
+ return "Configure";
+ })();
if (!hasExperimentWriteAccess) {
return null;
diff --git a/web/src/features/experiments/components/MultiStepExperimentForm.tsx b/web/src/features/experiments/components/MultiStepExperimentForm.tsx
index bcb756c5e8..86437e6a3c 100644
--- a/web/src/features/experiments/components/MultiStepExperimentForm.tsx
+++ b/web/src/features/experiments/components/MultiStepExperimentForm.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-null-render */
import { useHasProjectAccess } from "@/src/features/rbac";
import React, { useEffect, useRef, useState } from "react";
@@ -482,12 +481,15 @@ export const MultiStepExperimentForm = ({
.filter((step) => step.id !== "dataset" || !isDatasetValidationPending)
.filter((step) => !isStepValid(step.id))
.map((step) => step.label);
- const reviewErrorMessage =
- invalidRequiredStepLabels.length === 0
- ? undefined
- : invalidRequiredStepLabels.length === 1
- ? `Complete the ${invalidRequiredStepLabels[0]} step before running the experiment.`
- : `Complete the following steps before running the experiment: ${invalidRequiredStepLabels.join(", ")}.`;
+ const reviewErrorMessage = (() => {
+ if (invalidRequiredStepLabels.length === 0) {
+ return undefined;
+ }
+ if (invalidRequiredStepLabels.length === 1) {
+ return `Complete the ${invalidRequiredStepLabels[0]} step before running the experiment.`;
+ }
+ return `Complete the following steps before running the experiment: ${invalidRequiredStepLabels.join(", ")}.`;
+ })();
if (
!promptsByName ||
diff --git a/web/src/features/filters/hooks/useFilterState.ts b/web/src/features/filters/hooks/useFilterState.ts
index 4fb66a2038..7330c15959 100644
--- a/web/src/features/filters/hooks/useFilterState.ts
+++ b/web/src/features/filters/hooks/useFilterState.ts
@@ -88,26 +88,34 @@ const getCommaArrayParam = (table: TableName) => ({
type === "positionInTrace"
? normalizeLegacySessionPositionInTraceKey(key)
: key;
- const parsedValue =
- decodedValue === undefined || type === undefined
- ? undefined
- : type === "datetime"
- ? new Date(decodedValue)
- : type === "number" || type === "numberObject"
- ? Number(decodedValue)
- : type === "positionInTrace"
- ? decodedValue === ""
- ? undefined
- : Number(decodedValue)
- : type === "stringOptions" ||
- type === "arrayOptions" ||
- type === "categoryOptions"
- ? splitOnUnescapedPipe(decodedValue).map(
- unescapePipeInValue,
- )
- : type === "boolean" || type === "booleanObject"
- ? decodedValue === "true"
- : decodedValue;
+ const parsedValue = (() => {
+ if (decodedValue === undefined || type === undefined) {
+ return undefined;
+ }
+ if (type === "datetime") {
+ return new Date(decodedValue);
+ }
+ if (type === "number" || type === "numberObject") {
+ return Number(decodedValue);
+ }
+ if (type === "positionInTrace") {
+ if (decodedValue === "") {
+ return undefined;
+ }
+ return Number(decodedValue);
+ }
+ if (
+ type === "stringOptions" ||
+ type === "arrayOptions" ||
+ type === "categoryOptions"
+ ) {
+ return splitOnUnescapedPipe(decodedValue).map(unescapePipeInValue);
+ }
+ if (type === "boolean" || type === "booleanObject") {
+ return decodedValue === "true";
+ }
+ return decodedValue;
+ })();
if (DEBUG_QUERY_STATE) console.log("parsedValue", parsedValue);
const parsed = singleFilter.safeParse({
diff --git a/web/src/features/filters/lib/facet-display.ts b/web/src/features/filters/lib/facet-display.ts
index 63843b33ba..fee95e4a21 100644
--- a/web/src/features/filters/lib/facet-display.ts
+++ b/web/src/features/filters/lib/facet-display.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import type { UIFilter } from "@/src/features/filters/hooks/useSidebarFilterState";
import { filterRank } from "@/src/features/search-bar";
@@ -174,8 +173,15 @@ export function getFacetSummaryValue(filter: UIFilter): string | null {
}
/** Better of two ranks when either string may not match at all. */
-const bestRank = (a: number | null, b: number | null): number | null =>
- a === null ? b : b === null ? a : Math.min(a, b);
+const bestRank = (a: number | null, b: number | null): number | null => {
+ if (a === null) {
+ return b;
+ }
+ if (b === null) {
+ return a;
+ }
+ return Math.min(a, b);
+};
/**
* Rank a facet's option values for its search box the way the search bar
diff --git a/web/src/features/filters/lib/persistedSidebarFilterQuery.ts b/web/src/features/filters/lib/persistedSidebarFilterQuery.ts
index 3eaa4c8b78..a2766b74fd 100644
--- a/web/src/features/filters/lib/persistedSidebarFilterQuery.ts
+++ b/web/src/features/filters/lib/persistedSidebarFilterQuery.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
export type PersistedSidebarFilterQueryState = {
contextId: string | null;
query: string;
@@ -46,12 +45,15 @@ function parsePersistedSidebarFilterQueryState(
if (!parsed || typeof parsed !== "object") return null;
- const contextId =
- "contextId" in parsed && typeof parsed.contextId === "string"
- ? parsed.contextId
- : "contextId" in parsed && parsed.contextId === null
- ? null
- : undefined;
+ const contextId = (() => {
+ if ("contextId" in parsed && typeof parsed.contextId === "string") {
+ return parsed.contextId;
+ }
+ if ("contextId" in parsed && parsed.contextId === null) {
+ return null;
+ }
+ return undefined;
+ })();
const query =
"query" in parsed && typeof parsed.query === "string"
? parsed.query
diff --git a/web/src/features/in-app-agent/server/runCapacity.ts b/web/src/features/in-app-agent/server/runCapacity.ts
index 1ae030a84c..ca46e55158 100644
--- a/web/src/features/in-app-agent/server/runCapacity.ts
+++ b/web/src/features/in-app-agent/server/runCapacity.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { BaseError, type Plan } from "@langfuse/shared";
import type { PrismaClient } from "@langfuse/shared/src/db";
import {
@@ -81,18 +80,21 @@ export async function assertInAppAgentRunCapacity(params: {
const perOrg = env.LANGFUSE_IN_APP_AGENT_MAX_ACTIVE_RUNS_PER_ORG;
// User first, so the message names the limit the caller can act on.
- const exceeded =
- userActiveRuns >= perUser
- ? {
- limit: "user" as const,
- message: `You already have ${perUser} assistant runs in progress. Wait for one to finish.`,
- }
- : orgActiveRuns >= perOrg
- ? {
- limit: "org" as const,
- message: `Your organization is at its limit of ${perOrg} assistant runs in progress. Try again shortly.`,
- }
- : null;
+ const exceeded = (() => {
+ if (userActiveRuns >= perUser) {
+ return {
+ limit: "user" as const,
+ message: `You already have ${perUser} assistant runs in progress. Wait for one to finish.`,
+ };
+ }
+ if (orgActiveRuns >= perOrg) {
+ return {
+ limit: "org" as const,
+ message: `Your organization is at its limit of ${perOrg} assistant runs in progress. Try again shortly.`,
+ };
+ }
+ return null;
+ })();
if (!exceeded) {
return;
diff --git a/web/src/features/mcp/server/dashboardWidgets/tools/createDashboardWidget.ts b/web/src/features/mcp/server/dashboardWidgets/tools/createDashboardWidget.ts
index 28a85ff902..6c55c52e0a 100644
--- a/web/src/features/mcp/server/dashboardWidgets/tools/createDashboardWidget.ts
+++ b/web/src/features/mcp/server/dashboardWidgets/tools/createDashboardWidget.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { z } from "zod";
import {
DashboardWidgetChartType,
@@ -85,15 +84,21 @@ const throwActionableDashboardWidgetError = (
(field === "filters"
? Array.from(getWidgetImportFilterConfig(input.view).allowedColumns)
: []);
- const fieldLabel = field?.startsWith("dimensions")
- ? "dimensions"
- : field?.endsWith(".agg")
- ? "aggregations"
- : field?.endsWith(".measure")
- ? "measures"
- : field === "filters"
- ? "filter columns"
- : "values";
+ const fieldLabel = (() => {
+ if (field?.startsWith("dimensions")) {
+ return "dimensions";
+ }
+ if (field?.endsWith(".agg")) {
+ return "aggregations";
+ }
+ if (field?.endsWith(".measure")) {
+ return "measures";
+ }
+ if (field === "filters") {
+ return "filter columns";
+ }
+ return "values";
+ })();
const supportedValuesHint =
allowedValues.length > 0
? ` Supported ${fieldLabel} for "${input.view}": ${allowedValues.join(", ")}.`
diff --git a/web/src/features/mcp/server/metrics/tools/queryMetrics.ts b/web/src/features/mcp/server/metrics/tools/queryMetrics.ts
index 688f0b2f9e..175d102973 100644
--- a/web/src/features/mcp/server/metrics/tools/queryMetrics.ts
+++ b/web/src/features/mcp/server/metrics/tools/queryMetrics.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { InvalidRequestError } from "@langfuse/shared";
import { executeQuery } from "@langfuse/shared/query/server";
import {
@@ -90,11 +89,15 @@ const normalizeMetricOrderByFields = (
const matchingMetrics = isDimensionField
? []
: input.metrics.filter((metric) => metric.measure === orderBy.field);
- const normalizedField = isDimensionField
- ? orderBy.field
- : matchingMetrics.length === 1
- ? `${matchingMetrics[0].aggregation}_${matchingMetrics[0].measure}`
- : (reversedMetricAliases.get(orderBy.field) ?? orderBy.field);
+ const normalizedField = (() => {
+ if (isDimensionField) {
+ return orderBy.field;
+ }
+ if (matchingMetrics.length === 1) {
+ return `${matchingMetrics[0].aggregation}_${matchingMetrics[0].measure}`;
+ }
+ return reversedMetricAliases.get(orderBy.field) ?? orderBy.field;
+ })();
if (!allowedOrderByFields.has(normalizedField)) {
throw new InvalidRequestError(
diff --git a/web/src/features/mixpanel-integration/MixpanelIntegrationPage.tsx b/web/src/features/mixpanel-integration/MixpanelIntegrationPage.tsx
index c00fb67e0c..09594ac7eb 100644
--- a/web/src/features/mixpanel-integration/MixpanelIntegrationPage.tsx
+++ b/web/src/features/mixpanel-integration/MixpanelIntegrationPage.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { MixpanelLogo } from "@/src/components/MixpanelLogo";
import Header from "@/src/components/layouts/header";
import ContainerPage from "@/src/components/layouts/container-page";
@@ -74,12 +73,15 @@ export default function MixpanelIntegrationPage() {
const { project } = useQueryProject();
- const status =
- state.isLoading || !hasAccess
- ? undefined
- : state.data?.config?.enabled
- ? "active"
- : "inactive";
+ const status = (() => {
+ if (state.isLoading || !hasAccess) {
+ return undefined;
+ }
+ if (state.data?.config?.enabled) {
+ return "active";
+ }
+ return "inactive";
+ })();
return (
<ContainerPage
diff --git a/web/src/features/posthog-integration/PostHogIntegrationPage.tsx b/web/src/features/posthog-integration/PostHogIntegrationPage.tsx
index 1615567560..9535f9a919 100644
--- a/web/src/features/posthog-integration/PostHogIntegrationPage.tsx
+++ b/web/src/features/posthog-integration/PostHogIntegrationPage.tsx
@@ -50,14 +50,18 @@ export default function PostHogIntegrationPage() {
// A persisted fault outranks active/inactive: it is the state the admin has
// to act on, and it is cleared by the next successful sync.
- const status =
- state.isLoading || !hasAccess
- ? undefined
- : state.data?.config?.lastError
- ? "error"
- : state.data?.config?.enabled
- ? "active"
- : "inactive";
+ const status = (() => {
+ if (state.isLoading || !hasAccess) {
+ return undefined;
+ }
+ if (state.data?.config?.lastError) {
+ return "error";
+ }
+ if (state.data?.config?.enabled) {
+ return "active";
+ }
+ return "inactive";
+ })();
return (
<ContainerPage
diff --git a/web/src/features/prompts/PromptsPage.tsx b/web/src/features/prompts/PromptsPage.tsx
index b2efaf57bd..f9086689f7 100644
--- a/web/src/features/prompts/PromptsPage.tsx
+++ b/web/src/features/prompts/PromptsPage.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { useRouter } from "next/router";
import { ActionButton } from "@/src/components/ActionButton";
import Page from "@/src/components/layouts/page";
@@ -35,12 +34,15 @@ export default function PromptsPage() {
const isMetricsPage =
segmentsArray.length > 0 &&
segmentsArray[segmentsArray.length - 1] === "metrics";
- const promptNameFromRoute =
- segmentsArray.length > 0
- ? isMetricsPage
- ? segmentsArray.slice(0, -1).join("/")
- : segmentsArray.join("/")
- : "";
+ const promptNameFromRoute = (() => {
+ if (segmentsArray.length > 0) {
+ if (isMetricsPage) {
+ return segmentsArray.slice(0, -1).join("/");
+ }
+ return segmentsArray.join("/");
+ }
+ return "";
+ })();
const hasCUDAccess = useHasProjectAccess({
projectId,
diff --git a/web/src/features/prompts/components/ImportPromptsButtonDialogController.tsx b/web/src/features/prompts/components/ImportPromptsButtonDialogController.tsx
index 6998276dce..7b63709c83 100644
--- a/web/src/features/prompts/components/ImportPromptsButtonDialogController.tsx
+++ b/web/src/features/prompts/components/ImportPromptsButtonDialogController.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { useHasProjectAccess } from "@/src/features/rbac";
import { type ReactNode, useState } from "react";
import { CheckCircle, XCircle, Loader2 } from "lucide-react";
@@ -150,12 +149,15 @@ const ImportPromptsDialogContent: React.FC<{
const selectedFile =
state.step === "parsed" || state.step === "error" ? state.file : undefined;
const parsedItems = state.step === "parsed" ? state.items : null;
- const error =
- state.step === "error"
- ? state.error
- : state.step === "parsed"
- ? state.importError
- : undefined;
+ const error = (() => {
+ if (state.step === "error") {
+ return state.error;
+ }
+ if (state.step === "parsed") {
+ return state.importError;
+ }
+ return undefined;
+ })();
return (
<>
diff --git a/web/src/features/prompts/components/prompts-table.tsx b/web/src/features/prompts/components/prompts-table.tsx
index bc950fa9a2..79ea9166d3 100644
--- a/web/src/features/prompts/components/prompts-table.tsx
+++ b/web/src/features/prompts/components/prompts-table.tsx
@@ -194,12 +194,15 @@ export function PromptTable() {
const fullPath = prompt.id; // id now contains the full path (used for metrics join)
// Extract just the name portion (last segment) for display
const itemName = fullPath.split("/").pop() ?? fullPath;
- const type =
- isFolder || prompt.type === "folder"
- ? "folder"
- : prompt.type === "chat"
- ? "chat"
- : "text";
+ const type = (() => {
+ if (isFolder || prompt.type === "folder") {
+ return "folder";
+ }
+ if (prompt.type === "chat") {
+ return "chat";
+ }
+ return "text";
+ })();
combinedRows.push(
createRow({
diff --git a/web/src/features/public-api/server/toApiAccessScope.ts b/web/src/features/public-api/server/toApiAccessScope.ts
index f16caad890..ff6c8df99d 100644
--- a/web/src/features/public-api/server/toApiAccessScope.ts
+++ b/web/src/features/public-api/server/toApiAccessScope.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { InternalServerError } from "@langfuse/shared";
import {
type ApiAccessLevel,
@@ -62,11 +61,13 @@ function apiKeyAccessLevel(
principal: ApiKeyPrincipal,
projectId: string | null,
): ApiAccessLevel {
- return projectId === null
- ? "organization"
- : principal.presentation === "publicKey"
- ? "scores"
- : "project";
+ if (projectId === null) {
+ return "organization";
+ }
+ if (principal.presentation === "publicKey") {
+ return "scores";
+ }
+ return "project";
}
/** TargetResource is the resolved org and optional project a seam maps the principal onto. */
diff --git a/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsx b/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsx
index 530b355a68..c8aa34483d 100644
--- a/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsx
+++ b/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsx
@@ -163,11 +163,15 @@ export function DistributionBooleanCard() {
? `${score1.source} · ${score1.name}`
: score1.name;
- const score2FullLabel = score2
- ? score2.name === score1.name
- ? `${score2.source} · ${score2.name}`
- : score2.name
- : "Score 2";
+ const score2FullLabel = (() => {
+ if (score2) {
+ if (score2.name === score1.name) {
+ return `${score2.source} · ${score2.name}`;
+ }
+ return score2.name;
+ }
+ return "Score 2";
+ })();
return (
<Card>
diff --git a/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsx b/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsx
index 41dbb66fb5..74ad37eccc 100644
--- a/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsx
+++ b/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsx
@@ -254,11 +254,15 @@ export function DistributionCategoricalCard() {
? `${score1.source} · ${score1.name}`
: score1.name;
- const score2FullLabel = score2
- ? score2.name === score1.name
- ? `${score2.source} · ${score2.name}`
- : score2.name
- : "Score 2";
+ const score2FullLabel = (() => {
+ if (score2) {
+ if (score2.name === score1.name) {
+ return `${score2.source} · ${score2.name}`;
+ }
+ return score2.name;
+ }
+ return "Score 2";
+ })();
return (
<Card>
diff --git a/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsx b/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsx
index 47e0e40e27..4fa1901b3c 100644
--- a/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsx
+++ b/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsx
@@ -191,11 +191,15 @@ export function DistributionNumericCard() {
? `${score1.source} · ${score1.name}`
: score1.name;
- const score2FullLabel = score2
- ? score2.name === score1.name
- ? `${score2.source} · ${score2.name}`
- : score2.name
- : "Score 2";
+ const score2FullLabel = (() => {
+ if (score2) {
+ if (score2.name === score1.name) {
+ return `${score2.source} · ${score2.name}`;
+ }
+ return score2.name;
+ }
+ return "Score 2";
+ })();
return (
<Card>
diff --git a/web/src/features/score-analytics/components/cards/HeatmapCard.tsx b/web/src/features/score-analytics/components/cards/HeatmapCard.tsx
index 77c58a7295..4f896ddd43 100644
--- a/web/src/features/score-analytics/components/cards/HeatmapCard.tsx
+++ b/web/src/features/score-analytics/components/cards/HeatmapCard.tsx
@@ -198,14 +198,18 @@ export function HeatmapCard() {
const title =
dataType === "NUMERIC" ? "Score Comparison Heatmap" : "Confusion Matrix";
- const description =
- mode === "single"
- ? dataType === "NUMERIC"
- ? "Distribution of matched score pairs showing correlation patterns"
- : "Agreement matrix between categorical scores"
- : dataType === "NUMERIC"
- ? `${totalMatchedPairs.toLocaleString()} matched pairs showing correlation patterns`
- : `${totalMatchedPairs.toLocaleString()} matched pairs showing agreement`;
+ const description = (() => {
+ if (mode === "single") {
+ if (dataType === "NUMERIC") {
+ return "Distribution of matched score pairs showing correlation patterns";
+ }
+ return "Agreement matrix between categorical scores";
+ }
+ if (dataType === "NUMERIC") {
+ return `${totalMatchedPairs.toLocaleString()} matched pairs showing correlation patterns`;
+ }
+ return `${totalMatchedPairs.toLocaleString()} matched pairs showing agreement`;
+ })();
// Single score mode - show placeholder
if (mode === "single") {
@@ -237,12 +241,15 @@ export function HeatmapCard() {
// Calculate dynamic cell height based on available space
// Magic number 230px represents approximate available height for grid
// (card height minus header, labels, legend, gaps)
- const numRows =
- dataType === "NUMERIC"
- ? 10
- : heatmap && "rows" in heatmap
- ? heatmap.rows
- : 10;
+ const numRows = (() => {
+ if (dataType === "NUMERIC") {
+ return 10;
+ }
+ if (heatmap && "rows" in heatmap) {
+ return heatmap.rows;
+ }
+ return 10;
+ })();
const calculatedCellHeight = Math.floor(200 / numRows);
return (
diff --git a/web/src/features/score-analytics/components/cards/TimelineChartCard.tsx b/web/src/features/score-analytics/components/cards/TimelineChartCard.tsx
index 2ff4691b6a..e16fa5b802 100644
--- a/web/src/features/score-analytics/components/cards/TimelineChartCard.tsx
+++ b/web/src/features/score-analytics/components/cards/TimelineChartCard.tsx
@@ -247,11 +247,15 @@ export function TimelineChartCard() {
? `${score1.source} · ${score1.name}`
: score1.name;
- const score2FullLabel = score2
- ? score2.name === score1.name
- ? `${score2.source} · ${score2.name}`
- : score2.name
- : "Score 2";
+ const score2FullLabel = (() => {
+ if (score2) {
+ if (score2.name === score1.name) {
+ return `${score2.source} · ${score2.name}`;
+ }
+ return score2.name;
+ }
+ return "Score 2";
+ })();
return (
<Card>
diff --git a/web/src/features/score-analytics/hooks/useScoreAnalyticsQuery.ts b/web/src/features/score-analytics/hooks/useScoreAnalyticsQuery.ts
index 905da85d5e..e401e1dcaa 100644
--- a/web/src/features/score-analytics/hooks/useScoreAnalyticsQuery.ts
+++ b/web/src/features/score-analytics/hooks/useScoreAnalyticsQuery.ts
@@ -480,20 +480,23 @@ export function useScoreAnalyticsQuery(
: null;
// For Score 2: If same score selected twice, reuse Score 1 data
- const score2ModeMetrics =
- !isNumeric && mode === "two"
- ? isSameScore
- ? calculateModeMetrics({
- distribution: isBoolean ? distribution1 : apiData.distribution1, // Reuse Score 1 data
- timeSeries: apiData.timeSeriesCategorical1, // Reuse Score 1 data
- totalCount: apiData.counts.score2Total,
- })
- : calculateModeMetrics({
- distribution: isBoolean ? distribution2 : apiData.distribution2,
- timeSeries: apiData.timeSeriesCategorical2,
- totalCount: apiData.counts.score2Total,
- })
- : null;
+ const score2ModeMetrics = (() => {
+ if (!isNumeric && mode === "two") {
+ if (isSameScore) {
+ return calculateModeMetrics({
+ distribution: isBoolean ? distribution1 : apiData.distribution1, // Reuse Score 1 data
+ timeSeries: apiData.timeSeriesCategorical1, // Reuse Score 1 data
+ totalCount: apiData.counts.score2Total,
+ });
+ }
+ return calculateModeMetrics({
+ distribution: isBoolean ? distribution2 : apiData.distribution2,
+ timeSeries: apiData.timeSeriesCategorical2,
+ totalCount: apiData.counts.score2Total,
+ });
+ }
+ return null;
+ })();
// ========================================================================
// 6. Fill time series gaps
diff --git a/web/src/features/score-analytics/lib/statistics-utils.ts b/web/src/features/score-analytics/lib/statistics-utils.ts
index 2220b282ce..6bb2d9b6df 100644
--- a/web/src/features/score-analytics/lib/statistics-utils.ts
+++ b/web/src/features/score-analytics/lib/statistics-utils.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/**
* Statistical calculation utilities for score comparison analytics
* Provides functions for calculating Cohen's Kappa, F1 Score, Overall Agreement,
@@ -213,7 +212,15 @@ export function interpretPearsonCorrelation(
}
const abs = Math.abs(r);
- const direction = r > 0 ? "positive" : r < 0 ? "negative" : "no";
+ const direction = (() => {
+ if (r > 0) {
+ return "positive";
+ }
+ if (r < 0) {
+ return "negative";
+ }
+ return "no";
+ })();
if (abs >= 0.9) {
return {
@@ -269,7 +276,15 @@ export function interpretSpearmanCorrelation(
}
const abs = Math.abs(rho);
- const direction = rho > 0 ? "positive" : rho < 0 ? "negative" : "no";
+ const direction = (() => {
+ if (rho > 0) {
+ return "positive";
+ }
+ if (rho < 0) {
+ return "negative";
+ }
+ return "no";
+ })();
if (abs >= 0.9) {
return {
diff --git a/web/src/features/score-analytics/server/scoreAnalyticsRouter.ts b/web/src/features/score-analytics/server/scoreAnalyticsRouter.ts
index 023c5a1541..c5f156c873 100644
--- a/web/src/features/score-analytics/server/scoreAnalyticsRouter.ts
+++ b/web/src/features/score-analytics/server/scoreAnalyticsRouter.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { z } from "zod";
import {
@@ -112,14 +111,18 @@ export const createScoreAnalyticsRouter = ({
estimates.score2Count >= adaptiveFinalThreshold;
// Estimate query time based on dataset size
- const estimatedQueryTime =
- estimates.estimatedMatchedCount > 1_000_000
- ? "30-60s"
- : estimates.estimatedMatchedCount > 500_000
- ? "15-30s"
- : estimates.estimatedMatchedCount > 100_000
- ? "10-20s"
- : "<10s";
+ const estimatedQueryTime = (() => {
+ if (estimates.estimatedMatchedCount > 1_000_000) {
+ return "30-60s";
+ }
+ if (estimates.estimatedMatchedCount > 500_000) {
+ return "15-30s";
+ }
+ if (estimates.estimatedMatchedCount > 100_000) {
+ return "10-20s";
+ }
+ return "<10s";
+ })();
return {
score1Count: estimates.score1Count,
diff --git a/web/src/features/scores-chart-view/components/ScoresChartView.tsx b/web/src/features/scores-chart-view/components/ScoresChartView.tsx
index 997aa70945..c5c75fe92e 100644
--- a/web/src/features/scores-chart-view/components/ScoresChartView.tsx
+++ b/web/src/features/scores-chart-view/components/ScoresChartView.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import React, { useMemo } from "react";
import { type FilterState } from "@langfuse/shared";
import { type ViewVersion } from "@langfuse/shared/query";
@@ -97,12 +96,18 @@ export function ScoresChartView({
[queryResult.data, config],
);
- const error = !validRange
- ? "Pick a wider time range to chart."
- : queryResult.isError
- ? (queryResult.error?.message ??
- "Couldn't build a chart for the current view.")
- : null;
+ const error = (() => {
+ if (!validRange) {
+ return "Pick a wider time range to chart.";
+ }
+ if (queryResult.isError) {
+ return (
+ queryResult.error?.message ??
+ "Couldn't build a chart for the current view."
+ );
+ }
+ return null;
+ })();
const widgetInput = useMemo(
() => scoreChartConfigToWidgetInput({ config, filters }),
diff --git a/web/src/features/scores-chart-view/fns/scoreChartConfig.ts b/web/src/features/scores-chart-view/fns/scoreChartConfig.ts
index 49d61fa5ef..582569bfab 100644
--- a/web/src/features/scores-chart-view/fns/scoreChartConfig.ts
+++ b/web/src/features/scores-chart-view/fns/scoreChartConfig.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { type FilterState, type QueryType } from "@langfuse/shared";
import {
AGGREGATION_LABELS,
@@ -277,16 +276,24 @@ export function scoreRowsToDataPoints(
}
}
- const dim = hasBreakdown
- ? dimensionValue(row[dimension.field as string])
- : isNumber
- ? undefined
- : metric.label;
- const metricValue = Array.isArray(value)
- ? value
- : isTimeSeries && value == null
- ? null
- : Number(value ?? 0);
+ const dim = (() => {
+ if (hasBreakdown) {
+ return dimensionValue(row[dimension.field as string]);
+ }
+ if (isNumber) {
+ return undefined;
+ }
+ return metric.label;
+ })();
+ const metricValue = (() => {
+ if (Array.isArray(value)) {
+ return value;
+ }
+ if (isTimeSeries && value == null) {
+ return null;
+ }
+ return Number(value ?? 0);
+ })();
return { time_dimension, dimension: dim, metric: metricValue };
});
}
diff --git a/web/src/features/search-bar/components/SearchComposer.tsx b/web/src/features/search-bar/components/SearchComposer.tsx
index 5d2c65aeb3..661df14682 100644
--- a/web/src/features/search-bar/components/SearchComposer.tsx
+++ b/web/src/features/search-bar/components/SearchComposer.tsx
@@ -1093,12 +1093,15 @@ export function SearchComposer({
const current = highlightedRef.current;
const idx = current === null ? -1 : ids.indexOf(current);
const delta = event.key === "ArrowDown" ? 1 : -1;
- const next =
- idx === -1
- ? delta > 0
- ? 0
- : ids.length - 1
- : (idx + delta + ids.length) % ids.length;
+ const next = (() => {
+ if (idx === -1) {
+ if (delta > 0) {
+ return 0;
+ }
+ return ids.length - 1;
+ }
+ return (idx + delta + ids.length) % ids.length;
+ })();
setHighlightedOptionId(ids[next]!);
}
};
@@ -1331,12 +1334,15 @@ export function SearchComposer({
const removeTargetIdActual = removeTarget?.id ?? null;
// Measured separately from the remove target: an operator token explains
// itself but is not editable, so it never has a remove X to anchor to.
- const tooltipTargetId =
- errorTarget !== null
- ? errorTarget.id
- : explanation !== null
- ? explainTargetId
- : null;
+ const tooltipTargetId = (() => {
+ if (errorTarget !== null) {
+ return errorTarget.id;
+ }
+ if (explanation !== null) {
+ return explainTargetId;
+ }
+ return null;
+ })();
const measurePositions = React.useCallback(() => {
const root = rootRef.current;
const container = containerRef.current;
diff --git a/web/src/features/search-bar/lib/completions.ts b/web/src/features/search-bar/lib/completions.ts
index 00227b8817..6bfdb88174 100644
--- a/web/src/features/search-bar/lib/completions.ts
+++ b/web/src/features/search-bar/lib/completions.ts
@@ -372,7 +372,18 @@ function matchingFilterOptions(
for (const f of valueMatchFields) {
for (const o of observedValues(observed, f.id)) {
const v = o.value.toLowerCase();
- const rank = v === q ? 0 : v.startsWith(q) ? 1 : v.includes(q) ? 2 : null;
+ const rank = (() => {
+ if (v === q) {
+ return 0;
+ }
+ if (v.startsWith(q)) {
+ return 1;
+ }
+ if (v.includes(q)) {
+ return 2;
+ }
+ return null;
+ })();
if (rank === null) continue;
const insert = `${f.id}:${serializeValue(o.value)}`;
ranked.push({
@@ -1413,12 +1424,15 @@ export function planInputCompletions(
: (() => {
const ranked = rankFilter(allFields, keyPart);
const exact = registry.resolveField(keyPart);
- const exactId =
- exact?.type === "field"
- ? exact.field.id
- : exact?.type === "pseudo" || exact?.type === "searchScope"
- ? exact.id
- : null;
+ const exactId = (() => {
+ if (exact?.type === "field") {
+ return exact.field.id;
+ }
+ if (exact?.type === "pseudo" || exact?.type === "searchScope") {
+ return exact.id;
+ }
+ return null;
+ })();
return exactId === null
? ranked
: hoistFieldOption(ranked, exactId, allFields);
diff --git a/web/src/features/search-bar/lib/langQ.ts b/web/src/features/search-bar/lib/langQ.ts
index a33c8ed970..91ce5b7250 100644
--- a/web/src/features/search-bar/lib/langQ.ts
+++ b/web/src/features/search-bar/lib/langQ.ts
@@ -890,8 +890,15 @@ function serializeFilter(node: FilterNode): string {
// Text-match ops render as positional `*` globs around the value.
if (node.op === "~" || node.op === "^" || node.op === "$") {
const v = serializeValue(node.values[0] ?? "");
- const wrapped =
- node.op === "~" ? `*${v}*` : node.op === "^" ? `${v}*` : `*${v}`;
+ const wrapped = (() => {
+ if (node.op === "~") {
+ return `*${v}*`;
+ }
+ if (node.op === "^") {
+ return `${v}*`;
+ }
+ return `*${v}`;
+ })();
return `${key}:${wrapped}`;
}
return `${key}:${OP_SYMBOL[node.op] ?? ""}${node.values.map(serializeValue).join(",")}`;
diff --git a/web/src/features/search-bar/lib/searchBarInvariants.ts b/web/src/features/search-bar/lib/searchBarInvariants.ts
index 424680dad7..ee58f781f0 100644
--- a/web/src/features/search-bar/lib/searchBarInvariants.ts
+++ b/web/src/features/search-bar/lib/searchBarInvariants.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
// Reusable property-test harness for the search bar — the universal safety net
// described in README.md ("Round-trip property test", "Extending to other
// views"). It is PURE (no vitest import, no global state) so it is safe in the
@@ -88,9 +87,15 @@ function stable(value: unknown): string {
return JSON.stringify(value, (_k, v) =>
v && typeof v === "object" && !Array.isArray(v)
? Object.fromEntries(
- Object.entries(v as Record<string, unknown>).sort(([a], [b]) =>
- a < b ? -1 : a > b ? 1 : 0,
- ),
+ Object.entries(v as Record<string, unknown>).sort(([a], [b]) => {
+ if (a < b) {
+ return -1;
+ }
+ if (a > b) {
+ return 1;
+ }
+ return 0;
+ }),
)
: v,
);
diff --git a/web/src/features/sessions/ConnectedModernSessionBodyLegacy.tsx b/web/src/features/sessions/ConnectedModernSessionBodyLegacy.tsx
index 59314c8374..079eadd48c 100644
--- a/web/src/features/sessions/ConnectedModernSessionBodyLegacy.tsx
+++ b/web/src/features/sessions/ConnectedModernSessionBodyLegacy.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import React, { useEffect, useRef, useState } from "react";
import { useVirtualizer } from "@tanstack/react-virtual";
import { type FilterState } from "@langfuse/shared";
@@ -239,14 +238,18 @@ export function ConnectedModernSessionBodyLegacy({
const mayHaveMoreObservations = Boolean(
lastRelevantQuery?.isPending || lastRelevantQuery?.data?.hasMore,
);
- const observations =
- isPending && !hasLoadedObservations
- ? undefined
- : isError
- ? null
- : mayHaveMoreObservations && !hasLoadedObservations
- ? undefined
- : (observationsByTraceId.get(trace.id) ?? []);
+ const observations = (() => {
+ if (isPending && !hasLoadedObservations) {
+ return undefined;
+ }
+ if (isError) {
+ return null;
+ }
+ if (mayHaveMoreObservations && !hasLoadedObservations) {
+ return undefined;
+ }
+ return observationsByTraceId.get(trace.id) ?? [];
+ })();
if (
searchQuery &&
diff --git a/web/src/features/sessions/ConnectedModernSessionBodyTimeline.tsx b/web/src/features/sessions/ConnectedModernSessionBodyTimeline.tsx
index d1bc600708..ed97fba529 100644
--- a/web/src/features/sessions/ConnectedModernSessionBodyTimeline.tsx
+++ b/web/src/features/sessions/ConnectedModernSessionBodyTimeline.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { useEffect, useEffectEvent, useRef, useState } from "react";
import { type FilterState } from "@langfuse/shared";
@@ -265,14 +264,18 @@ export function ConnectedModernSessionBodyTimeline({
lastRelevantQuery?.isPending || lastRelevantQuery?.data?.hasMore,
);
if (mayHaveMoreObservations) incompleteTimelineTraceIds.add(trace.id);
- const observations =
- isPending && !hasLoadedObservations
- ? undefined
- : isError
- ? null
- : mayHaveMoreObservations && !hasLoadedObservations
- ? undefined
- : (observationsByTraceId.get(trace.id) ?? []);
+ const observations = (() => {
+ if (isPending && !hasLoadedObservations) {
+ return undefined;
+ }
+ if (isError) {
+ return null;
+ }
+ if (mayHaveMoreObservations && !hasLoadedObservations) {
+ return undefined;
+ }
+ return observationsByTraceId.get(trace.id) ?? [];
+ })();
if (
searchQuery &&
@@ -374,13 +377,18 @@ export function ConnectedModernSessionBodyTimeline({
const timelineTraces: ConnectedSessionConversationTimelineItem[] = traces.map(
(trace, index) => {
const sidebarTrace = sidebarTraceById.get(trace.id);
- const observations =
- sidebarTrace?.observations === null
- ? null
- : sidebarTrace?.observations === undefined ||
- incompleteTimelineTraceIds.has(trace.id)
- ? undefined
- : (timelineObservationsByTraceId.get(trace.id) ?? []);
+ const observations = (() => {
+ if (sidebarTrace?.observations === null) {
+ return null;
+ }
+ if (
+ sidebarTrace?.observations === undefined ||
+ incompleteTimelineTraceIds.has(trace.id)
+ ) {
+ return undefined;
+ }
+ return timelineObservationsByTraceId.get(trace.id) ?? [];
+ })();
return {
trace,
diff --git a/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.stories.tsx b/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.stories.tsx
index b18223f124..b22ad1eaf5 100644
--- a/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.stories.tsx
+++ b/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.stories.tsx
@@ -1632,14 +1632,18 @@ const inAppAgentObservations = [
),
},
]);
- const runtimeContextOffsetMs =
- actionIndex < 6
- ? inAppAgentActions[0]!.offsetMs
- : actionIndex < 13
- ? inAppAgentActions[6]!.offsetMs
- : actionIndex < 18
- ? inAppAgentActions[13]!.offsetMs
- : inAppAgentActions[18]!.offsetMs;
+ const runtimeContextOffsetMs = (() => {
+ if (actionIndex < 6) {
+ return inAppAgentActions[0]!.offsetMs;
+ }
+ if (actionIndex < 13) {
+ return inAppAgentActions[6]!.offsetMs;
+ }
+ if (actionIndex < 18) {
+ return inAppAgentActions[13]!.offsetMs;
+ }
+ return inAppAgentActions[18]!.offsetMs;
+ })();
const generationInput = JSON.stringify({
messages: [
...inAppAgentSystemMessages,
diff --git a/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsx b/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsx
index 96bce89b65..f72e54d29d 100644
--- a/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsx
+++ b/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsx
@@ -99,12 +99,15 @@ function SessionTimelineStatusIndicator({
}: {
observation: SessionObservation;
}) {
- const Icon =
- observation.level === "ERROR"
- ? CircleAlert
- : observation.level === "WARNING"
- ? TriangleAlert
- : Info;
+ const Icon = (() => {
+ if (observation.level === "ERROR") {
+ return CircleAlert;
+ }
+ if (observation.level === "WARNING") {
+ return TriangleAlert;
+ }
+ return Info;
+ })();
const colors = getLevelColors(observation.level);
return (
@@ -250,12 +253,15 @@ function getNestedObservationSummary(
}
const names = count <= 3 ? Array.from(toolNames) : [];
- const namesSummary =
- names.length < 2
- ? (names[0] ?? "")
- : names.length === 2
- ? `${names[0]} and ${names[1]}`
- : `${names.slice(0, -1).join(", ")}, and ${names.at(-1)}`;
+ const namesSummary = (() => {
+ if (names.length < 2) {
+ return names[0] ?? "";
+ }
+ if (names.length === 2) {
+ return `${names[0]} and ${names[1]}`;
+ }
+ return `${names.slice(0, -1).join(", ")}, and ${names.at(-1)}`;
+ })();
if (names.length === count) return `tools: ${namesSummary}`;
return `${count} tool${count === 1 ? "" : "s"}${namesSummary ? ` using ${namesSummary}` : ""}`;
diff --git a/web/src/features/sessions/SessionMetadataJsonPathControl.tsx b/web/src/features/sessions/SessionMetadataJsonPathControl.tsx
index df9d7c2751..f155d5d93d 100644
--- a/web/src/features/sessions/SessionMetadataJsonPathControl.tsx
+++ b/web/src/features/sessions/SessionMetadataJsonPathControl.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-exotic-operators */
import { type FilterState } from "@langfuse/shared";
import {
@@ -146,23 +145,31 @@ export function SessionMetadataJsonPathControl({
queryHashes: observationQueryHashes,
traceIds: loadedTraces.map((trace) => trace.id),
});
- const source = !shouldObserveMetadata
- ? ({ state: "idle" } as const)
- : traces.state === "loading"
- ? ({ state: "loading" } as const)
- : firstObservation
- ? ({
- state: "ready",
- metadata: firstObservation.metadata,
- metadataTruncated: firstObservation.metadataTruncated,
- } as const)
- : isFetching
- ? ({ state: "loading" } as const)
- : isError && !hasResolvedQuery
- ? ({ state: "error" } as const)
- : hasResolvedQuery || loadedTraces.length === 0
- ? ({ state: "empty" } as const)
- : ({ state: "loading" } as const);
+ const source = (() => {
+ if (!shouldObserveMetadata) {
+ return { state: "idle" } as const;
+ }
+ if (traces.state === "loading") {
+ return { state: "loading" } as const;
+ }
+ if (firstObservation) {
+ return {
+ state: "ready",
+ metadata: firstObservation.metadata,
+ metadataTruncated: firstObservation.metadataTruncated,
+ } as const;
+ }
+ if (isFetching) {
+ return { state: "loading" } as const;
+ }
+ if (isError && !hasResolvedQuery) {
+ return { state: "error" } as const;
+ }
+ if (hasResolvedQuery || loadedTraces.length === 0) {
+ return { state: "empty" } as const;
+ }
+ return { state: "loading" } as const;
+ })();
return children({
paths,
diff --git a/web/src/features/sessions/sessionMetadataJsonPath.ts b/web/src/features/sessions/sessionMetadataJsonPath.ts
index e93747946e..b153920e36 100644
--- a/web/src/features/sessions/sessionMetadataJsonPath.ts
+++ b/web/src/features/sessions/sessionMetadataJsonPath.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { evaluateJsonPath } from "@langfuse/shared";
import { z } from "zod";
@@ -61,14 +60,18 @@ export const resolveMetadataJsonPath = (
const value = evaluateJsonPath(metadata ?? {}, path);
if (value === undefined) return { state: "no-match" };
- const displayValue =
- typeof value === "string"
- ? value
- : typeof value === "number" || typeof value === "boolean"
- ? String(value)
- : value === null
- ? "null"
- : (JSON.stringify(value) ?? String(value));
+ const displayValue = (() => {
+ if (typeof value === "string") {
+ return value;
+ }
+ if (typeof value === "number" || typeof value === "boolean") {
+ return String(value);
+ }
+ if (value === null) {
+ return "null";
+ }
+ return JSON.stringify(value) ?? String(value);
+ })();
return { state: "match", displayValue };
} catch (error) {
return {
diff --git a/web/src/features/slack/SlackIntegrationPage.tsx b/web/src/features/slack/SlackIntegrationPage.tsx
index fdba3398dd..fca4f32a8f 100644
--- a/web/src/features/slack/SlackIntegrationPage.tsx
+++ b/web/src/features/slack/SlackIntegrationPage.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import ContainerPage from "@/src/components/layouts/container-page";
import { StatusBadge } from "@/src/components/ui/StatusBadge/StatusBadge";
import { AutomationButton } from "@/src/features/automations";
@@ -71,11 +70,15 @@ export default function SlackIntegrationPage() {
{ enabled: !!projectId },
);
- const status = isLoading
- ? undefined
- : integrationStatus?.isConnected
- ? "active"
- : "inactive";
+ const status = (() => {
+ if (isLoading) {
+ return undefined;
+ }
+ if (integrationStatus?.isConnected) {
+ return "active";
+ }
+ return "inactive";
+ })();
const [selectedChannel, setSelectedChannel] = useState<SlackChannel | null>(
null,
diff --git a/web/src/features/trace-graph-view/layout/elkLayout.ts b/web/src/features/trace-graph-view/layout/elkLayout.ts
index 07b0051955..9e2ae49ae6 100644
--- a/web/src/features/trace-graph-view/layout/elkLayout.ts
+++ b/web/src/features/trace-graph-view/layout/elkLayout.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import type { ELK, ElkNode } from "elkjs";
import {
@@ -219,14 +218,21 @@ function buildElkGraph(request: GraphLayoutRequest): ElkNode {
// the first/last layer so edge shape can't strand them mid-graph (e.g.
// a root span's `root→__end__` edge would otherwise place __end__ in
// the second column while the run continues to the right of it).
- const constraint =
- node.id === LANGFUSE_START_NODE_NAME ||
- node.id === LANGGRAPH_START_NODE_NAME
- ? "FIRST"
- : node.id === LANGFUSE_END_NODE_NAME ||
- node.id === LANGGRAPH_END_NODE_NAME
- ? "LAST"
- : null;
+ const constraint = (() => {
+ if (
+ node.id === LANGFUSE_START_NODE_NAME ||
+ node.id === LANGGRAPH_START_NODE_NAME
+ ) {
+ return "FIRST";
+ }
+ if (
+ node.id === LANGFUSE_END_NODE_NAME ||
+ node.id === LANGGRAPH_END_NODE_NAME
+ ) {
+ return "LAST";
+ }
+ return null;
+ })();
return {
id: node.id,
width,
diff --git a/web/src/features/traces/TracePage.tsx b/web/src/features/traces/TracePage.tsx
index 6a40905139..ee78466578 100644
--- a/web/src/features/traces/TracePage.tsx
+++ b/web/src/features/traces/TracePage.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { DetailPageNav } from "@/src/features/navigate-detail-pages";
import { useRouter } from "next/router";
import { ErrorPage } from "@/src/components/error-page";
@@ -58,31 +57,37 @@ export function TracePage({
const encodedTargetPath = encodeURIComponent(
stripBasePath(router.asPath || "/"),
);
- const leadingControl = showPublicIndicators ? (
- session.status === "authenticated" ? (
- <Button
- asChild
- size="sm"
- variant="outline"
- title="Back to Langfuse"
- className="px-3"
- >
- <Link href="/">Langfuse</Link>
- </Button>
- ) : (
- <Button
- asChild
- size="sm"
- variant="default"
- title="Sign in to Langfuse"
- className="px-3"
- >
- <Link href={`/auth/sign-in?targetPath=${encodedTargetPath}`}>
- Sign in
- </Link>
- </Button>
- )
- ) : undefined;
+ const leadingControl = (() => {
+ if (showPublicIndicators) {
+ if (session.status === "authenticated") {
+ return (
+ <Button
+ asChild
+ size="sm"
+ variant="outline"
+ title="Back to Langfuse"
+ className="px-3"
+ >
+ <Link href="/">Langfuse</Link>
+ </Button>
+ );
+ }
+ return (
+ <Button
+ asChild
+ size="sm"
+ variant="default"
+ title="Sign in to Langfuse"
+ className="px-3"
+ >
+ <Link href={`/auth/sign-in?targetPath=${encodedTargetPath}`}>
+ Sign in
+ </Link>
+ </Button>
+ );
+ }
+ return undefined;
+ })();
const sharedBadge = showPublicIndicators ? (
<Badge variant="outline" className="text-xs font-bold">
Public
diff --git a/web/src/features/traces/TracesTable.tsx b/web/src/features/traces/TracesTable.tsx
index e588510097..e0152d22f6 100644
--- a/web/src/features/traces/TracesTable.tsx
+++ b/web/src/features/traces/TracesTable.tsx
@@ -682,11 +682,15 @@ function TracesTableInternal({
setSelectedRows({});
};
- const displayCount = totalCountQuery.isPending
- ? "..."
- : selectAll
- ? compactNumberFormatter(totalCountQuery.data?.totalCount)
- : compactNumberFormatter(Object.keys(selectedRows).length);
+ const displayCount = (() => {
+ if (totalCountQuery.isPending) {
+ return "...";
+ }
+ if (selectAll) {
+ return compactNumberFormatter(totalCountQuery.data?.totalCount);
+ }
+ return compactNumberFormatter(Object.keys(selectedRows).length);
+ })();
// Select-all deletes persist the raw filterState into the batch action, but
// comment filters resolve via Postgres at read time and the server rejects
@@ -1055,12 +1059,15 @@ function TracesTableInternal({
enableHiding: true,
enableSorting,
isLive: false,
- getStatus: (level, { row }) =>
- isMetricPending(row.original.id)
- ? { type: "loading" }
- : level
- ? getObservationLevelStatus(level)
- : undefined,
+ getStatus: (level, { row }) => {
+ if (isMetricPending(row.original.id)) {
+ return { type: "loading" };
+ }
+ if (level) {
+ return getObservationLevelStatus(level);
+ }
+ return undefined;
+ },
}),
createTextTableColumn<TracesTableRow>({
accessorKey: "version",
@@ -1632,12 +1639,15 @@ const TracesDynamicCell = ({
},
);
- const data =
- col === "output"
- ? trace.data?.output
- : col === "input"
- ? trace.data?.input
- : trace.data?.metadata;
+ const data = (() => {
+ if (col === "output") {
+ return trace.data?.output;
+ }
+ if (col === "input") {
+ return trace.data?.input;
+ }
+ return trace.data?.metadata;
+ })();
if (trace.isPending) {
return <ConnectedIOTableCell isLoading singleLine={singleLine} />;
diff --git a/web/src/features/traces/components/AdvancedJsonViewer/components/ExpandButton.tsx b/web/src/features/traces/components/AdvancedJsonViewer/components/ExpandButton.tsx
index b98a49700c..255bb53970 100644
--- a/web/src/features/traces/components/AdvancedJsonViewer/components/ExpandButton.tsx
+++ b/web/src/features/traces/components/AdvancedJsonViewer/components/ExpandButton.tsx
@@ -31,7 +31,15 @@ export function ExpandButton({
}
// Show spinner when toggling, otherwise show chevron
- const Icon = isToggling ? Loader2 : isExpanded ? ChevronDown : ChevronRight;
+ const Icon = (() => {
+ if (isToggling) {
+ return Loader2;
+ }
+ if (isExpanded) {
+ return ChevronDown;
+ }
+ return ChevronRight;
+ })();
return (
<button
diff --git a/web/src/features/traces/components/AdvancedJsonViewer/components/JsonKey.tsx b/web/src/features/traces/components/AdvancedJsonViewer/components/JsonKey.tsx
index 17fa8fd94b..599410ad5e 100644
--- a/web/src/features/traces/components/AdvancedJsonViewer/components/JsonKey.tsx
+++ b/web/src/features/traces/components/AdvancedJsonViewer/components/JsonKey.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-style-props */
/**
* JsonKey - Renders a JSON property key or array index
@@ -60,12 +59,15 @@ export function JsonKey({
}}
>
{segments.map((segment, index) => {
- const backgroundColor =
- segment.type === "search"
- ? theme.searchMatchBackground
- : segment.type === "comment"
- ? COMMENT_HIGHLIGHT_COLOR
- : "transparent";
+ const backgroundColor = (() => {
+ if (segment.type === "search") {
+ return theme.searchMatchBackground;
+ }
+ if (segment.type === "comment") {
+ return COMMENT_HIGHLIGHT_COLOR;
+ }
+ return "transparent";
+ })();
const highlightedSpan = (
<span key={index} style={{ backgroundColor }}>
diff --git a/web/src/features/traces/components/AdvancedJsonViewer/components/JsonRowFixed.tsx b/web/src/features/traces/components/AdvancedJsonViewer/components/JsonRowFixed.tsx
index 2272237c4b..110ba1513b 100644
--- a/web/src/features/traces/components/AdvancedJsonViewer/components/JsonRowFixed.tsx
+++ b/web/src/features/traces/components/AdvancedJsonViewer/components/JsonRowFixed.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-style-props */
/**
* JsonRowFixed - Fixed column content (line number + expand button)
@@ -43,11 +42,15 @@ export function JsonRowFixed({
isToggling = false,
}: JsonRowFixedProps) {
// Calculate background based on search match
- const backgroundColor = isCurrentMatch
- ? theme.searchCurrentBackground
- : searchMatch
- ? theme.searchMatchBackground
- : "transparent";
+ const backgroundColor = (() => {
+ if (isCurrentMatch) {
+ return theme.searchCurrentBackground;
+ }
+ if (searchMatch) {
+ return theme.searchMatchBackground;
+ }
+ return "transparent";
+ })();
return (
<div
diff --git a/web/src/features/traces/components/AdvancedJsonViewer/components/JsonRowScrollable.tsx b/web/src/features/traces/components/AdvancedJsonViewer/components/JsonRowScrollable.tsx
index 530d2cc334..11d31d1652 100644
--- a/web/src/features/traces/components/AdvancedJsonViewer/components/JsonRowScrollable.tsx
+++ b/web/src/features/traces/components/AdvancedJsonViewer/components/JsonRowScrollable.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-style-props */
/**
* JsonRowScrollable - Scrollable column content (indent + key + value + badges + copy)
@@ -52,11 +51,15 @@ export function JsonRowScrollable({
const valueOffset = keyLength + colonLength + quoteLength;
// Calculate background based on search match only (comment highlighting is now character-level)
- const backgroundColor = isCurrentMatch
- ? theme.searchCurrentBackground
- : searchMatch
- ? theme.searchMatchBackground
- : "transparent";
+ const backgroundColor = (() => {
+ if (isCurrentMatch) {
+ return theme.searchCurrentBackground;
+ }
+ if (searchMatch) {
+ return theme.searchMatchBackground;
+ }
+ return "transparent";
+ })();
return (
<div
diff --git a/web/src/features/traces/components/AdvancedJsonViewer/components/JsonValue.tsx b/web/src/features/traces/components/AdvancedJsonViewer/components/JsonValue.tsx
index b9310d46a1..dc0b8d8736 100644
--- a/web/src/features/traces/components/AdvancedJsonViewer/components/JsonValue.tsx
+++ b/web/src/features/traces/components/AdvancedJsonViewer/components/JsonValue.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-style-props */
/**
* JsonValue - Renders a JSON value with type-based styling
@@ -135,12 +134,15 @@ export function JsonValue({
>
&quot;
{segments.map((segment, index) => {
- const backgroundColor =
- segment.type === "search"
- ? theme.searchMatchBackground
- : segment.type === "comment"
- ? COMMENT_HIGHLIGHT_COLOR
- : "transparent";
+ const backgroundColor = (() => {
+ if (segment.type === "search") {
+ return theme.searchMatchBackground;
+ }
+ if (segment.type === "comment") {
+ return COMMENT_HIGHLIGHT_COLOR;
+ }
+ return "transparent";
+ })();
const highlightedSpan = (
<span key={index} style={{ backgroundColor }}>
@@ -203,12 +205,15 @@ export function JsonValue({
}}
>
{segments.map((segment, index) => {
- const backgroundColor =
- segment.type === "search"
- ? theme.searchMatchBackground
- : segment.type === "comment"
- ? COMMENT_HIGHLIGHT_COLOR
- : "transparent";
+ const backgroundColor = (() => {
+ if (segment.type === "search") {
+ return theme.searchMatchBackground;
+ }
+ if (segment.type === "comment") {
+ return COMMENT_HIGHLIGHT_COLOR;
+ }
+ return "transparent";
+ })();
const highlightedSpan = (
<span key={index} style={{ backgroundColor }}>
diff --git a/web/src/features/traces/components/AdvancedJsonViewer/components/TruncatedString.tsx b/web/src/features/traces/components/AdvancedJsonViewer/components/TruncatedString.tsx
index 71423b7af3..639ab515ff 100644
--- a/web/src/features/traces/components/AdvancedJsonViewer/components/TruncatedString.tsx
+++ b/web/src/features/traces/components/AdvancedJsonViewer/components/TruncatedString.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/**
* TruncatedString - String value with truncation and popover
*
@@ -76,12 +75,15 @@ export function TruncatedString({
>
&quot;
{segments.map((segment, index) => {
- const backgroundColor =
- segment.type === "search"
- ? theme.searchMatchBackground
- : segment.type === "comment"
- ? COMMENT_HIGHLIGHT_COLOR
- : "transparent";
+ const backgroundColor = (() => {
+ if (segment.type === "search") {
+ return theme.searchMatchBackground;
+ }
+ if (segment.type === "comment") {
+ return COMMENT_HIGHLIGHT_COLOR;
+ }
+ return "transparent";
+ })();
const highlightedSpan = (
<span key={index} style={{ backgroundColor }}>
@@ -131,12 +133,15 @@ export function TruncatedString({
>
<span>&quot;</span>
{segments.map((segment, index) => {
- const backgroundColor =
- segment.type === "search"
- ? theme.searchMatchBackground
- : segment.type === "comment"
- ? COMMENT_HIGHLIGHT_COLOR
- : "transparent";
+ const backgroundColor = (() => {
+ if (segment.type === "search") {
+ return theme.searchMatchBackground;
+ }
+ if (segment.type === "comment") {
+ return COMMENT_HIGHLIGHT_COLOR;
+ }
+ return "transparent";
+ })();
return (
<span key={index} style={{ backgroundColor }}>
diff --git a/web/src/features/traces/components/AdvancedJsonViewer/lazy/react/LazyJsonList.tsx b/web/src/features/traces/components/AdvancedJsonViewer/lazy/react/LazyJsonList.tsx
index bef4430f63..b328c62517 100644
--- a/web/src/features/traces/components/AdvancedJsonViewer/lazy/react/LazyJsonList.tsx
+++ b/web/src/features/traces/components/AdvancedJsonViewer/lazy/react/LazyJsonList.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-style-props */
/**
* LazyJsonList — the virtualized body of the lazy JSON viewer. It positions row
@@ -33,12 +32,15 @@ async function copyFullValue(store: RowModelStore, nodeId: number) {
if (truncated) return;
// Out-of-double integers come back as bigint, which JSON.stringify can't
// serialize — handle strings and bigint before the object path.
- const text =
- typeof value === "string"
- ? value
- : typeof value === "bigint"
- ? value.toString()
- : safeStringify(value);
+ const text = (() => {
+ if (typeof value === "string") {
+ return value;
+ }
+ if (typeof value === "bigint") {
+ return value.toString();
+ }
+ return safeStringify(value);
+ })();
try {
await navigator.clipboard.writeText(text);
} catch {
diff --git a/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx b/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx
index 83b4c52367..35ee1d20e0 100644
--- a/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx
+++ b/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { useState, useEffect, useCallback, useRef, useMemo } from "react";
import { useTheme } from "next-themes";
import { countJsonRows } from "@/src/features/traces/components/AdvancedJsonViewer/utils/rowCount";
@@ -401,17 +400,15 @@ function IOPreviewJSONInner({
effectiveMetadata,
]);
- const wrapIcon = useMemo(
- () =>
- stringWrapMode === "truncate" ? (
- <Minus size={14} />
- ) : stringWrapMode === "wrap" ? (
- <WrapText size={14} />
- ) : (
- <ChevronDown size={14} className="-rotate-90" />
- ),
- [stringWrapMode],
- );
+ const wrapIcon = useMemo(() => {
+ if (stringWrapMode === "truncate") {
+ return <Minus size={14} />;
+ }
+ if (stringWrapMode === "wrap") {
+ return <WrapText size={14} />;
+ }
+ return <ChevronDown size={14} className="-rotate-90" />;
+ }, [stringWrapMode]);
// Build sections - memoized to prevent re-creation. A gated field renders as
// a section with no data (hideData → the viewer builds no tree for it, so it
diff --git a/web/src/features/traces/components/SpanContent.tsx b/web/src/features/traces/components/SpanContent.tsx
index 6cd4d1abc7..dee7fedd98 100644
--- a/web/src/features/traces/components/SpanContent.tsx
+++ b/web/src/features/traces/components/SpanContent.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-style-props */
/**
* SpanContent - Pure span/observation content renderer.
@@ -60,12 +59,15 @@ export function SpanContent({
node.calculatedTotalCost ??
(node.calculatedInputCost ?? 0) + (node.calculatedOutputCost ?? 0);
- const duration =
- node.endTime && node.startTime
- ? node.endTime.getTime() - node.startTime.getTime()
- : node.latency
- ? node.latency * 1000
- : undefined;
+ const duration = (() => {
+ if (node.endTime && node.startTime) {
+ return node.endTime.getTime() - node.startTime.getTime();
+ }
+ if (node.latency) {
+ return node.latency * 1000;
+ }
+ return undefined;
+ })();
const durationMs = duration || (node.latency ? node.latency * 1000 : 0);
diff --git a/web/src/features/traces/components/TraceTimelineDense/TimelineDense.tsx b/web/src/features/traces/components/TraceTimelineDense/TimelineDense.tsx
index 7ff293caf8..ed6fad95e5 100644
--- a/web/src/features/traces/components/TraceTimelineDense/TimelineDense.tsx
+++ b/web/src/features/traces/components/TraceTimelineDense/TimelineDense.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-null-render */
/**
* The Timeline. `TraceTimelineCompact` measures a box and renders this inside it,
@@ -479,11 +478,15 @@ export function TimelineDense({
// An explicit "Show labels" pin wins over a leftover rail-collapse
// override; otherwise the names stay a peek overlay and never take
// the gutter the user just asked for.
- const wantsOpen = labelsPinned
- ? true
- : override === "collapsed"
- ? false
- : asked || gutterMode === "auto";
+ const wantsOpen = (() => {
+ if (labelsPinned) {
+ return true;
+ }
+ if (override === "collapsed") {
+ return false;
+ }
+ return asked || gutterMode === "auto";
+ })();
const gutterFits =
contentWidth - wantedGutter >=
(asked ? MIN_LANE_WIDTH : AUTO_OPEN_MIN_LANE_WIDTH);
@@ -492,11 +495,15 @@ export function TimelineDense({
// not: it floats over the timeline instead, so hovering the edge never shoves
// the bars sideways while you are reading them.
const committedOpen = canShowNames && gutterFits && wantsOpen;
- const railWidth = canShowNames
- ? committedOpen
- ? wantedGutter
- : RAIL_WIDTH
- : 0;
+ const railWidth = (() => {
+ if (canShowNames) {
+ if (committedOpen) {
+ return wantedGutter;
+ }
+ return RAIL_WIDTH;
+ }
+ return 0;
+ })();
const laneWidth = Math.max(contentWidth - railWidth, 0);
const chartBox = useMemo(
@@ -951,12 +958,15 @@ export function TimelineDense({
// Deltas arrive in pixels, lines or pages depending on the browser and
// the device, so normalize before anything reads them: a line-mode wheel
// reports 3, and panning 3px per notch reads as stuck.
- const unit =
- event.deltaMode === 1
- ? WHEEL_LINE_PX
- : event.deltaMode === 2
- ? Math.max(rect.height, 1)
- : 1;
+ const unit = (() => {
+ if (event.deltaMode === 1) {
+ return WHEEL_LINE_PX;
+ }
+ if (event.deltaMode === 2) {
+ return Math.max(rect.height, 1);
+ }
+ return 1;
+ })();
const deltaX = event.deltaX * unit;
const deltaY = event.deltaY * unit;
// A macOS pinch is the ONLY wheel event that carries ctrlKey. Holding
diff --git a/web/src/features/traces/components/TraceTimelineDense/TimelineRowMetrics.tsx b/web/src/features/traces/components/TraceTimelineDense/TimelineRowMetrics.tsx
index 593a122bfd..7c7f23c31c 100644
--- a/web/src/features/traces/components/TraceTimelineDense/TimelineRowMetrics.tsx
+++ b/web/src/features/traces/components/TraceTimelineDense/TimelineRowMetrics.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-null-render */
/**
* The metrics beside a bar: how long it took, what it cost, whether anyone
@@ -94,28 +93,34 @@ export function TimelineRowMetrics({
const spaceBefore = Math.max(row.x - gapPx, 0);
const spaceAfter = Math.max(laneWidth - (row.x + row.width + gapPx), 0);
const spaceInside = Math.max(row.width - insetPx * 2, 0);
- const placement =
- spaceAfter >= spaceBefore && spaceAfter >= spaceInside
- ? "after"
- : spaceBefore >= spaceInside
- ? "before"
- : "inside";
+ const placement = (() => {
+ if (spaceAfter >= spaceBefore && spaceAfter >= spaceInside) {
+ return "after";
+ }
+ if (spaceBefore >= spaceInside) {
+ return "before";
+ }
+ return "inside";
+ })();
- const style =
- placement === "before"
- ? {
- right: `${Math.max(laneWidth - row.x + gapPx, 0)}px`,
- maxWidth: `${spaceBefore}px`,
- }
- : placement === "inside"
- ? {
- left: `${row.x + insetPx}px`,
- maxWidth: `${Math.max(row.width - insetPx * 2, 0)}px`,
- }
- : {
- left: `${row.x + row.width + gapPx}px`,
- maxWidth: `${spaceAfter}px`,
- };
+ const style = (() => {
+ if (placement === "before") {
+ return {
+ right: `${Math.max(laneWidth - row.x + gapPx, 0)}px`,
+ maxWidth: `${spaceBefore}px`,
+ };
+ }
+ if (placement === "inside") {
+ return {
+ left: `${row.x + insetPx}px`,
+ maxWidth: `${Math.max(row.width - insetPx * 2, 0)}px`,
+ };
+ }
+ return {
+ left: `${row.x + row.width + gapPx}px`,
+ maxWidth: `${spaceAfter}px`,
+ };
+ })();
const fits = createClusterFitter(
Number.parseFloat(style.maxWidth),
diff --git a/web/src/features/traces/components/TraceTruncationNotice.tsx b/web/src/features/traces/components/TraceTruncationNotice.tsx
index c0fcedc5d7..9afa7c4ae1 100644
--- a/web/src/features/traces/components/TraceTruncationNotice.tsx
+++ b/web/src/features/traces/components/TraceTruncationNotice.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-null-render */
/**
* Inline notice above the tree/timeline/search list when the trace has more
@@ -34,22 +33,29 @@ export function TraceTruncationNotice() {
// The detached row carries no marker of its own (deliberately — a per-row label
// is noise on every scroll), so this sentence is the ONLY place that can say
// the tree is showing it out of position.
- const detachedNote = !detachedObservationId
- ? null
- : detachedObservationIsMisplaced
- ? " The one you opened is loaded separately, and appears at the top level because its parent is missing too."
- : " The one you opened is loaded separately.";
+ const detachedNote = (() => {
+ if (!detachedObservationId) {
+ return null;
+ }
+ if (detachedObservationIsMisplaced) {
+ return " The one you opened is loaded separately, and appears at the top level because its parent is missing too.";
+ }
+ return " The one you opened is loaded separately.";
+ })();
// Ranked by how much the message says. Dismissing hides that message and
// everything it already covered, but never a later one that says MORE — so
// dismissing the short detached note cannot swallow the out-of-position
// caveat, which is the only warning that row gets.
- const rank =
- detachedObservationId && detachedObservationIsMisplaced
- ? 2
- : detachedObservationId
- ? 1
- : 0;
+ const rank = (() => {
+ if (detachedObservationId && detachedObservationIsMisplaced) {
+ return 2;
+ }
+ if (detachedObservationId) {
+ return 1;
+ }
+ return 0;
+ })();
if (rank <= dismissedRank) return null;
return (
diff --git a/web/src/features/traces/fns/chatMessageUtils.ts b/web/src/features/traces/fns/chatMessageUtils.ts
index 7b932274f9..fe139e5ce1 100644
--- a/web/src/features/traces/fns/chatMessageUtils.ts
+++ b/web/src/features/traces/fns/chatMessageUtils.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import type { z } from "zod";
import type { ChatMlMessageSchema } from "@/src/components/schemas/ChatMlSchema";
import type { combineInputOutputMessages } from "@/src/utils/chatml";
@@ -128,11 +127,13 @@ export function hasRenderableConversationMessages(
export function parseToolCallsFromMessage(
message: ReturnType<typeof combineInputOutputMessages>[0],
): unknown[] {
- return message.tool_calls && Array.isArray(message.tool_calls)
- ? message.tool_calls
- : message.json?.tool_calls && Array.isArray(message.json?.tool_calls)
- ? message.json.tool_calls
- : [];
+ if (message.tool_calls && Array.isArray(message.tool_calls)) {
+ return message.tool_calls;
+ }
+ if (message.json?.tool_calls && Array.isArray(message.json?.tool_calls)) {
+ return message.json.tool_calls;
+ }
+ return [];
}
/**
diff --git a/web/src/features/traces/fns/timeline/focusLens.ts b/web/src/features/traces/fns/timeline/focusLens.ts
index dcf9d918bd..994f3f7e13 100644
--- a/web/src/features/traces/fns/timeline/focusLens.ts
+++ b/web/src/features/traces/fns/timeline/focusLens.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-exotic-operators */
/**
* A focus+context lens over a list of rows — GROUNDWORK, not in use.
@@ -83,14 +82,18 @@ export function applyFocusLens(input: {
let totalWeight = 0;
for (let index = 0; index < rowCount; index++) {
const distance = Math.abs(index - focusIndex);
- const falloff =
- radius <= 0
- ? distance === 0
- ? 1
- : 0
- : distance >= radius
- ? 0
- : 0.5 * (1 + Math.cos((Math.PI * distance) / radius));
+ const falloff = (() => {
+ if (radius <= 0) {
+ if (distance === 0) {
+ return 1;
+ }
+ return 0;
+ }
+ if (distance >= radius) {
+ return 0;
+ }
+ return 0.5 * (1 + Math.cos((Math.PI * distance) / radius));
+ })();
const weight = 1 + (magnification - 1) * falloff;
weights[index] = weight;
totalWeight += weight;
diff --git a/web/src/features/traces/hooks/useChatMLParser.ts b/web/src/features/traces/hooks/useChatMLParser.ts
index a15fc95ad6..99a33a4ad0 100644
--- a/web/src/features/traces/hooks/useChatMLParser.ts
+++ b/web/src/features/traces/hooks/useChatMLParser.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { useMemo } from "react";
import type { z } from "zod";
import { type Prisma, deepParseJson } from "@langfuse/shared";
@@ -57,11 +56,13 @@ export interface ChatMLParserResult {
function parseToolCallsFromMessage(
message: ReturnType<typeof combineInputOutputMessages>[0],
) {
- return message.tool_calls && Array.isArray(message.tool_calls)
- ? message.tool_calls
- : message.json?.tool_calls && Array.isArray(message.json?.tool_calls)
- ? message.json.tool_calls
- : [];
+ if (message.tool_calls && Array.isArray(message.tool_calls)) {
+ return message.tool_calls;
+ }
+ if (message.json?.tool_calls && Array.isArray(message.json?.tool_calls)) {
+ return message.json.tool_calls;
+ }
+ return [];
}
function getToolCallStringField(
@@ -263,21 +264,33 @@ export function useChatMLParser(
): ChatMLParserResult {
// Use pre-parsed data if available (from Web Worker), otherwise parse synchronously
// This eliminates ~100ms of duplicate parsing when data comes from useParsedObservation
- const parsedInput = preParsedResult
- ? undefined
- : preParsedInput !== undefined
- ? preParsedInput
- : deepParseJson(input, { maxSize: 300_000, maxDepth: 25 });
- const parsedOutput = preParsedResult
- ? undefined
- : preParsedOutput !== undefined
- ? preParsedOutput
- : deepParseJson(output, { maxSize: 300_000, maxDepth: 25 });
- const parsedMetadata = preParsedResult
- ? undefined
- : preParsedMetadata !== undefined
- ? preParsedMetadata
- : deepParseJson(metadata, { maxSize: 100_000, maxDepth: 25 });
+ const parsedInput = (() => {
+ if (preParsedResult) {
+ return undefined;
+ }
+ if (preParsedInput !== undefined) {
+ return preParsedInput;
+ }
+ return deepParseJson(input, { maxSize: 300_000, maxDepth: 25 });
+ })();
+ const parsedOutput = (() => {
+ if (preParsedResult) {
+ return undefined;
+ }
+ if (preParsedOutput !== undefined) {
+ return preParsedOutput;
+ }
+ return deepParseJson(output, { maxSize: 300_000, maxDepth: 25 });
+ })();
+ const parsedMetadata = (() => {
+ if (preParsedResult) {
+ return undefined;
+ }
+ if (preParsedMetadata !== undefined) {
+ return preParsedMetadata;
+ }
+ return deepParseJson(metadata, { maxSize: 100_000, maxDepth: 25 });
+ })();
return useMemo(
() =>
diff --git a/web/src/features/traces/hooks/useIOPreviewParser.ts b/web/src/features/traces/hooks/useIOPreviewParser.ts
index 696244f16e..d172c0db1c 100644
--- a/web/src/features/traces/hooks/useIOPreviewParser.ts
+++ b/web/src/features/traces/hooks/useIOPreviewParser.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { useMemo } from "react";
import { type Prisma, deepParseJson } from "@langfuse/shared";
import { normalizeSpanIO } from "@langfuse/shared/src/utils/normalized-io";
@@ -32,21 +31,33 @@ export function useIOPreviewParser(
preParsedMetadata?: unknown,
preParsedResult?: ChatMLParserResult,
): ChatMLParserResult {
- const parsedInput = preParsedResult
- ? undefined
- : preParsedInput !== undefined
- ? preParsedInput
- : deepParseJson(input, { maxSize: 300_000, maxDepth: 25 });
- const parsedOutput = preParsedResult
- ? undefined
- : preParsedOutput !== undefined
- ? preParsedOutput
- : deepParseJson(output, { maxSize: 300_000, maxDepth: 25 });
- const parsedMetadata = preParsedResult
- ? undefined
- : preParsedMetadata !== undefined
- ? preParsedMetadata
- : deepParseJson(metadata, { maxSize: 100_000, maxDepth: 25 });
+ const parsedInput = (() => {
+ if (preParsedResult) {
+ return undefined;
+ }
+ if (preParsedInput !== undefined) {
+ return preParsedInput;
+ }
+ return deepParseJson(input, { maxSize: 300_000, maxDepth: 25 });
+ })();
+ const parsedOutput = (() => {
+ if (preParsedResult) {
+ return undefined;
+ }
+ if (preParsedOutput !== undefined) {
+ return preParsedOutput;
+ }
+ return deepParseJson(output, { maxSize: 300_000, maxDepth: 25 });
+ })();
+ const parsedMetadata = (() => {
+ if (preParsedResult) {
+ return undefined;
+ }
+ if (preParsedMetadata !== undefined) {
+ return preParsedMetadata;
+ }
+ return deepParseJson(metadata, { maxSize: 100_000, maxDepth: 25 });
+ })();
return useMemo<ChatMLParserResult>(() => {
if (preParsedResult) return preParsedResult;
diff --git a/web/src/features/traces/parsers/toIOPreview.ts b/web/src/features/traces/parsers/toIOPreview.ts
index 9c4e060045..c09b97183e 100644
--- a/web/src/features/traces/parsers/toIOPreview.ts
+++ b/web/src/features/traces/parsers/toIOPreview.ts
@@ -183,12 +183,15 @@ function toChatMessages(message: NormalizedMessage): ProjectedMessage {
? contentParts.join("")
: undefined;
- const json =
- jsonParts.length === 0
- ? undefined
- : jsonParts.length === 1
- ? jsonParts[0]
- : jsonParts;
+ const json = (() => {
+ if (jsonParts.length === 0) {
+ return undefined;
+ }
+ if (jsonParts.length === 1) {
+ return jsonParts[0];
+ }
+ return jsonParts;
+ })();
const hasMainMessage =
content !== undefined ||
diff --git a/web/src/features/tracing-tables/observations/ObservationsTable.tsx b/web/src/features/tracing-tables/observations/ObservationsTable.tsx
index cf549c470f..993fb34c2e 100644
--- a/web/src/features/tracing-tables/observations/ObservationsTable.tsx
+++ b/web/src/features/tracing-tables/observations/ObservationsTable.tsx
@@ -1726,12 +1726,15 @@ const GenerationsDynamicCell = ({
},
);
- const data =
- col === "output"
- ? observation.data?.output
- : col === "input"
- ? observation.data?.input
- : observation.data?.metadata;
+ const data = (() => {
+ if (col === "output") {
+ return observation.data?.output;
+ }
+ if (col === "input") {
+ return observation.data?.input;
+ }
+ return observation.data?.metadata;
+ })();
if (observation.isPending) {
return <ConnectedIOTableCell isLoading singleLine={singleLine} />;
diff --git a/web/src/features/v4-migration/V4MigrationContent.clienttest.tsx b/web/src/features/v4-migration/V4MigrationContent.clienttest.tsx
index 9da5d49927..4529c3c58f 100644
--- a/web/src/features/v4-migration/V4MigrationContent.clienttest.tsx
+++ b/web/src/features/v4-migration/V4MigrationContent.clienttest.tsx
@@ -37,14 +37,18 @@ const makeSdkUsageSeries = (
overrides.deliveryMode ?? (source === "otel" ? "realtime" : "delayed");
const sdkName = overrides.sdkName ?? "python";
const sdkVersion = overrides.sdkVersion ?? "4.7.1";
- const canonicalSdkName =
- overrides.canonicalSdkName !== undefined
- ? overrides.canonicalSdkName
- : sdkName === "python"
- ? "python"
- : sdkName === "javascript" || sdkName.startsWith("@langfuse/")
- ? "javascript"
- : null;
+ const canonicalSdkName = (() => {
+ if (overrides.canonicalSdkName !== undefined) {
+ return overrides.canonicalSdkName;
+ }
+ if (sdkName === "python") {
+ return "python";
+ }
+ if (sdkName === "javascript" || sdkName.startsWith("@langfuse/")) {
+ return "javascript";
+ }
+ return null;
+ })();
const sdkVersionMajor =
overrides.sdkVersionMajor !== undefined
? overrides.sdkVersionMajor
@@ -52,12 +56,15 @@ const makeSdkUsageSeries = (
const resolvedMajor = Number.isFinite(sdkVersionMajor)
? Number(sdkVersionMajor)
: null;
- const latestMajor =
- canonicalSdkName === "python"
- ? 4
- : canonicalSdkName === "javascript"
- ? 5
- : null;
+ const latestMajor = (() => {
+ if (canonicalSdkName === "python") {
+ return 4;
+ }
+ if (canonicalSdkName === "javascript") {
+ return 5;
+ }
+ return null;
+ })();
const v4MigrationStatus =
overrides.v4MigrationStatus ??
(canonicalSdkName === null || resolvedMajor === null
diff --git a/web/src/features/v4-migration/V4MigrationContent.tsx b/web/src/features/v4-migration/V4MigrationContent.tsx
index c19e256daf..3f6436b601 100644
--- a/web/src/features/v4-migration/V4MigrationContent.tsx
+++ b/web/src/features/v4-migration/V4MigrationContent.tsx
@@ -376,13 +376,18 @@ function SdkUsageSeriesRows({
language: usage.canonicalSdkName ?? usage.sdkName,
version: usage.sdkVersion,
});
- const publicKey = usage.publicKey
- ? usage.publicKey.length > 18
- ? `${usage.publicKey.slice(0, 9)}…${usage.publicKey.slice(-6)}`
- : usage.publicKey
- : hideMissingApiKey
- ? null
- : "No API key";
+ const publicKey = (() => {
+ if (usage.publicKey) {
+ if (usage.publicKey.length > 18) {
+ return `${usage.publicKey.slice(0, 9)}…${usage.publicKey.slice(-6)}`;
+ }
+ return usage.publicKey;
+ }
+ if (hideMissingApiKey) {
+ return null;
+ }
+ return "No API key";
+ })();
const evidenceHref =
projectId && usage.eventCount > 0
? `/project/${projectId}/observations?filter=${encodeURIComponent(
@@ -517,13 +522,17 @@ export function V4MigrationSdkSection({
projectId={projectId}
analyticsSection="sdk"
needsAction={isActionableSdkSeries}
- suffix={(usage) =>
- usage.v4MigrationStatus === "upgrade_required" ? (
- <span>· {formatSdkUpgradeRequirement(usage.latestSdkMajor)}</span>
- ) : usage.v4MigrationStatus === "unknown" ? (
- <span>· version not recognized</span>
- ) : null
- }
+ suffix={(usage) => {
+ if (usage.v4MigrationStatus === "upgrade_required") {
+ return (
+ <span>· {formatSdkUpgradeRequirement(usage.latestSdkMajor)}</span>
+ );
+ }
+ if (usage.v4MigrationStatus === "unknown") {
+ return <span>· version not recognized</span>;
+ }
+ return null;
+ }}
/>
</Section>
);
@@ -978,13 +987,18 @@ export function V4MigrationApisSection({
caller.sdkName,
caller.sdkVersion,
);
- const callerName = caller.isOther
- ? "Unknown callers"
- : caller.sdkName
- ? `Langfuse ${caller.sdkName === "python" ? "Python" : "JavaScript"} SDK${caller.sdkVersion ? ` ${caller.sdkVersion}` : ""}`
- : codingAgent
- ? codingAgent
- : caller.userAgent || "Unknown caller";
+ const callerName = (() => {
+ if (caller.isOther) {
+ return "Unknown callers";
+ }
+ if (caller.sdkName) {
+ return `Langfuse ${caller.sdkName === "python" ? "Python" : "JavaScript"} SDK${caller.sdkVersion ? ` ${caller.sdkVersion}` : ""}`;
+ }
+ if (codingAgent) {
+ return codingAgent;
+ }
+ return caller.userAgent || "Unknown caller";
+ })();
const callerCount = Math.max(
1,
Math.round(caller.count),
diff --git a/web/src/features/v4-migration/V4MigrationDelayBadge.clienttest.tsx b/web/src/features/v4-migration/V4MigrationDelayBadge.clienttest.tsx
index 6bbdc51603..964d42aab1 100644
--- a/web/src/features/v4-migration/V4MigrationDelayBadge.clienttest.tsx
+++ b/web/src/features/v4-migration/V4MigrationDelayBadge.clienttest.tsx
@@ -19,14 +19,18 @@ const makeSdkUsageSeries = (
overrides.deliveryMode ?? (source === "otel" ? "realtime" : "delayed");
const sdkName = overrides.sdkName ?? "python";
const sdkVersion = overrides.sdkVersion ?? "4.7.1";
- const canonicalSdkName =
- overrides.canonicalSdkName !== undefined
- ? overrides.canonicalSdkName
- : sdkName === "python"
- ? "python"
- : sdkName === "javascript" || sdkName.startsWith("@langfuse/")
- ? "javascript"
- : null;
+ const canonicalSdkName = (() => {
+ if (overrides.canonicalSdkName !== undefined) {
+ return overrides.canonicalSdkName;
+ }
+ if (sdkName === "python") {
+ return "python";
+ }
+ if (sdkName === "javascript" || sdkName.startsWith("@langfuse/")) {
+ return "javascript";
+ }
+ return null;
+ })();
const sdkVersionMajor =
overrides.sdkVersionMajor !== undefined
? overrides.sdkVersionMajor
@@ -34,12 +38,15 @@ const makeSdkUsageSeries = (
const resolvedMajor = Number.isFinite(sdkVersionMajor)
? Number(sdkVersionMajor)
: null;
- const latestMajor =
- canonicalSdkName === "python"
- ? 4
- : canonicalSdkName === "javascript"
- ? 5
- : null;
+ const latestMajor = (() => {
+ if (canonicalSdkName === "python") {
+ return 4;
+ }
+ if (canonicalSdkName === "javascript") {
+ return 5;
+ }
+ return null;
+ })();
const v4MigrationStatus =
overrides.v4MigrationStatus ??
(canonicalSdkName === null || resolvedMajor === null
diff --git a/web/src/features/v4-migration/V4MigrationDelayBadge.tsx b/web/src/features/v4-migration/V4MigrationDelayBadge.tsx
index a5e8de1f0a..5cebb4d77c 100644
--- a/web/src/features/v4-migration/V4MigrationDelayBadge.tsx
+++ b/web/src/features/v4-migration/V4MigrationDelayBadge.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/* eslint-disable @repo/no-null-render */
import { useEffect, useRef, useState } from "react";
import { useRouter } from "next/router";
@@ -153,14 +152,18 @@ export function V4MigrationDelayBadge({
// The hover's action clause echoes the panel section the click opens;
// multiple delayed paths get the generic clause.
- const description =
- actionablePaths > 1
- ? "Upgrade to v4 for real-time data"
- : sdkActionable
- ? "Update your SDK for real-time data"
- : otelActionable
- ? "Update your OTel instrumentation for real-time data"
- : "Upgrade your instrumentation for real-time data";
+ const description = (() => {
+ if (actionablePaths > 1) {
+ return "Upgrade to v4 for real-time data";
+ }
+ if (sdkActionable) {
+ return "Update your SDK for real-time data";
+ }
+ if (otelActionable) {
+ return "Update your OTel instrumentation for real-time data";
+ }
+ return "Upgrade your instrumentation for real-time data";
+ })();
return (
<V4MigrationBadgeContent
diff --git a/web/src/features/v4-migration/V4MigrationSections.stories.tsx b/web/src/features/v4-migration/V4MigrationSections.stories.tsx
index ce8a3fccd5..e6b1b23da6 100644
--- a/web/src/features/v4-migration/V4MigrationSections.stories.tsx
+++ b/web/src/features/v4-migration/V4MigrationSections.stories.tsx
@@ -30,14 +30,18 @@ const makeSeries = (
overrides.deliveryMode ?? (source === "otel" ? "realtime" : "delayed");
const sdkName = overrides.sdkName ?? "python";
const sdkVersion = overrides.sdkVersion ?? "4.7.1";
- const canonicalSdkName =
- overrides.canonicalSdkName !== undefined
- ? overrides.canonicalSdkName
- : sdkName === "python"
- ? "python"
- : sdkName === "javascript" || sdkName.startsWith("@langfuse/")
- ? "javascript"
- : null;
+ const canonicalSdkName = (() => {
+ if (overrides.canonicalSdkName !== undefined) {
+ return overrides.canonicalSdkName;
+ }
+ if (sdkName === "python") {
+ return "python";
+ }
+ if (sdkName === "javascript" || sdkName.startsWith("@langfuse/")) {
+ return "javascript";
+ }
+ return null;
+ })();
const sdkVersionMajor =
overrides.sdkVersionMajor !== undefined
? overrides.sdkVersionMajor
@@ -45,12 +49,15 @@ const makeSeries = (
const resolvedMajor = Number.isFinite(sdkVersionMajor)
? Number(sdkVersionMajor)
: null;
- const latestMajor =
- canonicalSdkName === "python"
- ? 4
- : canonicalSdkName === "javascript"
- ? 5
- : null;
+ const latestMajor = (() => {
+ if (canonicalSdkName === "python") {
+ return 4;
+ }
+ if (canonicalSdkName === "javascript") {
+ return 5;
+ }
+ return null;
+ })();
const v4MigrationStatus =
overrides.v4MigrationStatus ??
(canonicalSdkName === null || resolvedMajor === null
diff --git a/web/src/features/v4-migration/V4MigrationStatusPage.tsx b/web/src/features/v4-migration/V4MigrationStatusPage.tsx
index 15195e32b4..78d48cc405 100644
--- a/web/src/features/v4-migration/V4MigrationStatusPage.tsx
+++ b/web/src/features/v4-migration/V4MigrationStatusPage.tsx
@@ -80,13 +80,13 @@ function MigrationActionCell({ state }: { state: MigrationActionState }) {
if (state.status === "error") {
return <span className="text-foreground-tertiary">Unavailable</span>;
}
- return state.result === "required" ? (
- <span>Update required</span>
- ) : state.result === "sdk_usage_inconclusive" ? (
- <span>Needs review</span>
- ) : (
- <span className="text-foreground-tertiary">Up to date</span>
- );
+ if (state.result === "required") {
+ return <span>Update required</span>;
+ }
+ if (state.result === "sdk_usage_inconclusive") {
+ return <span>Needs review</span>;
+ }
+ return <span className="text-foreground-tertiary">Up to date</span>;
}
function StatusPill({ readiness }: { readiness: ProjectMigrationReadiness }) {
@@ -250,29 +250,38 @@ function OrgStatusSection({
"partner-managed": 4,
}[row.readiness];
case "sdk":
- return row.status.sdk.status === "latest"
- ? 5
- : row.status.sdk.status === "otel_realtime"
- ? 5
- : row.status.sdk.status === "no_data"
- ? 5
- : row.status.sdk.status === "legacy"
- ? 4
- : row.status.sdk.status === "otel_header_required"
- ? 3
- : row.status.sdk.status === "unknown"
- ? 2
- : row.status.sdk.status === "checking"
- ? 1
- : 0;
+ if (row.status.sdk.status === "latest") {
+ return 5;
+ }
+ if (row.status.sdk.status === "otel_realtime") {
+ return 5;
+ }
+ if (row.status.sdk.status === "no_data") {
+ return 5;
+ }
+ if (row.status.sdk.status === "legacy") {
+ return 4;
+ }
+ if (row.status.sdk.status === "otel_header_required") {
+ return 3;
+ }
+ if (row.status.sdk.status === "unknown") {
+ return 2;
+ }
+ if (row.status.sdk.status === "checking") {
+ return 1;
+ }
+ return 0;
case "evals":
return row.status.evals.count;
case "experiments":
- return row.status.experiments.result === "required"
- ? 2
- : row.status.experiments.result === "sdk_usage_inconclusive"
- ? 1
- : 0;
+ if (row.status.experiments.result === "required") {
+ return 2;
+ }
+ if (row.status.experiments.result === "sdk_usage_inconclusive") {
+ return 1;
+ }
+ return 0;
case "apis":
return row.status.apis.count;
case "exports":
@@ -339,29 +348,43 @@ function OrgStatusSection({
...columnOptions,
accessorKey: "sdk",
header: () => sortableHeader("SDK", "sdk"),
- cell: ({ row }) =>
- row.original.status.sdk.status === "latest" ? (
- <span className="text-foreground-tertiary">Latest</span>
- ) : row.original.status.sdk.status === "otel_realtime" ? (
- <span className="text-foreground-tertiary">OTel real-time</span>
- ) : row.original.status.sdk.status === "no_data" ? (
- <span className="text-foreground-tertiary">No data detected</span>
- ) : row.original.status.sdk.status === "checking" ? (
- <span className="text-foreground-tertiary">Checking…</span>
- ) : row.original.status.sdk.status === "unknown" ? (
- <span className="text-foreground-tertiary">Unknown</span>
- ) : row.original.status.sdk.status === "otel_header_required" ? (
- <span>
- {row.original.status.sdk.delayedOtelIngestionCount} OTel header{" "}
- {row.original.status.sdk.delayedOtelIngestionCount === 1
- ? "required"
- : "issues"}
- </span>
- ) : row.original.status.sdk.status === "error" ? (
- <span className="text-foreground-tertiary">Unavailable</span>
- ) : (
+ cell: ({ row }) => {
+ if (row.original.status.sdk.status === "latest") {
+ return <span className="text-foreground-tertiary">Latest</span>;
+ }
+ if (row.original.status.sdk.status === "otel_realtime") {
+ return (
+ <span className="text-foreground-tertiary">OTel real-time</span>
+ );
+ }
+ if (row.original.status.sdk.status === "no_data") {
+ return (
+ <span className="text-foreground-tertiary">No data detected</span>
+ );
+ }
+ if (row.original.status.sdk.status === "checking") {
+ return <span className="text-foreground-tertiary">Checking…</span>;
+ }
+ if (row.original.status.sdk.status === "unknown") {
+ return <span className="text-foreground-tertiary">Unknown</span>;
+ }
+ if (row.original.status.sdk.status === "otel_header_required") {
+ return (
+ <span>
+ {row.original.status.sdk.delayedOtelIngestionCount} OTel header{" "}
+ {row.original.status.sdk.delayedOtelIngestionCount === 1
+ ? "required"
+ : "issues"}
+ </span>
+ );
+ }
+ if (row.original.status.sdk.status === "error") {
+ return <span className="text-foreground-tertiary">Unavailable</span>;
+ }
+ return (
<span>{row.original.status.sdk.upgradeRequiredCount} outdated</span>
- ),
+ );
+ },
},
{
...columnOptions,
diff --git a/web/src/features/v4-migration/sdkVersionStatus.clienttest.ts b/web/src/features/v4-migration/sdkVersionStatus.clienttest.ts
index 2cb7bb6d8a..3d734940e7 100644
--- a/web/src/features/v4-migration/sdkVersionStatus.clienttest.ts
+++ b/web/src/features/v4-migration/sdkVersionStatus.clienttest.ts
@@ -21,14 +21,18 @@ const sdkSeries = (
overrides.deliveryMode ?? (source === "otel" ? "realtime" : "delayed");
const sdkName = overrides.sdkName ?? "python";
const sdkVersion = overrides.sdkVersion ?? "4.7.0";
- const canonicalSdkName =
- overrides.canonicalSdkName !== undefined
- ? overrides.canonicalSdkName
- : sdkName === "python"
- ? "python"
- : sdkName === "javascript" || sdkName.startsWith("@langfuse/")
- ? "javascript"
- : null;
+ const canonicalSdkName = (() => {
+ if (overrides.canonicalSdkName !== undefined) {
+ return overrides.canonicalSdkName;
+ }
+ if (sdkName === "python") {
+ return "python";
+ }
+ if (sdkName === "javascript" || sdkName.startsWith("@langfuse/")) {
+ return "javascript";
+ }
+ return null;
+ })();
const sdkVersionMajor =
overrides.sdkVersionMajor !== undefined
? overrides.sdkVersionMajor
@@ -36,12 +40,15 @@ const sdkSeries = (
const resolvedMajor = Number.isFinite(sdkVersionMajor)
? Number(sdkVersionMajor)
: null;
- const latestMajor =
- canonicalSdkName === "python"
- ? 4
- : canonicalSdkName === "javascript"
- ? 5
- : null;
+ const latestMajor = (() => {
+ if (canonicalSdkName === "python") {
+ return 4;
+ }
+ if (canonicalSdkName === "javascript") {
+ return 5;
+ }
+ return null;
+ })();
const v4MigrationStatus =
overrides.v4MigrationStatus ??
(canonicalSdkName === null || resolvedMajor === null
diff --git a/web/src/features/v4-migration/sdkVersionStatus.ts b/web/src/features/v4-migration/sdkVersionStatus.ts
index 217773ea91..4556aebd5d 100644
--- a/web/src/features/v4-migration/sdkVersionStatus.ts
+++ b/web/src/features/v4-migration/sdkVersionStatus.ts
@@ -196,12 +196,15 @@ export const getDetectedInstrumentationSeries = (
export const formatSdkVersion = (sdkVersion: SdkVersionInfo | undefined) => {
if (!sdkVersion?.language || !sdkVersion.version) return null;
- const language =
- sdkVersion.language === "javascript"
- ? "JavaScript"
- : sdkVersion.language === "python"
- ? "Python"
- : sdkVersion.language;
+ const language = (() => {
+ if (sdkVersion.language === "javascript") {
+ return "JavaScript";
+ }
+ if (sdkVersion.language === "python") {
+ return "Python";
+ }
+ return sdkVersion.language;
+ })();
return `${language} ${sdkVersion.version}`;
};
diff --git a/web/src/features/v4/server/v4TransitionSdkUsage.ts b/web/src/features/v4/server/v4TransitionSdkUsage.ts
index c9945809dd..9801905d4a 100644
--- a/web/src/features/v4/server/v4TransitionSdkUsage.ts
+++ b/web/src/features/v4/server/v4TransitionSdkUsage.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/**
* SDK / events_core usage checks for the v4 transition.
*
@@ -514,11 +513,13 @@ export const deriveExperimentInstrumentationMigration = ({
currentInstrumentationStatus !== "supported")
);
});
- return hasCurrentExperimentInstrumentation
- ? { status: "not_required", upgradePath: null }
- : hasInconclusiveExperimentSdkUsage
- ? { status: "sdk_usage_inconclusive", upgradePath: "sdk" }
- : { status: "required", upgradePath: "api" };
+ if (hasCurrentExperimentInstrumentation) {
+ return { status: "not_required", upgradePath: null };
+ }
+ if (hasInconclusiveExperimentSdkUsage) {
+ return { status: "sdk_usage_inconclusive", upgradePath: "sdk" };
+ }
+ return { status: "required", upgradePath: "api" };
};
export const getSdkUsageSummaries = async ({
diff --git a/web/src/features/v4/server/v4TransitionService.ts b/web/src/features/v4/server/v4TransitionService.ts
index 4f33a24c8e..1121c49da1 100644
--- a/web/src/features/v4/server/v4TransitionService.ts
+++ b/web/src/features/v4/server/v4TransitionService.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/**
* v4 transition orchestration: Postgres summaries, sidebar migration actions,
* and re-exports for the tRPC router. SDK / events_core and system.query_log
@@ -294,17 +293,20 @@ export const getMigrationActions = async ({
const postBlob = postBlobs[0] ?? null;
const apiBlob = apiBlobs[0] ?? null;
- const experimentsActionNeeded =
- postBlob === null
- ? null
- : postBlob.used === false
- ? false
- : ["required", "sdk_usage_inconclusive"].includes(
- deriveExperimentInstrumentationMigration({
- sdkUsageSeries,
- postUsage: true,
- }).status,
- );
+ const experimentsActionNeeded = (() => {
+ if (postBlob === null) {
+ return null;
+ }
+ if (postBlob.used === false) {
+ return false;
+ }
+ return ["required", "sdk_usage_inconclusive"].includes(
+ deriveExperimentInstrumentationMigration({
+ sdkUsageSeries,
+ postUsage: true,
+ }).status,
+ );
+ })();
return {
forceV3Experience: isForceV3ExperienceProject(projectId),
diff --git a/web/src/features/widgets/chart-library/ChartLoadingState.tsx b/web/src/features/widgets/chart-library/ChartLoadingState.tsx
index cde667aba5..3880af9284 100644
--- a/web/src/features/widgets/chart-library/ChartLoadingState.tsx
+++ b/web/src/features/widgets/chart-library/ChartLoadingState.tsx
@@ -109,12 +109,15 @@ export function ChartLoadingState({
);
}
- const statusTitle =
- isPendingProgressState || shouldShowProgress
- ? "Running query"
- : showSpinner
- ? "Loading widget"
- : "Query needs attention";
+ const statusTitle = (() => {
+ if (isPendingProgressState || shouldShowProgress) {
+ return "Running query";
+ }
+ if (showSpinner) {
+ return "Loading widget";
+ }
+ return "Query needs attention";
+ })();
return (
<div
diff --git a/web/src/features/widgets/chart-library/prepareTimeAxis.ts b/web/src/features/widgets/chart-library/prepareTimeAxis.ts
index a42df02c80..7eb7098189 100644
--- a/web/src/features/widgets/chart-library/prepareTimeAxis.ts
+++ b/web/src/features/widgets/chart-library/prepareTimeAxis.ts
@@ -216,8 +216,15 @@ export function prepareTimeAxis(
const temporal =
timestamps.length > 0 && timestamps.length >= rawValues.length / 2;
if (!temporal) {
- const full = (raw: unknown): string =>
- raw == null ? "" : typeof raw === "string" ? raw : String(raw);
+ const full = (raw: unknown): string => {
+ if (raw == null) {
+ return "";
+ }
+ if (typeof raw === "string") {
+ return raw;
+ }
+ return String(raw);
+ };
// Opt-in (experiments / dataset-compare): hide the entity names on the axis
// entirely and surface the full name on hover instead — the names cluttered
// the axis with little value. Nothing to fit, so draw every tick (`0`)
diff --git a/web/src/features/widgets/chart-library/prepareVisibleSeries.ts b/web/src/features/widgets/chart-library/prepareVisibleSeries.ts
index fcfe995e46..e506e6845b 100644
--- a/web/src/features/widgets/chart-library/prepareVisibleSeries.ts
+++ b/web/src/features/widgets/chart-library/prepareVisibleSeries.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { type DataPoint } from "@/src/features/widgets/chart-library/chart-props";
import { getDimensionSummaries } from "@/src/features/widgets/chart-library/utils";
@@ -56,7 +55,13 @@ export function prepareVisibleSeries(
const ranked = [...dimensions].sort((a, b) => {
const diff = magnitude(b) - magnitude(a);
if (diff !== 0 && !Number.isNaN(diff)) return diff;
- return a < b ? -1 : a > b ? 1 : 0;
+ if (a < b) {
+ return -1;
+ }
+ if (a > b) {
+ return 1;
+ }
+ return 0;
});
const visible = ranked.slice(0, maxSeries);
diff --git a/web/src/features/widgets/components/DashboardWidget.tsx b/web/src/features/widgets/components/DashboardWidget.tsx
index 536d4909e3..cd79d51c41 100644
--- a/web/src/features/widgets/components/DashboardWidget.tsx
+++ b/web/src/features/widgets/components/DashboardWidget.tsx
@@ -292,12 +292,15 @@ export function DashboardWidget({
isV4Enabled: isV4,
version: metricsVersion,
});
- const loadingStateLayout =
- placement.y_size <= 2
- ? "tight"
- : placement.x_size <= 4
- ? "compact"
- : "default";
+ const loadingStateLayout = (() => {
+ if (placement.y_size <= 2) {
+ return "tight";
+ }
+ if (placement.x_size <= 4) {
+ return "compact";
+ }
+ return "default";
+ })();
const loadingProgress = getChartLoadingProgress({
isPending: queryResult.isPending,
progress: queryResult.progress,
diff --git a/web/src/pages/api/dashboard/execute-query-stream.ts b/web/src/pages/api/dashboard/execute-query-stream.ts
index bcf80d4438..9bb1e98ba7 100644
--- a/web/src/pages/api/dashboard/execute-query-stream.ts
+++ b/web/src/pages/api/dashboard/execute-query-stream.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import type { NextApiRequest, NextApiResponse } from "next";
import * as z from "zod/v4";
import {
@@ -197,12 +196,15 @@ export default async function handler(
error: error instanceof Error ? error.message : String(error),
projectId,
});
- const message =
- error instanceof ClickHouseResourceError
- ? RESOURCE_LIMIT_ERROR_MESSAGE
- : error instanceof Error
- ? error.message
- : "Internal server error";
+ const message = (() => {
+ if (error instanceof ClickHouseResourceError) {
+ return RESOURCE_LIMIT_ERROR_MESSAGE;
+ }
+ if (error instanceof Error) {
+ return error.message;
+ }
+ return "Internal server error";
+ })();
res.write(formatSSEEvent({ type: "error", message }));
}
} finally {
diff --git a/web/src/pages/api/public/traces/[traceId].ts b/web/src/pages/api/public/traces/[traceId].ts
index 25e75d79a5..3babd8e193 100644
--- a/web/src/pages/api/public/traces/[traceId].ts
+++ b/web/src/pages/api/public/traces/[traceId].ts
@@ -163,16 +163,24 @@ export default withMiddlewares(
.filter((t) => t)
.sort((a, b) => (a as Date).getTime() - (b as Date).getTime());
- const latencyMs =
- obsStartTimes.length > 0
- ? obsEndTimes.length > 0
- ? (obsEndTimes[obsEndTimes.length - 1] as Date).getTime() -
+ const latencyMs = (() => {
+ if (obsStartTimes.length > 0) {
+ if (obsEndTimes.length > 0) {
+ return (
+ (obsEndTimes[obsEndTimes.length - 1] as Date).getTime() -
obsStartTimes[0]!.getTime()
- : obsStartTimes.length > 1
- ? obsStartTimes[obsStartTimes.length - 1]!.getTime() -
- obsStartTimes[0]!.getTime()
- : undefined
- : undefined;
+ );
+ }
+ if (obsStartTimes.length > 1) {
+ return (
+ obsStartTimes[obsStartTimes.length - 1]!.getTime() -
+ obsStartTimes[0]!.getTime()
+ );
+ }
+ return undefined;
+ }
+ return undefined;
+ })();
return {
...trace,
externalId: null,
diff --git a/web/src/server/api/routers/models.ts b/web/src/server/api/routers/models.ts
index 2135804d37..e7da28fc3f 100644
--- a/web/src/server/api/routers/models.ts
+++ b/web/src/server/api/routers/models.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { v4 as uuidv4 } from "uuid";
import { z } from "zod";
@@ -443,14 +442,18 @@ export const modelRouter = createTRPCRouter({
// Without usage details, fall back to the model's default pricing tier.
const defaultTier = pricingTiers.find((tier) => tier.isDefault);
- const matchResult = hasPricingTierUsageDetails(usageDetails)
- ? matchPricingTier(pricingTiers, usageDetails ?? {}, {
+ const matchResult = (() => {
+ if (hasPricingTierUsageDetails(usageDetails)) {
+ return matchPricingTier(pricingTiers, usageDetails ?? {}, {
modelParameters,
metadata,
- })
- : defaultTier
- ? { pricingTierId: defaultTier.id }
- : null;
+ });
+ }
+ if (defaultTier) {
+ return { pricingTierId: defaultTier.id };
+ }
+ return null;
+ })();
if (!matchResult) {
return { matched: false as const };
diff --git a/web/src/server/api/routers/traces.ts b/web/src/server/api/routers/traces.ts
index 0f2827b62a..a71ef67187 100644
--- a/web/src/server/api/routers/traces.ts
+++ b/web/src/server/api/routers/traces.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { z } from "zod";
import { auditLog } from "@/src/features/audit-logs/server";
import { throwIfNoProjectAccess } from "@/src/features/rbac";
@@ -431,16 +430,24 @@ export const traceRouter = createTRPCRouter({
.map((o) => o.endTime)
.filter((t) => t)
.sort((a, b) => (a as Date).getTime() - (b as Date).getTime());
- const latencyMs =
- obsStartTimes.length > 0
- ? obsEndTimes.length > 0
- ? (obsEndTimes[obsEndTimes.length - 1] as Date).getTime() -
+ const latencyMs = (() => {
+ if (obsStartTimes.length > 0) {
+ if (obsEndTimes.length > 0) {
+ return (
+ (obsEndTimes[obsEndTimes.length - 1] as Date).getTime() -
obsStartTimes[0]!.getTime()
- : obsStartTimes.length > 1
- ? obsStartTimes[obsStartTimes.length - 1]!.getTime() -
- obsStartTimes[0]!.getTime()
- : undefined
- : undefined;
+ );
+ }
+ if (obsStartTimes.length > 1) {
+ return (
+ obsStartTimes[obsStartTimes.length - 1]!.getTime() -
+ obsStartTimes[0]!.getTime()
+ );
+ }
+ return undefined;
+ }
+ return undefined;
+ })();
const scoresDomain =
toDomainArrayWithStringifiedMetadata<ScoreDomain>(scores);
diff --git a/web/src/utils/api.ts b/web/src/utils/api.ts
index eafed5b2b1..e75f95928e 100644
--- a/web/src/utils/api.ts
+++ b/web/src/utils/api.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
/**
* This is the client-side entrypoint for your tRPC API. It is used to create the `api` object which
* contains the Next.js App-wrapper, as well as your type-safe React Query hooks.
@@ -35,12 +34,15 @@ export { isTrpcZodValidationError } from "@/src/utils/trpcValidationError";
setUpSuperjson();
const getBaseUrl = () => {
- const hostname =
- typeof window !== "undefined"
- ? window.location.origin
- : process.env.VERCEL_URL
- ? `https://${process.env.VERCEL_URL}`
- : `http://localhost:${process.env.PORT ?? 3000}`;
+ const hostname = (() => {
+ if (typeof window !== "undefined") {
+ return window.location.origin;
+ }
+ if (process.env.VERCEL_URL) {
+ return `https://${process.env.VERCEL_URL}`;
+ }
+ return `http://localhost:${process.env.PORT ?? 3000}`;
+ })();
return `${hostname}${env.NEXT_PUBLIC_BASE_PATH ?? ""}`;
};
diff --git a/worker/src/backgroundMigrations/utils/backfillBase.ts b/worker/src/backgroundMigrations/utils/backfillBase.ts
index b32177b531..3f3c73ddcd 100644
--- a/worker/src/backgroundMigrations/utils/backfillBase.ts
+++ b/worker/src/backgroundMigrations/utils/backfillBase.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { randomUUID } from "crypto";
import { parseArgs } from "node:util";
import {
@@ -259,12 +258,15 @@ async function fireQuery({
const abortController = new AbortController();
- const retrySetting =
- attemptNumber > 1
- ? (retrySettings.retry2 ?? {})
- : attemptNumber > 0
- ? (retrySettings.retry1 ?? {})
- : (retrySettings.retry0 ?? {});
+ const retrySetting = (() => {
+ if (attemptNumber > 1) {
+ return retrySettings.retry2 ?? {};
+ }
+ if (attemptNumber > 0) {
+ return retrySettings.retry1 ?? {};
+ }
+ return retrySettings.retry0 ?? {};
+ })();
if (attemptNumber > 0) {
logger.info(
diff --git a/worker/src/ee/usageThresholds/thresholdProcessing.ts b/worker/src/ee/usageThresholds/thresholdProcessing.ts
index e8bfefcfa8..c5c0d108a7 100644
--- a/worker/src/ee/usageThresholds/thresholdProcessing.ts
+++ b/worker/src/ee/usageThresholds/thresholdProcessing.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import type { Organization } from "@prisma/client";
import { prisma } from "@langfuse/shared/src/db";
import {
@@ -436,12 +435,15 @@ export async function processThresholds(
};
// 8. Return result for metrics tracking
- const actionTaken =
- currentState === "BLOCKED"
- ? "BLOCKED"
- : currentState === "WARNING"
- ? "WARNING"
- : "NONE";
+ const actionTaken = (() => {
+ if (currentState === "BLOCKED") {
+ return "BLOCKED";
+ }
+ if (currentState === "WARNING") {
+ return "WARNING";
+ }
+ return "NONE";
+ })();
return {
actionTaken,
emailSent,
diff --git a/worker/src/features/batchAction/processAddObservationsToDataset.ts b/worker/src/features/batchAction/processAddObservationsToDataset.ts
index b4d1aea4cb..a24d7b86f0 100644
--- a/worker/src/features/batchAction/processAddObservationsToDataset.ts
+++ b/worker/src/features/batchAction/processAddObservationsToDataset.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { logger, traceException } from "@langfuse/shared/src/server";
import { prisma } from "@langfuse/shared/src/db";
import { createManyDatasetItems } from "@langfuse/shared/src/server";
@@ -187,12 +186,15 @@ export async function processAddObservationsToDataset(params: {
}
// Determine final status
- const finalStatus =
- failed === 0
- ? BatchActionStatus.Completed
- : processed === 0
- ? BatchActionStatus.Failed
- : BatchActionStatus.Partial;
+ const finalStatus = (() => {
+ if (failed === 0) {
+ return BatchActionStatus.Completed;
+ }
+ if (processed === 0) {
+ return BatchActionStatus.Failed;
+ }
+ return BatchActionStatus.Partial;
+ })();
// Aggregate error summary
const errorSummary =
diff --git a/worker/src/features/batchAction/processBatchedObservationEval.ts b/worker/src/features/batchAction/processBatchedObservationEval.ts
index 50097b1e5d..91cd3e9928 100644
--- a/worker/src/features/batchAction/processBatchedObservationEval.ts
+++ b/worker/src/features/batchAction/processBatchedObservationEval.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import pLimit from "p-limit";
import { prisma } from "@langfuse/shared/src/db";
import { BatchActionStatus, observationForEvalSchema } from "@langfuse/shared";
@@ -112,12 +111,15 @@ export async function processBatchedObservationEval(params: {
await processBatch(buffer);
}
- const finalStatus =
- failedCount === 0
- ? BatchActionStatus.Completed
- : processedCount === 0
- ? BatchActionStatus.Failed
- : BatchActionStatus.Partial;
+ const finalStatus = (() => {
+ if (failedCount === 0) {
+ return BatchActionStatus.Completed;
+ }
+ if (processedCount === 0) {
+ return BatchActionStatus.Failed;
+ }
+ return BatchActionStatus.Partial;
+ })();
const errorSummary =
errors.length > 0
diff --git a/worker/src/features/blobstorage/handleBlobStorageIntegrationProjectJob.ts b/worker/src/features/blobstorage/handleBlobStorageIntegrationProjectJob.ts
index 5af4b290ac..c000b1faf4 100644
--- a/worker/src/features/blobstorage/handleBlobStorageIntegrationProjectJob.ts
+++ b/worker/src/features/blobstorage/handleBlobStorageIntegrationProjectJob.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { pipeline, Transform, type Readable } from "stream";
import { monitorEventLoopDelay } from "perf_hooks";
import { Job, UnrecoverableError } from "bullmq";
@@ -502,25 +501,37 @@ const processBlobStorageExport = async (config: {
(config.table === "observations" ||
config.table === "observations_v2");
- const exportPath = parquetEligible
- ? "parquet"
- : passthroughEligible
- ? "passthrough"
- : "standard";
+ const exportPath = (() => {
+ if (parquetEligible) {
+ return "parquet";
+ }
+ if (passthroughEligible) {
+ return "passthrough";
+ }
+ return "standard";
+ })();
const timestamp = formatBlobExportTimestamp(config.maxTimestamp);
// Parquet: fixed `.parquet` extension (no `.gz`) and Parquet content type.
- const extension = parquetEligible
- ? "parquet"
- : config.compressed
- ? `${blobStorageProps.extension}.gz`
- : blobStorageProps.extension;
+ const extension = (() => {
+ if (parquetEligible) {
+ return "parquet";
+ }
+ if (config.compressed) {
+ return `${blobStorageProps.extension}.gz`;
+ }
+ return blobStorageProps.extension;
+ })();
const filePath = `${config.prefix ?? ""}${config.projectId}/${config.table}/${timestamp}.${extension}`;
- const uploadContentType = parquetEligible
- ? "application/vnd.apache.parquet"
- : config.compressed
- ? "application/gzip"
- : blobStorageProps.contentType;
+ const uploadContentType = (() => {
+ if (parquetEligible) {
+ return "application/vnd.apache.parquet";
+ }
+ if (config.compressed) {
+ return "application/gzip";
+ }
+ return blobStorageProps.contentType;
+ })();
const exportFieldGroups =
config.exportFieldGroups && config.exportFieldGroups.length > 0
@@ -880,11 +891,15 @@ const processBlobStorageExport = async (config: {
)
: 0;
// Measured backpressure (gzip / parquet boundary), else duration residual.
- const uploadWaitMs = gzipStats
- ? Math.round(gzipStats.backpressureMs)
- : parquetEligible
- ? Math.round(sourceStats.backpressureMs)
- : Math.max(0, uploadDurationMs - chReadMs - enrichMs);
+ const uploadWaitMs = (() => {
+ if (gzipStats) {
+ return Math.round(gzipStats.backpressureMs);
+ }
+ if (parquetEligible) {
+ return Math.round(sourceStats.backpressureMs);
+ }
+ return Math.max(0, uploadDurationMs - chReadMs - enrichMs);
+ })();
logger.info(
`[BLOB INTEGRATION] Successfully exported ${config.table} for project ${config.projectId}: ` +
@@ -940,11 +955,15 @@ const processBlobStorageExport = async (config: {
Math.round(gzipStats.activeMs - gzipStats.backpressureMs),
)
: 0;
- const finalUploadWaitMs = gzipStats
- ? Math.round(gzipStats.backpressureMs)
- : parquetEligible
- ? Math.round(sourceStats.backpressureMs)
- : Math.max(0, totalUploadMs - finalChReadMs - finalEnrichMs);
+ const finalUploadWaitMs = (() => {
+ if (gzipStats) {
+ return Math.round(gzipStats.backpressureMs);
+ }
+ if (parquetEligible) {
+ return Math.round(sourceStats.backpressureMs);
+ }
+ return Math.max(0, totalUploadMs - finalChReadMs - finalEnrichMs);
+ })();
span.setAttribute("blob.gzipCpuMs", finalGzipCpuMs);
span.setAttribute("blob.uploadWaitMs", finalUploadWaitMs);
const finalExportFormat = parquetEligible
@@ -1891,12 +1910,15 @@ function extractStorageErrorMessage(error: unknown): string {
const errorDetails = (error as unknown as { Details?: unknown }).Details;
const causeDetails = (cause as unknown as { Details?: unknown } | undefined)
?.Details;
- const details =
- typeof errorDetails === "string"
- ? errorDetails
- : typeof causeDetails === "string"
- ? causeDetails
- : undefined;
+ const details = (() => {
+ if (typeof errorDetails === "string") {
+ return errorDetails;
+ }
+ if (typeof causeDetails === "string") {
+ return causeDetails;
+ }
+ return undefined;
+ })();
const full = details ? `${message} Details: ${details}` : message;
return full.slice(0, 1000);
diff --git a/worker/src/features/in-app-agent/runtime/mcpRateLimitWait.ts b/worker/src/features/in-app-agent/runtime/mcpRateLimitWait.ts
index 5fdd1e924c..9209a589e0 100644
--- a/worker/src/features/in-app-agent/runtime/mcpRateLimitWait.ts
+++ b/worker/src/features/in-app-agent/runtime/mcpRateLimitWait.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { InAppAgentRateLimitErrorResponseSchema } from "@langfuse/shared/in-app-agent";
import { logger, recordIncrement } from "@langfuse/shared/src/server";
@@ -20,12 +19,15 @@ export function parseMcpRateLimitError(
return { retryAfterSeconds: parsed.data.details.retryAfterSeconds };
}
- const message =
- typeof error === "string"
- ? error
- : error instanceof Error
- ? error.message
- : null;
+ const message = (() => {
+ if (typeof error === "string") {
+ return error;
+ }
+ if (error instanceof Error) {
+ return error.message;
+ }
+ return null;
+ })();
return message === null ? null : parseEmbeddedRateLimitError(message);
}
diff --git a/worker/src/features/in-app-agent/runtime/sandbox/providers/lambdaMicrovm.ts b/worker/src/features/in-app-agent/runtime/sandbox/providers/lambdaMicrovm.ts
index 0b52bbdc8f..1fff084fa0 100644
--- a/worker/src/features/in-app-agent/runtime/sandbox/providers/lambdaMicrovm.ts
+++ b/worker/src/features/in-app-agent/runtime/sandbox/providers/lambdaMicrovm.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { randomUUID } from "crypto";
import {
@@ -373,11 +372,15 @@ export function createLambdaMicrovmSandboxProvider(params: {
return {
async probeSession({ sessionId }) {
const existing = await getMicrovm(client, sessionId);
- const lostReason = !existing
- ? "not_found"
- : isTerminalMicrovmState(existing.state)
- ? "terminal_state"
- : null;
+ const lostReason = (() => {
+ if (!existing) {
+ return "not_found";
+ }
+ if (isTerminalMicrovmState(existing.state)) {
+ return "terminal_state";
+ }
+ return null;
+ })();
logger.debug("[Lambda MicroVM Sandbox] probed session", {
sessionId,
state: existing?.state,
diff --git a/worker/src/features/traceBatching/traceBatching.ts b/worker/src/features/traceBatching/traceBatching.ts
index fcf6a9ef31..a048f72d41 100644
--- a/worker/src/features/traceBatching/traceBatching.ts
+++ b/worker/src/features/traceBatching/traceBatching.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { createHash, randomUUID } from "node:crypto";
import { xxh32 } from "@node-rs/xxhash";
import {
@@ -40,8 +39,15 @@ export type PendingTrace = {
const compareNumbers = (left: number, right: number) => left - right;
-const compareStrings = (left: string, right: string) =>
- left < right ? -1 : left > right ? 1 : 0;
+const compareStrings = (left: string, right: string) => {
+ if (left < right) {
+ return -1;
+ }
+ if (left > right) {
+ return 1;
+ }
+ return 0;
+};
const toMinuteBucket = (timestamp: number) => Math.floor(timestamp / MINUTE_MS);
@@ -771,9 +777,15 @@ export class TraceBatchDispatcher extends PeriodicExclusiveRunner {
projectId: (JSON.parse(member) as [string, string])[0],
}));
// Stable sorting keeps Redis readiness order within each project.
- members.sort((a, b) =>
- a.projectId < b.projectId ? -1 : a.projectId > b.projectId ? 1 : 0,
- );
+ members.sort((a, b) => {
+ if (a.projectId < b.projectId) {
+ return -1;
+ }
+ if (a.projectId > b.projectId) {
+ return 1;
+ }
+ return 0;
+ });
recordDistribution("langfuse.trace_batch.snapshot_size", members.length);
const enqueue = async (batch: PendingTrace[]) => {
@@ -800,12 +812,15 @@ export class TraceBatchDispatcher extends PeriodicExclusiveRunner {
"langfuse.trace_batch.project_count",
new Set(traces.map((trace) => trace.projectId)).size,
);
- const fill =
- batch.length === 1
- ? "singleton"
- : batch.length === env.LANGFUSE_TRACE_BATCH_MAX_SIZE
- ? "full"
- : "partial";
+ const fill = (() => {
+ if (batch.length === 1) {
+ return "singleton";
+ }
+ if (batch.length === env.LANGFUSE_TRACE_BATCH_MAX_SIZE) {
+ return "full";
+ }
+ return "partial";
+ })();
recordIncrement("langfuse.trace_batch.dispatched_batches", 1, {
strategy,
fill,
diff --git a/worker/src/queues/coreDataS3ExportQueue.ts b/worker/src/queues/coreDataS3ExportQueue.ts
index 6a83c652a6..6ba3ce4963 100644
--- a/worker/src/queues/coreDataS3ExportQueue.ts
+++ b/worker/src/queues/coreDataS3ExportQueue.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { Processor } from "bullmq";
import { Readable } from "node:stream";
import pLimit from "p-limit";
@@ -103,12 +102,15 @@ const KNOWN_WIDGET_DIMENSIONS = new Set(
const KNOWN_WIDGET_AGGREGATIONS = new Set<string>(metricAggregations.options);
const INVALID_SENTINEL = "__invalid__";
-const allowlisted = (value: unknown, allowlist: Set<string>): string | null =>
- value == null
- ? null
- : typeof value === "string" && allowlist.has(value)
- ? value
- : INVALID_SENTINEL;
+const allowlisted = (value: unknown, allowlist: Set<string>): string | null => {
+ if (value == null) {
+ return null;
+ }
+ if (typeof value === "string" && allowlist.has(value)) {
+ return value;
+ }
+ return INVALID_SENTINEL;
+};
type DashboardWidgetCoreDataInput = {
dimensions: unknown;
diff --git a/worker/src/queues/traceBatchQueue.ts b/worker/src/queues/traceBatchQueue.ts
index bfce12fc30..afbc03e92a 100644
--- a/worker/src/queues/traceBatchQueue.ts
+++ b/worker/src/queues/traceBatchQueue.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
import { type Processor } from "bullmq";
import { randomUUID } from "node:crypto";
import { type Observation } from "@langfuse/shared";
@@ -55,11 +54,15 @@ export const traceBatchQueueProcessor: Processor<
"langfuse.trace_batch.job_id": job.id,
"langfuse.trace_batch.attempt": job.attemptsMade + 1,
});
- const disabledReason = !env.NEXT_PUBLIC_LANGFUSE_CLOUD_REGION
- ? "not_cloud"
- : env.LANGFUSE_TRACE_BATCH_READ_ENABLED !== "true"
- ? "reads_disabled"
- : undefined;
+ const disabledReason = (() => {
+ if (!env.NEXT_PUBLIC_LANGFUSE_CLOUD_REGION) {
+ return "not_cloud";
+ }
+ if (env.LANGFUSE_TRACE_BATCH_READ_ENABLED !== "true") {
+ return "reads_disabled";
+ }
+ return undefined;
+ })();
if (disabledReason) {
outcome = "discard";
// BullMQ reads these options after the processor returns, then removes atomically.