Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(sessions): Clear filters from empty timeline (#17414)

Ben Bachem173cdea03277
diff --git a/web/src/features/sessions/ConnectedModernSessionBodyTimeline.tsx b/web/src/features/sessions/ConnectedModernSessionBodyTimeline.tsx
index d8c1fc6b9e..c9cce8bfb2 100644
--- a/web/src/features/sessions/ConnectedModernSessionBodyTimeline.tsx
+++ b/web/src/features/sessions/ConnectedModernSessionBodyTimeline.tsx
@@ -447,6 +447,7 @@ export function ConnectedModernSessionBodyTimeline({
openPeek={openPeek}
controller={timelineController}
scrollTarget={scrollTarget}
+ onClearFilters={sidebarFilterControls.onClearFilters}
onFilterObservationByName={onFilterObservationByName}
onLoadMoreObservations={
hasMoreObservations && !isLoadingMoreObservations
diff --git a/web/src/features/sessions/SessionConversationTimeline/ConnectedSessionConversationTimeline.tsx b/web/src/features/sessions/SessionConversationTimeline/ConnectedSessionConversationTimeline.tsx
index 893dbdc274..40dd2a03f0 100644
--- a/web/src/features/sessions/SessionConversationTimeline/ConnectedSessionConversationTimeline.tsx
+++ b/web/src/features/sessions/SessionConversationTimeline/ConnectedSessionConversationTimeline.tsx
@@ -43,6 +43,7 @@ export function ConnectedSessionConversationTimeline({
openPeek,
controller,
scrollTarget,
+ onClearFilters,
onFilterObservationByName,
onLoadMoreObservations,
}: {
@@ -58,6 +59,7 @@ export function ConnectedSessionConversationTimeline({
) => void;
controller: SessionConversationTimelineController;
scrollTarget: SessionConversationTimelineScrollTarget | null;
+ onClearFilters: () => void;
onFilterObservationByName: (
name: string,
operator: "any of" | "none of",
@@ -196,12 +198,14 @@ export function ConnectedSessionConversationTimeline({
})),
[hydratedObservationGroups, traces],
);
- const emptyMessage =
+ const emptyState =
filterState.length === 0
- ? "This trace has no observations."
- : viewLabel
- ? `No observation matches the “${viewLabel}” view in this trace.`
- : "No observation matches the current filters in this trace.";
+ ? ({ type: "empty" } as const)
+ : ({
+ type: "filtered-empty",
+ viewLabel,
+ onClearFilters,
+ } as const);
return (
<AnnotateDrawerController projectId={projectId}>
@@ -215,7 +219,7 @@ export function ConnectedSessionConversationTimeline({
<SessionConversationTimeline
traces={timelineTraces}
filterMeasurementKey={filterMeasurementKey}
- emptyMessage={emptyMessage}
+ emptyState={emptyState}
onOpenTrace={(trace) => openPeek(trace.id, trace)}
onOpenObservation={(trace, observationId) =>
openPeek(trace.id, { ...trace, observationId })
diff --git a/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.stories.tsx b/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.stories.tsx
index ce58f2a484..80cacb86ad 100644
--- a/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.stories.tsx
+++ b/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.stories.tsx
@@ -1810,7 +1810,7 @@ const observationActions = {
const loadedArgs = {
traces: [{ trace, turnNumber: 1, observations }],
filterMeasurementKey: "default",
- emptyMessage: "This trace has no observations.",
+ emptyState: { type: "empty" },
onOpenTrace: fn(),
onOpenObservation: fn(),
observationActions,
@@ -2040,11 +2040,23 @@ export const Empty = meta.story({
});
export const FilteredEmpty = meta.story({
+ name: "(Test) Filtered Empty",
args: {
...loadedArgs,
traces: [{ trace, turnNumber: 1, observations: [] }],
- emptyMessage:
- "No observation matches the “Generations” view in this trace.",
+ emptyState: {
+ type: "filtered-empty",
+ viewLabel: "Generations",
+ onClearFilters: fn(),
+ },
+ },
+ play: async ({ args, canvasElement }) => {
+ const canvas = within(canvasElement);
+ await userEvent.click(
+ canvas.getByRole("button", { name: "Clear filters" }),
+ );
+ if (args.emptyState.type !== "filtered-empty") throw new globalThis.Error();
+ await expect(args.emptyState.onClearFilters).toHaveBeenCalledOnce();
},
});
diff --git a/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.tsx b/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.tsx
index c9dc15fe72..6711007321 100644
--- a/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.tsx
+++ b/web/src/features/sessions/SessionConversationTimeline/SessionConversationTimeline.tsx
@@ -141,7 +141,7 @@ export type SessionConversationTimelineController = ReturnType<
export function SessionConversationTimeline({
traces,
filterMeasurementKey,
- emptyMessage,
+ emptyState,
onOpenTrace,
onOpenObservation,
controller,
@@ -151,7 +151,13 @@ export function SessionConversationTimeline({
}: {
traces: readonly SessionConversationTimelineItem[];
filterMeasurementKey: string;
- emptyMessage: string;
+ emptyState:
+ | { type: "empty" }
+ | {
+ type: "filtered-empty";
+ viewLabel: string | null;
+ onClearFilters: () => void;
+ };
onOpenTrace: (trace: EventSessionTrace) => void;
onOpenObservation: (trace: EventSessionTrace, observationId: string) => void;
controller: SessionConversationTimelineController;
@@ -196,9 +202,7 @@ export function SessionConversationTimeline({
): PreparedSessionConversationTimelineTraceState => {
if (observations === undefined) return { type: "loading" };
if (observations === null) return { type: "error" };
- if (observations.length === 0) {
- return { type: "empty", message: emptyMessage };
- }
+ if (observations.length === 0) return emptyState;
return {
type: "loaded",
@@ -207,7 +211,7 @@ export function SessionConversationTimeline({
},
),
};
- }, [emptyMessage, observationFingerprint, traces]);
+ }, [emptyState, observationFingerprint, traces]);
return (
<SessionConversationTimelineFeed
diff --git a/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.clienttest.tsx b/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.clienttest.tsx
index 5c9f451ed0..33c7cb9e21 100644
--- a/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.clienttest.tsx
+++ b/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.clienttest.tsx
@@ -52,6 +52,29 @@ const trace = {
} satisfies TraceProps["trace"];
describe("SessionConversationTimelineTrace", () => {
+ it("clears filters from a filtered empty state", () => {
+ const onClearFilters = vi.fn();
+
+ render(
+ <SessionConversationTimelineTrace
+ trace={trace}
+ turnNumber={1}
+ state={{
+ type: "filtered-empty",
+ viewLabel: null,
+ onClearFilters,
+ }}
+ onOpenTrace={vi.fn()}
+ onOpenObservation={vi.fn()}
+ scrollTarget={null}
+ />,
+ );
+
+ fireEvent.click(screen.getByRole("button", { name: "Clear filters" }));
+
+ expect(onClearFilters).toHaveBeenCalledOnce();
+ });
+
it("expands every parent when an observation scroll is requested", async () => {
const props = {
trace,
diff --git a/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsx b/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsx
index 926b41c29b..890b277c16 100644
--- a/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsx
+++ b/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsx
@@ -53,7 +53,12 @@ export type SessionObservation = Omit<
type SessionConversationTimelineTraceState =
| { type: "loading" }
| { type: "error" }
- | { type: "empty"; message: string }
+ | { type: "empty" }
+ | {
+ type: "filtered-empty";
+ viewLabel: string | null;
+ onClearFilters: () => void;
+ }
| {
type: "loaded";
observations: readonly SessionObservation[];
@@ -1095,9 +1100,26 @@ export function SessionConversationTimelineTrace({
<div className="border-destructive/40 bg-destructive/5 text-foreground rounded-lg border p-4 text-xs">
Failed to load observations.
</div>
- ) : state.type === "empty" ? (
- <div className="text-muted-foreground rounded-lg border border-dashed p-4 text-xs">
- {state.message}
+ ) : state.type === "empty" || state.type === "filtered-empty" ? (
+ <div className="text-muted-foreground flex items-center justify-between gap-4 rounded-lg border border-dashed p-4 text-xs">
+ <span>
+ {state.type === "empty"
+ ? "This trace has no observations."
+ : state.viewLabel
+ ? `No observation matches the “${state.viewLabel}” view in this trace.`
+ : "No observation matches the current filters in this trace."}
+ </span>
+ {state.type === "filtered-empty" ? (
+ <Button
+ type="button"
+ variant="outline"
+ size="sm"
+ className="shrink-0"
+ onClick={state.onClearFilters}
+ >
+ Clear filters
+ </Button>
+ ) : null}
</div>
) : (
<LoadedSessionConversationTimeline