Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(web): session header metadata tooltip and overflow badge gap (#18623)

Trang Nguyen190c09a6a16f
diff --git a/web/src/components/SingleLineOverflowList.tsx b/web/src/components/SingleLineOverflowList.tsx
index f86404d0da..ce84b382d8 100644
--- a/web/src/components/SingleLineOverflowList.tsx
+++ b/web/src/components/SingleLineOverflowList.tsx
@@ -18,6 +18,8 @@ import { type ReactNode, useEffect, useRef, useState } from "react";
// Rows of boxed pills read fine at gap-2; rows of mostly-plain text (the
// session header's metrics/attributes/links) need more air to scan as
// separate facts, matching the trace headers' gap-4; bordered chips pull to 4px.
+/** Matches `-ml-3`, the pull applied to tight items and the overflow control. */
+const TIGHT_PULL_PX = 12;
const SPACING_CLASS = {
compact: "gap-2",
comfortable: "gap-4",
@@ -81,18 +83,31 @@ export function SingleLineOverflowList<TItem>({
const hasOverflow =
additionalOverflowCount > 0 ||
contentWidth > availableWidthBeforeOverflow - 1;
- const availableWidth = hasOverflow
- ? availableWidthBeforeOverflow -
- (overflowRef.current?.offsetWidth ?? 0) -
- normalizedGap
- : availableWidthBeforeOverflow;
- const nextHiddenKeys = itemElements.flatMap((element) => {
- const key = element.dataset.overflowItemKey;
- return key &&
- element.offsetLeft + element.offsetWidth > availableWidth - 1
- ? [key]
- : [];
- });
+ const overflowWidth = overflowRef.current?.offsetWidth ?? 0;
+ // The overflow control pulls in after a tight item, so it needs less room.
+ const availableWidthFor = (element: HTMLElement) =>
+ hasOverflow
+ ? availableWidthBeforeOverflow -
+ overflowWidth -
+ Math.max(
+ 0,
+ element.dataset.tight
+ ? normalizedGap - TIGHT_PULL_PX
+ : normalizedGap,
+ )
+ : availableWidthBeforeOverflow;
+ const firstHiddenIndex = itemElements.findIndex(
+ (element) =>
+ element.offsetLeft + element.offsetWidth >
+ availableWidthFor(element) - 1,
+ );
+ const nextHiddenKeys =
+ firstHiddenIndex === -1
+ ? []
+ : itemElements.slice(firstHiddenIndex).flatMap((element) => {
+ const key = element.dataset.overflowItemKey;
+ return key ? [key] : [];
+ });
setHiddenKeys((current) =>
current.length === nextHiddenKeys.length &&
@@ -125,6 +140,8 @@ export function SingleLineOverflowList<TItem>({
overflowItemCount,
]);
+ const lastVisibleItem = visibleItems.at(-1);
+
return (
<div
className={`relative flex min-w-0 flex-1 items-center overflow-hidden ${gapClass}`}
@@ -174,7 +191,15 @@ export function SingleLineOverflowList<TItem>({
</div>
) : null}
{overflowItemCount > 0 ? (
- <div ref={overflowRef} className="flex shrink-0 items-center">
+ <div
+ ref={overflowRef}
+ className={cn(
+ "flex shrink-0 items-center",
+ lastVisibleItem !== undefined &&
+ isTightItem?.(lastVisibleItem) &&
+ "-ml-3",
+ )}
+ >
{renderOverflow({ hiddenItems, overflowItemCount })}
</div>
) : null}
diff --git a/web/src/features/sessions/ModernSessionHeader.stories.tsx b/web/src/features/sessions/ModernSessionHeader.stories.tsx
index 4adf5b0b91..d7545a71bb 100644
--- a/web/src/features/sessions/ModernSessionHeader.stories.tsx
+++ b/web/src/features/sessions/ModernSessionHeader.stories.tsx
@@ -162,7 +162,7 @@ export const TestSearchesHiddenPills = meta.story({
),
).toBeLessThanOrEqual(0.5);
const trailingButton = canvas.getByRole("button", {
- name: "Add metadata JSONPath",
+ name: "Edit Metadata",
});
const trailingGap =
trailingButton.getBoundingClientRect().left -
@@ -272,9 +272,7 @@ export const TestConfiguresMultipleMetadataPaths = meta.story({
const canvas = within(canvasElement);
const body = within(canvasElement.ownerDocument.body);
const openEditor = () =>
- userEvent.click(
- canvas.getByRole("button", { name: "Add metadata JSONPath" }),
- );
+ userEvent.click(canvas.getByRole("button", { name: "Edit Metadata" }));
await openEditor();
let input = body.getByLabelText("Metadata JSONPath");
diff --git a/web/src/features/sessions/ModernSessionHeader.tsx b/web/src/features/sessions/ModernSessionHeader.tsx
index 206ccc4384..a956d6ffa3 100644
--- a/web/src/features/sessions/ModernSessionHeader.tsx
+++ b/web/src/features/sessions/ModernSessionHeader.tsx
@@ -26,6 +26,7 @@ import {
} from "@/src/features/sessions/sessionUsers";
import { Input } from "@/src/components/ui/input";
import { Button } from "@/src/components/ui/button";
+import { Tooltip } from "@/src/components/design-system/Tooltip/Tooltip";
import { Label } from "@/src/components/ui/label";
import {
Popover,
@@ -446,17 +447,22 @@ export function ModernSessionHeader({
open={isMetadataEditorOpen}
onOpenChange={handleMetadataEditorOpenChange}
>
- <PopoverTrigger asChild>
- <Button
- type="button"
- variant="ghost"
- size="icon-xs"
- aria-label="Add metadata JSONPath"
- data-session-header-pill="true"
- >
- <Plus className="icon-base" />
- </Button>
- </PopoverTrigger>
+ <Tooltip label="Edit Metadata" placement="bottom">
+ {({ getTriggerProps }) => (
+ <PopoverTrigger asChild>
+ <Button
+ {...getTriggerProps()}
+ type="button"
+ variant="ghost"
+ size="icon-xs"
+ aria-label="Edit Metadata"
+ data-session-header-pill="true"
+ >
+ <Plus className="icon-base" />
+ </Button>
+ </PopoverTrigger>
+ )}
+ </Tooltip>
{isMetadataEditorOpen ? (
<MetadataJsonPathEditorContent
metadataJsonPaths={metadataJsonPaths}