🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(public-api): send X-RateLimit-Reset as epoch seconds (#18573)
Niklas Semmler1aa14c35ff71
diff --git a/web/src/__tests__/server/rate-limit.servertest.ts b/web/src/__tests__/server/rate-limit.servertest.tsindex 7fa34281f4..24b637f5a1 100644--- a/web/src/__tests__/server/rate-limit.servertest.ts+++ b/web/src/__tests__/server/rate-limit.servertest.ts@@ -84,7 +84,7 @@ describe("RateLimitService", () => {"Retry-After": 1,"X-RateLimit-Limit": 1000,"X-RateLimit-Remaining": 999,- "X-RateLimit-Reset": expect.any(String),+ "X-RateLimit-Reset": expect.any(Number),});});diff --git a/web/src/__tests__/server/unit/rate-limit-response.servertest.ts b/web/src/__tests__/server/unit/rate-limit-response.servertest.tsindex 5793c50a48..47349c0196 100644--- a/web/src/__tests__/server/unit/rate-limit-response.servertest.ts+++ b/web/src/__tests__/server/unit/rate-limit-response.servertest.ts@@ -149,6 +149,23 @@ describe("sendRateLimitResponse", () => {expect(mockSendStructuredPublicApiErrorResponse).toHaveBeenCalledTimes(1);});+ it("sends X-RateLimit-Reset as epoch seconds, rounded up", () => {+ vi.useFakeTimers();+ vi.setSystemTime(new Date("2026-01-01T00:00:00.400Z"));+ try {+ const res = createResponse();++ sendRateLimitResponse(res, rateLimitResult);++ // 00:00:00.400 + 2500ms = 00:00:02.900 -> next full second+ expect(res.getHeader("X-RateLimit-Reset")).toBe(+ Date.parse("2026-01-01T00:00:03.000Z") / 1000,+ );+ } finally {+ vi.useRealTimers();+ }+ });+it("returns upgrade guidance for stable responses with an upgrade path", () => {const res = createResponse();diff --git a/web/src/features/public-api/server/RateLimitService.ts b/web/src/features/public-api/server/RateLimitService.tsindex 58931f7185..6717d0d240 100644--- a/web/src/features/public-api/server/RateLimitService.ts+++ b/web/src/features/public-api/server/RateLimitService.ts@@ -228,7 +228,7 @@ export const createHttpHeaderFromRateLimit = (res: RateLimitResult) => {"Retry-After": Math.ceil(res.msBeforeNext / 1000),"X-RateLimit-Limit": res.points,"X-RateLimit-Remaining": res.remainingPoints,- "X-RateLimit-Reset": new Date(Date.now() + res.msBeforeNext).toString(),+ "X-RateLimit-Reset": Math.ceil((Date.now() + res.msBeforeNext) / 1000),};};