Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(web): remove the pulsing dot on the trace panel toggle (#17930)

Trang Nguyen21b2cecab51b
diff --git a/web/src/features/traces/components/TraceLayoutDesktop.tsx b/web/src/features/traces/components/TraceLayoutDesktop.tsx
index b135b6b0df..2e3363ebe5 100644
--- a/web/src/features/traces/components/TraceLayoutDesktop.tsx
+++ b/web/src/features/traces/components/TraceLayoutDesktop.tsx
@@ -145,7 +145,6 @@ interface TraceLayoutDesktopContext {
setIsNavigationPanelCollapsed: (collapsed: boolean) => void;
panelRef: React.RefObject<PanelImperativeHandle | null>;
handleTogglePanel: () => void;
- shouldPulseToggle: boolean;
// Detail (info/preview) panel — collapsible like the navigation panel.
detailPanelRef: React.RefObject<PanelImperativeHandle | null>;
isDetailPanelCollapsed: boolean;
@@ -219,10 +218,6 @@ function TraceNavigationDetailLayout({
reviewNavigationCollapsed: boolean;
toggleReviewNavigation: () => void;
}) {
- // Get current view mode from URL
- const [viewMode] = useQueryParam("view", StringParam);
- const isTimelineView = viewMode === "timeline";
-
// Peek sizing depends on the drawer width; persistence scope is caller-owned.
const { isPeekMode } = useViewPreferences();
@@ -539,21 +534,6 @@ function TraceNavigationDetailLayout({
}
};
- // Pulse animation: hint to user that panel can be collapsed when switching to timeline
- const [shouldPulseToggle, setShouldPulseToggle] = useState(false);
-
- useEffect(() => {
- if (isTimelineView) {
- setShouldPulseToggle(true);
- const timeout = setTimeout(() => {
- setShouldPulseToggle(false);
- }, 12000); // Stop pulse after 12 seconds
- return () => clearTimeout(timeout);
- }
- // Reset pulse when leaving timeline view
- setShouldPulseToggle(false);
- }, [isTimelineView]);
-
const contextValue: TraceLayoutDesktopContext = {
reviewOpen,
isNavigationPanelCollapsed: reviewOpen
@@ -562,7 +542,6 @@ function TraceNavigationDetailLayout({
setIsNavigationPanelCollapsed,
panelRef,
handleTogglePanel,
- shouldPulseToggle,
detailPanelRef,
isDetailPanelCollapsed: reviewOpen ? false : isDetailPanelCollapsed,
setIsDetailPanelCollapsed,
diff --git a/web/src/features/traces/components/TracePanelNavigationHeader/TracePanelNavigationHeader.tsx b/web/src/features/traces/components/TracePanelNavigationHeader/TracePanelNavigationHeader.tsx
index 6b79773f78..9e97dd166a 100644
--- a/web/src/features/traces/components/TracePanelNavigationHeader/TracePanelNavigationHeader.tsx
+++ b/web/src/features/traces/components/TracePanelNavigationHeader/TracePanelNavigationHeader.tsx
@@ -66,7 +66,6 @@ import { useElementSize } from "@/src/hooks/useElementSize";
interface TracePanelNavigationHeaderProps {
isPanelCollapsed: boolean;
onTogglePanel: () => void;
- shouldPulseToggle?: boolean;
}
export function TracePanelNavigationHeader(
@@ -81,14 +80,12 @@ export function TracePanelNavigationHeader(
function TracePanelNavigationHeaderCollapsed({
isPanelCollapsed,
onTogglePanel,
- shouldPulseToggle = false,
}: TracePanelNavigationHeaderProps) {
return (
<div className="flex w-full flex-row items-center justify-center p-2">
<TracePanelNavigationButton
isPanelCollapsed={isPanelCollapsed}
onTogglePanel={onTogglePanel}
- shouldPulseToggle={shouldPulseToggle}
/>
</div>
);
@@ -97,7 +94,6 @@ function TracePanelNavigationHeaderCollapsed({
function TracePanelNavigationHeaderExpanded({
isPanelCollapsed,
onTogglePanel,
- shouldPulseToggle = false,
}: TracePanelNavigationHeaderProps) {
const { searchInputValue, setSearchInputValue, setSearchQueryImmediate } =
useSearch();
@@ -277,7 +273,6 @@ function TracePanelNavigationHeaderExpanded({
<TracePanelNavigationButton
isPanelCollapsed={isPanelCollapsed}
onTogglePanel={onTogglePanel}
- shouldPulseToggle={shouldPulseToggle}
/>
</div>
)}
diff --git a/web/src/features/traces/components/TracePanelNavigationHeader/components/TracePanelNavigationButton.tsx b/web/src/features/traces/components/TracePanelNavigationHeader/components/TracePanelNavigationButton.tsx
index 7458b551d4..27f1014770 100644
--- a/web/src/features/traces/components/TracePanelNavigationHeader/components/TracePanelNavigationButton.tsx
+++ b/web/src/features/traces/components/TracePanelNavigationHeader/components/TracePanelNavigationButton.tsx
@@ -7,45 +7,33 @@ import { useTraceAnalyticsDimensions } from "@/src/features/traces/hooks/useTrac
interface TracePanelNavigationButtonProps {
isPanelCollapsed: boolean;
onTogglePanel: () => void;
- shouldPulseToggle?: boolean;
}
export function TracePanelNavigationButton({
isPanelCollapsed,
onTogglePanel,
- shouldPulseToggle = false,
}: TracePanelNavigationButtonProps) {
const capture = usePostHogClientCapture();
const analyticsDimensions = useTraceAnalyticsDimensions();
return (
- <div className="relative">
- <Button
- onClick={() => {
- onTogglePanel();
- capture("trace_detail:tree_panel_toggle", {
- collapsed: !isPanelCollapsed,
- ...analyticsDimensions,
- });
- }}
- variant="ghost"
- size="icon"
- title={isPanelCollapsed ? "Expand panel" : "Collapse panel"}
- className="h-7 w-7 shrink-0"
- >
- {isPanelCollapsed ? (
- <PanelLeftOpen className="h-3.5 w-3.5" />
- ) : (
- <PanelLeftClose className="h-3.5 w-3.5" />
- )}
- </Button>
-
- {/* Pulsing status indicator */}
- {shouldPulseToggle && (
- <span className="pointer-events-none absolute top-0.5 right-0.5 flex h-2.5 w-2.5">
- <span className="absolute inline-flex h-full w-full animate-ping rounded-full bg-blue-400 opacity-75" />
- <span className="relative inline-flex h-2.5 w-2.5 rounded-full bg-blue-500" />
- </span>
+ <Button
+ onClick={() => {
+ onTogglePanel();
+ capture("trace_detail:tree_panel_toggle", {
+ collapsed: !isPanelCollapsed,
+ ...analyticsDimensions,
+ });
+ }}
+ variant="ghost"
+ size="icon"
+ title={isPanelCollapsed ? "Expand panel" : "Collapse panel"}
+ className="h-7 w-7 shrink-0"
+ >
+ {isPanelCollapsed ? (
+ <PanelLeftOpen className="h-3.5 w-3.5" />
+ ) : (
+ <PanelLeftClose className="h-3.5 w-3.5" />
)}
- </div>
+ </Button>
);
}
diff --git a/web/src/features/traces/components/TracePanelNavigationLayoutDesktop/TracePanelNavigationLayoutDesktop.tsx b/web/src/features/traces/components/TracePanelNavigationLayoutDesktop/TracePanelNavigationLayoutDesktop.tsx
index e5930a1f43..d2686e500f 100644
--- a/web/src/features/traces/components/TracePanelNavigationLayoutDesktop/TracePanelNavigationLayoutDesktop.tsx
+++ b/web/src/features/traces/components/TracePanelNavigationLayoutDesktop/TracePanelNavigationLayoutDesktop.tsx
@@ -22,7 +22,7 @@ export function TracePanelNavigationLayoutDesktop({
}: {
children: ReactNode;
}) {
- const { isNavigationPanelCollapsed, handleTogglePanel, shouldPulseToggle } =
+ const { isNavigationPanelCollapsed, handleTogglePanel } =
useDesktopLayoutContext();
return (
@@ -30,7 +30,6 @@ export function TracePanelNavigationLayoutDesktop({
<TracePanelNavigationHeader
isPanelCollapsed={isNavigationPanelCollapsed}
onTogglePanel={handleTogglePanel}
- shouldPulseToggle={shouldPulseToggle}
/>
<div
className={cn(
diff --git a/web/src/features/traces/components/TraceReviewLayout.clienttest.tsx b/web/src/features/traces/components/TraceReviewLayout.clienttest.tsx
index a66429d9b1..6348701b76 100644
--- a/web/src/features/traces/components/TraceReviewLayout.clienttest.tsx
+++ b/web/src/features/traces/components/TraceReviewLayout.clienttest.tsx
@@ -15,7 +15,6 @@ const { navigationContext } = vi.hoisted(() => ({
navigationContext: {
isNavigationPanelCollapsed: false,
handleTogglePanel: vi.fn(),
- shouldPulseToggle: false,
},
}));