Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(scores): return every score per trace when the v4 scores table has a trace filter (#19065)

Niklas Semmler21e92407266a
diff --git a/packages/shared/src/server/repositories/scores.ts b/packages/shared/src/server/repositories/scores.ts
index 3f911cf45a..f9d669fa39 100644
--- a/packages/shared/src/server/repositories/scores.ts
+++ b/packages/shared/src/server/repositories/scores.ts
@@ -1633,10 +1633,13 @@ const getScoresUiGenericFromEvents = async <T>(props: {
// Inner join when trace filters are active (exclude scores without matching traces)
// Left join when only sorting (keep all scores)
+ // The traces CTE is unique per trace (LIMIT 1 BY), so the inner join cannot
+ // fan out. It must not be ANY: an inner ANY JOIN also dedups the left side,
+ // keeping only one score per trace.
const eventsJoin = (() => {
if (needsTracesCTE) {
if (traceFilterState.length > 0) {
- return `ANY JOIN traces e ON s.trace_id = e.id`;
+ return `INNER JOIN traces e ON s.trace_id = e.id`;
}
return `LEFT ANY JOIN traces e ON s.trace_id = e.id`;
}
diff --git a/web/src/__tests__/server/scores-trpc.servertest.ts b/web/src/__tests__/server/scores-trpc.servertest.ts
index 01a7f70742..78e50a2796 100644
--- a/web/src/__tests__/server/scores-trpc.servertest.ts
+++ b/web/src/__tests__/server/scores-trpc.servertest.ts
@@ -769,6 +769,55 @@ describe("scores trpc", () => {
expect(result.scores.map(({ id }) => id)).toContain(score.id);
});
+
+ it("returns every score of a trace, not one per trace", async () => {
+ const traceName = `multi-score-trace-${randomUUID()}`;
+ const traceIds = [randomUUID(), randomUUID()];
+ const scores = traceIds.flatMap((traceId) =>
+ ["a", "b", "c"].map((name) =>
+ createTraceScore({ project_id: projectId, trace_id: traceId, name }),
+ ),
+ );
+
+ await createEventsCh(
+ traceIds.map((traceId) =>
+ createEvent({
+ trace_id: traceId,
+ project_id: projectId,
+ parent_span_id: "",
+ name: traceName,
+ trace_name: traceName,
+ }),
+ ),
+ );
+ await createScoresCh(scores);
+
+ const payload = {
+ projectId,
+ filter: [
+ {
+ column: "traceName",
+ operator: "=" as const,
+ value: traceName,
+ type: "string" as const,
+ },
+ ],
+ page: 0,
+ limit: 50,
+ };
+ const [result, count] = await Promise.all([
+ caller.scores.allFromEvents({
+ ...payload,
+ orderBy: { column: "timestamp", order: "DESC" },
+ }),
+ caller.scores.countAllFromEvents({ ...payload, orderBy: null }),
+ ]);
+
+ expect(result.scores.map(({ id }) => id).sort()).toEqual(
+ scores.map(({ id }) => id).sort(),
+ );
+ expect(count.totalCount).toBe(scores.length);
+ });
});
describe("scores.createAnnotationScore", () => {