Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): one design-system Tabs with inset and underline variants (#18391)

Trang Nguyen2705316cb747
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index b082611bfe..604e6614da 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -951,7 +951,7 @@ importers:
'@storybook/addon-vitest':
specifier: 10.5.10
'@storybook/nextjs-vite':
specifier: 10.5.10
@@ -1032,7 +1032,7 @@ importers:
eslint-plugin-boundaries:
specifier: 7.2.0
eslint-plugin-check-file:
specifier: 3.3.2
@@ -7099,15 +7099,9 @@ packages:
'@vitest/[email protected]':
resolution: {integrity: sha512-IVNZik8IVRJRTr9fxlitMKeJeXFFFN0JaB9PHPGQ8NKQbGpfjlTx9zO4RefN8gp7eqjNy8nyK3NZmBzOPeIxtA==}
- '@vitest/[email protected]':
- resolution: {integrity: sha512-W1HsjSH4MXQ9YfmmhLAoIYf1HRfekQCGngeIgcei6MP5QQGWUe0gkopdZQaVCFO+JDJMrAJGwa5pRpNpvy4P8Q==}
-
'@vitest/[email protected]':
resolution: {integrity: sha512-yiZzPbGTS9Sr/JpFl8zHrcIkAofNbFV6k21vIgQN/cY/oxZeXhJv5sc/MBJ5jFKWmWs+oJHw0UXLZjmf931+Vw==}
- '@vitest/[email protected]':
- resolution: {integrity: sha512-IKI6kpIH+LmpROplyLwBBaCfMgOZOMsygVa6BARD6ahA04VRuJSa6OaVG7kRvSEMD870Vd91rSSw0eegtWyLGg==}
-
'@vitest/[email protected]':
resolution: {integrity: sha512-LztvUgdwMNJMIkj3hQnnxiC2Xy1zNxq928W/xhjCLaNCzqTZOudjwbQf6v9IntZGPw132i2Lq2rgTRZHD3JHNw==}
@@ -7123,9 +7117,6 @@ packages:
'@vitest/[email protected]':
resolution: {integrity: sha512-fB2V0JFrQSMsCo9HiSq3Ezpdv4iYaXRG1Sx8edX3MwxfyNn83mKiGzOcH+Fkxt4MHxr3y42fQi1oeAInqgX2QA==}
- '@vitest/[email protected]':
- resolution: {integrity: sha512-fy9am/HWxbaGt/Sawrp90vt6Y6jQwf1RX77cz3uwoJwJVMli/e1IEwRPnMNJ7vKfPTwo0diXifkpPvwH9v7nGA==}
-
'@vitest/[email protected]':
resolution: {integrity: sha512-zTCVGpyFsGWBhllOyKlTw/vnr6D9qxsfSDyfbyZmTyjHw5N/VuvzHpHoQjm2ZJzn4RJgx5w4r7V0er69CmLgPQ==}
@@ -13654,10 +13645,10 @@ snapshots:
'@blazediff/[email protected]': {}
dependencies:
eslint-import-resolver-node: 0.3.9([email protected])
handlebars: 4.7.9
is-core-module: 2.16.1
micromatch: 4.0.8
@@ -14168,7 +14159,7 @@ snapshots:
dependencies:
'@floating-ui/dom': 1.8.0
- '@floating-ui/utils': 0.2.12
+ '@floating-ui/utils': 0.2.10
transitivePeerDependencies:
- '@vue/composition-api'
@@ -17759,7 +17750,7 @@ snapshots:
- vite
- webpack
dependencies:
'@storybook/global': 5.0.0
'@storybook/icons': 2.1.0([email protected])
@@ -17767,7 +17758,7 @@ snapshots:
optionalDependencies:
- '@vitest/runner': 4.1.10
+ '@vitest/runner': 4.1.11
transitivePeerDependencies:
- react
@@ -18455,19 +18446,6 @@ snapshots:
transitivePeerDependencies:
- supports-color
- dependencies:
- '@typescript-eslint/scope-manager': 8.67.0
- '@typescript-eslint/types': 8.67.0
- '@typescript-eslint/typescript-estree': 8.67.0([email protected])([email protected])
- '@typescript-eslint/visitor-keys': 8.67.0
- debug: 4.4.3([email protected])
- typescript: 7.0.2
- transitivePeerDependencies:
- - supports-color
- optional: true
-
'@typescript-eslint/[email protected](@typescript/[email protected])([email protected])':
dependencies:
'@typescript-eslint/tsconfig-utils': 8.67.0(@typescript/[email protected])
@@ -18901,21 +18879,10 @@ snapshots:
dependencies:
tinyrainbow: 2.0.0
- '@vitest/[email protected]':
- dependencies:
- tinyrainbow: 3.1.0
- optional: true
-
'@vitest/[email protected]':
dependencies:
tinyrainbow: 3.1.0
- '@vitest/[email protected]':
- dependencies:
- '@vitest/utils': 4.1.10
- pathe: 2.0.3
- optional: true
-
'@vitest/[email protected]':
dependencies:
'@vitest/utils': 4.1.11
@@ -18940,13 +18907,6 @@ snapshots:
loupe: 3.2.1
tinyrainbow: 2.0.0
- '@vitest/[email protected]':
- dependencies:
- '@vitest/pretty-format': 4.1.10
- convert-source-map: 2.0.0
- tinyrainbow: 3.1.0
- optional: true
-
'@vitest/[email protected]':
dependencies:
'@vitest/pretty-format': 4.1.11
@@ -19165,11 +19125,11 @@ snapshots:
dependencies:
- acorn: 8.18.0
+ acorn: 8.17.0
dependencies:
- acorn: 8.18.0
+ acorn: 8.17.0
@@ -20535,35 +20495,23 @@ snapshots:
transitivePeerDependencies:
- supports-color
dependencies:
debug: 3.2.7([email protected])
optionalDependencies:
- eslint-import-resolver-node: 0.3.10([email protected])
- transitivePeerDependencies:
- - supports-color
-
- dependencies:
- debug: 3.2.7([email protected])
- optionalDependencies:
eslint-import-resolver-node: 0.3.9([email protected])
transitivePeerDependencies:
- supports-color
dependencies:
chalk: 4.1.2
eslint-import-resolver-node: 0.3.9([email protected])
handlebars: 4.7.9
micromatch: 4.0.8
transitivePeerDependencies:
@@ -20607,35 +20555,6 @@ snapshots:
- eslint-import-resolver-webpack
- supports-color
- dependencies:
- '@rtsao/scc': 1.1.0
- array-includes: 3.1.9
- array.prototype.findlastindex: 1.2.6
- array.prototype.flat: 1.3.3
- array.prototype.flatmap: 1.3.3
- debug: 3.2.7([email protected])
- doctrine: 2.1.0
- eslint-import-resolver-node: 0.3.10([email protected])
- hasown: 2.0.4
- is-core-module: 2.16.2
- is-glob: 4.0.3
- minimatch: 3.1.5
- object.fromentries: 2.0.8
- object.groupby: 1.0.3
- object.values: 1.2.1
- semver: 6.3.1
- string.prototype.trimend: 1.0.9
- tsconfig-paths: 3.15.0
- optionalDependencies:
- transitivePeerDependencies:
- - eslint-import-resolver-typescript
- - eslint-import-resolver-webpack
- - supports-color
-
dependencies:
aria-query: 5.3.2
diff --git a/web/.structure-baseline.json b/web/.structure-baseline.json
index 836c0acf3d..fe44f83ad0 100644
--- a/web/.structure-baseline.json
+++ b/web/.structure-baseline.json
@@ -1850,7 +1850,6 @@
"src/components/ui/splash-screen.tsx",
"src/components/ui/StatusBadge/StatusBadge.tsx",
"src/components/ui/table.tsx",
- "src/components/ui/tabs-bar.tsx",
"src/components/ui/textarea.tsx",
"src/components/ui/time-icon.tsx",
"src/components/ui/time-period-select.tsx",
diff --git a/web/src/components/design-system/Tabs/Tabs.stories.tsx b/web/src/components/design-system/Tabs/Tabs.stories.tsx
index dd334badef..1b2e6d2bc1 100644
--- a/web/src/components/design-system/Tabs/Tabs.stories.tsx
+++ b/web/src/components/design-system/Tabs/Tabs.stories.tsx
@@ -5,31 +5,13 @@ import { expect, userEvent, waitFor, within } from "storybook/test";
import preview from "../../../../.storybook/preview";
import { Tabs } from "./Tabs";
-type ListVariant = NonNullable<
- React.ComponentProps<typeof Tabs.List>["variant"]
->;
-type ListSize = NonNullable<React.ComponentProps<typeof Tabs.List>["size"]>;
-
const meta = preview.meta({
component: Tabs,
});
-const listVariants = Object.keys({
- default: true,
- underline: true,
- outline: true,
-} satisfies Record<ListVariant, true>) as ListVariant[];
-
-const listSizes = Object.keys({
- default: true,
- md: true,
- sm: true,
- auto: true,
-} satisfies Record<ListSize, true>) as ListSize[];
-
const defaultChildren = (
<>
- <Tabs.List>
+ <Tabs.List variant="inset" size="md">
<Tabs.Trigger value="account" label="Account" />
<Tabs.Trigger value="password" label="Password" />
</Tabs.List>
@@ -40,7 +22,7 @@ const defaultChildren = (
const fullWidthChildren = (
<>
- <Tabs.List layout="full">
+ <Tabs.List variant="inset" size="md" layout="full">
<span className="flex-1">
<Tabs.Trigger value="first" label="First" />
</span>
@@ -53,6 +35,17 @@ const fullWidthChildren = (
</>
);
+const underlineChildren = (
+ <>
+ <Tabs.List variant="underline">
+ <Tabs.Trigger value="first" label="First" />
+ <Tabs.Trigger value="second" label="Second" />
+ </Tabs.List>
+ <Tabs.Content value="first">First panel</Tabs.Content>
+ <Tabs.Content value="second">Second panel</Tabs.Content>
+ </>
+);
+
function ResizableSlidingTabs() {
const [expanded, setExpanded] = React.useState(false);
@@ -62,7 +55,7 @@ function ResizableSlidingTabs() {
Expand active tab
</button>
<Tabs defaultValue="first">
- <Tabs.List variant="outline">
+ <Tabs.List variant="inset" size="md">
<span className={expanded ? "w-40" : "w-20"}>
<Tabs.Trigger value="first" label="First" />
</span>
@@ -73,6 +66,16 @@ function ResizableSlidingTabs() {
);
}
+function LinkTabs() {
+ return (
+ <Tabs.List variant="underline" aria-label="Page sections">
+ <Tabs.Trigger href="/traces" active label="Traces" />
+ <Tabs.Trigger href="/observations" active={false} label="Observations" />
+ <Tabs.Trigger href="/sessions" active={false} disabled label="Sessions" />
+ </Tabs.List>
+ );
+}
+
export const Default = meta.story({
args: {
defaultValue: "account",
@@ -85,7 +88,7 @@ export const Disabled = meta.story({
defaultValue: "account",
children: (
<>
- <Tabs.List>
+ <Tabs.List variant="inset" size="md">
<Tabs.Trigger value="account" label="Account" />
<Tabs.Trigger value="password" disabled label="Password" />
</Tabs.List>
@@ -108,7 +111,7 @@ export const WithIcons = meta.story({
defaultValue: "account",
children: (
<>
- <Tabs.List>
+ <Tabs.List variant="inset" size="md">
<Tabs.Trigger value="account" icon={User} label="Account" />
<Tabs.Trigger value="password" icon={KeyRound} label="Password" />
</Tabs.List>
@@ -119,6 +122,23 @@ export const WithIcons = meta.story({
},
});
+export const Underline = meta.story({
+ args: {
+ defaultValue: "first",
+ children: underlineChildren,
+ },
+});
+
+/** Link tabs render outside a `Tabs` root: navigation, not a tablist. */
+export const Links = meta.story({
+ parameters: {
+ controls: {
+ disable: true,
+ },
+ },
+ render: () => <LinkTabs />,
+});
+
export const VariantMatrix = meta.story({
parameters: {
controls: {
@@ -127,31 +147,32 @@ export const VariantMatrix = meta.story({
},
render: () => (
<div className="grid gap-6">
- {listVariants.map((variant) =>
- listSizes.map((size) => (
- <div key={`${variant}-${size}`}>
- <div className="text-muted-foreground mb-2 text-sm">
- {variant} / {size}
- </div>
- <Tabs defaultValue="one">
- <Tabs.List variant={variant} size={size}>
- <Tabs.Trigger
- value="one"
- variant={variant === "underline" ? "underline" : "default"}
- size={size === "sm" ? "sm" : "default"}
- label="One"
- />
- <Tabs.Trigger
- value="two"
- variant={variant === "underline" ? "underline" : "default"}
- size={size === "sm" ? "sm" : "default"}
- label="Two"
- />
- </Tabs.List>
- </Tabs>
+ {(["sm", "md"] as const).map((size) => (
+ <div key={size}>
+ <div className="text-muted-foreground mb-2 text-sm">
+ inset / {size}
</div>
- )),
- )}
+ <Tabs defaultValue="one">
+ <Tabs.List variant="inset" size={size}>
+ <Tabs.Trigger value="one" label="One" />
+ <Tabs.Trigger value="two" label="Two" />
+ </Tabs.List>
+ </Tabs>
+ </div>
+ ))}
+ <div>
+ <div className="text-muted-foreground mb-2 text-sm">underline</div>
+ <Tabs defaultValue="one">
+ <Tabs.List variant="underline">
+ <Tabs.Trigger value="one" label="One" />
+ <Tabs.Trigger value="two" label="Two" />
+ </Tabs.List>
+ </Tabs>
+ </div>
+ <div>
+ <div className="text-muted-foreground mb-2 text-sm">links</div>
+ <LinkTabs />
+ </div>
</div>
),
});
@@ -222,7 +243,7 @@ export const KeepsUnwrappedTriggersContentWidth = meta.story({
args: {
defaultValue: "short",
children: (
- <Tabs.List variant="outline">
+ <Tabs.List variant="inset" size="md">
<Tabs.Trigger value="short" label="Python" />
<Tabs.Trigger value="long" label="TypeScript" />
</Tabs.List>
@@ -244,7 +265,7 @@ export const TruncatesLabel = meta.story({
args: {
defaultValue: "long",
children: (
- <Tabs.List>
+ <Tabs.List variant="inset" size="md">
<span className="w-20">
<Tabs.Trigger
value="long"
@@ -276,7 +297,7 @@ export const AlignsSlidingIndicatorInScaledContainer = meta.story({
args: {
defaultValue: "short",
children: (
- <Tabs.List variant="outline">
+ <Tabs.List variant="inset" size="md">
<Tabs.Trigger value="short" label="Python" />
<Tabs.Trigger value="long" label="TypeScript" />
</Tabs.List>
@@ -306,12 +327,7 @@ export const KeepsUnderlineStyle = meta.story({
name: "(Test) Keeps Underline Style",
args: {
defaultValue: "first",
- children: (
- <Tabs.List variant="underline">
- <Tabs.Trigger value="first" variant="underline" label="First" />
- <Tabs.Trigger value="second" variant="underline" label="Second" />
- </Tabs.List>
- ),
+ children: underlineChildren,
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
@@ -326,6 +342,27 @@ export const KeepsUnderlineStyle = meta.story({
},
});
+export const RendersLinksAsNavigation = meta.story({
+ name: "(Test) Renders Links As Navigation",
+ parameters: {
+ controls: {
+ disable: true,
+ },
+ },
+ render: () => <LinkTabs />,
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ const active = canvas.getByRole("link", { name: "Traces" });
+
+ await expect(active).toHaveAttribute("aria-current", "page");
+ await expect(
+ canvas.getByRole("link", { name: "Observations" }),
+ ).not.toHaveAttribute("aria-current");
+ await expect(canvas.queryByRole("tab")).not.toBeInTheDocument();
+ await expect(canvas.queryByRole("tablist")).not.toBeInTheDocument();
+ },
+});
+
export const TracksTriggerResize = meta.story({
name: "(Test) Tracks Trigger Resize",
render: () => <ResizableSlidingTabs />,
diff --git a/web/src/components/design-system/Tabs/Tabs.tsx b/web/src/components/design-system/Tabs/Tabs.tsx
index f1c1c7442c..17abe15bd2 100644
--- a/web/src/components/design-system/Tabs/Tabs.tsx
+++ b/web/src/components/design-system/Tabs/Tabs.tsx
@@ -2,30 +2,38 @@
import * as React from "react";
import * as TabsPrimitive from "@radix-ui/react-tabs";
-import { cva, type VariantProps } from "class-variance-authority";
+import { cva } from "class-variance-authority";
import { type LucideIcon } from "lucide-react";
+import Link, { type LinkProps } from "next/link";
import { cn } from "@/src/utils/tailwind";
+type TabsVariant = "inset" | "underline";
+type TabsInsetSize = "sm" | "md";
+/** `navigation` is the underline look for link tabs: the page header owns the divider. */
+type TabsLook = TabsVariant | "navigation";
+
+const rootFillClassName =
+ "flex h-full min-h-0 w-full flex-1 flex-col overflow-hidden";
+
const tabsListVariants = cva(
- "text-foreground-tertiary items-center justify-center [&>:not([role=tab])]:flex [&>:not([role=tab])>[role=tab]]:w-full",
+ "items-center [&>:not([role=tab])]:flex [&>:not([role=tab])>[role=tab]]:w-full",
{
variants: {
- variant: {
- default: "bg-control-track/60 dark:bg-muted rounded-md",
- underline: "rounded-none border-b bg-transparent",
- outline: "bg-background rounded-md border",
+ look: {
+ inset:
+ "bg-control-track/60 dark:bg-muted text-foreground-tertiary relative isolate justify-center rounded-md p-0.5",
+ underline: "h-9 shrink-0 justify-start border-b",
+ navigation: "h-9 shrink-0 justify-start",
},
size: {
- default: "",
- md: "",
sm: "",
- auto: "",
+ md: "",
},
layout: {
- default: "inline-flex",
+ default: "",
full: "grid w-full auto-cols-fr grid-flow-col",
- packed: "inline-flex",
+ packed: "",
},
gap: {
none: "",
@@ -34,22 +42,16 @@ const tabsListVariants = cva(
},
},
compoundVariants: [
- { variant: "default", size: "default", class: "h-8 p-0.5" },
- { variant: "default", size: "md", class: "h-7 p-0.5" },
- { variant: "default", size: "sm", class: "h-6 p-0.5" },
- { variant: "default", size: "auto", class: "h-auto p-0.5" },
- { variant: "outline", size: "default", class: "h-8 p-0.5" },
- { variant: "outline", size: "md", class: "h-7 p-0.5" },
- { variant: "outline", size: "sm", class: "h-6 p-0.5" },
- { variant: "outline", size: "auto", class: "h-auto p-0.5" },
- { variant: "underline", size: "default", class: "h-auto p-0" },
- { variant: "underline", size: "md", class: "h-auto p-0" },
- { variant: "underline", size: "sm", class: "h-auto p-0" },
- { variant: "underline", size: "auto", class: "h-auto p-0" },
+ { look: "inset", size: "sm", class: "h-6" },
+ { look: "inset", size: "md", class: "h-7" },
+ { look: "inset", layout: ["default", "packed"], class: "inline-flex" },
+ {
+ look: ["underline", "navigation"],
+ layout: ["default", "packed"],
+ class: "flex w-full",
+ },
],
defaultVariants: {
- variant: "default",
- size: "default",
layout: "default",
gap: "none",
},
@@ -57,44 +59,29 @@ const tabsListVariants = cva(
);
const tabsTriggerVariants = cva(
- "ring-offset-background focus-visible:ring-ring data-[state=active]:text-foreground inline-flex min-w-0 items-center justify-center gap-1.5 font-bold leading-none whitespace-nowrap transition-all focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:outline-hidden disabled:pointer-events-none disabled:cursor-not-allowed disabled:opacity-50",
+ "ring-offset-background focus-visible:ring-ring data-[state=active]:text-foreground inline-flex h-full items-center justify-center gap-1.5 font-bold leading-none whitespace-nowrap transition-all focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:outline-hidden disabled:pointer-events-none disabled:cursor-not-allowed disabled:opacity-50 aria-disabled:pointer-events-none aria-disabled:opacity-50",
{
variants: {
- variant: {
- default:
- "rounded-sm data-[state=active]:bg-background data-[state=active]:shadow-sm dark:data-[state=active]:bg-control-track dark:data-[state=active]:text-primary dark:data-[state=active]:shadow-none",
+ look: {
+ inset:
+ "relative z-1 min-w-0 rounded-sm dark:data-[state=active]:text-primary",
underline:
- "rounded-none border-b-2 border-transparent bg-transparent text-muted-foreground shadow-none data-[state=active]:border-primary-accent data-[state=active]:bg-transparent data-[state=active]:shadow-none",
+ "text-muted-foreground data-[state=active]:border-foreground-secondary rounded-none border-b-2 border-transparent bg-transparent px-4 text-sm",
+ navigation:
+ "text-muted-foreground data-[state=active]:border-foreground-secondary rounded-none border-b-2 border-transparent bg-transparent px-3 text-sm",
},
size: {
- default: "h-6 px-4 py-0.5 text-sm",
- lg: "h-7 px-1 text-xs",
- sm: "h-5 px-2 text-xs",
+ sm: "px-2 text-xs",
+ md: "px-4 text-sm",
},
},
- compoundVariants: [
- // Inside a boxed list the trigger fills the list's inner height, so the
- // list's padding is the inset on every side and the smaller radius
- // nests inside the list's. A fixed height overflowed once the list had
- // a border (outline) and left uneven top/bottom vs side spacing.
- { variant: "default", class: "h-full" },
- ],
- defaultVariants: {
- variant: "default",
- size: "default",
- },
},
);
-type TabsListProps = {
- "aria-label"?: string;
- children: React.ReactNode;
-} & Pick<
- VariantProps<typeof tabsListVariants>,
- "gap" | "layout" | "size" | "variant"
->;
type TabsRootProps = {
children: React.ReactNode;
+ /** `fill`: a column that takes its flex parent's remaining height, for `Tabs.Content layout="fill"`. */
+ layout?: "fill";
onValueChange?: (value: string) => void;
ref?: React.Ref<HTMLDivElement>;
} & (
@@ -102,27 +89,47 @@ type TabsRootProps = {
| { defaultValue?: never; value: string }
);
+const TabsRootContext = React.createContext(false);
+
function TabsRoot({
children,
defaultValue,
+ layout,
onValueChange,
ref,
value,
}: TabsRootProps) {
return (
- <TabsPrimitive.Root
- defaultValue={defaultValue}
- onValueChange={onValueChange}
- ref={ref}
- value={value}
- >
- {children}
- </TabsPrimitive.Root>
+ <TabsRootContext value={true}>
+ <TabsPrimitive.Root
+ className={layout === "fill" ? rootFillClassName : undefined}
+ defaultValue={defaultValue}
+ onValueChange={onValueChange}
+ ref={ref}
+ value={value}
+ >
+ {children}
+ </TabsPrimitive.Root>
+ </TabsRootContext>
);
}
-const TabsIndicatorContext = React.createContext(false);
+type TabsListProps = {
+ "aria-label"?: string;
+ children: React.ReactNode;
+ gap?: "none" | "sm" | "lg";
+ layout?: "default" | "full" | "packed";
+} & (
+ | { variant: "inset"; size: TabsInsetSize }
+ | { variant: "underline"; size?: never }
+);
+
+const TabsListContext = React.createContext<{
+ look: TabsLook;
+ size?: TabsInsetSize;
+} | null>(null);
+/** Outside a `Tabs` root the list is page navigation: a `<nav>` of link triggers, not a tablist. */
function TabsList({
"aria-label": ariaLabel,
children,
@@ -131,9 +138,12 @@ function TabsList({
size,
variant,
}: TabsListProps) {
+ const inRoot = React.use(TabsRootContext);
+ const look: TabsLook =
+ variant === "underline" && !inRoot ? "navigation" : variant;
const listRef = React.useRef<HTMLDivElement>(null);
const indicatorRef = React.useRef<HTMLSpanElement>(null);
- const hasSlidingIndicator = variant !== "underline";
+ const hasSlidingIndicator = look === "inset";
React.useLayoutEffect(() => {
if (!hasSlidingIndicator) return;
@@ -220,78 +230,74 @@ function TabsList({
};
}, [hasSlidingIndicator]);
+ const className = tabsListVariants({ gap, layout, look, size });
+
+ if (look === "navigation") {
+ return (
+ <TabsListContext value={{ look }}>
+ <nav aria-label={ariaLabel} className={className}>
+ {children}
+ </nav>
+ </TabsListContext>
+ );
+ }
+
return (
- <TabsIndicatorContext value={hasSlidingIndicator}>
+ <TabsListContext value={{ look, size }}>
<TabsPrimitive.List
ref={listRef}
aria-label={ariaLabel}
- className={cn(
- tabsListVariants({ gap, layout, size, variant }),
- hasSlidingIndicator && "relative isolate",
- )}
+ className={className}
>
{hasSlidingIndicator ? (
<span
ref={indicatorRef}
data-tabs-indicator=""
aria-hidden="true"
- className={cn(
- "pointer-events-none absolute inset-y-0.5 left-0 z-0 rounded-sm opacity-0 data-[ready=true]:transition-[width,transform] data-[ready=true]:duration-200 data-[ready=true]:ease-out motion-reduce:transition-none",
- variant === "outline"
- ? "bg-muted"
- : "bg-background dark:bg-control-track shadow-sm dark:shadow-none",
- )}
+ className="bg-background dark:bg-control-track pointer-events-none absolute inset-y-0.5 left-0 z-0 rounded-sm opacity-0 shadow-sm data-[ready=true]:transition-[width,transform] data-[ready=true]:duration-200 data-[ready=true]:ease-out motion-reduce:transition-none dark:shadow-none"
/>
) : null}
{children}
</TabsPrimitive.List>
- </TabsIndicatorContext>
+ </TabsListContext>
);
}
type TabsTriggerProps = {
disabled?: boolean;
icon?: LucideIcon;
- value: string;
-} & Pick<VariantProps<typeof tabsTriggerVariants>, "size" | "variant"> &
+} & (
+ | {
+ /** Preferred for plain-text trigger content. */
+ label: string;
+ children?: never;
+ title?: never;
+ }
+ | {
+ label?: never;
+ /** Rich-content escape hatch. */
+ children: React.ReactNode;
+ title?: string;
+ }
+) &
(
+ | { value: string; href?: never; active?: never; onClick?: never }
| {
- /** Preferred for plain-text trigger content. */
- label: string;
- children?: never;
- title?: never;
- }
- | {
- label?: never;
- /** Rich-content escape hatch. */
- children: React.ReactNode;
- title?: string;
+ /** Renders a Next.js link with `aria-current` instead of a tab. */
+ href: LinkProps["href"];
+ active: boolean;
+ onClick?: () => void;
+ value?: never;
}
);
-function TabsTrigger({
- children,
- disabled,
- icon: Icon,
- label,
- size,
- title,
- value,
- variant,
-}: TabsTriggerProps) {
- const slidingIndicator = React.use(TabsIndicatorContext);
-
- return (
- <TabsPrimitive.Trigger
- value={value}
- disabled={disabled}
- title={label ?? title}
- className={cn(
- tabsTriggerVariants({ size, variant }),
- slidingIndicator &&
- "relative z-1 data-[state=active]:bg-transparent data-[state=active]:shadow-none dark:data-[state=active]:bg-transparent",
- )}
- >
+function TabsTrigger(props: TabsTriggerProps) {
+ // Outside a Tabs.List, fall back to the underline look instead of crashing.
+ const list = React.use(TabsListContext) ?? { look: "underline" as const };
+ const { children, disabled, icon: Icon, label, title } = props;
+ const className = tabsTriggerVariants({ look: list.look, size: list.size });
+ const content = (
+ <>
{Icon ? <Icon aria-hidden="true" className="icon-base shrink-0" /> : null}
{label !== undefined ? (
<span className="min-w-0 truncate" title={label}>
@@ -300,20 +306,54 @@ function TabsTrigger({
) : (
children
)}
+ </>
+ );
+
+ if (props.href !== undefined) {
+ return (
+ <Link
+ href={props.href}
+ onClick={props.onClick}
+ aria-current={props.active ? "page" : undefined}
+ aria-disabled={disabled || undefined}
+ tabIndex={disabled ? -1 : undefined}
+ data-state={props.active ? "active" : "inactive"}
+ title={label ?? title}
+ className={className}
+ >
+ {content}
+ </Link>
+ );
+ }
+
+ return (
+ <TabsPrimitive.Trigger
+ value={props.value}
+ disabled={disabled}
+ title={label ?? title}
+ className={className}
+ >
+ {content}
</TabsPrimitive.Trigger>
);
}
type TabsContentProps = {
children: React.ReactNode;
+ /** `fill`: a column that takes the remaining height of a `layout="fill"` root. */
+ layout?: "fill";
value: string;
};
-function TabsContent({ children, value }: TabsContentProps) {
+function TabsContent({ children, layout, value }: TabsContentProps) {
return (
<TabsPrimitive.Content
value={value}
- className="ring-offset-background focus-visible:ring-ring focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:outline-hidden"
+ className={cn(
+ "ring-offset-background focus-visible:ring-ring focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:outline-hidden",
+ layout === "fill" &&
+ "flex min-h-0 w-full flex-1 flex-col overflow-hidden",
+ )}
>
{children}
</TabsPrimitive.Content>
diff --git a/web/src/components/layouts/page-tabs.tsx b/web/src/components/layouts/page-tabs.tsx
index 77072945d8..9103de6bae 100644
--- a/web/src/components/layouts/page-tabs.tsx
+++ b/web/src/components/layouts/page-tabs.tsx
@@ -1,26 +1,24 @@
/* eslint-disable @repo/no-style-props, @repo/no-margin-on-root-elements */
+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
import { cn } from "@/src/utils/tailwind";
-import Link from "next/link";
import { useRouter } from "next/router";
import { type ParsedUrlQuery } from "querystring";
type TabDefinition = {
value: string;
label: string;
- href?: string;
+ href: string;
onClick?: () => void;
querySelector?: (
query: ParsedUrlQuery,
) => Record<string, string | string[] | undefined>;
disabled?: boolean;
- className?: string;
};
export type PageTabsProps = {
tabs: TabDefinition[];
activeTab: string;
className?: string;
- listClassName?: string;
/** Horizontal scroll for narrow viewports (mobile). */
scrollable?: boolean;
};
@@ -33,61 +31,26 @@ export const PageTabs = ({
tabs,
activeTab,
className,
- listClassName,
scrollable = false,
}: PageTabsProps) => {
const router = useRouter();
return (
<div className={cn(scrollable && "-mx-1 overflow-x-auto px-1", className)}>
- <div
- className={cn(
- "inline-flex h-9 items-center justify-start",
- listClassName,
- )}
- >
- {tabs.map((tab) => {
- const tabClassName = cn(
- "focus-visible:ring-ring text-muted-foreground font-bold inline-flex h-full items-center justify-center rounded-none border-b-2 border-transparent px-3 py-0.5 text-base whitespace-nowrap transition-all focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:outline-hidden",
- tab.value === activeTab
- ? "border-foreground-secondary text-foreground bg-transparent shadow-none"
- : "",
- tab.disabled && "pointer-events-none opacity-50",
- tab.className,
- );
-
- if (tab.href) {
- return (
- <Link
- key={tab.value}
- href={{
- pathname: tab.href ?? "",
- query: tab.querySelector?.(router.query),
- }}
- className={tabClassName}
- onClick={tab.onClick}
- >
- {tab.label}
- </Link>
- );
- }
-
- if (tab.onClick) {
- return (
- <button
- key={tab.value}
- type="button"
- onClick={tab.onClick}
- className={tabClassName}
- disabled={tab.disabled}
- >
- {tab.label}
- </button>
- );
- }
-
- return null;
- })}
- </div>
+ <Tabs.List variant="underline">
+ {tabs.map((tab) => (
+ <Tabs.Trigger
+ key={tab.value}
+ href={{
+ pathname: tab.href,
+ query: tab.querySelector?.(router.query),
+ }}
+ active={tab.value === activeTab}
+ onClick={tab.onClick}
+ disabled={tab.disabled}
+ label={tab.label}
+ />
+ ))}
+ </Tabs.List>
</div>
);
};
diff --git a/web/src/components/table/data-table-controls.tsx b/web/src/components/table/data-table-controls.tsx
index a825a77fe5..3bf6212b19 100644
--- a/web/src/components/table/data-table-controls.tsx
+++ b/web/src/components/table/data-table-controls.tsx
@@ -1875,9 +1875,9 @@ function CategoricalSelectContent({
onOperatorChange(newOperator as "any of" | "all of" | "none of")
}
>
- <Tabs.List layout="full" size="sm">
- <Tabs.Trigger value="any of" size="sm" label="Any of" />
- <Tabs.Trigger value="all of" size="sm" label="All of" />
+ <Tabs.List variant="inset" layout="full" size="sm">
+ <Tabs.Trigger value="any of" label="Any of" />
+ <Tabs.Trigger value="all of" label="All of" />
{/* Without a persisted selection, switching to "none of" is a
deliberate no-op in the state model (an empty exclusion
would persist a vacuous filter — LFE-10717), which used to
@@ -1890,7 +1890,6 @@ function CategoricalSelectContent({
<Tabs.Trigger
value="none of"
disabled={operator === undefined}
- size="sm"
label="None of"
/>
</span>
@@ -2548,9 +2547,9 @@ function FilterModeTabs({ mode, onModeChange }: FilterModeTabsProps) {
value={mode}
onValueChange={(newMode) => onModeChange(newMode as "select" | "text")}
>
- <Tabs.List layout="full" size="sm">
- <Tabs.Trigger value="select" size="sm" label="Select" />
- <Tabs.Trigger value="text" size="sm" label="Text" />
+ <Tabs.List variant="inset" layout="full" size="sm">
+ <Tabs.Trigger value="select" label="Select" />
+ <Tabs.Trigger value="text" label="Text" />
</Tabs.List>
</Tabs>
</div>
diff --git a/web/src/components/ui/tabs-bar.tsx b/web/src/components/ui/tabs-bar.tsx
deleted file mode 100644
index 0a99a14d15..0000000000
--- a/web/src/components/ui/tabs-bar.tsx
+++ /dev/null
@@ -1,66 +0,0 @@
-/* eslint-disable @repo/no-style-props, @repo/no-margin-on-root-elements */
-"use client";
-
-import * as React from "react";
-import * as TabsPrimitive from "@radix-ui/react-tabs";
-
-import { cn } from "@/src/utils/tailwind";
-
-const TabsBar = React.forwardRef<
- React.ComponentRef<typeof TabsPrimitive.Root>,
- React.ComponentPropsWithoutRef<typeof TabsPrimitive.Root>
->(({ className, ...props }, ref) => (
- <TabsPrimitive.Root
- ref={ref}
- className={cn("flex h-full w-full flex-col overflow-hidden", className)}
- {...props}
- />
-));
-TabsBar.displayName = TabsPrimitive.Root.displayName;
-
-const TabsBarList = React.forwardRef<
- React.ComponentRef<typeof TabsPrimitive.List>,
- React.ComponentPropsWithoutRef<typeof TabsPrimitive.List>
->(({ className, ...props }, ref) => (
- <TabsPrimitive.List
- ref={ref}
- className={cn(
- "inline-flex h-9 items-center justify-start border-b bg-transparent",
- className,
- )}
- {...props}
- />
-));
-TabsBarList.displayName = TabsPrimitive.List.displayName;
-
-const TabsBarTrigger = React.forwardRef<
- React.ComponentRef<typeof TabsPrimitive.Trigger>,
- React.ComponentPropsWithoutRef<typeof TabsPrimitive.Trigger>
->(({ className, ...props }, ref) => (
- <TabsPrimitive.Trigger
- ref={ref}
- className={cn(
- "focus-visible:ring-ring text-muted-foreground data-[state=active]:border-foreground-secondary data-[state=active]:text-foreground inline-flex h-full items-center justify-center rounded-none border-b-2 border-transparent px-4 py-0.5 text-base font-bold whitespace-nowrap transition-all focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:outline-hidden disabled:pointer-events-none disabled:opacity-50 data-[state=active]:bg-transparent data-[state=active]:shadow-none",
- className,
- )}
- {...props}
- />
-));
-TabsBarTrigger.displayName = TabsPrimitive.Trigger.displayName;
-
-const TabsBarContent = React.forwardRef<
- React.ComponentRef<typeof TabsPrimitive.Content>,
- React.ComponentPropsWithoutRef<typeof TabsPrimitive.Content>
->(({ className, ...props }, ref) => (
- <TabsPrimitive.Content
- ref={ref}
- className={cn(
- "ring-offset-background focus-visible:ring-ring mt-2 h-full focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:outline-hidden data-[state=inactive]:hidden",
- className,
- )}
- {...props}
- />
-));
-TabsBarContent.displayName = TabsPrimitive.Content.displayName;
-
-export { TabsBar, TabsBarList, TabsBarTrigger, TabsBarContent };
diff --git a/web/src/features/automations/components/AutomationDetails.tsx b/web/src/features/automations/components/AutomationDetails.tsx
index 752ca1dcee..6ba28ac538 100644
--- a/web/src/features/automations/components/AutomationDetails.tsx
+++ b/web/src/features/automations/components/AutomationDetails.tsx
@@ -11,12 +11,7 @@ import {
TriggerEventSource,
type FilterState,
} from "@langfuse/shared";
-import {
- TabsBar,
- TabsBarContent,
- TabsBarList,
- TabsBarTrigger,
-} from "@/src/components/ui/tabs-bar";
+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
import Header from "@/src/components/layouts/header";
import { SettingsTableCard } from "@/src/components/layouts/settings-table-card";
import { DeleteAutomationDialogController } from "./DeleteAutomationDialogController";
@@ -175,37 +170,33 @@ export const AutomationDetails: React.FC<AutomationDetailsProps> = ({
isEditing={false}
/>
) : (
- <TabsBar
- value={activeTab}
- onValueChange={setActiveTab}
- className="w-full"
- >
- <TabsBarList>
- <TabsBarTrigger value="executions">
- Execution History
- </TabsBarTrigger>
- <TabsBarTrigger value="configuration">
- Configuration
- </TabsBarTrigger>
- </TabsBarList>
+ <Tabs value={activeTab} onValueChange={setActiveTab}>
+ <Tabs.List variant="underline">
+ <Tabs.Trigger value="executions" label="Execution History" />
+ <Tabs.Trigger value="configuration" label="Configuration" />
+ </Tabs.List>
+
+ <Tabs.Content value="executions">
+ <div className="mt-6">
+ <SettingsTableCard>
+ <AutomationExecutionsTable
+ projectId={projectId}
+ automationId={automationId}
+ />
+ </SettingsTableCard>
+ </div>
+ </Tabs.Content>
- <TabsBarContent value="executions" className="mt-6">
- <SettingsTableCard>
- <AutomationExecutionsTable
+ <Tabs.Content value="configuration">
+ <div className="mt-6">
+ <AutomationForm
projectId={projectId}
- automationId={automationId}
+ automation={automationForForm}
+ isEditing={false}
/>
- </SettingsTableCard>
- </TabsBarContent>
-
- <TabsBarContent value="configuration" className="mt-6">
- <AutomationForm
- projectId={projectId}
- automation={automationForForm}
- isEditing={false}
- />
- </TabsBarContent>
- </TabsBar>
+ </div>
+ </Tabs.Content>
+ </Tabs>
)}
</>
)}
diff --git a/web/src/features/batch-actions/components/AddObservationsToDatasetDialog/components/CustomMappingEditor.tsx b/web/src/features/batch-actions/components/AddObservationsToDatasetDialog/components/CustomMappingEditor.tsx
index ad686d4bf8..a488f54f92 100644
--- a/web/src/features/batch-actions/components/AddObservationsToDatasetDialog/components/CustomMappingEditor.tsx
+++ b/web/src/features/batch-actions/components/AddObservationsToDatasetDialog/components/CustomMappingEditor.tsx
@@ -151,7 +151,7 @@ export function CustomMappingEditor({
value={config.type}
onValueChange={(v) => handleTypeChange(v as MappingTarget)}
>
- <Tabs.List layout="full">
+ <Tabs.List variant="inset" size="md" layout="full">
<Tabs.Trigger value="root" label="Root" />
<Tabs.Trigger value="keyValueMap" label="Key-value map" />
</Tabs.List>
diff --git a/web/src/features/datasets/DatasetItemPage.tsx b/web/src/features/datasets/DatasetItemPage.tsx
index a73cf22984..43f34231f0 100644
--- a/web/src/features/datasets/DatasetItemPage.tsx
+++ b/web/src/features/datasets/DatasetItemPage.tsx
@@ -142,9 +142,9 @@ function DatasetItemContent({
setRenderMode(value === "json" ? "json" : "pretty")
}
>
- <Tabs.List size="sm">
- <Tabs.Trigger value="pretty" size="sm" label="Formatted" />
- <Tabs.Trigger value="json" size="sm" label="Raw" />
+ <Tabs.List variant="inset" size="sm">
+ <Tabs.Trigger value="pretty" label="Formatted" />
+ <Tabs.Trigger value="json" label="Raw" />
</Tabs.List>
</Tabs>
)}
diff --git a/web/src/features/evals/components/eval-template-type-selector.tsx b/web/src/features/evals/components/eval-template-type-selector.tsx
index 1a5932bbe5..bfefe4ea90 100644
--- a/web/src/features/evals/components/eval-template-type-selector.tsx
+++ b/web/src/features/evals/components/eval-template-type-selector.tsx
@@ -106,7 +106,7 @@ export function EvalTemplateTypeSelector({
)
}
>
- <Tabs.List layout="packed" gap="lg">
+ <Tabs.List variant="inset" size="md" layout="packed" gap="lg">
{mode === "all" ? (
<span className="min-w-[100px]">
<Tabs.Trigger
diff --git a/web/src/features/evals/components/inner-evaluator-form.tsx b/web/src/features/evals/components/inner-evaluator-form.tsx
index 6fc176cfcf..c1783ceef4 100644
--- a/web/src/features/evals/components/inner-evaluator-form.tsx
+++ b/web/src/features/evals/components/inner-evaluator-form.tsx
@@ -897,7 +897,12 @@ export const InnerEvaluatorForm = (props: {
}
}}
>
- <Tabs.List layout="packed" gap="lg">
+ <Tabs.List
+ variant="inset"
+ size="md"
+ layout="packed"
+ gap="lg"
+ >
<span className="min-w-[100px]">
<Tabs.Trigger
value="event"
@@ -980,7 +985,12 @@ export const InnerEvaluatorForm = (props: {
);
}}
>
- <Tabs.List layout="packed" gap="lg">
+ <Tabs.List
+ variant="inset"
+ size="md"
+ layout="packed"
+ gap="lg"
+ >
<span className="min-w-[100px]">
<Tabs.Trigger
value="otel"
diff --git a/web/src/features/evals/v2/components/Evaluators/Code/EvaluatorCodeLanguageSelector/EvaluatorCodeLanguageSelector.tsx b/web/src/features/evals/v2/components/Evaluators/Code/EvaluatorCodeLanguageSelector/EvaluatorCodeLanguageSelector.tsx
index 09b99a627e..89152c6218 100644
--- a/web/src/features/evals/v2/components/Evaluators/Code/EvaluatorCodeLanguageSelector/EvaluatorCodeLanguageSelector.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/Code/EvaluatorCodeLanguageSelector/EvaluatorCodeLanguageSelector.tsx
@@ -24,7 +24,7 @@ export function EvaluatorCodeLanguageSelector({
onValueChange(language as EvalTemplateSourceCodeLanguage)
}
>
- <Tabs.List variant="outline">
+ <Tabs.List variant="inset" size="md">
<Tabs.Trigger
value={EvalTemplateSourceCodeLanguageEnum.PYTHON}
disabled={disabled}
diff --git a/web/src/features/evals/v2/components/Evaluators/EvaluationTypeConfiguration/components/EvaluationTypeToggle/EvaluationTypeToggle.tsx b/web/src/features/evals/v2/components/Evaluators/EvaluationTypeConfiguration/components/EvaluationTypeToggle/EvaluationTypeToggle.tsx
index 4c96032674..d3f86d7d08 100644
--- a/web/src/features/evals/v2/components/Evaluators/EvaluationTypeConfiguration/components/EvaluationTypeToggle/EvaluationTypeToggle.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/EvaluationTypeConfiguration/components/EvaluationTypeToggle/EvaluationTypeToggle.tsx
@@ -80,7 +80,7 @@ export function EvaluationTypeToggle({
value={value}
onValueChange={(mode) => onValueChange(mode as EvalTemplateType)}
>
- <Tabs.List variant="outline">
+ <Tabs.List variant="inset" size="md">
{visibleTypes.map(({ value: typeValue, label, icon }) => (
<Tabs.Trigger
key={typeValue}
diff --git a/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/FilterModeToggle.tsx b/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/FilterModeToggle.tsx
index bf29401110..4918913871 100644
--- a/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/FilterModeToggle.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/FilterModeToggle.tsx
@@ -15,7 +15,7 @@ export function FilterModeToggle({
value={mode}
onValueChange={(value) => onChange(value as EvaluatorFilterExperience)}
>
- <Tabs.List aria-label="Filter editor mode">
+ <Tabs.List variant="inset" size="md" aria-label="Filter editor mode">
<Tabs.Trigger value="query" icon={Braces} label="Query" />
<Tabs.Trigger value="builder" icon={ListFilter} label="Builder" />
</Tabs.List>
diff --git a/web/src/features/in-app-agent/components/InAppAgentWindow.clienttest.tsx b/web/src/features/in-app-agent/components/InAppAgentWindow.clienttest.tsx
index ad73254815..d3305f5597 100644
--- a/web/src/features/in-app-agent/components/InAppAgentWindow.clienttest.tsx
+++ b/web/src/features/in-app-agent/components/InAppAgentWindow.clienttest.tsx
@@ -140,12 +140,12 @@ describe("InAppAgentWindow quick actions", () => {
screen.queryByRole("button", { name: /stop run/i }),
).not.toBeInTheDocument();
expect(screen.getAllByRole("tab").map((tab) => tab.textContent)).toEqual([
- "Observability",
+ "Observe",
"Prompts",
"Evaluation",
"Dashboard",
]);
- expect(screen.getByRole("tab", { name: "Observability" })).toHaveAttribute(
+ expect(screen.getByRole("tab", { name: "Observe" })).toHaveAttribute(
"aria-selected",
"true",
);
@@ -162,7 +162,7 @@ describe("InAppAgentWindow quick actions", () => {
quickActionResetKey: "/project/project-1/observations",
}),
);
- expect(screen.getByRole("tab", { name: "Observability" })).toHaveAttribute(
+ expect(screen.getByRole("tab", { name: "Observe" })).toHaveAttribute(
"aria-selected",
"true",
);
diff --git a/web/src/features/in-app-agent/components/InAppAgentWindow.tsx b/web/src/features/in-app-agent/components/InAppAgentWindow.tsx
index 1ff7d143fe..ee27191437 100644
--- a/web/src/features/in-app-agent/components/InAppAgentWindow.tsx
+++ b/web/src/features/in-app-agent/components/InAppAgentWindow.tsx
@@ -147,24 +147,18 @@ function InAppAgentQuickActionPicker({
}
}}
>
- <Tabs.List
- aria-label="Quick action category"
- variant="underline"
- size="auto"
- layout="full"
- >
- {IN_APP_AGENT_QUICK_ACTION_CONTEXTS.map((context) => (
- <span key={context} className="min-w-0 flex-1">
+ <div className="max-w-full min-w-0 overflow-x-auto">
+ <Tabs.List aria-label="Quick action category" variant="underline">
+ {IN_APP_AGENT_QUICK_ACTION_CONTEXTS.map((context) => (
<Tabs.Trigger
+ key={context}
value={context}
disabled={isDisabled}
- variant="underline"
- size="lg"
label={IN_APP_AGENT_QUICK_ACTION_CONTEXT_LABELS[context]}
/>
- </span>
- ))}
- </Tabs.List>
+ ))}
+ </Tabs.List>
+ </div>
</Tabs>
</div>
<div className="mt-3 grid w-full max-w-sm grid-cols-1 gap-2">
diff --git a/web/src/features/in-app-agent/quickActions.ts b/web/src/features/in-app-agent/quickActions.ts
index fb7f775396..a3024b01bf 100644
--- a/web/src/features/in-app-agent/quickActions.ts
+++ b/web/src/features/in-app-agent/quickActions.ts
@@ -40,7 +40,7 @@ export const IN_APP_AGENT_QUICK_ACTION_CONTEXT_LABELS: Record<
InAppAgentQuickActionContext,
string
> = {
- observability: "Observability",
+ observability: "Observe",
prompts: "Prompts",
evaluation: "Evaluation",
dashboards: "Dashboard",
diff --git a/web/src/features/organization-usage/components/OrganizationUsageBreakdown.tsx b/web/src/features/organization-usage/components/OrganizationUsageBreakdown.tsx
index a22d3cb966..ae45e45ab9 100644
--- a/web/src/features/organization-usage/components/OrganizationUsageBreakdown.tsx
+++ b/web/src/features/organization-usage/components/OrganizationUsageBreakdown.tsx
@@ -173,7 +173,7 @@ export const OrganizationUsageBreakdown = ({ orgId }: { orgId: string }) => {
value={groupBy}
onValueChange={(value) => setGroupBy(value as GroupBy)}
>
- <Tabs.List aria-label="Group usage by">
+ <Tabs.List variant="inset" size="md" aria-label="Group usage by">
<Tabs.Trigger value="project" label="By project" />
<Tabs.Trigger value="type" label="By type" />
</Tabs.List>
diff --git a/web/src/features/prompts/components/NewPromptForm/index.tsx b/web/src/features/prompts/components/NewPromptForm/index.tsx
index 32fc6158e7..839ae8e97c 100644
--- a/web/src/features/prompts/components/NewPromptForm/index.tsx
+++ b/web/src/features/prompts/components/NewPromptForm/index.tsx
@@ -296,7 +296,7 @@ export const NewPromptForm: React.FC<NewPromptFormProps> = (props) => {
}}
>
{!initialPrompt ? (
- <Tabs.List layout="full">
+ <Tabs.List variant="inset" size="md" layout="full">
<span className="flex-1">
<Tabs.Trigger
disabled={
diff --git a/web/src/features/prompts/components/prompt-detail.tsx b/web/src/features/prompts/components/prompt-detail.tsx
index 224680f0e6..d622db22de 100644
--- a/web/src/features/prompts/components/prompt-detail.tsx
+++ b/web/src/features/prompts/components/prompt-detail.tsx
@@ -9,12 +9,6 @@ import {
} from "use-query-params";
import type { z } from "zod";
import { ChatMessageList } from "@/src/features/traces";
-import {
- TabsBar,
- TabsBarList,
- TabsBarContent,
- TabsBarTrigger,
-} from "@/src/components/ui/tabs-bar";
import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
import { Badge } from "@/src/components/ui/badge";
import { CodeView, JSONView } from "@/src/components/ui/CodeJsonViewer";
@@ -658,24 +652,24 @@ export const PromptDetail = ({
</div>
</div>
</div>
- <TabsBar
+ <Tabs
value={currentTab}
- className="min-h-0"
+ layout="fill"
onValueChange={(value) => setCurrentTab(value)}
>
- <TabsBarList className="max-w-full min-w-0 justify-start overflow-x-auto">
- <TabsBarTrigger value="prompt">Prompt</TabsBarTrigger>
- <TabsBarTrigger value="config">Config</TabsBarTrigger>
- <TabsBarTrigger value="linked-generations">
- Linked Generations
- </TabsBarTrigger>
- <TabsBarTrigger value="use-prompt">Use Prompt</TabsBarTrigger>
- </TabsBarList>
- <TabsBarContent
- value="linked-generations"
- className="mt-0 mb-2 flex max-h-full min-h-0 flex-1 flex-col overflow-hidden"
- >
- <div className="flex h-full flex-1 flex-col overflow-hidden">
+ <div className="max-w-full min-w-0 shrink-0 overflow-x-auto">
+ <Tabs.List variant="underline">
+ <Tabs.Trigger value="prompt" label="Prompt" />
+ <Tabs.Trigger value="config" label="Config" />
+ <Tabs.Trigger
+ value="linked-generations"
+ label="Linked Generations"
+ />
+ <Tabs.Trigger value="use-prompt" label="Use Prompt" />
+ </Tabs.List>
+ </div>
+ <Tabs.Content value="linked-generations" layout="fill">
+ <div className="flex h-full flex-1 flex-col overflow-hidden pb-2">
{isV4 ? (
<EventsTable
projectId={prompt.projectId}
@@ -693,11 +687,8 @@ export const PromptDetail = ({
/>
)}
</div>
- </TabsBarContent>
- <TabsBarContent
- value="prompt"
- className="mt-0 flex max-h-full min-h-0 flex-1 overflow-hidden"
- >
+ </Tabs.Content>
+ <Tabs.Content value="prompt" layout="fill">
<div className="mb-2 flex max-h-full min-h-0 w-full flex-col gap-2 overflow-y-auto">
{promptGraph.data?.graph && (
<div className="flex items-center justify-end py-2">
@@ -707,17 +698,12 @@ export const PromptDetail = ({
setResolutionMode(value as "tagged" | "resolved");
}}
>
- <Tabs.List gap="sm" size="auto">
+ <Tabs.List variant="inset" gap="sm" size="md">
<Tabs.Trigger
value="resolved"
- size="sm"
label="Resolved prompt"
/>
- <Tabs.Trigger
- value="tagged"
- size="sm"
- label="Tagged prompt"
- />
+ <Tabs.Trigger value="tagged" label="Tagged prompt" />
</Tabs.List>
</Tabs>
</div>
@@ -755,11 +741,8 @@ export const PromptDetail = ({
<PromptVariableListPreview variables={extractedVariables} />
)}
</div>
- </TabsBarContent>
- <TabsBarContent
- value="config"
- className="mt-0 flex max-h-full min-h-0 flex-1 overflow-hidden"
- >
+ </Tabs.Content>
+ <Tabs.Content value="config" layout="fill">
<div className="flex max-h-full min-h-0 w-full flex-col overflow-y-auto pb-4">
<JSONView
json={prompt.config}
@@ -767,11 +750,8 @@ export const PromptDetail = ({
className="pb-2"
/>
</div>
- </TabsBarContent>
- <TabsBarContent
- value="use-prompt"
- className="mt-0 flex max-h-full min-h-0 flex-1 overflow-hidden"
- >
+ </Tabs.Content>
+ <Tabs.Content value="use-prompt" layout="fill">
<div className="flex h-full min-h-0 w-full flex-col gap-2 overflow-y-auto pb-4">
{pythonCode && <CodeView content={pythonCode} title="Python" />}
{jsCode && <CodeView content={jsCode} title="JS/TS" />}
@@ -789,8 +769,8 @@ export const PromptDetail = ({
Langchain.
</p>
</div>
- </TabsBarContent>
- </TabsBar>
+ </Tabs.Content>
+ </Tabs>
</div>
</div>
</Page>
diff --git a/web/src/features/public-api/components/CreateLLMApiKeyForm.tsx b/web/src/features/public-api/components/CreateLLMApiKeyForm.tsx
index a27666a566..3ef956f338 100644
--- a/web/src/features/public-api/components/CreateLLMApiKeyForm.tsx
+++ b/web/src/features/public-api/components/CreateLLMApiKeyForm.tsx
@@ -912,15 +912,18 @@ export function CreateLLMApiKeyForm({
field.onChange(value as BedrockAuthMethod)
}
>
- <Tabs.List layout="full" gap="sm" size="auto">
+ <Tabs.List
+ variant="inset"
+ layout="full"
+ gap="sm"
+ size="md"
+ >
<Tabs.Trigger
value={AuthMethod.AccessKeys}
- size="sm"
label="AWS access keys"
/>
<Tabs.Trigger
value={AuthMethod.ApiKey}
- size="sm"
label="API key"
/>
</Tabs.List>
diff --git a/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsx b/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsx
index c8aa34483d..0e5d94a878 100644
--- a/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsx
+++ b/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsx
@@ -196,19 +196,11 @@ export function DistributionBooleanCard() {
value={activeTab}
onValueChange={(v) => setActiveTab(v as DistributionTab)}
>
- <Tabs.List size="md">
- <Tabs.Trigger
- value="score1"
- size="sm"
- label={score1FullLabel}
- />
- <Tabs.Trigger
- value="score2"
- size="sm"
- label={score2FullLabel}
- />
- <Tabs.Trigger value="all" size="sm" label="all" />
- <Tabs.Trigger value="matched" size="sm" label="matched" />
+ <Tabs.List variant="inset" size="md">
+ <Tabs.Trigger value="score1" label={score1FullLabel} />
+ <Tabs.Trigger value="score2" label={score2FullLabel} />
+ <Tabs.Trigger value="all" label="all" />
+ <Tabs.Trigger value="matched" label="matched" />
</Tabs.List>
</Tabs>
)}
diff --git a/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsx b/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsx
index 74ad37eccc..1d071378c0 100644
--- a/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsx
+++ b/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsx
@@ -287,19 +287,11 @@ export function DistributionCategoricalCard() {
value={activeTab}
onValueChange={(v) => setActiveTab(v as DistributionTab)}
>
- <Tabs.List size="md">
- <Tabs.Trigger
- value="score1"
- size="sm"
- label={score1FullLabel}
- />
- <Tabs.Trigger
- value="score2"
- size="sm"
- label={score2FullLabel}
- />
- <Tabs.Trigger value="all" size="sm" label="all" />
- <Tabs.Trigger value="matched" size="sm" label="matched" />
+ <Tabs.List variant="inset" size="md">
+ <Tabs.Trigger value="score1" label={score1FullLabel} />
+ <Tabs.Trigger value="score2" label={score2FullLabel} />
+ <Tabs.Trigger value="all" label="all" />
+ <Tabs.Trigger value="matched" label="matched" />
</Tabs.List>
</Tabs>
)}
diff --git a/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsx b/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsx
index 4fa1901b3c..3138301862 100644
--- a/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsx
+++ b/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsx
@@ -224,19 +224,11 @@ export function DistributionNumericCard() {
value={activeTab}
onValueChange={(v) => setActiveTab(v as DistributionTab)}
>
- <Tabs.List size="md">
- <Tabs.Trigger
- value="score1"
- size="sm"
- label={score1FullLabel}
- />
- <Tabs.Trigger
- value="score2"
- size="sm"
- label={score2FullLabel}
- />
- <Tabs.Trigger value="all" size="sm" label="all" />
- <Tabs.Trigger value="matched" size="sm" label="matched" />
+ <Tabs.List variant="inset" size="md">
+ <Tabs.Trigger value="score1" label={score1FullLabel} />
+ <Tabs.Trigger value="score2" label={score2FullLabel} />
+ <Tabs.Trigger value="all" label="all" />
+ <Tabs.Trigger value="matched" label="matched" />
</Tabs.List>
</Tabs>
)}
diff --git a/web/src/features/score-analytics/components/cards/TimelineChartCard.tsx b/web/src/features/score-analytics/components/cards/TimelineChartCard.tsx
index e16fa5b802..1013eb47ac 100644
--- a/web/src/features/score-analytics/components/cards/TimelineChartCard.tsx
+++ b/web/src/features/score-analytics/components/cards/TimelineChartCard.tsx
@@ -280,19 +280,11 @@ export function TimelineChartCard() {
value={activeTab}
onValueChange={(v) => setActiveTab(v as TimelineTab)}
>
- <Tabs.List size="md">
- <Tabs.Trigger
- value="score1"
- size="sm"
- label={score1FullLabel}
- />
- <Tabs.Trigger
- value="score2"
- size="sm"
- label={score2FullLabel}
- />
- <Tabs.Trigger value="all" size="sm" label="all" />
- <Tabs.Trigger value="matched" size="sm" label="matched" />
+ <Tabs.List variant="inset" size="md">
+ <Tabs.Trigger value="score1" label={score1FullLabel} />
+ <Tabs.Trigger value="score2" label={score2FullLabel} />
+ <Tabs.Trigger value="all" label="all" />
+ <Tabs.Trigger value="matched" label="matched" />
</Tabs.List>
</Tabs>
)}
diff --git a/web/src/features/skills/components/SkillFilePreview.tsx b/web/src/features/skills/components/SkillFilePreview.tsx
index e36099ee21..2f2bf9237f 100644
--- a/web/src/features/skills/components/SkillFilePreview.tsx
+++ b/web/src/features/skills/components/SkillFilePreview.tsx
@@ -19,9 +19,9 @@ export function SkillFilePreview({
return (
<Tabs defaultValue="preview">
<div className="mb-3 flex justify-end">
- <Tabs.List aria-label="File display" size="sm">
- <Tabs.Trigger value="preview" label="Preview" size="sm" />
- <Tabs.Trigger value="raw" label="Raw" size="sm" />
+ <Tabs.List aria-label="File display" variant="inset" size="sm">
+ <Tabs.Trigger value="preview" label="Preview" />
+ <Tabs.Trigger value="raw" label="Raw" />
</Tabs.List>
</div>
<Tabs.Content value="preview">
diff --git a/web/src/features/topics/CurrentTopics.tsx b/web/src/features/topics/CurrentTopics.tsx
index d40a9fabe5..22f62a99b2 100644
--- a/web/src/features/topics/CurrentTopics.tsx
+++ b/web/src/features/topics/CurrentTopics.tsx
@@ -64,7 +64,6 @@ export function CurrentTopics({
key={facet.facetId}
value={facet.facetId}
label={facet.name}
- variant="underline"
/>
))}
</Tabs.List>
diff --git a/web/src/features/topics/TopicTraceSelector.tsx b/web/src/features/topics/TopicTraceSelector.tsx
index ad7680d774..de2b57ec27 100644
--- a/web/src/features/topics/TopicTraceSelector.tsx
+++ b/web/src/features/topics/TopicTraceSelector.tsx
@@ -198,7 +198,11 @@ export function useTopicTraceSelector({
setRequest(null);
}}
>
- <Tabs.List aria-label="Trace selection method">
+ <Tabs.List
+ variant="inset"
+ size="md"
+ aria-label="Trace selection method"
+ >
<Tabs.Trigger value="filters" label="Filters" />
<Tabs.Trigger value="paste" label="Paste IDs" />
</Tabs.List>
diff --git a/web/src/features/trace-graph-view/components/GraphViewModeSwitch.tsx b/web/src/features/trace-graph-view/components/GraphViewModeSwitch.tsx
index 3368fb01ec..ffc4e32c7e 100644
--- a/web/src/features/trace-graph-view/components/GraphViewModeSwitch.tsx
+++ b/web/src/features/trace-graph-view/components/GraphViewModeSwitch.tsx
@@ -40,7 +40,7 @@ export function GraphViewModeSwitch({
value={value}
onValueChange={(mode) => onChange(mode as GraphViewMode)}
>
- <Tabs.List size="md" aria-label="Graph mode">
+ <Tabs.List variant="inset" size="md" aria-label="Graph mode">
{MODES.map(({ mode, icon: Icon, label, title }) => (
<Tabs.Trigger key={mode} value={mode} title={title}>
<Icon aria-hidden="true" className="icon-base shrink-0" />
diff --git a/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsx b/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsx
index 3934210005..44f7b76926 100644
--- a/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsx
+++ b/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsx
@@ -383,9 +383,9 @@ function ToolDefinitionRow({
setCurrentView(value as "formatted" | "json")
}
>
- <Tabs.List size="sm">
- <Tabs.Trigger value="formatted" size="sm" label="Formatted" />
- <Tabs.Trigger value="json" size="sm" label="Raw" />
+ <Tabs.List variant="inset" size="sm">
+ <Tabs.Trigger value="formatted" label="Formatted" />
+ <Tabs.Trigger value="json" label="Raw" />
</Tabs.List>
</Tabs>
</div>
diff --git a/web/src/features/traces/components/IOPreview/components/ViewModeToggle.tsx b/web/src/features/traces/components/IOPreview/components/ViewModeToggle.tsx
index cd2ffd9029..1244c42389 100644
--- a/web/src/features/traces/components/IOPreview/components/ViewModeToggle.tsx
+++ b/web/src/features/traces/components/IOPreview/components/ViewModeToggle.tsx
@@ -31,9 +31,9 @@ export function ViewModeToggle({
value={selectedViewTab}
onValueChange={handleViewTabChange}
>
- <Tabs.List size="sm">
- <Tabs.Trigger value="pretty" size="sm" label="Formatted" />
- <Tabs.Trigger value="json" size="sm" label="Raw" />
+ <Tabs.List variant="inset" size="sm">
+ <Tabs.Trigger value="pretty" label="Formatted" />
+ <Tabs.Trigger value="json" label="Raw" />
</Tabs.List>
</Tabs>
</div>
diff --git a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx
index d50b52224e..0679cef905 100644
--- a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx
+++ b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx
@@ -23,11 +23,6 @@ import { useCallback, useMemo, useState } from "react";
import { Switch } from "@/src/components/design-system/Switch/Switch";
import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
-import {
- TabsBar,
- TabsBarContent,
- TabsBarTrigger,
-} from "@/src/components/ui/tabs-bar";
import {
Tooltip,
TooltipContent,
@@ -377,9 +372,9 @@ export function ConnectedObservationDetailView({
treeNodeTotalCost={treeNode?.totalCost}
/>
- <TabsBar
+ <Tabs
value={selectedTab}
- className="flex min-h-0 flex-1 flex-col overflow-hidden"
+ layout="fill"
onValueChange={(value) => setSelectedTab(value as DetailTab)}
>
<TooltipProvider>
@@ -395,20 +390,18 @@ export function ConnectedObservationDetailView({
]}
triggers={
<>
- <TabsBarTrigger value="preview">Preview</TabsBarTrigger>
+ <Tabs.Trigger value="preview" label="Preview" />
{showMessagesTab && (
- <TabsBarTrigger value="messages" className="gap-1">
+ <Tabs.Trigger value="messages">
Messages <InternalFeatureBadge />
- </TabsBarTrigger>
+ </Tabs.Trigger>
)}
- <TabsBarTrigger value="attributes">
- Attributes
- </TabsBarTrigger>
+ <Tabs.Trigger value="attributes" label="Attributes" />
{showScoresTab ? (
- <TabsBarTrigger value="scores">Scores</TabsBarTrigger>
+ <Tabs.Trigger value="scores" label="Scores" />
) : null}
{showLogViewTab ? (
- <TabsBarTrigger value="log">
+ <Tabs.Trigger value="log">
<Tooltip>
<TooltipTrigger asChild>
<span>Log View</span>
@@ -419,7 +412,7 @@ export function ConnectedObservationDetailView({
: "Shows all observations concatenated. Great for quickly scanning through them."}
</TooltipContent>
</Tooltip>
- </TabsBarTrigger>
+ </Tabs.Trigger>
) : null}
</>
}
@@ -446,12 +439,8 @@ export function ConnectedObservationDetailView({
handleViewTabChange(value);
}}
>
- <Tabs.List size="sm">
- <Tabs.Trigger
- value="pretty"
- size="sm"
- label="Formatted"
- />
+ <Tabs.List variant="inset" size="sm">
+ <Tabs.Trigger value="pretty" label="Formatted" />
{selectedTab === "log" && isLogViewVirtualized ? (
<HoverCard
openDelay={200}
@@ -477,7 +466,6 @@ export function ConnectedObservationDetailView({
<span tabIndex={0} {...getTriggerProps()}>
<Tabs.Trigger
value="json"
- size="sm"
disabled
label="Raw"
/>
@@ -485,11 +473,7 @@ export function ConnectedObservationDetailView({
)}
</HoverCard>
) : (
- <Tabs.Trigger
- value="json"
- size="sm"
- label="Raw"
- />
+ <Tabs.Trigger value="json" label="Raw" />
)}
</Tabs.List>
</Tabs>
@@ -515,17 +499,13 @@ export function ConnectedObservationDetailView({
</TooltipProvider>
{selectedTab === "messages" && (
- <TabsBarContent
- value="messages"
- className="mt-0 min-h-0 flex-1 overflow-auto px-4"
- >
- <TraceMessagesView />
- </TabsBarContent>
+ <Tabs.Content value="messages" layout="fill">
+ <div className="min-h-0 flex-1 overflow-auto px-4">
+ <TraceMessagesView />
+ </div>
+ </Tabs.Content>
)}
- <TabsBarContent
- value="preview"
- className="mt-0 flex max-h-full min-h-0 w-full flex-1"
- >
+ <Tabs.Content value="preview" layout="fill">
<ObservationPreview
currentView={currentView}
previewKey={observation.id}
@@ -595,12 +575,9 @@ export function ConnectedObservationDetailView({
environment: observation.environment,
}}
/>
- </TabsBarContent>
+ </Tabs.Content>
- <TabsBarContent
- value="attributes"
- className="mt-0 flex max-h-full min-h-0 w-full flex-1"
- >
+ <Tabs.Content value="attributes" layout="fill">
<ObservationAttributesTab
attributes={attributes}
attributesAnchorTime={observation.startTime}
@@ -611,13 +588,10 @@ export function ConnectedObservationDetailView({
projectId={projectId}
currentView={selectedViewTab}
/>
- </TabsBarContent>
+ </Tabs.Content>
{showScoresTab ? (
- <TabsBarContent
- value="scores"
- className="mt-0 flex h-full min-h-0 flex-1 overflow-hidden"
- >
+ <Tabs.Content value="scores" layout="fill">
<div className="flex h-full min-h-0 w-full flex-1 flex-col overflow-hidden">
<ScoresTable
projectId={projectId}
@@ -637,23 +611,20 @@ export function ConnectedObservationDetailView({
disableUrlPersistence={isPeekMode || isAnnotationMode}
/>
</div>
- </TabsBarContent>
+ </Tabs.Content>
) : null}
{showLogViewTab ? (
- <TabsBarContent
- value="log"
- className="mt-0 flex max-h-full min-h-0 w-full flex-1"
- >
+ <Tabs.Content value="log" layout="fill">
<TraceLogView
traceId={traceId}
projectId={projectId}
currentView={isLogViewVirtualized ? "pretty" : currentView}
target="observation"
/>
- </TabsBarContent>
+ </Tabs.Content>
) : null}
- </TabsBar>
+ </Tabs>
</div>
)}
</CommentDrawerController>
diff --git a/web/src/features/traces/components/TraceDetailTabsBarList.clienttest.tsx b/web/src/features/traces/components/TraceDetailTabsBarList.clienttest.tsx
index 6772740db4..49075f140a 100644
--- a/web/src/features/traces/components/TraceDetailTabsBarList.clienttest.tsx
+++ b/web/src/features/traces/components/TraceDetailTabsBarList.clienttest.tsx
@@ -2,7 +2,7 @@
import { act, cleanup, render, screen } from "@testing-library/react";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-import { TabsBar, TabsBarTrigger } from "@/src/components/ui/tabs-bar";
+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
import { TraceDetailTabsBarList } from "./TraceDetailTabsBarList";
@@ -31,20 +31,20 @@ function setAvailableWidth(width: number) {
function renderTabsBar() {
return render(
- <TabsBar value="preview" onValueChange={vi.fn()}>
+ <Tabs value="preview" onValueChange={vi.fn()}>
<TraceDetailTabsBarList
tabs={["preview", "scores"]}
selectedTab="preview"
onSelect={vi.fn()}
triggers={
<>
- <TabsBarTrigger value="preview">Preview</TabsBarTrigger>
- <TabsBarTrigger value="scores">Scores</TabsBarTrigger>
+ <Tabs.Trigger value="preview" label="Preview" />
+ <Tabs.Trigger value="scores" label="Scores" />
</>
}
trailingControls={<div>Trailing</div>}
/>
- </TabsBar>,
+ </Tabs>,
);
}
diff --git a/web/src/features/traces/components/TraceDetailTabsBarList.tsx b/web/src/features/traces/components/TraceDetailTabsBarList.tsx
index b7e2457478..4321baf518 100644
--- a/web/src/features/traces/components/TraceDetailTabsBarList.tsx
+++ b/web/src/features/traces/components/TraceDetailTabsBarList.tsx
@@ -1,6 +1,6 @@
import { type ReactNode } from "react";
-import { TabsBarList } from "@/src/components/ui/tabs-bar";
+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
import { useFitsAvailableWidth } from "@/src/hooks/useFitsAvailableWidth";
import { cn } from "@/src/utils/tailwind";
@@ -37,7 +37,7 @@ export function TraceDetailTabsBarList({
>();
return (
- <TabsBarList className="shrink-0">
+ <Tabs.List variant="underline">
{/* A zero flex basis makes this the row space left over by the trailing
controls, so the triggers are compared against the width they can
actually occupy without that width depending on them in turn. */}
@@ -68,6 +68,6 @@ export function TraceDetailTabsBarList({
)}
</div>
{trailingControls}
- </TabsBarList>
+ </Tabs.List>
);
}
diff --git a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx
index 43afd44cb0..45fdc0977a 100644
--- a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx
+++ b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx
@@ -5,11 +5,6 @@
import { type TraceDomain, type ScoreDomain } from "@langfuse/shared";
import { type ObservationReturnTypeWithMetadata } from "@/src/server/api/routers/traces";
import { type WithStringifiedMetadata } from "@/src/utils/clientSideDomainTypes";
-import {
- TabsBar,
- TabsBarContent,
- TabsBarTrigger,
-} from "@/src/components/ui/tabs-bar";
import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
import { Switch } from "@/src/components/design-system/Switch/Switch";
import { useCallback, useMemo, useState } from "react";
@@ -281,9 +276,9 @@ export function TraceDetailView({
/>
{/* Tabs section */}
- <TabsBar
+ <Tabs
value={selectedTab}
- className="flex min-h-0 flex-1 flex-col overflow-hidden"
+ layout="fill"
onValueChange={handleTabChange}
>
{/* Hide the tabs bar when only Preview remains. */}
@@ -300,14 +295,14 @@ export function TraceDetailView({
]}
triggers={
<>
- <TabsBarTrigger value="preview">Preview</TabsBarTrigger>
+ <Tabs.Trigger value="preview" label="Preview" />
{showMessagesTab && (
- <TabsBarTrigger value="messages" className="gap-1">
+ <Tabs.Trigger value="messages">
Messages <InternalFeatureBadge />
- </TabsBarTrigger>
+ </Tabs.Trigger>
)}
{showLogViewTab && (
- <TabsBarTrigger value="log">
+ <Tabs.Trigger value="log">
<Tooltip>
<TooltipTrigger asChild>
<span>Log View</span>
@@ -318,10 +313,10 @@ export function TraceDetailView({
: "Shows all observations concatenated. Great for quickly scanning through them."}
</TooltipContent>
</Tooltip>
- </TabsBarTrigger>
+ </Tabs.Trigger>
)}
{showScoresTab && (
- <TabsBarTrigger value="scores">Scores</TabsBarTrigger>
+ <Tabs.Trigger value="scores" label="Scores" />
)}
</>
}
@@ -350,12 +345,8 @@ export function TraceDetailView({
handleViewTabChange(value);
}}
>
- <Tabs.List size="sm">
- <Tabs.Trigger
- value="pretty"
- size="sm"
- label="Formatted"
- />
+ <Tabs.List variant="inset" size="sm">
+ <Tabs.Trigger value="pretty" label="Formatted" />
{selectedTab === "log" && isLogViewVirtualized ? (
<HoverCard
openDelay={200}
@@ -381,7 +372,6 @@ export function TraceDetailView({
<span tabIndex={0} {...getTriggerProps()}>
<Tabs.Trigger
value="json"
- size="sm"
disabled
label="Raw"
/>
@@ -389,11 +379,7 @@ export function TraceDetailView({
)}
</HoverCard>
) : (
- <Tabs.Trigger
- value="json"
- size="sm"
- label="Raw"
- />
+ <Tabs.Trigger value="json" label="Raw" />
)}
</Tabs.List>
</Tabs>
@@ -420,19 +406,15 @@ export function TraceDetailView({
)}
{selectedTab === "messages" && (
- <TabsBarContent
- value="messages"
- className="mt-0 min-h-0 flex-1 overflow-auto px-4"
- >
- <TraceMessagesView />
- </TabsBarContent>
+ <Tabs.Content value="messages" layout="fill">
+ <div className="min-h-0 flex-1 overflow-auto px-4">
+ <TraceMessagesView />
+ </div>
+ </Tabs.Content>
)}
{/* Preview tab content */}
- <TabsBarContent
- value="preview"
- className="mt-0 flex max-h-full min-h-0 w-full flex-1"
- >
+ <Tabs.Content value="preview" layout="fill">
<div
className={cn(
"flex min-h-0 w-full flex-1 flex-col",
@@ -515,27 +497,21 @@ export function TraceDetailView({
environment={trace.environment}
/>
</div>
- </TabsBarContent>
+ </Tabs.Content>
{/* Log View tab content */}
- <TabsBarContent
- value="log"
- className="mt-0 flex max-h-full min-h-0 w-full flex-1"
- >
+ <Tabs.Content value="log" layout="fill">
<TraceLogView
traceId={trace.id}
projectId={projectId}
currentView={isLogViewVirtualized ? "pretty" : currentView}
target="trace"
/>
- </TabsBarContent>
+ </Tabs.Content>
{/* Scores tab content */}
{showScoresTab && (
- <TabsBarContent
- value="scores"
- className="mt-0 flex max-h-full min-h-0 w-full flex-1 overflow-hidden"
- >
+ <Tabs.Content value="scores" layout="fill">
<div className="flex h-full min-h-0 w-full flex-col overflow-hidden">
<ScoresTable
projectId={projectId}
@@ -552,9 +528,9 @@ export function TraceDetailView({
disableUrlPersistence={isPeekMode || isAnnotationMode}
/>
</div>
- </TabsBarContent>
+ </Tabs.Content>
)}
- </TabsBar>
+ </Tabs>
</div>
)}
</CommentDrawerController>
diff --git a/web/src/features/traces/components/TraceLayoutMobile.tsx b/web/src/features/traces/components/TraceLayoutMobile.tsx
index 7f29afa8bb..b215764fca 100644
--- a/web/src/features/traces/components/TraceLayoutMobile.tsx
+++ b/web/src/features/traces/components/TraceLayoutMobile.tsx
@@ -31,12 +31,7 @@ import {
type ReactNode,
} from "react";
import { StringParam, useQueryParam } from "use-query-params";
-import {
- TabsBar,
- TabsBarContent,
- TabsBarList,
- TabsBarTrigger,
-} from "@/src/components/ui/tabs-bar";
+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
import { useSelection } from "@/src/features/traces/contexts/SelectionContext";
import { TraceTruncationNotice } from "./TraceTruncationNotice";
@@ -66,8 +61,6 @@ export function useMobileLayoutContextOptional() {
return useContext(MobileLayoutContext);
}
-const TAB_BODY_CLASS = "mt-0 flex min-h-0 flex-1 flex-col overflow-hidden";
-
export function TraceLayoutMobile({
tree,
timeline,
@@ -124,17 +117,17 @@ export function TraceLayoutMobile({
return (
<MobileLayoutContext.Provider value={contextValue}>
- <TabsBar
+ <Tabs
value={activeTab}
onValueChange={(value) => setTabParam(value, "pushIn")}
- className="h-full w-full"
+ layout="fill"
>
- <TabsBarList className="shrink-0 px-2">
- <TabsBarTrigger value="tree">Tree</TabsBarTrigger>
- <TabsBarTrigger value="timeline">Timeline</TabsBarTrigger>
- {showGraph && <TabsBarTrigger value="graph">Graph</TabsBarTrigger>}
- <TabsBarTrigger value="info">Data</TabsBarTrigger>
- </TabsBarList>
+ <Tabs.List variant="underline">
+ <Tabs.Trigger value="tree" label="Tree" />
+ <Tabs.Trigger value="timeline" label="Timeline" />
+ {showGraph && <Tabs.Trigger value="graph" label="Graph" />}
+ <Tabs.Trigger value="info" label="Data" />
+ </Tabs.List>
{/* Above the tab bodies, not inside one: the truncation applies to every
tab, and the navigators own their own scroll containers. */}
@@ -145,21 +138,21 @@ export function TraceLayoutMobile({
the elk graph layout, and the detail JSON never all mount at once);
the cost is that a navigator's scroll/zoom resets when revisited —
an accepted v1 tradeoff (follow-up: preserve navigator state). */}
- <TabsBarContent value="tree" className={TAB_BODY_CLASS}>
+ <Tabs.Content value="tree" layout="fill">
{tree}
- </TabsBarContent>
- <TabsBarContent value="timeline" className={TAB_BODY_CLASS}>
+ </Tabs.Content>
+ <Tabs.Content value="timeline" layout="fill">
{timeline}
- </TabsBarContent>
+ </Tabs.Content>
{showGraph && (
- <TabsBarContent value="graph" className={TAB_BODY_CLASS}>
+ <Tabs.Content value="graph" layout="fill">
{graph}
- </TabsBarContent>
+ </Tabs.Content>
)}
- <TabsBarContent value="info" className={TAB_BODY_CLASS}>
+ <Tabs.Content value="info" layout="fill">
{info}
- </TabsBarContent>
- </TabsBar>
+ </Tabs.Content>
+ </Tabs>
</MobileLayoutContext.Provider>
);
}
diff --git a/web/src/features/traces/components/TracePanelNavigationHeader/TracePanelNavigationHeader.tsx b/web/src/features/traces/components/TracePanelNavigationHeader/TracePanelNavigationHeader.tsx
index a4ccb87704..bfb1f734a0 100644
--- a/web/src/features/traces/components/TracePanelNavigationHeader/TracePanelNavigationHeader.tsx
+++ b/web/src/features/traces/components/TracePanelNavigationHeader/TracePanelNavigationHeader.tsx
@@ -372,7 +372,7 @@ function ViewModeSwitch({
value={activeView}
onValueChange={(value) => onSelect(value as TraceViewMode)}
>
- <Tabs.List size="md" aria-label="Trace view">
+ <Tabs.List variant="inset" size="md" aria-label="Trace view">
<Tabs.Trigger value="tree" label="Tree" />
{/* One Timeline. What it IS depends on the Compact Timeline feature
preview — see TracePanelNavigation — rather than on a third segment
diff --git a/web/src/features/widgets/components/SelectWidgetDialog.tsx b/web/src/features/widgets/components/SelectWidgetDialog.tsx
index 431756129a..88f146e844 100644
--- a/web/src/features/widgets/components/SelectWidgetDialog.tsx
+++ b/web/src/features/widgets/components/SelectWidgetDialog.tsx
@@ -224,7 +224,7 @@ export function SelectWidgetDialog({
capture("dashboard:add_widget_tab_switch", { tab })
}
>
- <Tabs.List>
+ <Tabs.List variant="inset" size="md">
<Tabs.Trigger
value="project"
label={`Your widgets (${projectWidgets.length})`}