Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

chore(worker): count completed queue jobs in the rate metric (#16203)

Niklas Semmler2af2a3f052cf
diff --git a/worker/src/__tests__/workerManagerMetrics.test.ts b/worker/src/__tests__/workerManagerMetrics.test.ts
index 2c10706015..1bd01f5a8d 100644
--- a/worker/src/__tests__/workerManagerMetrics.test.ts
+++ b/worker/src/__tests__/workerManagerMetrics.test.ts
@@ -129,4 +129,16 @@ describe("WorkerManager queue metrics", () => {
["langfuse.queue.trace_delete.rate", 1, { type: "stalled" }],
]);
});
+
+ it("emits a rate counter for completed jobs but not for active ones", () => {
+ // Own queue name: register() no-ops on the statically registered one above.
+ WorkerManager.register("trace-upsert" as never, async () => "processed");
+
+ mocks.handlers.get("active")?.({ id: "job-id", name: "job" });
+ mocks.handlers.get("completed")?.({ id: "job-id", name: "job" });
+
+ expect(mocks.recordIncrement.mock.calls).toEqual([
+ ["langfuse.queue.trace_upsert.rate", 1, { type: "completed" }],
+ ]);
+ });
});
diff --git a/worker/src/queues/workerManager.ts b/worker/src/queues/workerManager.ts
index 80857beab5..03baee399e 100644
--- a/worker/src/queues/workerManager.ts
+++ b/worker/src/queues/workerManager.ts
@@ -154,14 +154,21 @@ export class WorkerManager {
markQueueWorkerRegistered();
logger.info(`${queueName} executor started: ${worker.isRunning()}`);
+ const { baseMetric, shardTag } = WorkerManager.resolveMetricInfo(queueName);
+
// Liveness signal for the ?failIfQueueConsumptionStuck=true health check.
// "active" and "completed" prove this container's consumption loop is
// alive; "failed" is excluded because the stalled-checker emits it for
// jobs this container never picked up.
worker.on("active", markQueueJobActivity);
- worker.on("completed", markQueueJobActivity);
-
- const { baseMetric, shardTag } = WorkerManager.resolveMetricInfo(queueName);
+ // No "active" counter: metricWrapper already records "request" on pickup.
+ worker.on("completed", () => {
+ markQueueJobActivity();
+ recordIncrement(baseMetric + ".rate", 1, {
+ type: "completed",
+ ...shardTag,
+ });
+ });
// Add error handling
worker.on("failed", (job: Job | undefined, err: Error) => {