Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(evals): clip overflowing filter pills in the evaluators table (#16264)

Nikita Kabardin2b5ca5d7b9a0
diff --git a/web/src/features/evals/components/EvaluatorFilterCell.clienttest.tsx b/web/src/features/evals/components/EvaluatorFilterCell.clienttest.tsx
new file mode 100644
index 0000000000..3d984f81ab
--- /dev/null
+++ b/web/src/features/evals/components/EvaluatorFilterCell.clienttest.tsx
@@ -0,0 +1,41 @@
+import { render, screen } from "@testing-library/react";
+import { type FilterState } from "@langfuse/shared";
+import { EvaluatorFilterCell } from "@/src/features/evals/components/EvaluatorFilterCell";
+
+const ENVIRONMENT_FILTER = [
+ {
+ type: "stringOptions",
+ column: "environment",
+ operator: "any of",
+ value: ["prod"],
+ },
+] satisfies FilterState;
+
+const LONG_NAME_FILTER = [
+ {
+ type: "stringOptions",
+ column: "Name",
+ operator: "any of",
+ value: ["Chat about billing and account recovery"],
+ },
+] satisfies FilterState;
+
+describe("EvaluatorFilterCell", () => {
+ it("does not enable a per-cell horizontal scrollbar", () => {
+ const { container } = render(
+ <EvaluatorFilterCell filterState={ENVIRONMENT_FILTER} />,
+ );
+
+ expect(container.querySelector(".overflow-x-auto")).toBeNull();
+ expect(container.firstElementChild).toHaveClass("overflow-hidden");
+ });
+
+ it("renders the filter pill and exposes the full value on hover", () => {
+ render(<EvaluatorFilterCell filterState={LONG_NAME_FILTER} />);
+
+ expect(screen.getByText("Name")).toBeInTheDocument();
+ expect(
+ screen.getByTitle("Name any of Chat about billing and account recovery"),
+ ).toBeInTheDocument();
+ });
+});
diff --git a/web/src/features/evals/components/EvaluatorFilterCell.stories.tsx b/web/src/features/evals/components/EvaluatorFilterCell.stories.tsx
new file mode 100644
index 0000000000..4cd6dfcf91
--- /dev/null
+++ b/web/src/features/evals/components/EvaluatorFilterCell.stories.tsx
@@ -0,0 +1,50 @@
+import preview from "../../../../.storybook/preview";
+import type { FilterState } from "@langfuse/shared";
+import { EvaluatorFilterCell } from "@/src/features/evals/components/EvaluatorFilterCell";
+
+const SHORT_FILTER = [
+ {
+ type: "stringOptions",
+ column: "environment",
+ operator: "any of",
+ value: ["prod"],
+ },
+] satisfies FilterState;
+
+const LONG_FILTER = [
+ {
+ type: "stringOptions",
+ column: "Name",
+ operator: "any of",
+ value: ["Chat about billing and account recovery"],
+ },
+ {
+ type: "arrayOptions",
+ column: "Tags",
+ operator: "any of",
+ value: ["web_search_"],
+ },
+] satisfies FilterState;
+
+const meta = preview.meta({
+ component: EvaluatorFilterCell,
+});
+
+export default meta;
+
+export const Default = meta.story({
+ args: {
+ filterState: SHORT_FILTER,
+ },
+});
+
+export const Overflowing = meta.story({
+ args: {
+ filterState: LONG_FILTER,
+ },
+ render: (args) => (
+ <div className="w-[200px] overflow-hidden">
+ <EvaluatorFilterCell {...args} />
+ </div>
+ ),
+});
diff --git a/web/src/features/evals/components/EvaluatorFilterCell.tsx b/web/src/features/evals/components/EvaluatorFilterCell.tsx
new file mode 100644
index 0000000000..ece3130664
--- /dev/null
+++ b/web/src/features/evals/components/EvaluatorFilterCell.tsx
@@ -0,0 +1,23 @@
+import type { FilterState } from "@langfuse/shared";
+import { formatFilterPreview } from "@/src/components/table/table-view-presets/lib/viewPreview";
+import { InlineFilterState } from "@/src/features/filters/components/filter-builder";
+
+export function EvaluatorFilterCell({
+ filterState,
+}: {
+ filterState: FilterState;
+}) {
+ const title =
+ filterState.length > 0
+ ? filterState.map(formatFilterPreview).join(" · ")
+ : undefined;
+
+ return (
+ <div
+ className="flex w-full max-w-full min-w-0 items-center gap-2 overflow-hidden"
+ title={title}
+ >
+ <InlineFilterState className="ml-0" filterState={filterState} />
+ </div>
+ );
+}
diff --git a/web/src/features/evals/components/evaluator-table.tsx b/web/src/features/evals/components/evaluator-table.tsx
index 02b4cfff9d..d426306be2 100644
--- a/web/src/features/evals/components/evaluator-table.tsx
+++ b/web/src/features/evals/components/evaluator-table.tsx
@@ -10,7 +10,7 @@ import {
import { ResizableFilterLayout } from "@/src/components/table/resizable-filter-layout";
import { type LangfuseColumnDef } from "@/src/components/table/types";
import useColumnVisibility from "@/src/features/column-visibility/hooks/useColumnVisibility";
-import { InlineFilterState } from "@/src/features/filters/components/filter-builder";
+import { EvaluatorFilterCell } from "@/src/features/evals/components/EvaluatorFilterCell";
import { useDetailPageLists } from "@/src/features/navigate-detail-pages/context";
import { useSidebarFilterState } from "@/src/features/filters/hooks/useSidebarFilterState";
import { evaluatorFilterConfig } from "@/src/features/filters/config/evaluators-config";
@@ -354,11 +354,7 @@ export default function EvaluatorTable({ projectId }: { projectId: string }) {
return filter;
});
- return (
- <div className="flex h-full overflow-x-auto">
- <InlineFilterState filterState={newFilterState} />
- </div>
- );
+ return <EvaluatorFilterCell filterState={newFilterState} />;
},
}),
columnHelper.accessor("id", {