🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
feat(ingestion): measure synchronous OTEL work and preparation codepaths (#18844)
Valery Meleshkin2c7133a9619b
diff --git a/worker/src/features/otel-ingestion/prepareOtelBatch.ts b/worker/src/features/otel-ingestion/prepareOtelBatch.tsindex e55194ff34..654b468480 100644--- a/worker/src/features/otel-ingestion/prepareOtelBatch.ts+++ b/worker/src/features/otel-ingestion/prepareOtelBatch.ts@@ -43,24 +43,38 @@ export async function prepareOtelBatch(params: {const { bytes, extractMedia, ...context } = params;const startedAt = performance.now();let outcome: "native" | "unchanged" | "masking_drop" | "error" = "error";+ let codepath: "inline_check" | "uv_dispatch" | "disabled" = "disabled";let originalInput: ValidatedOtelJson | undefined;let maskedInput: ValidatedOtelJson | undefined;try {if (!isIngestionMaskingEnabled()) {+ codepath = extractMedia ? "inline_check" : "disabled";+ const inputStartedAt = performance.now();const needsExtraction =extractMedia &&(bytes.length > MAX_SYNC_MEDIA_CHECK_BYTES ||hasOtelMediaCandidate(bytes));- const batch = needsExtraction ? await extractOtelMedia(bytes) : null;+ if (needsExtraction) codepath = "uv_dispatch";+ const extraction = needsExtraction ? extractOtelMedia(bytes) : null;+ recordDistribution(+ "langfuse.ingestion.otel.main_thread_duration_ms",+ performance.now() - inputStartedAt,+ { phase: "input_handling", media_path: "early" },+ );+ const batch = needsExtraction ? await extraction : null;outcome = batch ? "native" : "unchanged";return { batch: batch ?? undefined, sourceUnchanged: !batch };}+ codepath = "uv_dispatch";originalInput = await validateOtelJson(bytes);const masking = await applyIngestionMasking({...context,data: {- bytes: originalInput.normalizedBytes() ?? bytes,+ bytes:+ measureOtelMainThread("native_result", () =>+ originalInput!.normalizedBytes(),+ ) ?? bytes,validated: originalInput,},},@@ -86,7 +100,10 @@ export async function prepareOtelBatch(params: {);maskedInput = await validateOtelJson(json);return {- bytes: maskedInput.normalizedBytes() ?? json,+ bytes:+ measureOtelMainThread("native_result", () =>+ maskedInput!.normalizedBytes(),+ ) ?? json,validated: maskedInput,};} finally {@@ -125,6 +142,7 @@ export async function prepareOtelBatch(params: {.finally(() => {const tags = {outcome,+ codepath,extract_media: extractMedia.toString(),};recordIncrement(@@ -160,15 +178,34 @@ export async function parsePreparedOtelBatch(downloadedBytes.byteLength,);} else {- json = batch.takeJsonBuffer();+ json = measureOtelMainThread("native_result", () =>+ batch!.takeJsonBuffer(),+ );}- return { resourceSpans: JSON.parse(json.toString("utf8")), batch };+ return measureOtelMainThread("input_json", () => ({+ resourceSpans: JSON.parse(json.toString("utf8")),+ batch,+ }));} catch (error) {await batch?.dispose();throw error;}}+// Measure synchronous result handling; awaited native work stays outside.+function measureOtelMainThread<T>(phase: string, work: () => T): T {+ const startedAt = performance.now();+ try {+ return work();+ } finally {+ recordDistribution(+ "langfuse.ingestion.otel.main_thread_duration_ms",+ performance.now() - startedAt,+ { phase, media_path: "early" },+ );+ }+}+// Match Node's Response.json(): accept up to two leading UTF-8 BOMs and leave// a third for the JSON parser to reject.function stripResponseJsonBoms(bytes: Buffer): Buffer {diff --git a/worker/src/features/otel-media/mediaReferenceText.ts b/worker/src/features/otel-media/mediaReferenceText.tsindex b46311363a..179b614bbe 100644--- a/worker/src/features/otel-media/mediaReferenceText.ts+++ b/worker/src/features/otel-media/mediaReferenceText.ts@@ -4,7 +4,7 @@ import type {MediaRestoreRequest,} from "@langfuse/native";import { asRecord, defineOwnValue } from "@langfuse/shared";-import { forEachMedia } from "@langfuse/shared/src/server";+import { forEachMedia, recordDistribution } from "@langfuse/shared/src/server";export type MediaRegistry = ReadonlyMap<string, ExtractedOtelMedia>;@@ -154,10 +154,16 @@ export function createMediaReferenceRewriter(: originals.get(replacement.key)!,),);+ const resultStartedAt = performance.now();for (const [index, match] of group.entries()) {output += value.slice(end, match.index) + values[index]!;end = match.index + match.reference.length;}+ recordDistribution(+ "langfuse.ingestion.otel.main_thread_duration_ms",+ performance.now() - resultStartedAt,+ { phase: "media_reference_results", media_path: "early" },+ );}return end === 0 ? value : output + value.slice(end);};diff --git a/worker/src/features/otel-media/resolveExtractedMedia.ts b/worker/src/features/otel-media/resolveExtractedMedia.tsindex f6b37bab0f..2c21b09df7 100644--- a/worker/src/features/otel-media/resolveExtractedMedia.ts+++ b/worker/src/features/otel-media/resolveExtractedMedia.ts@@ -51,8 +51,14 @@ async function batchMedia(batch: EarlyOtelBatch): Promise<MediaRegistry> {const count = batch.mediaCount();const media = new Map<string, ExtractedOtelMedia>();for (let offset = 0; offset < count; ) {+ const resultStartedAt = performance.now();const page = batch.mediaPage(offset, MEDIA_PAGE_SIZE);for (const entry of page) media.set(entry.reference, entry);+ recordDistribution(+ "langfuse.ingestion.otel.main_thread_duration_ms",+ performance.now() - resultStartedAt,+ { phase: "media_descriptors", media_path: "early" },+ );const nextOffset = offset + page.length;if (nextOffset <= offset)throw new Error("native media page returned no progress");