🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(datasets): encode item IDs in navigation links (#17486)
marliessophie305accd1433b
diff --git a/web/src/features/datasets/components/DatasetCompareRunsTable.tsx b/web/src/features/datasets/components/DatasetCompareRunsTable.tsxindex 5eab9b588b..217bba3473 100644--- a/web/src/features/datasets/components/DatasetCompareRunsTable.tsx+++ b/web/src/features/datasets/components/DatasetCompareRunsTable.tsx@@ -144,7 +144,7 @@ function DatasetCompareRunsTableInternal(props: {return {type: "link",props: {- path: `/project/${props.projectId}/datasets/${props.datasetId}/items/${id}`,+ path: `/project/${props.projectId}/datasets/${props.datasetId}/items/${encodeURIComponent(id)}`,value: id,},};diff --git a/web/src/features/datasets/components/DatasetItemsTable.tsx b/web/src/features/datasets/components/DatasetItemsTable.tsxindex 879187a765..c94e111c12 100644--- a/web/src/features/datasets/components/DatasetItemsTable.tsx+++ b/web/src/features/datasets/components/DatasetItemsTable.tsx@@ -167,7 +167,7 @@ export function DatasetItemsTable({return {type: "link",props: {- path: `/project/${projectId}/datasets/${datasetId}/items/${id}${versionParam}`,+ path: `/project/${projectId}/datasets/${datasetId}/items/${encodeURIComponent(id)}${versionParam}`,value: id,},};diff --git a/web/src/features/datasets/components/DatasetRunItemsByRunTable.tsx b/web/src/features/datasets/components/DatasetRunItemsByRunTable.tsxindex 801a3de7f7..ef81b46b2e 100644--- a/web/src/features/datasets/components/DatasetRunItemsByRunTable.tsx+++ b/web/src/features/datasets/components/DatasetRunItemsByRunTable.tsx@@ -115,7 +115,7 @@ export function DatasetRunItemsByRunTable(props: {return {type: "link",props: {- path: `/project/${projectId}/datasets/${datasetId}/items/${datasetItemId}${versionParam}`,+ path: `/project/${projectId}/datasets/${datasetId}/items/${encodeURIComponent(datasetItemId)}${versionParam}`,value: datasetItemId,},};diff --git a/web/src/features/datasets/components/DatasetSchemaValidationError.tsx b/web/src/features/datasets/components/DatasetSchemaValidationError.tsxindex 57fd08bc08..277b14ac11 100644--- a/web/src/features/datasets/components/DatasetSchemaValidationError.tsx+++ b/web/src/features/datasets/components/DatasetSchemaValidationError.tsx@@ -68,7 +68,7 @@ export const DatasetSchemaValidationError: React.FC<#{idx + 1}</span><Link- href={`/project/${projectId}/datasets/${datasetId}/items/${error.datasetItemId}`}+ href={`/project/${projectId}/datasets/${datasetId}/items/${encodeURIComponent(error.datasetItemId)}`}target="_blank"rel="noopener noreferrer"className="flex items-center gap-1 text-sm font-bold hover:underline"diff --git a/web/src/features/datasets/components/ExistingDatasetItemsDropdownMenuController.tsx b/web/src/features/datasets/components/ExistingDatasetItemsDropdownMenuController.tsxindex 229cdb9542..912739dfe7 100644--- a/web/src/features/datasets/components/ExistingDatasetItemsDropdownMenuController.tsx+++ b/web/src/features/datasets/components/ExistingDatasetItemsDropdownMenuController.tsx@@ -123,7 +123,7 @@ export function ExistingDatasetItemsDropdownMenuController(props: {asChild><Link- href={`/project/${props.projectId}/datasets/${datasetId}/items/${datasetItemId}`}+ href={`/project/${props.projectId}/datasets/${datasetId}/items/${encodeURIComponent(datasetItemId)}`}>{datasetName}</Link>diff --git a/web/src/features/navigation/utils/dataset-item-tabs.ts b/web/src/features/navigation/utils/dataset-item-tabs.tsindex de2ef37da2..574eab5e69 100644--- a/web/src/features/navigation/utils/dataset-item-tabs.ts+++ b/web/src/features/navigation/utils/dataset-item-tabs.ts@@ -18,11 +18,11 @@ export const getDatasetItemTabs = ({{value: DATASET_ITEM_TABS.ITEM,label: "Item",- href: `/project/${projectId}/datasets/${datasetId}/items/${itemId}`,+ href: `/project/${projectId}/datasets/${datasetId}/items/${encodeURIComponent(itemId)}`,},{value: DATASET_ITEM_TABS.RUNS,label: "Experiments",- href: `/project/${projectId}/datasets/${datasetId}/items/${itemId}/runs`,+ href: `/project/${projectId}/datasets/${datasetId}/items/${encodeURIComponent(itemId)}/runs`,},];diff --git a/web/src/pages/project/[projectId]/datasets/[datasetId]/items/[itemId]/runs.tsx b/web/src/pages/project/[projectId]/datasets/[datasetId]/items/[itemId]/runs.tsxindex 597b956328..909aefbab2 100644--- a/web/src/pages/project/[projectId]/datasets/[datasetId]/items/[itemId]/runs.tsx+++ b/web/src/pages/project/[projectId]/datasets/[datasetId]/items/[itemId]/runs.tsx@@ -39,7 +39,7 @@ function DatasetItemRuns({useEffect(() => {if (isInitializing || !isExperimentsBetaActive || !projectId) return;router.replace(- `/project/${projectId}/datasets/${datasetId}/items/${itemId}`,+ `/project/${projectId}/datasets/${datasetId}/items/${encodeURIComponent(itemId)}`,);}, [isExperimentsBetaActive,