🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
refactor(web): move scores table into features/scores and break peek cycle (#17422)
Nikita Kabardin31e522886cca
diff --git a/web/src/components/table/peek/peek-trace-detail.tsx b/web/src/components/table/peek/peek-trace-detail.tsxindex 047e669649..8c9251373f 100644--- a/web/src/components/table/peek/peek-trace-detail.tsx+++ b/web/src/components/table/peek/peek-trace-detail.tsx@@ -1,11 +1,9 @@import { usePeekData } from "@/src/components/table/peek/hooks/usePeekData";import { useRouter } from "next/router";import { useRef } from "react";-import {- TraceDetailActions,- TraceDetailBody,- traceDetailTitle,-} from "@/src/features/traces";+import { TraceDetailActions } from "@/src/features/traces/components/TraceDetailActions";+import { TraceDetailBody } from "@/src/features/traces/components/TraceDetailBody";+import { traceDetailTitle } from "@/src/features/traces/fns/traceDetailTitle";import {TablePeekView,shouldClosePeekAfterDelete,diff --git a/web/src/features/scores/README.md b/web/src/features/scores/README.mdindex 2510e863ee..faea719e2c 100644--- a/web/src/features/scores/README.md+++ b/web/src/features/scores/README.md@@ -11,7 +11,7 @@ Score rendering, annotation forms, mutations, and the project Scores search bar.numeric ranges, boolean values, and categorical values retain their existingfilter shapes. There is no independent full-text search or aggregate-scorenamespace.-- `components/table/use-cases/scores.tsx` (under `src/`) owns data fetching,+- `ScoresTable.tsx` owns data fetching,URL/saved-view filters, and the table. Sidebar tables share the bar and passtheir filter configuration so the grammar matches their available facets.diff --git a/web/src/features/scores/ScoresPage.tsx b/web/src/features/scores/ScoresPage.tsxnew file mode 100644index 0000000000..0809170fba--- /dev/null+++ b/web/src/features/scores/ScoresPage.tsx@@ -0,0 +1,72 @@+import { useRouter } from "next/router";+import ScoresTable from "@/src/features/scores/ScoresTable";+import { TablePeekViewTraceDetail } from "@/src/components/table/peek/peek-trace-detail";+import Page from "@/src/components/layouts/page";+import { api } from "@/src/utils/api";+import { ScoresOnboarding } from "@/src/components/onboarding/ScoresOnboarding";+import {+ getScoresTabs,+ SCORES_TABS,+} from "@/src/features/navigation/utils/scores-tabs";+import { useReadPath } from "@/src/features/events/hooks/useReadPath";++export default function ScoresPage() {+ const router = useRouter();+ const projectId = router.query.projectId as string;+ const { isV4 } = useReadPath();++ // Check if the user has any scores+ const { data: hasAnyScore, isLoading } = api.scores.hasAny.useQuery(+ { projectId },+ {+ enabled: !!projectId,+ trpc: {+ context: {+ skipBatch: true,+ },+ },+ refetchInterval: 10_000,+ },+ );++ const showOnboarding = !isLoading && !hasAnyScore;++ return (+ <Page+ headerProps={{+ title: "Scores",+ help: {+ description:+ "A scores is an evaluation of a traces or observations. It can be created from user feedback, model-based evaluations, or manual review. See docs to learn more.",+ href: "https://langfuse.com/docs/evaluation/overview",+ },+ tabsProps: {+ tabs: getScoresTabs(projectId),+ activeTab: SCORES_TABS.SCORES,+ },+ }}+ scrollable={showOnboarding}+ >+ {/* Show onboarding screen if user has no scores */}+ {showOnboarding ? (+ <ScoresOnboarding />+ ) : (+ <ScoresTable+ projectId={projectId}+ showControlsInPageHeader+ showAllEnvironments={router.query.showAllEnvironments === "true"}+ renderTracePeek={({ closePeek, expandPeek }) => (+ <TablePeekViewTraceDetail+ projectId={projectId}+ itemType="TRACE"+ tableName="scores"+ closePeek={closePeek}+ expandPeek={expandPeek}+ isV4={isV4}+ />+ )}+ />+ )}+ </Page>+ );+}diff --git a/web/src/components/table/use-cases/scores.tsx b/web/src/features/scores/ScoresTable.tsxsimilarity index 98%rename from web/src/components/table/use-cases/scores.tsxrename to web/src/features/scores/ScoresTable.tsxindex 9f13304909..d358e03b65 100644--- a/web/src/components/table/use-cases/scores.tsx+++ b/web/src/features/scores/ScoresTable.tsx@@ -24,7 +24,6 @@ import {} from "@/src/features/filters/hooks/useSidebarFilterState";import { usePeekTableState } from "@/src/components/table/peek/contexts/PeekTableStateContext";import { usePeekNavigation } from "@/src/components/table/peek/hooks/usePeekNavigation";-import { TablePeekViewTraceDetail } from "@/src/components/table/peek/peek-trace-detail";import {getScoreFilterConfig,observationScopeFilter,@@ -60,7 +59,13 @@ import useColumnOrder from "@/src/features/column-visibility/hooks/useColumnOrdeimport { BatchExportTableButton } from "@/src/components/BatchExportTableButton";import { showSuccessToast } from "@/src/features/notifications/showSuccessToast";import { TableActionMenu } from "@/src/features/table/components/TableActionMenu";-import React, { useState, useRef, useCallback, useMemo } from "react";+import React, {+ type ReactNode,+ useState,+ useRef,+ useCallback,+ useMemo,+} from "react";import type { TableAction } from "@/src/features/table/types";import type { RowSelectionState } from "@tanstack/react-table";import { useHasEntitlement } from "@/src/features/entitlements/hooks";@@ -136,6 +141,11 @@ export type ScoresTableProps = {showControlsInPageHeader?: boolean;/** Skip the default exclusion of internal environments. */showAllEnvironments?: boolean;+ /** Page-owned peek panel; omit when embedded inside a trace/observation view. */+ renderTracePeek?: (api: {+ closePeek: () => void;+ expandPeek: (openInNewTab: boolean) => void;+ }) => ReactNode;};function createFilterState(@@ -165,6 +175,7 @@ export default function ScoresTable({disableUrlPersistence = false,showControlsInPageHeader = false,showAllEnvironments = false,+ renderTracePeek,}: ScoresTableProps) {const peekContext = usePeekTableState();const hasBatchExportAccess = useHasProjectAccess({@@ -1284,16 +1295,11 @@ export default function ScoresTable({)}</div></ResizableFilterLayout>- {peekEnabled && (- <TablePeekViewTraceDetail- closePeek={closeScorePeek}- expandPeek={expandScorePeek}- itemType="TRACE"- tableName={scoresFilterConfig.tableName}- isV4={isV4}- projectId={projectId}- />- )}+ {peekEnabled &&+ renderTracePeek?.({+ closePeek: closeScorePeek,+ expandPeek: expandScorePeek,+ })}</div></DataTableControlsProvider>);diff --git a/web/src/features/scores/index.ts b/web/src/features/scores/index.tsindex ab43494e15..4e4661169f 100644--- a/web/src/features/scores/index.ts+++ b/web/src/features/scores/index.ts@@ -59,3 +59,5 @@ export type {ScoreData,ScoreTarget,} from "@/src/features/scores/types";++export { default as ScoresTable } from "@/src/features/scores/ScoresTable";diff --git a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsxindex 2f476ad861..e88801115f 100644--- a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx+++ b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx@@ -44,7 +44,7 @@ import {getCommentDrawerInitialStateFromUrl,} from "@/src/features/comments/CommentDrawerController";import { useRouter } from "next/router";-import ScoresTable from "@/src/components/table/use-cases/scores";+import ScoresTable from "@/src/features/scores/ScoresTable";import { getMostRecentCorrection } from "@/src/features/corrections/utils/getMostRecentCorrection";import { useJsonExpansion } from "@/src/features/traces/contexts/JsonExpansionContext";import { useMedia } from "@/src/features/traces/hooks/useMedia";diff --git a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsxindex e585cef125..07eded787f 100644--- a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx+++ b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx@@ -61,7 +61,7 @@ import { useSession } from "next-auth/react";import { TraceDetailViewHeader } from "./components/TraceDetailViewHeader";import { TraceLogView } from "../TraceLogView/TraceLogView";import { TRACE_VIEW_CONFIG } from "@/src/features/traces/constants/traceViewConfig";-import ScoresTable from "@/src/components/table/use-cases/scores";+import ScoresTable from "@/src/features/scores/ScoresTable";import { getMostRecentCorrection } from "@/src/features/corrections/utils/getMostRecentCorrection";export interface TraceDetailViewProps {diff --git a/web/src/features/users/UserDetailPage.tsx b/web/src/features/users/UserDetailPage.tsxindex 47eaf947ef..a5ef715dcb 100644--- a/web/src/features/users/UserDetailPage.tsx+++ b/web/src/features/users/UserDetailPage.tsx@@ -6,7 +6,8 @@ import {useReadyRouteParams,} from "@/src/hooks/useReadyRouteParams";import TracesTable from "@/src/components/table/use-cases/traces";-import ScoresTable from "@/src/components/table/use-cases/scores";+import { ScoresTable } from "@/src/features/scores";+import { TablePeekViewTraceDetail } from "@/src/components/table/peek/peek-trace-detail";import { compactNumberFormatter, usdFormatter } from "@/src/utils/numbers";import { StringParam, useQueryParam, withDefault } from "use-query-params";import { DetailPageNav } from "@/src/features/navigate-detail-pages/DetailPageNav";@@ -196,11 +197,23 @@ type TabProps = {};function ScoresTab({ userId, projectId }: TabProps) {+ const { isV4 } = useReadPath();+return (<ScoresTableprojectId={projectId}userId={userId}hiddenColumns={["userId"]}+ renderTracePeek={({ closePeek, expandPeek }) => (+ <TablePeekViewTraceDetail+ projectId={projectId}+ itemType="TRACE"+ tableName="scores"+ closePeek={closePeek}+ expandPeek={expandPeek}+ isV4={isV4}+ />+ )}/>);}diff --git a/web/src/pages/project/[projectId]/scores/index.tsx b/web/src/pages/project/[projectId]/scores/index.tsxindex 0660ce5e22..16ffa6bbc2 100644--- a/web/src/pages/project/[projectId]/scores/index.tsx+++ b/web/src/pages/project/[projectId]/scores/index.tsx@@ -1,59 +1 @@-import { useRouter } from "next/router";-import ScoresTable from "@/src/components/table/use-cases/scores";-import Page from "@/src/components/layouts/page";-import { api } from "@/src/utils/api";-import { ScoresOnboarding } from "@/src/components/onboarding/ScoresOnboarding";-import {- getScoresTabs,- SCORES_TABS,-} from "@/src/features/navigation/utils/scores-tabs";--export default function ScoresPage() {- const router = useRouter();- const projectId = router.query.projectId as string;-- // Check if the user has any scores- const { data: hasAnyScore, isLoading } = api.scores.hasAny.useQuery(- { projectId },- {- enabled: !!projectId,- trpc: {- context: {- skipBatch: true,- },- },- refetchInterval: 10_000,- },- );-- const showOnboarding = !isLoading && !hasAnyScore;-- return (- <Page- headerProps={{- title: "Scores",- help: {- description:- "A scores is an evaluation of a traces or observations. It can be created from user feedback, model-based evaluations, or manual review. See docs to learn more.",- href: "https://langfuse.com/docs/evaluation/overview",- },- tabsProps: {- tabs: getScoresTabs(projectId),- activeTab: SCORES_TABS.SCORES,- },- }}- scrollable={showOnboarding}- >- {/* Show onboarding screen if user has no scores */}- {showOnboarding ? (- <ScoresOnboarding />- ) : (- <ScoresTable- projectId={projectId}- showControlsInPageHeader- showAllEnvironments={router.query.showAllEnvironments === "true"}- />- )}- </Page>- );-}+export { default } from "@/src/features/scores/ScoresPage";