Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Fix no-null-render: evaluator-detail.tsx (#17172)

Ben Bachem323f10f96e0a
diff --git a/web/src/features/evals/components/evaluator-detail.tsx b/web/src/features/evals/components/evaluator-detail.tsx
index eceacd2052..355440300e 100644
--- a/web/src/features/evals/components/evaluator-detail.tsx
+++ b/web/src/features/evals/components/evaluator-detail.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @repo/no-null-render */
import * as React from "react";
import { api } from "@/src/utils/api";
import { useRouter } from "next/router";
@@ -11,28 +10,12 @@ import { generateJobExecutionCounts } from "@/src/features/evals/utils/job-execu
import { EvaluatorPausedCallout } from "@/src/features/evals/components/evaluator-paused-callout";
import {
type EvalTargetObject,
- type EvaluatorExecutionStatusCount,
validateEvaluatorFiltersForTarget,
} from "@langfuse/shared";
import { useLazyEvaluatorExecutionCounts } from "@/src/features/evals/hooks/useLazyEvaluatorExecutionCounts";
import { Alert } from "@/src/components/design-system/Alert/Alert";
import { AlertTriangle } from "lucide-react";
-const JobExecutionCounts = ({
- isLoading,
- jobExecutionCounts,
-}: {
- isLoading?: boolean;
- jobExecutionCounts?: EvaluatorExecutionStatusCount[];
-}) => {
- if (!isLoading && (!jobExecutionCounts || jobExecutionCounts.length === 0)) {
- return null;
- }
-
- const counts = generateJobExecutionCounts(jobExecutionCounts);
- return <LevelCountsDisplay counts={counts} isLoading={isLoading} />;
-};
-
export const EvaluatorDetail = () => {
const router = useRouter();
const projectId = router.query.projectId as string;
@@ -115,9 +98,11 @@ export const EvaluatorDetail = () => {
<>
{shouldRenderExecutionCounts && (
<div className="bg-muted-gray flex min-h-6 min-w-24 flex-col items-center justify-center rounded-md px-2">
- <JobExecutionCounts
+ <LevelCountsDisplay
+ counts={generateJobExecutionCounts(
+ lazyExecutionCounts.jobExecutionCounts,
+ )}
isLoading={lazyExecutionCounts.isLoading}
- jobExecutionCounts={lazyExecutionCounts.jobExecutionCounts}
/>
</div>
)}