🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
refactor(web): Fix no-null-render: code-eval-test-run-card.tsx (#17224)
Ben Bachem3825cb35875a
diff --git a/web/src/features/evals/components/code-eval-test-run-card.tsx b/web/src/features/evals/components/code-eval-test-run-card.tsxindex 17d6f1f011..9c9aa91f11 100644--- a/web/src/features/evals/components/code-eval-test-run-card.tsx+++ b/web/src/features/evals/components/code-eval-test-run-card.tsx@@ -1,4 +1,3 @@-/* eslint-disable @repo/no-null-render */import { CodeMirrorEditor } from "@/src/components/editor";import { TablePeekViewTraceDetail } from "@/src/components/table/peek/peek-trace-detail";import { usePeekNavigation } from "@/src/components/table/peek/hooks/usePeekNavigation";@@ -27,10 +26,6 @@ import { useMemo } from "react";import { toast } from "sonner";import { type EvalFormType } from "@/src/features/evals/utils/evaluator-form-utils";-import {- isEventTarget,- isExperimentTarget,-} from "@/src/features/evals/utils/typeHelpers";type CodeEvalTestRunResult =| RouterOutputs["evals"]["testRunCodeEval"]@@ -44,32 +39,20 @@ type CodeEvalInputPreviewData = Extract<{ type: typeof EvalTargetObject.EVENT }>;-function isCodeEvalTestTarget(- target: EvalFormType["target"],-): target is- | typeof EvalTargetObject.EVENT- | typeof EvalTargetObject.EXPERIMENT {- return isEventTarget(target) || isExperimentTarget(target);-}-export function CodeEvalTestRunCard({projectId,evalTemplate,target,scoreName,- disabled = false,enableExecutionTracePeek = true,}: {projectId: string;evalTemplate: EvalTemplate;- target: EvalFormType["target"];+ target: typeof EvalTargetObject.EVENT | typeof EvalTargetObject.EXPERIMENT;scoreName: EvalFormType["scoreName"];- disabled?: boolean;enableExecutionTracePeek?: boolean;}) {const { isV4 } = useReadPath();- const isSupportedTarget = isCodeEvalTestTarget(target);- const canPreview = isSupportedTarget && !disabled;const previewPointer = useFirstEvalPreviewPointer({target,useEventsTable: isV4,@@ -96,7 +79,7 @@ export function CodeEvalTestRunCard({const { previewData, isLoading } = usePreviewData({projectId,- enabled: canPreview && Boolean(previewPointer),+ enabled: Boolean(previewPointer),target,traceId: previewPointer?.traceId,observationId: previewPointer?.observationId,@@ -117,8 +100,6 @@ export function CodeEvalTestRunCard({},});- if (!isSupportedTarget || !canPreview) return null;-return (<><Card className="flex min-w-0 flex-col gap-4 p-4">diff --git a/web/src/features/evals/components/inner-evaluator-form.tsx b/web/src/features/evals/components/inner-evaluator-form.tsxindex c55f30bab8..33531372d0 100644--- a/web/src/features/evals/components/inner-evaluator-form.tsx+++ b/web/src/features/evals/components/inner-evaluator-form.tsx@@ -1363,9 +1363,12 @@ export const InnerEvaluatorForm = (props: {<CodeEvalTestRunCardprojectId={props.projectId}evalTemplate={props.evalTemplate}- target={watchedTarget}+ target={+ isEventTarget(watchedTarget)+ ? EvalTargetObject.EVENT+ : EvalTargetObject.EXPERIMENT+ }scoreName={watchedScoreName}- disabled={props.disabled}enableExecutionTracePeek={!props.existingEvaluator}/>) : isCodeEvalConfig ? null : (