🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(sessions): Persist transcript source setting (#19265)
Ben Bachem3923301ed0c5
diff --git a/web/src/features/sessions/ModernSession.clienttest.tsx b/web/src/features/sessions/ModernSession.clienttest.tsxindex 867b51b1c0..3852e07129 100644--- a/web/src/features/sessions/ModernSession.clienttest.tsx+++ b/web/src/features/sessions/ModernSession.clienttest.tsx@@ -11,7 +11,11 @@ vi.mock("@/src/features/sessions/ConnectedModernSessionBodyLegacy", () => ({vi.mock("@/src/features/sessions/components/ConnectedModernSessionBodyTimeline/ConnectedModernSessionBodyTimeline",() => ({- ConnectedModernSessionBodyTimeline: () => <div>Timeline body</div>,+ ConnectedModernSessionBodyTimeline: ({+ transcriptSource,+ }: Pick<ComponentProps<typeof ModernSession>, "transcriptSource">) => (+ <div data-source={transcriptSource}>Timeline body</div>+ ),}),);@@ -50,6 +54,7 @@ vi.mock("@/src/features/sessions/SessionMetadataJsonPathControl", () => ({const defaultProps = {isTimelineEnabled: false,+ transcriptSource: "generations",session: {countTraces: 0,inputUsage: 0,@@ -98,6 +103,24 @@ const defaultProps = {} satisfies ComponentProps<typeof ModernSession>;describe("ModernSession", () => {+ it.each(["root", "generations"] as const)(+ "passes the resolved %s transcript source to the timeline",+ (transcriptSource) => {+ render(+ <ModernSession+ {...defaultProps}+ isTimelineEnabled+ transcriptSource={transcriptSource}+ />,+ );++ expect(screen.getByText("Timeline body")).toHaveAttribute(+ "data-source",+ transcriptSource,+ );+ },+ );+it("renders the shared header and legacy connected body by default", () => {render(<ModernSession {...defaultProps} />);diff --git a/web/src/features/sessions/ModernSession.tsx b/web/src/features/sessions/ModernSession.tsxindex 9d8a51276c..1203c16875 100644--- a/web/src/features/sessions/ModernSession.tsx+++ b/web/src/features/sessions/ModernSession.tsx@@ -15,6 +15,9 @@ import {type ModernSessionProps = {headerDividerTone?: ComponentProps<typeof ModernSessionHeader>["dividerTone"];isTimelineEnabled: boolean;+ transcriptSource: ComponentProps<+ typeof ConnectedModernSessionBodyTimeline+ >["transcriptSource"];session: Pick<EventSession,| "countTraces"@@ -52,6 +55,7 @@ type ModernSessionProps = {export function ModernSession({headerDividerTone,isTimelineEnabled,+ transcriptSource,session,tracesState,projectId,@@ -113,6 +117,7 @@ export function ModernSession({</SessionMetadataJsonPathControl>{isTimelineEnabled ? (<ConnectedModernSessionBodyTimeline+ transcriptSource={transcriptSource}tracesState={tracesState}projectId={projectId}sessionId={sessionId}diff --git a/web/src/features/sessions/SessionPages.tsx b/web/src/features/sessions/SessionPages.tsxindex 53df1d9c24..fc07a9142c 100644--- a/web/src/features/sessions/SessionPages.tsx+++ b/web/src/features/sessions/SessionPages.tsx@@ -121,7 +121,10 @@ import { SessionRedesignBanner } from "@/src/features/sessions/SessionRedesignBaimport { HeaderActionMenuRow } from "@/src/components/HeaderActionMenuRow";import { ModernSessionHeaderActionsController } from "@/src/features/sessions/ModernSessionHeaderActionsController";import { ConnectedSessionAddToDropdownMenuController } from "@/src/features/sessions/ConnectedSessionAddToDropdownMenuController";-import { useIsFeatureEnabled } from "@/src/features/feature-flags";+import {+ useInternalFeaturesEnabled,+ useIsFeatureEnabled,+} from "@/src/features/feature-flags";import { useIsMobile } from "@/src/hooks/use-mobile";import { useStore } from "zustand";import { TraceReviewPanelProvider } from "@/src/features/traces/contexts/TraceReviewPanelProvider";@@ -1129,6 +1132,7 @@ function SessionEventsLoadingPage({</div></SessionReviewLeading><ConnectedModernSessionBodyTimeline+ transcriptSource="generations"tracesState={{ type: "loading" }}projectId={projectId}sessionId={sessionId}@@ -1323,10 +1327,23 @@ const LoadedSessionEventsPage: React.FC<{};}, [positionInTraceColumn, sessionEventsTableName]);const [urlFiltersQuery] = useQueryParam("filter", StringParam);- const [transcriptSource, setTranscriptSource] = useQueryParam(+ const [urlTranscriptSource, setUrlTranscriptSource] = useQueryParam("transcriptSource",StringParam,);+ const [storedTranscriptSource, setStoredTranscriptSource] = useLocalStorage<+ "root" | "generations"+ >("sessionTranscriptSource", "generations");+ const internalFeaturesEnabled = useInternalFeaturesEnabled();+ const transcriptSource =+ internalFeaturesEnabled &&+ (urlTranscriptSource ?? storedTranscriptSource) === "root"+ ? "root"+ : "generations";+ const setTranscriptSource = (source: typeof storedTranscriptSource) => {+ setStoredTranscriptSource(source);+ setUrlTranscriptSource(source);+ };const filtersQuery = React.useMemo(() =>urlFiltersQuery ??@@ -2216,6 +2233,7 @@ const LoadedSessionEventsPage: React.FC<{</div>) : (<ModernSession+ transcriptSource={transcriptSource}headerDividerTone={showRedesignBanner ? "orange" : "default"}isTimelineEnabled={isSessionTimelineEnabled}session={session}diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/ConnectedModernSessionBodyTimeline.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/ConnectedModernSessionBodyTimeline.tsxindex 3b7bca1b10..e1ca392806 100644--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/ConnectedModernSessionBodyTimeline.tsx+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/ConnectedModernSessionBodyTimeline.tsx@@ -1,6 +1,4 @@import { useRef, useState } from "react";-import { StringParam, useQueryParam } from "use-query-params";-import { useInternalFeaturesEnabled } from "@/src/features/feature-flags";import {ConnectedSessionConversationTimeline,@@ -22,6 +20,7 @@ const EMPTY_TRACES: EventSessionTrace[] = [];type OpenPeek = (id: string, row: EventSessionTrace) => void;type ConnectedModernSessionBodyTimelineProps = {+ transcriptSource: "root" | "generations";tracesState:| { type: "loading" }| { type: "loaded"; traces: EventSessionTrace[] };@@ -31,20 +30,12 @@ type ConnectedModernSessionBodyTimelineProps = {};export function ConnectedModernSessionBodyTimeline({+ transcriptSource,tracesState,projectId,sessionId,openPeek,}: ConnectedModernSessionBodyTimelineProps) {- const [transcriptSourceParam] = useQueryParam(- "transcriptSource",- StringParam,- );- const internalFeaturesEnabled = useInternalFeaturesEnabled();- const transcriptSource =- internalFeaturesEnabled && transcriptSourceParam === "root"- ? "root"- : "generations";const traces =tracesState.type === "loaded" ? tracesState.traces : EMPTY_TRACES;const [timelineVisibleTraceIds, setTimelineVisibleTraceIds] = useState<