Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Continue ID table column standardization (#16848)

Ben Bachem3b0a8a049aac
diff --git a/web/src/components/design-system/table/columns/createIdTableColumn.stories.tsx b/web/src/components/design-system/table/columns/createIdTableColumn.stories.tsx
index 49cdf5893c..1bd599c678 100644
--- a/web/src/components/design-system/table/columns/createIdTableColumn.stories.tsx
+++ b/web/src/components/design-system/table/columns/createIdTableColumn.stories.tsx
@@ -7,18 +7,33 @@ import {
import { createIdTableColumn } from "./createIdTableColumn";
type Row = {
+ promptVersion?: number;
traceId: string | null;
};
-const columns = [
- createIdTableColumn<Row>({
- id: "traceId",
- accessorFn: (row) => row.traceId,
- header: "ID",
- }),
-];
+function IdTableColumnStory({
+ data,
+ emptyValue,
+ getValue,
+}: {
+ data: AsyncTableData<Row[]>;
+ emptyValue?: string;
+ getValue?: boolean;
+}) {
+ const columns = [
+ createIdTableColumn<Row>({
+ accessorKey: "traceId",
+ header: "ID",
+ emptyValue,
+ getValue: getValue
+ ? (value, { row }) =>
+ value && row.original.promptVersion
+ ? `${value} (v${row.original.promptVersion})`
+ : undefined
+ : undefined,
+ }),
+ ];
-function IdTableColumnStory({ data }: { data: AsyncTableData<Row[]> }) {
return (
<DataTable
tableName="id-column-story"
@@ -58,6 +73,30 @@ export const EmptyValue = meta.story({
},
});
+export const EmptyPlaceholder = meta.story({
+ name: "Empty Placeholder",
+ args: {
+ emptyValue: "-",
+ data: {
+ isLoading: false,
+ isError: false,
+ data: [{ traceId: null }],
+ },
+ },
+});
+
+export const DerivedValue = meta.story({
+ name: "Derived Value",
+ args: {
+ getValue: true,
+ data: {
+ isLoading: false,
+ isError: false,
+ data: [{ traceId: "prompt-name", promptVersion: 2 }],
+ },
+ },
+});
+
export const Loading = meta.story({
args: {
data: {
diff --git a/web/src/components/design-system/table/columns/createIdTableColumn.tsx b/web/src/components/design-system/table/columns/createIdTableColumn.tsx
index be2171b8bd..1f6b1fedd7 100644
--- a/web/src/components/design-system/table/columns/createIdTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createIdTableColumn.tsx
@@ -1,7 +1,7 @@
/* eslint-disable boundaries/dependencies */
-import { type RowData } from "@tanstack/react-table";
+import { type CellContext, type RowData } from "@tanstack/react-table";
-import TableIdOrName from "@/src/components/table/table-id";
+import { IdTableCell } from "@/src/components/design-system/table/components/IdTableCell/IdTableCell";
import { Skeleton } from "@/src/components/ui/skeleton";
import {
createTableColumn,
@@ -9,11 +9,24 @@ import {
} from "./utils/createTableColumn";
export function createIdTableColumn<TData extends RowData>(
- options: TableColumnOptions<TData, string>,
+ options: TableColumnOptions<TData, string> & {
+ emptyValue?: string;
+ getValue?: (
+ value: string | null | undefined,
+ context: CellContext<TData, string | null | undefined>,
+ ) => string | undefined;
+ },
) {
+ const { emptyValue, getValue } = options;
+
return createTableColumn<TData, string>({
...options,
loadingCell: <Skeleton className="h-4 w-1/2" />,
- renderCell: (value) => (value ? <TableIdOrName value={value} /> : null),
+ renderCell: (value, context) => {
+ const resolvedValue = getValue ? getValue(value, context) : value;
+ const displayValue = resolvedValue || emptyValue;
+
+ return displayValue ? <IdTableCell value={displayValue} /> : null;
+ },
});
}
diff --git a/web/src/components/design-system/table/components/IdTableCell/IdTableCell.tsx b/web/src/components/design-system/table/components/IdTableCell/IdTableCell.tsx
new file mode 100644
index 0000000000..a7ad4b0297
--- /dev/null
+++ b/web/src/components/design-system/table/components/IdTableCell/IdTableCell.tsx
@@ -0,0 +1,10 @@
+export function IdTableCell({ value }: { value: string }) {
+ return (
+ <div
+ title={value}
+ className="inline-block max-w-full overflow-hidden rounded py-0.5 text-xs text-nowrap text-ellipsis"
+ >
+ {value}
+ </div>
+ );
+}
diff --git a/web/src/components/table/DataTable.stories.tsx b/web/src/components/table/DataTable.stories.tsx
index 952b409ccb..f552fb7111 100644
--- a/web/src/components/table/DataTable.stories.tsx
+++ b/web/src/components/table/DataTable.stories.tsx
@@ -29,7 +29,7 @@ import { createDropdownTableColumn } from "@/src/components/design-system/table/
import { createTokenUsageTableColumn } from "@/src/components/design-system/table/columns/createTokenUsageTableColumn";
import { Skeleton } from "@/src/components/ui/skeleton";
import { TextLink } from "@/src/components/design-system/TextLink/TextLink";
-import TableIdOrName from "@/src/components/table/table-id";
+import { IdTableCell } from "@/src/components/design-system/table/components/IdTableCell/IdTableCell";
import {
buildLocalIsoDatePresentation,
formatIntervalSeconds,
@@ -85,7 +85,7 @@ const renderMediaReference = (descriptor: MediaDescriptor) => (
// instead of TagPromptPopover/TagManager (same visible children).
// - actions: createDropdownTableColumn (ghost MoreVertical trigger), with a
// plain menu item instead of the tRPC-bound DeleteTraceButton.
-// Everything else (TextLink, Badge, IOTableCell, LocalIsoDate, TableIdOrName,
+// Everything else (TextLink, Badge, IOTableCell, LocalIsoDate, IdTableCell,
// createTokenUsageTableColumn, LevelCountsDisplay, folder links, Skeleton, the
// loading cells) is the actual production component.
//
@@ -419,19 +419,14 @@ function buildTraceColumns(
singleLine,
enableExpandOnHover: singleLine,
}),
- {
+ createIdTableColumn<TraceRow>({
accessorKey: "userId",
header: "User",
- id: "userId",
size: 150,
// Default-hidden in the real table; seeds the Columns drawer unchecked.
defaultHidden: true,
- cell: ({ row }) => {
- const value = row.original.userId;
- return value ? <TableIdOrName value={value} /> : undefined;
- },
enableSorting: true,
- },
+ }),
createIdTableColumn<TraceRow>({
accessorKey: "id",
header: "Trace ID",
@@ -1333,8 +1328,8 @@ export const WithFolderRows = meta.story({
// "Provided Model Name" create-affordance, ListTree source links, folder rows).
// They must NOT shift the text baseline relative to plain rows. This story puts
// every variant in one column so any vertical-alignment regression is obvious:
-// - plain TableIdOrName (no icon)
-// - TableIdOrName + trailing PlusCircle — mirrors features/models
+// - plain IdTableCell (no icon)
+// - IdTableCell + trailing PlusCircle — mirrors features/models
// ProvidedModelNameCell: the name is wrapped in `inline-flex items-center`
// with the icon as a `shrink-0` adornment, so it lands on the same baseline
// as the no-icon rows.
@@ -1384,14 +1379,14 @@ const iconCellColumns: LangfuseColumnDef<IconCellRow>[] = [
const { name, kind } = row.original;
switch (kind) {
case "createModel":
- // Faithful to ProvidedModelNameCell: same TableIdOrName + trailing
+ // Faithful to ProvidedModelNameCell: same IdTableCell + trailing
// icon, in a native <button> trigger (keyboard-activatable).
return (
<button
type="button"
- className="inline-flex max-w-full cursor-pointer items-center gap-1 text-left"
+ className="inline-flex max-w-full min-w-0 cursor-pointer items-center gap-1 text-left"
>
- <TableIdOrName value={name} className="min-w-0" />
+ <IdTableCell value={name} />
<PlusCircle className="h-3.5 w-3.5 shrink-0" />
</button>
);
@@ -1412,8 +1407,8 @@ const iconCellColumns: LangfuseColumnDef<IconCellRow>[] = [
case "plain":
default:
return (
- <span className="inline-flex max-w-full items-center">
- <TableIdOrName value={name} className="min-w-0" />
+ <span className="inline-flex max-w-full min-w-0 items-center">
+ <IdTableCell value={name} />
</span>
);
}
diff --git a/web/src/components/table/table-id.tsx b/web/src/components/table/table-id.tsx
deleted file mode 100644
index ee617208b5..0000000000
--- a/web/src/components/table/table-id.tsx
+++ /dev/null
@@ -1,22 +0,0 @@
-/* eslint-disable @repo/no-style-props */
-import { cn } from "@/src/utils/tailwind";
-
-export default function TableIdOrName({
- value,
- className,
-}: {
- value: string;
- className?: string;
-}) {
- return (
- <div
- title={value}
- className={cn(
- "inline-block max-w-full overflow-hidden rounded py-0.5 text-xs text-nowrap text-ellipsis",
- className,
- )}
- >
- {value}
- </div>
- );
-}
diff --git a/web/src/components/table/use-cases/observations.tsx b/web/src/components/table/use-cases/observations.tsx
index ca5ee35e18..4140117e16 100644
--- a/web/src/components/table/use-cases/observations.tsx
+++ b/web/src/components/table/use-cases/observations.tsx
@@ -74,7 +74,6 @@ import {
} from "@/src/features/traces";
import { InfoIcon } from "lucide-react";
import { ProvidedModelNameCell } from "@/src/features/models/components/ProvidedModelNameCell";
-import TableIdOrName from "@/src/components/table/table-id";
import { createBadgeTableColumn } from "@/src/components/design-system/table/columns/createBadgeTableColumn";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
@@ -927,9 +926,8 @@ export default function ObservationsTable({
);
},
},
- {
+ createIdTableColumn<ObservationsTableRow>({
accessorKey: "promptName",
- id: "promptName",
header: "Prompt",
headerTooltip: {
description: "Link to prompt version in Langfuse prompt management.",
@@ -938,13 +936,14 @@ export default function ObservationsTable({
size: 200,
enableHiding: true,
enableSorting,
- cell: ({ row }) => {
+ getValue: (_value, { row }) => {
const promptName = row.original.promptName;
const promptVersion = row.original.promptVersion;
- const value = `${promptName} (v${promptVersion})`;
- return promptName && promptVersion && <TableIdOrName value={value} />;
+ return promptName && promptVersion
+ ? `${promptName} (v${promptVersion})`
+ : undefined;
},
- },
+ }),
createBadgeTableColumn<ObservationsTableRow>({
accessorKey: "environment",
header: "Environment",
@@ -1004,23 +1003,20 @@ export default function ObservationsTable({
enableSorting,
defaultHidden: true,
}),
- {
+ createIdTableColumn<ObservationsTableRow>({
accessorKey: "id",
- id: "id",
header: "ObservationID",
size: 100,
defaultHidden: true,
enableSorting,
enableHiding: true,
- cell: ({ row }) => {
- const observationId = row.getValue("id");
+ getValue: (observationId, { row }) => {
const traceId = row.getValue("traceId");
- return typeof observationId === "string" &&
- typeof traceId === "string" ? (
- <TableIdOrName value={observationId} />
- ) : null;
+ return typeof observationId === "string" && typeof traceId === "string"
+ ? observationId
+ : undefined;
},
- },
+ }),
createTextTableColumn<ObservationsTableRow>({
accessorKey: "traceName",
header: "Trace Name",
diff --git a/web/src/components/table/use-cases/scores.tsx b/web/src/components/table/use-cases/scores.tsx
index 36f4a3c41b..13fc6e1bdc 100644
--- a/web/src/components/table/use-cases/scores.tsx
+++ b/web/src/components/table/use-cases/scores.tsx
@@ -64,7 +64,7 @@ import { useHasEntitlement } from "@/src/features/entitlements/hooks";
import { useSelectAll } from "@/src/features/table/hooks/useSelectAll";
import { TableSelectionManager } from "@/src/features/table/components/TableSelectionManager";
import { useTableViewManager } from "@/src/components/table/table-view-presets/hooks/useTableViewManager";
-import TableIdOrName from "@/src/components/table/table-id";
+import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
import { usePaginationState } from "@/src/hooks/usePaginationState";
import { useV4Beta } from "@/src/features/events/hooks/useV4Beta";
import {
@@ -577,22 +577,15 @@ export default function ScoresTable({
const rawColumns: LangfuseColumnDef<ScoresTableRow>[] = [
selectActionColumn,
- {
+ createIdTableColumn<ScoresTableRow>({
accessorKey: "id",
- id: "id",
enableColumnFilter: false,
header: "Score ID",
size: 100,
enableSorting: false,
defaultHidden: true,
enableHiding: true,
- cell: ({ row }) => {
- const value = row.getValue("id");
- return typeof value === "string" ? (
- <TableIdOrName value={value} />
- ) : undefined;
- },
- },
+ }),
createDateTableColumn<ScoresTableRow>({
accessorKey: "timestamp",
header: "Timestamp",
diff --git a/web/src/components/table/use-cases/traces.tsx b/web/src/components/table/use-cases/traces.tsx
index d8763f8225..40ebbb4722 100644
--- a/web/src/components/table/use-cases/traces.tsx
+++ b/web/src/components/table/use-cases/traces.tsx
@@ -8,6 +8,7 @@ import { Skeleton } from "@/src/components/ui/skeleton";
import { createBadgeTableColumn } from "@/src/components/design-system/table/columns/createBadgeTableColumn";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createDropdownTableColumn } from "@/src/components/design-system/table/columns/createDropdownTableColumn";
+import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
import { createTagsTableColumn } from "@/src/components/design-system/table/columns/createTagsTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
@@ -79,7 +80,6 @@ import {
type LevelCount,
} from "@/src/components/level-counts-display";
import { DropdownMenuItem } from "@/src/components/ui/dropdown-menu";
-import TableIdOrName from "@/src/components/table/table-id";
import {
type UseSidebarFilterStateOptions,
useSidebarFilterState,
@@ -914,10 +914,9 @@ export default function TracesTable({
columns: scoreColumns,
},
]),
- {
+ createIdTableColumn<TracesTableRow>({
accessorKey: "sessionId",
enableColumnFilter: !omittedFilter.includes("sessionId"),
- id: "sessionId",
header: "Session",
size: 150,
headerTooltip: {
@@ -939,20 +938,13 @@ export default function TracesTable({
),
href: "https://langfuse.com/docs/observability/features/sessions",
},
- cell: ({ row }) => {
- const value: TracesTableRow["sessionId"] = row.getValue("sessionId");
- return value && typeof value === "string" ? (
- <TableIdOrName value={value} />
- ) : undefined;
- },
defaultHidden: true,
enableHiding: true,
enableSorting,
- },
- {
+ }),
+ createIdTableColumn<TracesTableRow>({
accessorKey: "userId",
header: "User",
- id: "userId",
size: 150,
headerTooltip: {
description: (
@@ -973,16 +965,10 @@ export default function TracesTable({
),
href: "https://langfuse.com/docs/observability/features/users",
},
- cell: ({ row }) => {
- const value: TracesTableRow["userId"] = row.getValue("userId");
- return value && typeof value === "string" ? (
- <TableIdOrName value={value} />
- ) : undefined;
- },
defaultHidden: true,
enableHiding: true,
enableSorting,
- },
+ }),
createNumberTableColumn<TracesTableRow, bigint>({
accessorKey: "observationCount",
header: "Observations",
@@ -1080,22 +1066,14 @@ export default function TracesTable({
enableHiding: true,
enableSorting,
},
- {
+ createIdTableColumn<TracesTableRow>({
accessorKey: "id",
header: "Trace ID",
- id: "id",
size: 90,
- cell: ({ row }) => {
- const value: TracesTableRow["id"] = row.getValue("id");
-
- return value && typeof value === "string" ? (
- <TableIdOrName value={value} />
- ) : undefined;
- },
defaultHidden: true,
enableHiding: true,
enableSorting,
- },
+ }),
{
accessorKey: "cost",
header: "Cost",
diff --git a/web/src/features/datasets/components/DatasetRunItemsByItemTable.tsx b/web/src/features/datasets/components/DatasetRunItemsByItemTable.tsx
index 03bbbcb09a..c5fce63ba9 100644
--- a/web/src/features/datasets/components/DatasetRunItemsByItemTable.tsx
+++ b/web/src/features/datasets/components/DatasetRunItemsByItemTable.tsx
@@ -13,9 +13,9 @@ import { ListTree } from "lucide-react";
import { useScoreColumns } from "@/src/features/scores/hooks/useScoreColumns";
import useColumnOrder from "@/src/features/column-visibility/hooks/useColumnOrder";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
+import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
import { Skeleton } from "@/src/components/ui/skeleton";
import { scoreFilters } from "@/src/features/scores/lib/scoreColumns";
-import TableIdOrName from "@/src/components/table/table-id";
import { convertRunItemToItemsByItemUiTableRow } from "@/src/features/datasets/lib/convertRunItemDataToUiTableRow";
import {
DatasetItemIOCell,
@@ -65,18 +65,13 @@ export function DatasetRunItemsByItemTable(props: {
});
const columns: LangfuseColumnDef<DatasetRunItemByItemRowData>[] = [
- {
+ createIdTableColumn<DatasetRunItemByItemRowData>({
accessorKey: "datasetRunName",
header: "Run Name",
- id: "datasetRunName",
size: 150,
isPinnedLeft: true,
- cell: ({ row }) => {
- const datasetRunName: string | undefined =
- row.getValue("datasetRunName");
- return <TableIdOrName value={datasetRunName || "-"} />;
- },
- },
+ emptyValue: "-",
+ }),
createDateTableColumn<DatasetRunItemByItemRowData>({
accessorKey: "runAt",
header: "Run At",
diff --git a/web/src/features/evals/components/eval-templates-table.tsx b/web/src/features/evals/components/eval-templates-table.tsx
index 9a75d59fa2..936d569688 100644
--- a/web/src/features/evals/components/eval-templates-table.tsx
+++ b/web/src/features/evals/components/eval-templates-table.tsx
@@ -10,7 +10,6 @@ import { Copy, MoreVertical, Pen, Trash } from "lucide-react";
import { useQueryParam, StringParam, withDefault } from "use-query-params";
import { useEffect, useMemo, useState } from "react";
import { usePaginationState } from "@/src/hooks/usePaginationState";
-import TableIdOrName from "@/src/components/table/table-id";
import { TablePeekViewEvaluatorTemplateDetail } from "@/src/components/table/peek/peek-evaluator-template-detail";
import { usePeekNavigation } from "@/src/components/table/peek/hooks/usePeekNavigation";
import { useDetailPageLists } from "@/src/features/navigate-detail-pages/context";
@@ -56,6 +55,7 @@ import {
} from "@/src/features/evals/utils/code-eval-template-utils";
import { SiPython, SiTypescript } from "react-icons/si";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
+import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
export type EvalsTemplateRow = {
name: string;
@@ -331,13 +331,9 @@ export default function EvalsTemplateTable({
const columnHelper = createColumnHelper<EvalsTemplateRow>();
const columns = [
- columnHelper.accessor("name", {
+ createIdTableColumn<EvalsTemplateRow>({
+ accessorKey: "name",
header: "Name",
- id: "name",
- cell: (row) => {
- const name = row.getValue();
- return name ? <TableIdOrName value={name} /> : undefined;
- },
}),
columnHelper.accessor("type", {
id: "type",
@@ -404,15 +400,11 @@ export default function EvalsTemplateTable({
size: 80,
formatter: (value) => String(value),
}),
- columnHelper.accessor("id", {
+ createIdTableColumn<EvalsTemplateRow>({
+ accessorKey: "id",
header: "Id",
- id: "id",
size: 100,
enableHiding: true,
- cell: (row) => {
- const id = row.getValue();
- return id ? <TableIdOrName value={id} /> : null;
- },
}),
columnHelper.accessor("actions", {
header: "Actions",
diff --git a/web/src/features/evals/components/evaluator-table.tsx b/web/src/features/evals/components/evaluator-table.tsx
index bfd2cfacf9..bf582c7160 100644
--- a/web/src/features/evals/components/evaluator-table.tsx
+++ b/web/src/features/evals/components/evaluator-table.tsx
@@ -22,7 +22,7 @@ import { usePaginationState } from "@/src/hooks/usePaginationState";
import { isEventTarget } from "@/src/features/evals/utils/typeHelpers";
import { useEvalCapabilities } from "@/src/features/evals/hooks/useEvalCapabilities";
import { useOrderByState } from "@/src/features/orderBy/hooks/useOrderByState";
-import TableIdOrName from "@/src/components/table/table-id";
+import { IdTableCell } from "@/src/components/design-system/table/components/IdTableCell/IdTableCell";
import { ExternalLinkIcon, Pen } from "lucide-react";
import { usePeekNavigation } from "@/src/components/table/peek/hooks/usePeekNavigation";
import { TablePeekViewEvaluatorConfigDetail } from "@/src/components/table/peek/peek-evaluator-config-detail";
@@ -47,6 +47,7 @@ import { useHasProjectAccess } from "@/src/features/rbac/utils/checkProjectAcces
import { Skeleton } from "@/src/components/ui/skeleton";
import { usdFormatter } from "@/src/utils/numbers";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
+import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
import {
type EvaluatorDataRow,
useEvaluatorTableData,
@@ -186,7 +187,9 @@ export default function EvaluatorTable({ projectId }: { projectId: string }) {
return (
<div className="flex w-[calc(var(--col-scoreName-size)*1px-0.75rem)] items-center gap-2">
- <TableIdOrName value={scoreName} className="min-w-[4px] flex-1" />
+ <div className="min-w-[4px] flex-1">
+ <IdTableCell value={scoreName} />
+ </div>
{row.row.original.isLegacy ? (
<span className="ml-auto justify-self-end">
{v4UpgradeUiEnabled ? (
@@ -291,7 +294,7 @@ export default function EvaluatorTable({ projectId }: { projectId: string }) {
if (!template) return "template not found";
return (
<div className="flex items-center gap-2">
- <TableIdOrName value={template.name} />
+ <IdTableCell value={template.name} />
<div className="flex justify-center">
<MaintainerTooltip maintainer={row.original.maintainer} />
</div>
@@ -352,16 +355,12 @@ export default function EvaluatorTable({ projectId }: { projectId: string }) {
return <EvaluatorFilterCell filterState={newFilterState} />;
},
}),
- columnHelper.accessor("id", {
+ createIdTableColumn<EvaluatorDataRow>({
+ accessorKey: "id",
header: "Id",
- id: "id",
size: 100,
enableSorting: false,
enableHiding: true,
- cell: (row) => {
- const id = row.getValue();
- return id ? <TableIdOrName value={id} /> : undefined;
- },
}),
columnHelper.accessor("actions", {
header: "Actions",
diff --git a/web/src/features/events/components/EventsTable.tsx b/web/src/features/events/components/EventsTable.tsx
index 2df9e7e1bd..34f4626258 100644
--- a/web/src/features/events/components/EventsTable.tsx
+++ b/web/src/features/events/components/EventsTable.tsx
@@ -40,6 +40,7 @@ import { Skeleton } from "@/src/components/ui/skeleton";
import { createBadgeTableColumn } from "@/src/components/design-system/table/columns/createBadgeTableColumn";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createDurationTableColumn } from "@/src/components/design-system/table/columns/createDurationTableColumn";
+import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
import { createItemBadgeTableColumn } from "@/src/components/design-system/table/columns/createItemBadgeTableColumn";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
import { createIOTableColumn } from "@/src/components/design-system/table/columns/createIOTableColumn";
@@ -82,7 +83,6 @@ import { BreakdownTooltip } from "@/src/features/traces";
import { InfoIcon, LightbulbIcon } from "lucide-react";
import { ProvidedModelNameCell } from "@/src/features/models/components/ProvidedModelNameCell";
import { type RowSelectionState } from "@tanstack/react-table";
-import TableIdOrName from "@/src/components/table/table-id";
import { TablePeekViewObservationDetail } from "@/src/components/table/peek/peek-observation-detail";
import { usePeekNavigation } from "@/src/components/table/peek/hooks/usePeekNavigation";
import {
@@ -1421,9 +1421,8 @@ export default function ObservationsEventsTable({
);
},
},
- {
+ createIdTableColumn<EventsTableRow>({
accessorKey: "promptName",
- id: "promptName",
header: getEventsColumnName("promptName"),
headerTooltip: {
description: "Link to prompt version in Langfuse prompt management.",
@@ -1432,13 +1431,14 @@ export default function ObservationsEventsTable({
size: 200,
enableHiding: true,
enableSorting,
- cell: ({ row }) => {
+ getValue: (_value, { row }) => {
const promptName = row.original.promptName;
const promptVersion = row.original.promptVersion;
- const value = `${promptName} (v${promptVersion})`;
- return promptName && promptVersion && <TableIdOrName value={value} />;
+ return promptName && promptVersion
+ ? `${promptName} (v${promptVersion})`
+ : undefined;
},
- },
+ }),
createBadgeTableColumn<EventsTableRow>({
accessorKey: "environment",
header: getEventsColumnName("environment"),
@@ -1471,21 +1471,14 @@ export default function ObservationsEventsTable({
enableSorting,
defaultHidden: true,
}),
- {
+ createIdTableColumn<EventsTableRow>({
accessorKey: "traceId",
- id: "traceId",
header: getEventsColumnName("traceId"),
size: 100,
- cell: ({ row }) => {
- const value = row.getValue("traceId");
- return typeof value === "string" ? (
- <TableIdOrName value={value} />
- ) : undefined;
- },
enableSorting,
enableHiding: true,
defaultHidden: true,
- },
+ }),
{
accessorKey: "modelId",
id: "modelId",
diff --git a/web/src/features/experiments/components/table/ExperimentItemsTable.tsx b/web/src/features/experiments/components/table/ExperimentItemsTable.tsx
index 1c4b653da7..6b1726e3a1 100644
--- a/web/src/features/experiments/components/table/ExperimentItemsTable.tsx
+++ b/web/src/features/experiments/components/table/ExperimentItemsTable.tsx
@@ -40,7 +40,7 @@ import useColumnOrder from "@/src/features/column-visibility/hooks/useColumnOrde
import { buildLocalIsoDatePresentation } from "@/src/utils/dates";
import { usdFormatter, latencyFormatter } from "@/src/utils/numbers";
import { type RowSelectionState } from "@tanstack/react-table";
-import TableIdOrName from "@/src/components/table/table-id";
+import { IdTableCell } from "@/src/components/design-system/table/components/IdTableCell/IdTableCell";
import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
import { createIOTableColumn } from "@/src/components/design-system/table/columns/createIOTableColumn";
import { usePeekNavigation } from "@/src/components/table/peek/hooks/usePeekNavigation";
@@ -713,7 +713,7 @@ export default function ExperimentItemsTable({
experiments={experiments}
allExperimentIds={allExperimentIds}
colorExperimentIds={colorExperimentIds}
- renderValue={(exp) => <TableIdOrName value={exp.observationId} />}
+ renderValue={(exp) => <IdTableCell value={exp.observationId} />}
/>
);
},
diff --git a/web/src/features/experiments/components/table/ExperimentsTable.tsx b/web/src/features/experiments/components/table/ExperimentsTable.tsx
index 24b49c24a2..e1fe4ee153 100644
--- a/web/src/features/experiments/components/table/ExperimentsTable.tsx
+++ b/web/src/features/experiments/components/table/ExperimentsTable.tsx
@@ -39,7 +39,7 @@ import { TableActionMenu } from "@/src/features/table/components/TableActionMenu
import { type TableAction } from "@/src/features/table/types";
import { Badge } from "@/src/components/ui/badge";
import { useStore } from "zustand";
-import TableIdOrName from "@/src/components/table/table-id";
+import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
import { Skeleton } from "@/src/components/ui/skeleton";
import { useDetailPageLists } from "@/src/features/navigate-detail-pages/context";
import { useTableViewManager } from "@/src/components/table/table-view-presets/hooks/useTableViewManager";
@@ -465,17 +465,12 @@ export default function ExperimentsTable({
const columns: LangfuseColumnDef<ExperimentsTableRow>[] = [
selectActionColumn,
- {
+ createIdTableColumn<ExperimentsTableRow>({
accessorKey: "name",
- id: "name",
header: getExperimentsColumnName("name"),
size: 200,
isPinnedLeft: true,
- cell: ({ row }) => {
- const value: string = row.getValue("name");
- return value ? <TableIdOrName value={value} /> : undefined;
- },
- },
+ }),
createIOTableColumn<ExperimentsTableRow>({
accessorKey: "description",
header: getExperimentsColumnName("description"),
diff --git a/web/src/features/models/components/ProvidedModelNameCell.tsx b/web/src/features/models/components/ProvidedModelNameCell.tsx
index 7607af7d8d..167eee6102 100644
--- a/web/src/features/models/components/ProvidedModelNameCell.tsx
+++ b/web/src/features/models/components/ProvidedModelNameCell.tsx
@@ -1,5 +1,5 @@
import { PlusCircle } from "lucide-react";
-import TableIdOrName from "@/src/components/table/table-id";
+import { IdTableCell } from "@/src/components/design-system/table/components/IdTableCell/IdTableCell";
import { UpsertModelFormDialog } from "@/src/features/models/components/UpsertModelFormDialog/UpsertModelFormDialog";
/**
@@ -7,7 +7,7 @@ import { UpsertModelFormDialog } from "@/src/features/models/components/UpsertMo
* tables. When the model resolves to a definition it is a plain name; when it
* does not, the name carries a trailing "add model definition" affordance.
*
- * Both states render the name through {@link TableIdOrName} so typography and
+ * Both states render the name through {@link IdTableCell} so typography and
* vertical alignment stay identical row-to-row — the trailing icon is a
* `shrink-0` adornment that never shifts the text baseline. The trigger is a
* `role="button"` and stops click propagation so opening the dialog does not
@@ -30,8 +30,8 @@ export function ProvidedModelNameCell({
// identical baseline whether or not the trailing affordance is present.
if (modelId) {
return (
- <span className="inline-flex max-w-full items-center">
- <TableIdOrName value={modelName} className="min-w-0" />
+ <span className="inline-flex max-w-full min-w-0 items-center">
+ <IdTableCell value={modelName} />
</span>
);
}
@@ -66,9 +66,9 @@ export function ProvidedModelNameCell({
type="button"
title={`Add a model definition for "${modelName}"`}
onClick={(e) => e.stopPropagation()}
- className="inline-flex max-w-full cursor-pointer items-center gap-1 text-left"
+ className="inline-flex max-w-full min-w-0 cursor-pointer items-center gap-1 text-left"
>
- <TableIdOrName value={modelName} className="min-w-0" />
+ <IdTableCell value={modelName} />
<PlusCircle className="h-3.5 w-3.5 shrink-0" />
</button>
</UpsertModelFormDialog>