🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(web): remove TagButton; tags render the design-system Tag (#18901)
Trang Nguyen3ca14f3dc139
diff --git a/web/src/features/monitors/components/MonitorsTable.tsx b/web/src/features/monitors/components/MonitorsTable.tsxindex f6c563cc62..d5dc133622 100644--- a/web/src/features/monitors/components/MonitorsTable.tsx+++ b/web/src/features/monitors/components/MonitorsTable.tsx@@ -241,7 +241,6 @@ export function MonitorsTable() {selectedTags={row.original.tags ?? []}isLoading={false}viewOnly- isTableCell/></div>),diff --git a/web/src/features/tag/components/TagButton.tsx b/web/src/features/tag/components/TagButton.tsxdeleted file mode 100644index 450f21257f..0000000000--- a/web/src/features/tag/components/TagButton.tsx+++ /dev/null@@ -1,48 +0,0 @@-import { Tag, TagShell } from "@/src/components/design-system/Tag/Tag";-import { cn } from "@/src/utils/tailwind";-import { TagIcon } from "lucide-react";-import React from "react";--export const TagButton: React.FC<{- tag: string;- loading: boolean;- viewOnly?: boolean;- isTableCell?: boolean;-}> = React.memo(({ tag, loading, viewOnly = false, isTableCell = false }) => {- const label = (- <>- <TagIcon className="text-foreground-tertiary icon-sm shrink-0" />- <span- className={cn(- "overflow-hidden py-0.5 text-ellipsis whitespace-nowrap",- !isTableCell && "text-xs",- )}- title={tag}- >- {tag}- </span>- </>- );-- if (viewOnly) {- return (- <span className="inline-flex max-w-40 min-w-0">- <Tag text={tag} icon={TagIcon} />- </span>- );- }-- return (- <TagShell asChild>- <button- key={tag}- type="button"- disabled={loading}- className="focus-visible:ring-ring hover:bg-accent w-fit max-w-40 min-w-0 focus-visible:ring-2 focus-visible:outline-hidden disabled:cursor-not-allowed disabled:opacity-50"- >- {label}- </button>- </TagShell>- );-});-TagButton.displayName = "TagButton";diff --git a/web/src/features/tag/components/TagList.tsx b/web/src/features/tag/components/TagList.tsxindex a8204f66b4..0af57492c5 100644--- a/web/src/features/tag/components/TagList.tsx+++ b/web/src/features/tag/components/TagList.tsx@@ -1,30 +1,30 @@import { IconButton } from "@/src/components/design-system/IconButton/IconButton";+import { Tag, TagShell } from "@/src/components/design-system/Tag/Tag";import { Tooltip } from "@/src/components/design-system/Tooltip/Tooltip";-import { TagButton } from "@/src/features/tag/components/TagButton";import { TagIcon } from "lucide-react";type TagListProps = {selectedTags: string[];isLoading: boolean;viewOnly?: boolean;- isTableCell?: boolean;};const TagList = ({selectedTags,isLoading,viewOnly = false,- isTableCell = false,}: TagListProps) => {- return selectedTags.length > 0 || viewOnly ? (+ if (viewOnly) {+ return selectedTags.map((tag) => (+ <span key={tag} className="inline-flex max-w-40 min-w-0">+ <Tag text={tag} icon={TagIcon} />+ </span>+ ));+ }++ return selectedTags.length > 0 ? (selectedTags.map((tag) => (- <TagButton- key={tag}- tag={tag}- loading={isLoading}- viewOnly={viewOnly}- isTableCell={isTableCell}- />+ <EditableTag key={tag} tag={tag} disabled={isLoading} />))) : (<Tooltip label="Add tag" hoverableContent={false}>@@ -41,3 +41,21 @@ const TagList = ({};export default TagList;++/** Opens the tag editor; the surrounding popover trigger handles the click. */+function EditableTag({ tag, disabled }: { tag: string; disabled: boolean }) {+ return (+ <TagShell asChild>+ <button+ type="button"+ disabled={disabled}+ className="focus-visible:ring-ring hover:bg-accent w-fit max-w-40 min-w-0 focus-visible:ring-2 focus-visible:outline-hidden disabled:cursor-not-allowed disabled:opacity-50"+ >+ <TagIcon className="text-foreground-tertiary icon-sm shrink-0" />+ <span className="truncate py-0.5" title={tag}>+ {tag}+ </span>+ </button>+ </TagShell>+ );+}diff --git a/web/src/features/tag/components/TagManager.tsx b/web/src/features/tag/components/TagManager.tsxindex 86c826914e..f17d40ea9a 100644--- a/web/src/features/tag/components/TagManager.tsx+++ b/web/src/features/tag/components/TagManager.tsx@@ -80,12 +80,7 @@ const TagManager = ({className,)}>- <TagList- selectedTags={selectedTags}- isLoading={isLoading}- viewOnly- isTableCell={isTableCell}- />+ <TagList selectedTags={selectedTags} isLoading={isLoading} viewOnly /></div>);}@@ -100,11 +95,7 @@ const TagManager = ({<PopoverAnchor asChild>{triggerButton}</PopoverAnchor>{selectedTags.length > 0 && (<div className="flex flex-1 flex-wrap gap-1">- <TagList- selectedTags={selectedTags}- isLoading={isLoading}- isTableCell={isTableCell}- />+ <TagList selectedTags={selectedTags} isLoading={isLoading} /></div>)}</div>@@ -126,11 +117,7 @@ const TagManager = ({className,)}>- <TagList- selectedTags={selectedTags}- isLoading={isLoading}- isTableCell={isTableCell}- />+ <TagList selectedTags={selectedTags} isLoading={isLoading} /></div></PopoverTrigger>)}diff --git a/web/src/features/tag/index.ts b/web/src/features/tag/index.tsindex bd9da69ae7..a707eb7863 100644--- a/web/src/features/tag/index.ts+++ b/web/src/features/tag/index.ts@@ -1,7 +1,6 @@// The tag feature's public client surface (RFC rule 8). Named re-exports// only. TagList and TagManager are default exports in their own files;// the door names them, so consumers import them by name.-export { TagButton } from "@/src/features/tag/components/TagButton";export { default as TagList } from "@/src/features/tag/components/TagList";export { default as TagManager } from "@/src/features/tag/components/TagManager";export { TagPromptDetailsPopover } from "@/src/features/tag/components/TagPromptDetailsPopover";diff --git a/web/src/features/traces/components/TraceHeader.tsx b/web/src/features/traces/components/TraceHeader.tsxindex 97a9c50424..6ed62620dd 100644--- a/web/src/features/traces/components/TraceHeader.tsx+++ b/web/src/features/traces/components/TraceHeader.tsx@@ -7,7 +7,7 @@ import { GroupedScoreBadges } from "@/src/components/grouped-score-badge";import { BadgeShell } from "@/src/components/design-system/Badge/Badge";import { Button } from "@/src/components/ui/button";import { Skeleton } from "@/src/components/ui/skeleton";-import { TagButton } from "@/src/features/tag";+import { TagList } from "@/src/features/tag";import {SessionBadge,UserIdBadge,@@ -119,9 +119,7 @@ function LoadedTraceHeader() {{traceScores.length > 0 && (<GroupedScoreBadges scores={traceScores} />)}- {visibleTags.map((tag) => (- <TagButton key={tag} tag={tag} loading={false} viewOnly />- ))}+ <TagList selectedTags={visibleTags} isLoading={false} viewOnly />{hiddenTagCount > 0 && (<OverflowCountBadgecount={hiddenTagCount}