🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(evals): stop offering bookmarked as a trace evaluator filter column (#16175)
Max Deichmann411483470b86
diff --git a/web/src/features/evals/components/inner-evaluator-form.tsx b/web/src/features/evals/components/inner-evaluator-form.tsxindex 7aa671c89b..df241b577f 100644--- a/web/src/features/evals/components/inner-evaluator-form.tsx+++ b/web/src/features/evals/components/inner-evaluator-form.tsx@@ -48,6 +48,7 @@ import {evalConfigFormSchema,getActiveJsonPathCompatibilityWarning,type EvalFormType,+ RETIRED_TRACE_FILTER_COLUMNS,getTargetDisplayName,inferDefaultMapping,type LangfuseObject,@@ -1231,6 +1232,11 @@ export const InnerEvaluatorForm = (props: {? ["tags", "name", "calledToolNames"]: undefined}+ columnsHiddenUnlessSelected={+ isTraceTarget(target)+ ? RETIRED_TRACE_FILTER_COLUMNS+ : undefined+ }/>)}</div>diff --git a/web/src/features/evals/utils/evaluator-form-utils.ts b/web/src/features/evals/utils/evaluator-form-utils.tsindex b8d9deae87..328d025f09 100644--- a/web/src/features/evals/utils/evaluator-form-utils.ts+++ b/web/src/features/evals/utils/evaluator-form-utils.ts@@ -135,6 +135,12 @@ export function getActiveJsonPathCompatibilityWarning(mappingRow: {return getJsonPathCompatibilityWarning(mappingRow.jsonSelector);}+// Bookmarking is retired from the UI. Keep these ids/names in the shared+// column list so existing bookmarked filter rows still resolve a definition,+// but pass them to InlineFilterBuilder as hiddenUnlessSelected so only those+// grandfathered rows can keep the column — new rows cannot pick it.+export const RETIRED_TRACE_FILTER_COLUMNS = ["bookmarked", "⭐️"] as const;+export const getTargetDisplayName = (target: string): string => {switch (target) {case "trace":diff --git a/web/src/features/filters/components/filter-builder.tsx b/web/src/features/filters/components/filter-builder.tsxindex f27241d5a8..27a1e00f85 100644--- a/web/src/features/filters/components/filter-builder.tsx+++ b/web/src/features/filters/components/filter-builder.tsx@@ -42,6 +42,7 @@ import {import { MultiSelect } from "@/src/features/filters/components/multi-select";import { SingleSelect } from "@/src/features/filters/components/single-select";import { FilterToken } from "@/src/features/filters/components/FilterToken";+import { getColumnOptionsForFilterRow } from "@/src/features/filters/lib/filter-transform";import {type WipFilterState,type WipFilterCondition,@@ -445,6 +446,7 @@ export function InlineFilterBuilder({columnIdentifier = "name",disabled,columnsWithCustomSelect,+ columnsHiddenUnlessSelected,stringObjectValueOptions,onStringObjectKeyChange,compact = false,@@ -458,6 +460,11 @@ export function InlineFilterBuilder({columnIdentifier?: ColumnIdentifier;disabled?: boolean;columnsWithCustomSelect?: string[];+ /**+ * Column ids/names that stay in the picker only for rows that already use+ * them. Used to grandfather retired columns without offering them on new rows.+ */+ columnsHiddenUnlessSelected?: readonly string[];/** Per-key value suggestions for opt-in stringObject columns (metadata). */stringObjectValueOptions?: Record<string, SingleValueOption[]>;/** Fires when a suggestion-enabled stringObject key changes, so the parent can load its values. */@@ -509,6 +516,7 @@ export function InlineFilterBuilder({onChange={setWipFilterState}disabled={disabled}columnsWithCustomSelect={columnsWithCustomSelect}+ columnsHiddenUnlessSelected={columnsHiddenUnlessSelected}stringObjectValueOptions={stringObjectValueOptions}onStringObjectKeyChange={onStringObjectKeyChange}compact={compact}@@ -554,6 +562,7 @@ function FilterBuilderForm({onChange,disabled,columnsWithCustomSelect = [],+ columnsHiddenUnlessSelected = [],stringObjectValueOptions = {},onStringObjectKeyChange,compact = false,@@ -565,6 +574,11 @@ function FilterBuilderForm({onChange: Dispatch<SetStateAction<WipFilterState>>;disabled?: boolean;columnsWithCustomSelect?: string[];+ /**+ * Column ids/names that stay in the picker only for rows that already use+ * them. Used to grandfather retired columns without offering them on new rows.+ */+ columnsHiddenUnlessSelected?: readonly string[];/** Per-key value suggestions for opt-in stringObject columns (metadata). */stringObjectValueOptions?: Record<string, SingleValueOption[]>;/** Fires when a suggestion-enabled stringObject key changes, so the parent can load its values. */@@ -654,6 +668,11 @@ function FilterBuilderForm({column?.type === "stringObject" &&columnsWithCustomSelect.includes(column.id);const columnLabel = column ? column.name : "Column";+ const columnsForPicker = getColumnOptionsForFilterRow(+ columns,+ filter.column,+ columnsHiddenUnlessSelected,+ );const columnCombobox = (<Popover@@ -686,7 +705,7 @@ function FilterBuilderForm({<InputCommandList><InputCommandEmpty>No options found.</InputCommandEmpty><InputCommandGroup>- {columns.map((option) => {+ {columnsForPicker.map((option) => {const hasAlert = !!option.alert;const severity = option.alert?.severity ?? "warning";const alertStyles = getAlertStyles(severity);diff --git a/web/src/features/filters/lib/filter-transform.clienttest.ts b/web/src/features/filters/lib/filter-transform.clienttest.tsnew file mode 100644index 0000000000..d448280fe4--- /dev/null+++ b/web/src/features/filters/lib/filter-transform.clienttest.ts@@ -0,0 +1,49 @@+import { describe, expect, it } from "vitest";+import { getColumnOptionsForFilterRow } from "./filter-transform";++describe("getColumnOptionsForFilterRow", () => {+ const columns = [+ { name: "⭐️", id: "bookmarked", type: "boolean", internal: "t.bookmarked" },+ { name: "Name", id: "traceName", type: "string", internal: 't."name"' },+ ] as const;+ const hiddenUnlessSelected = ["bookmarked", "⭐️"];++ it("returns all columns when nothing is hidden", () => {+ expect(getColumnOptionsForFilterRow([...columns], undefined)).toEqual(+ columns,+ );+ });++ it("hides retired columns on a new filter row", () => {+ expect(+ getColumnOptionsForFilterRow(+ [...columns],+ undefined,+ hiddenUnlessSelected,+ ),+ ).toEqual([columns[1]]);+ });++ it.each(["bookmarked", "⭐️"] as const)(+ "keeps the retired column only on the row that already uses %s",+ (filterColumn) => {+ expect(+ getColumnOptionsForFilterRow(+ [...columns],+ filterColumn,+ hiddenUnlessSelected,+ ),+ ).toEqual(columns);+ },+ );++ it("does not re-offer a retired column on a sibling row", () => {+ expect(+ getColumnOptionsForFilterRow(+ [...columns],+ "traceName",+ hiddenUnlessSelected,+ ),+ ).toEqual([columns[1]]);+ });+});diff --git a/web/src/features/filters/lib/filter-transform.ts b/web/src/features/filters/lib/filter-transform.tsindex b9ad1cbb0c..af8f203d1e 100644--- a/web/src/features/filters/lib/filter-transform.ts+++ b/web/src/features/filters/lib/filter-transform.ts@@ -83,3 +83,30 @@ export function transformFiltersForBackend(return filter;});}++/**+ * Columns listed in `hiddenUnlessSelected` stay in the picker only for the+ * filter row that already uses them. New / other rows cannot select them.+ */+export function getColumnOptionsForFilterRow<+ T extends Pick<ColumnDefinition, "id" | "name" | "aliases">,+>(+ columns: T[],+ filterColumn: string | undefined,+ hiddenUnlessSelected: readonly string[] = [],+): T[] {+ if (hiddenUnlessSelected.length === 0) return columns;++ const hidden = new Set(hiddenUnlessSelected);+ return columns.filter((option) => {+ const isHiddenUnlessSelected =+ hidden.has(option.id) || hidden.has(option.name);+ if (!isHiddenUnlessSelected) return true;++ return (+ option.id === filterColumn ||+ option.name === filterColumn ||+ (filterColumn !== undefined && option.aliases?.includes(filterColumn))+ );+ });+}