🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
refactor(web): Fix no-null-render: eval-version-callout.tsx (#17143)
Ben Bachem42727d072ffb
diff --git a/web/src/features/evals/components/eval-version-callout.tsx b/web/src/features/evals/components/eval-version-callout.tsxindex 7dc766ee61..49cc2eea0a 100644--- a/web/src/features/evals/components/eval-version-callout.tsx+++ b/web/src/features/evals/components/eval-version-callout.tsx@@ -1,4 +1,3 @@-/* eslint-disable @repo/no-null-render */import { Alert } from "@/src/components/design-system/Alert/Alert";import { AlertTriangle } from "lucide-react";import { type EvalCapabilities } from "@/src/features/evals/hooks/useEvalCapabilities";@@ -10,30 +9,25 @@ import {} from "@/src/features/evals/utils/typeHelpers";interface EvalVersionCalloutProps {- targetObject: string;- evalCapabilities: EvalCapabilities;+ content: CalloutContent;}interface CalloutContent {- visible: boolean;title: string;description: React.ReactNode;}-const getCalloutContent = (+export const getEvalVersionCalloutContent = (targetObject: string,evalCapabilities: EvalCapabilities,-): CalloutContent => {- const hidden = { visible: false, title: "", description: "" };-+) => {// For event/observation targetif (isEventTarget(targetObject)) {if (evalCapabilities.isNewCompatible) {- return hidden;+ return null;}return {- visible: true,title: "Please verify your SDK version",description: (<>@@ -58,7 +52,6 @@ const getCalloutContent = (if (isExperimentTarget(targetObject)) {if (!evalCapabilities.isNewCompatible) {return {- visible: true,title: "Please verify you are using the Experiment Runner SDK",description: (<>@@ -79,7 +72,7 @@ const getCalloutContent = (};}- return hidden;+ return null;}// For dataset target (legacy dataset run methods)@@ -87,11 +80,10 @@ const getCalloutContent = (// Forced-v3 projects keep trace evaluators as their intended experience —// no upgrade nag.if (evalCapabilities.forceV3Experience) {- return hidden;+ return null;}return {- visible: true,title: "Legacy low-level SDK methods",description: (<>@@ -118,11 +110,10 @@ const getCalloutContent = (// Forced-v3 projects keep trace evaluators as their intended experience —// no upgrade nag.if (evalCapabilities.forceV3Experience) {- return hidden;+ return null;}return {- visible: true,title: "Consider upgrading to observation evaluators",description: (<>@@ -142,19 +133,10 @@ const getCalloutContent = (};}- return hidden;+ return null;};-export function EvalVersionCallout({- targetObject,- evalCapabilities,-}: EvalVersionCalloutProps) {- const content = getCalloutContent(targetObject, evalCapabilities);-- if (!content.visible) {- return null;- }-+export function EvalVersionCallout({ content }: EvalVersionCalloutProps) {return (<div className="mt-2 w-full max-w-4xl"><Alert variant="warning" icon={AlertTriangle}>diff --git a/web/src/features/evals/components/inner-evaluator-form.tsx b/web/src/features/evals/components/inner-evaluator-form.tsxindex 9b5b35839f..0fde1d66b5 100644--- a/web/src/features/evals/components/inner-evaluator-form.tsx+++ b/web/src/features/evals/components/inner-evaluator-form.tsx@@ -63,7 +63,10 @@ import {} from "@/src/utils/date-range-utils";import { type PartialConfig } from "@/src/features/evals/types";import { type EvalCapabilities } from "@/src/features/evals/hooks/useEvalCapabilities";-import { EvalVersionCallout } from "@/src/features/evals/components/eval-version-callout";+import {+ EvalVersionCallout,+ getEvalVersionCalloutContent,+} from "@/src/features/evals/components/eval-version-callout";import { Skeleton } from "@/src/components/ui/skeleton";import {Dialog,@@ -566,6 +569,10 @@ export const InnerEvaluatorForm = (props: {const previewTableVisible = !props.disabled && !props.hidePreviewTable;const previewAlreadyShowsSdkWarning =previewTableVisible && shouldShowEventsPreview;+ const evalVersionCalloutContent = getEvalVersionCalloutContent(+ watchedTarget,+ props.evalCapabilities,+ );const eventsPreviewFilterState = useMemo(() =>shouldShowExperimentEventsPreview@@ -1002,11 +1009,9 @@ export const InnerEvaluatorForm = (props: {{!props.hideTargetSelection &&props.mode !== "edit" &&!props.disabled &&- !previewAlreadyShowsSdkWarning && (- <EvalVersionCallout- targetObject={watchedTarget}- evalCapabilities={props.evalCapabilities}- />+ !previewAlreadyShowsSdkWarning &&+ evalVersionCalloutContent && (+ <EvalVersionCallout content={evalVersionCalloutContent} />)}{!props.hideAdvancedSettings &&