Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(web): remove dead markdown toggle, tabs inset and badge polish (#17446)

Trang Nguyen431d5bad4bd9
diff --git a/web/.storybook/preview.tsx b/web/.storybook/preview.tsx
index 5c62eda84d..ab8da938f4 100644
--- a/web/.storybook/preview.tsx
+++ b/web/.storybook/preview.tsx
@@ -15,7 +15,6 @@ import { SessionProvider } from "next-auth/react";
import { TooltipProvider } from "../src/components/ui/tooltip";
import { LayerProvider } from "../src/context/LayerContext/LayerContext";
import { ThemeProvider } from "../src/features/theming/ThemeProvider";
-import { MarkdownContextProvider } from "../src/features/theming/useMarkdownContext";
import "./storybook.css";
import "./docs.css";
// Mirror the global CSS that _app.tsx imports so vendored components
@@ -137,19 +136,13 @@ export default definePreview({
fullHeight={context.viewMode !== "docs"}
theme={context.globals.theme === "dark" ? "dark" : "light"}
>
- {/* MarkdownContextProvider mirrors the app: pages render inside it so
- the JSON/IO viewers (CodeJsonViewer's JSONView calls
- useMarkdownContext) work identically to production. Without it,
- multi-line IOTableCell renders (rowHeight m/l) throw. */}
{/* SessionProvider mirrors _app.tsx: components reading feature
flags call useSession, which throws without a provider. A null
session resolves every flag to false (regular-user behavior). */}
<SessionProvider session={null}>
- <MarkdownContextProvider>
- <TooltipProvider>
- <Story />
- </TooltipProvider>
- </MarkdownContextProvider>
+ <TooltipProvider>
+ <Story />
+ </TooltipProvider>
</SessionProvider>
</StorybookThemeProvider>
);
diff --git a/web/src/components/ItemBadge.tsx b/web/src/components/ItemBadge.tsx
index 69cf6053a8..84c8c705cd 100644
--- a/web/src/components/ItemBadge.tsx
+++ b/web/src/components/ItemBadge.tsx
@@ -102,6 +102,16 @@ export function renderFilterIcon(value: string): React.ReactNode {
);
}
+/**
+ * `"DATASET_RUN"` -> `{ label: "Dataset_run", displayLabel: "Dataset run" }`.
+ * `label` titles the element, `displayLabel` is what the user reads.
+ */
+export function getItemTypeLabels(type: LangfuseItemType) {
+ const label =
+ String(type).charAt(0).toUpperCase() + String(type).slice(1).toLowerCase();
+ return { label, displayLabel: label.replace(/_/g, " ") };
+}
+
export function ItemBadge({
type,
showLabel = false,
@@ -123,10 +133,7 @@ export function ItemBadge({
className,
);
- const label =
- String(type).charAt(0).toUpperCase() + String(type).slice(1).toLowerCase();
-
- const displayLabel = label.replace(/_/g, " ");
+ const { label, displayLabel } = getItemTypeLabels(type);
return (
<Badge
diff --git a/web/src/components/SingleLineOverflowList.tsx b/web/src/components/SingleLineOverflowList.tsx
index ed01d38878..bec7bbba6d 100644
--- a/web/src/components/SingleLineOverflowList.tsx
+++ b/web/src/components/SingleLineOverflowList.tsx
@@ -9,6 +9,14 @@ import { type ReactNode, useEffect, useRef, useState } from "react";
* presentation remain entirely caller-defined. `trailingContent` stays pinned
* immediately after the overflow control and participates in width measurement.
*/
+
+// Rows of boxed pills read fine at gap-2; rows of mostly-plain text (the
+// session header's metrics/attributes/links) need more air to scan as
+// separate facts, matching the trace headers' gap-x-3.
+const SPACING_CLASS = {
+ compact: "gap-2",
+ comfortable: "gap-3",
+} as const;
export function SingleLineOverflowList<TItem>({
items,
additionalOverflowCount,
@@ -16,6 +24,7 @@ export function SingleLineOverflowList<TItem>({
renderItem,
renderOverflow,
trailingContent,
+ spacing = "compact",
}: {
items: readonly TItem[];
additionalOverflowCount: number;
@@ -26,7 +35,9 @@ export function SingleLineOverflowList<TItem>({
overflowItemCount: number;
}) => ReactNode;
trailingContent?: ReactNode;
+ spacing?: keyof typeof SPACING_CLASS;
}) {
+ const gapClass = SPACING_CLASS[spacing];
const measurementRowRef = useRef<HTMLDivElement>(null);
const overflowRef = useRef<HTMLDivElement>(null);
const trailingContentRef = useRef<HTMLDivElement>(null);
@@ -107,11 +118,13 @@ export function SingleLineOverflowList<TItem>({
]);
return (
- <div className="relative flex min-w-0 flex-1 items-center gap-2 overflow-hidden">
+ <div
+ className={`relative flex min-w-0 flex-1 items-center overflow-hidden ${gapClass}`}
+ >
<div
ref={measurementRowRef}
aria-hidden="true"
- className="invisible absolute inset-x-0 flex items-center gap-2 [&>*]:shrink-0"
+ className={`invisible absolute inset-x-0 flex items-center [&>*]:shrink-0 ${gapClass}`}
>
{items.map((item) => {
const key = getKey(item);
@@ -126,7 +139,9 @@ export function SingleLineOverflowList<TItem>({
);
})}
</div>
- <div className="flex min-w-0 items-center gap-2 overflow-hidden [&>*]:shrink-0">
+ <div
+ className={`flex min-w-0 items-center overflow-hidden [&>*]:shrink-0 ${gapClass}`}
+ >
{visibleItems.map((item) => {
const key = getKey(item);
return (
diff --git a/web/src/components/TextChip.stories.tsx b/web/src/components/TextChip.stories.tsx
new file mode 100644
index 0000000000..9e57d4cbbd
--- /dev/null
+++ b/web/src/components/TextChip.stories.tsx
@@ -0,0 +1,47 @@
+import preview from "../../.storybook/preview";
+import { getItemTypeLabels, type LangfuseItemType } from "./ItemBadge";
+import { TextChip } from "./TextChip";
+
+const meta = preview.meta({
+ component: TextChip,
+});
+
+const TYPES: LangfuseItemType[] = [
+ "TRACE",
+ "SPAN",
+ "GENERATION",
+ "EVENT",
+ "AGENT",
+ "TOOL",
+ "CHAIN",
+ "RETRIEVER",
+ "EMBEDDING",
+ "GUARDRAIL",
+ "SESSION",
+ "USER",
+ "QUEUE_ITEM",
+ "DATASET",
+ "DATASET_RUN",
+ "DATASET_ITEM",
+ "ANNOTATION_QUEUE",
+ "PROMPT",
+ "EVALUATOR",
+ "RUNNING_EVALUATOR",
+ "EXPERIMENT",
+];
+
+export const Default = meta.story({
+ args: { text: "Trace" },
+});
+
+export const VariantMatrix = meta.story({
+ args: { text: "Trace" },
+ render: () => (
+ <div className="flex flex-wrap items-center gap-2">
+ {TYPES.map((type) => {
+ const { displayLabel } = getItemTypeLabels(type);
+ return <TextChip key={type} text={displayLabel} />;
+ })}
+ </div>
+ ),
+});
diff --git a/web/src/components/TextChip.tsx b/web/src/components/TextChip.tsx
new file mode 100644
index 0000000000..303d7a88cf
--- /dev/null
+++ b/web/src/components/TextChip.tsx
@@ -0,0 +1,19 @@
+import { Badge } from "@/src/components/ui/badge";
+
+/**
+ * Quiet text-only chip for page and peek headers: no fill and muted text so it
+ * doesn't compete with the title next to it.
+ */
+export function TextChip({ text }: { text: string }) {
+ return (
+ <Badge
+ variant="outline"
+ title={text}
+ className="text-muted-foreground border-border flex max-w-fit items-center overflow-hidden border bg-transparent px-1 whitespace-nowrap"
+ >
+ <span className="truncate" title={text}>
+ {text}
+ </span>
+ </Badge>
+ );
+}
diff --git a/web/src/components/design-system/Tabs/Tabs.tsx b/web/src/components/design-system/Tabs/Tabs.tsx
index efe3cd0bfd..2a95ef96bc 100644
--- a/web/src/components/design-system/Tabs/Tabs.tsx
+++ b/web/src/components/design-system/Tabs/Tabs.tsx
@@ -72,6 +72,13 @@ const tabsTriggerVariants = cva(
sm: "h-5 px-1 text-xs",
},
},
+ compoundVariants: [
+ // Inside a boxed list the trigger fills the list's inner height, so the
+ // list's padding is the inset on every side and the smaller radius
+ // nests inside the list's. A fixed height overflowed once the list had
+ // a border (outline) and left uneven top/bottom vs side spacing.
+ { variant: "default", class: "h-full" },
+ ],
defaultVariants: {
variant: "default",
size: "default",
diff --git a/web/src/components/design-system/table/components/IOTableCell/IOTableCell.clienttest.tsx b/web/src/components/design-system/table/components/IOTableCell/IOTableCell.clienttest.tsx
index 3a68879366..274ef90062 100644
--- a/web/src/components/design-system/table/components/IOTableCell/IOTableCell.clienttest.tsx
+++ b/web/src/components/design-system/table/components/IOTableCell/IOTableCell.clienttest.tsx
@@ -1,15 +1,6 @@
import { render, screen } from "@testing-library/react";
import { IOTableCell } from "./IOTableCell";
-// The JSON viewer underneath reads the app's markdown preference. Stubbed
-// rather than imported: a design-system file must not reach into `src/features`.
-vi.mock("@/src/features/theming/useMarkdownContext", () => ({
- useMarkdownContext: () => ({
- isMarkdownEnabled: false,
- setIsMarkdownEnabled: () => {},
- }),
-}));
-
const renderCell = (props: Partial<Parameters<typeof IOTableCell>[0]> = {}) =>
render(
<IOTableCell
diff --git a/web/src/components/layouts/page-header.tsx b/web/src/components/layouts/page-header.tsx
index 7cbe67aeed..286aab89ef 100644
--- a/web/src/components/layouts/page-header.tsx
+++ b/web/src/components/layouts/page-header.tsx
@@ -1,7 +1,11 @@
/* eslint-disable @repo/no-style-props */
import { EnvLabelBadge } from "@/src/components/EnvLabelBadge";
import { useEnvLabel } from "@/src/hooks/useEnvLabel";
-import { ItemBadge, type LangfuseItemType } from "@/src/components/ItemBadge";
+import {
+ getItemTypeLabels,
+ type LangfuseItemType,
+} from "@/src/components/ItemBadge";
+import { TextChip } from "@/src/components/TextChip";
import BreadcrumbComponent from "@/src/components/layouts/breadcrumb";
import { PageHeaderControlsSlotTarget } from "@/src/components/layouts/page-header-controls-slot";
import { InAppAiAgentButton } from "@/src/components/nav/in-app-ai-agent-button";
@@ -165,7 +169,7 @@ const PageHeader = ({
<div className="mr-2 flex items-center gap-1">
{itemType && (
<div className="flex items-center">
- <ItemBadge type={itemType} showLabel />
+ <TextChip text={getItemTypeLabels(itemType).displayLabel} />
</div>
)}
<div className="relative inline-block max-w-md md:max-w-none">
diff --git a/web/src/components/publish-object-switch.tsx b/web/src/components/publish-object-switch.tsx
index cd866be945..5fded07bba 100644
--- a/web/src/components/publish-object-switch.tsx
+++ b/web/src/components/publish-object-switch.tsx
@@ -236,9 +236,11 @@ const Base = (props: {
id="publish-trace"
variant="ghost"
size={props.label ? "sm" : props.size}
+ // Menu row: same box and icon size as the peek menu's
+ // Delete and Expand rows, so the three line up.
className={
props.label
- ? "w-full justify-start gap-2 font-normal"
+ ? "h-auto w-full justify-start gap-2 rounded-sm py-1.5 pr-2 pl-1.5 font-normal"
: undefined
}
loading={props.isLoading}
@@ -246,13 +248,15 @@ const Base = (props: {
>
{props.isPublic ? (
<Globe
- className="h-4 w-4"
+ className={props.label ? "h-4 w-4" : "h-3.5 w-3.5"}
fill="#b3d9ff"
stroke="#4d94ff"
strokeWidth={2}
/>
) : (
- <Share2 className="h-4 w-4" />
+ <Share2
+ className={props.label ? "h-4 w-4" : "h-3.5 w-3.5"}
+ />
)}
{props.label ? (
<span className="text-sm">{props.label}</span>
diff --git a/web/src/components/ui/CodeJsonViewer.tsx b/web/src/components/ui/CodeJsonViewer.tsx
index 632b5fd6f3..ffbbd1d53a 100644
--- a/web/src/components/ui/CodeJsonViewer.tsx
+++ b/web/src/components/ui/CodeJsonViewer.tsx
@@ -16,8 +16,6 @@ import { deepParseJson } from "@langfuse/shared";
import { decodeUnicodeInJson } from "@/src/utils/decodeUnicodeInJson";
import { Skeleton } from "@/src/components/ui/skeleton";
import { useTheme } from "next-themes";
-import { usePostHogClientCapture } from "@/src/features/posthog-analytics/usePostHogClientCapture";
-import { useMarkdownContext } from "@/src/features/theming/useMarkdownContext";
import { type MediaReturnType } from "@/src/features/media/validation";
import { LangfuseMediaView } from "@/src/components/ui/LangfuseMediaView";
import { classifyMediaValue } from "@/src/components/ui/media/mediaUtils";
@@ -33,7 +31,6 @@ import { useCopyToClipboard } from "@/src/hooks/useCopyToClipboard";
export const IO_TABLE_CHAR_LIMIT = 10000;
export function JSONView(props: {
- canEnableMarkdown?: boolean;
json?: unknown;
title?: string;
hideTitle?: boolean;
@@ -64,8 +61,6 @@ export function JSONView(props: {
[props.json, props.preserveStrings],
);
const { resolvedTheme } = useTheme();
- const { setIsMarkdownEnabled } = useMarkdownContext();
- const capture = usePostHogClientCapture();
const promptReferenceProjectId = usePromptReferenceProjectId();
const [internalCollapsed, setInternalCollapsed] = useState(false);
@@ -90,13 +85,6 @@ export function JSONView(props: {
}
};
- const handleOnValueChange = () => {
- setIsMarkdownEnabled(true);
- capture("trace_detail:io_pretty_format_toggle_group", {
- renderMarkdown: true,
- });
- };
-
const handleToggleCollapse = () => {
if (props.onToggleCollapse) {
props.onToggleCollapse();
@@ -195,16 +183,15 @@ export function JSONView(props: {
return (
<div
className={cn(
- "flex max-h-full min-h-0 max-w-full min-w-0 flex-col",
+ "group/iosection flex max-h-full min-h-0 max-w-full min-w-0 flex-col",
props.className,
props.scrollable ? "overflow-hidden" : "",
)}
>
{props.title && !props.hideTitle ? (
<MarkdownJsonViewHeader
+ hoverRevealControls
title={props.title}
- canEnableMarkdown={props.canEnableMarkdown ?? false}
- handleOnValueChange={handleOnValueChange}
handleOnCopy={handleOnCopy}
controlButtons={
<>
diff --git a/web/src/components/ui/MarkdownJsonView.tsx b/web/src/components/ui/MarkdownJsonView.tsx
index 3724770da2..ff2cf553cc 100644
--- a/web/src/components/ui/MarkdownJsonView.tsx
+++ b/web/src/components/ui/MarkdownJsonView.tsx
@@ -16,34 +16,41 @@ import { cn } from "@/src/utils/tailwind";
type MarkdownJsonViewHeaderProps = {
title: string | React.ReactNode;
titleIcon?: React.ReactNode;
- handleOnValueChange: () => void;
handleOnCopy: (event?: React.MouseEvent<HTMLButtonElement>) => void;
- canEnableMarkdown?: boolean;
controlButtons?: React.ReactNode;
/** When set, the header hosts expand/collapse so a long body is not the
- only place to find the control. */
+ only place to find the control. `subject` names what collapses in the
+ accessible labels (defaults to "system prompt", its original use). */
collapseControl?: {
isCollapsed: boolean;
onToggle: () => void;
+ subject?: string;
};
inset?: boolean;
+ /** Hosts that render their own copy control (e.g. inside the content box)
+ suppress the header's. */
+ hideCopyButton?: boolean;
+ /** Reveal the right-side controls only while hovering the hosting section
+ (requires a `group/iosection` ancestor). */
+ hoverRevealControls?: boolean;
};
export function MarkdownJsonViewHeader({
title,
titleIcon,
- handleOnValueChange: _handleOnValueChange,
handleOnCopy,
- canEnableMarkdown: _canEnableMarkdown = true,
controlButtons,
collapseControl,
inset = false,
+ hideCopyButton = false,
+ hoverRevealControls = false,
}: MarkdownJsonViewHeaderProps) {
const [isCopied, setIsCopied] = useState(false);
+ const collapseSubject = collapseControl?.subject ?? "system prompt";
const collapseLabel = collapseControl
? collapseControl.isCollapsed
- ? "Expand system prompt"
- : "Collapse system prompt"
+ ? `Expand ${collapseSubject}`
+ : `Collapse ${collapseSubject}`
: undefined;
// Keep the visible title in the title-button name (WCAG 2.5.3). A generic
// aria-label would hide message `name`s from assistive tech.
@@ -92,7 +99,15 @@ export function MarkdownJsonViewHeader({
titleContent
)}
</div>
- <div className="mr-1 flex min-w-0 shrink flex-row items-center gap-1">
+ <div
+ className={cn(
+ "mr-1 flex min-w-0 shrink flex-row items-center gap-1",
+ // pointer-coarse: touch devices have no hover, so the controls
+ // stay visible there instead of being unreachable.
+ hoverRevealControls &&
+ "opacity-0 transition-opacity group-hover/iosection:opacity-100 focus-within:opacity-100 pointer-coarse:opacity-100",
+ )}
+ >
{collapseControl ? (
<Button
variant="ghost"
@@ -106,24 +121,26 @@ export function MarkdownJsonViewHeader({
</Button>
) : null}
{controlButtons}
- <Button
- title="Copy to clipboard"
- variant="ghost"
- size="icon-xs"
- type="button"
- onClick={(event) => {
- setIsCopied(true);
- handleOnCopy(event);
- setTimeout(() => setIsCopied(false), 1000);
- }}
- className="hover:bg-border -mr-2"
- >
- {isCopied ? (
- <Check className="h-3 w-3" />
- ) : (
- <Copy className="h-3 w-3" />
- )}
- </Button>
+ {!hideCopyButton && (
+ <Button
+ title="Copy to clipboard"
+ variant="ghost"
+ size="icon-xs"
+ type="button"
+ onClick={(event) => {
+ setIsCopied(true);
+ handleOnCopy(event);
+ setTimeout(() => setIsCopied(false), 1000);
+ }}
+ className="hover:bg-border -mr-2"
+ >
+ {isCopied ? (
+ <Check className="h-3 w-3" />
+ ) : (
+ <Copy className="h-3 w-3" />
+ )}
+ </Button>
+ )}
</div>
</div>
);
@@ -147,8 +164,8 @@ export const canRenderContentAsMarkdown = (
// Don't render if markdown content is huge
JSON.stringify(content || {}).length <= characterLimit;
-// MarkdownJsonView will render markdown if `isMarkdownEnabled` (global context) is true and the content is valid markdown
-// otherwise, if content is valid markdown will render JSON with switch to enable markdown globally
+// MarkdownJsonView renders markdown whenever the content is valid markdown
+// (see canRenderContentAsMarkdown), otherwise it falls back to JSON.
export function MarkdownJsonView({
content,
title,
@@ -203,6 +220,7 @@ export function MarkdownJsonView({
title={title}
titleIcon={titleIcon}
className={className}
+ hoverControls
media={media}
currentView="pretty"
controlButtons={controlButtons}
diff --git a/web/src/components/ui/MarkdownViewer.clienttest.tsx b/web/src/components/ui/MarkdownViewer.clienttest.tsx
index 0eaf375ca5..d8e365d513 100644
--- a/web/src/components/ui/MarkdownViewer.clienttest.tsx
+++ b/web/src/components/ui/MarkdownViewer.clienttest.tsx
@@ -3,7 +3,6 @@ import {
MarkdownView,
prependBasePathToInternalHref,
} from "@/src/components/ui/MarkdownViewer";
-import { MarkdownContextProvider } from "@/src/features/theming/useMarkdownContext";
vi.mock("next/router", () => ({
useRouter: () => ({ query: {} }),
@@ -18,11 +17,7 @@ vi.mock("@/src/features/posthog-analytics/usePostHogClientCapture", () => ({
}));
const renderMarkdown = (markdown: string) =>
- render(
- <MarkdownContextProvider>
- <MarkdownView markdown={markdown} />
- </MarkdownContextProvider>,
- );
+ render(<MarkdownView markdown={markdown} />);
describe("MarkdownView link rendering", () => {
it("renders an external link as a native anchor opening in a new tab", () => {
@@ -161,19 +156,13 @@ describe("MarkdownView code blocks", () => {
it("reuses the same code block instance across re-renders", () => {
const markdown = "```js\nconst x = 1;\n```";
const { container, rerender } = render(
- <MarkdownContextProvider>
- <MarkdownView markdown={markdown} />
- </MarkdownContextProvider>,
+ <MarkdownView markdown={markdown} />,
);
const codeblock = container.querySelector(".codeblock");
expect(codeblock).not.toBeNull();
- rerender(
- <MarkdownContextProvider>
- <MarkdownView markdown={markdown} />
- </MarkdownContextProvider>,
- );
+ rerender(<MarkdownView markdown={markdown} />);
expect(container.querySelector(".codeblock")).toBe(codeblock);
});
diff --git a/web/src/components/ui/MarkdownViewer.stories.tsx b/web/src/components/ui/MarkdownViewer.stories.tsx
index 1dc889ec49..9a780348c5 100644
--- a/web/src/components/ui/MarkdownViewer.stories.tsx
+++ b/web/src/components/ui/MarkdownViewer.stories.tsx
@@ -1,4 +1,5 @@
import preview from "../../../.storybook/preview";
+import { expect, userEvent, waitFor, within } from "storybook/test";
import { MarkdownView } from "./MarkdownViewer";
const meta = preview.meta({
@@ -152,3 +153,24 @@ trace.generation({ name: "answer" });
- Compare cost`,
},
});
+
+export const HeaderControlsOnHover = meta.story({
+ name: "(Test) Reveals Header Controls On Hover",
+ args: {
+ markdown: "Hover this message to reveal its header controls.",
+ title: "assistant",
+ },
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ const copyButton = canvas.getByTitle("Copy to clipboard");
+ const message = copyButton.closest<HTMLElement>(".group\\/iosection");
+
+ if (!message) throw new Error("no markdown message");
+
+ await userEvent.unhover(message);
+ await waitFor(() => expect(copyButton).not.toBeVisible());
+
+ await userEvent.hover(message);
+ await waitFor(() => expect(copyButton).toBeVisible());
+ },
+});
diff --git a/web/src/components/ui/MarkdownViewer.tsx b/web/src/components/ui/MarkdownViewer.tsx
index f1feeeace7..5a27110128 100644
--- a/web/src/components/ui/MarkdownViewer.tsx
+++ b/web/src/components/ui/MarkdownViewer.tsx
@@ -18,8 +18,6 @@ import remarkGfm from "remark-gfm";
import { Codeblock as CodeBlock } from "@/src/components/design-system/Codeblock/Codeblock";
import { useTheme } from "next-themes";
import { ImageOff, Info } from "lucide-react";
-import { usePostHogClientCapture } from "@/src/features/posthog-analytics/usePostHogClientCapture";
-import { useMarkdownContext } from "@/src/features/theming/useMarkdownContext";
import { MentionBadge } from "@/src/features/comments/components/MentionBadge";
import {
OpenAIUrlImageUrl,
@@ -507,10 +505,8 @@ export function MarkdownView({
role. Falls back to matching the title for callers without role data. */
isSystemPrompt?: boolean;
}) {
- const capture = usePostHogClientCapture();
const { forcedTheme, resolvedTheme } = useTheme();
const theme = forcedTheme ?? resolvedTheme;
- const { setIsMarkdownEnabled } = useMarkdownContext();
const markdownContent =
typeof markdown === "string" ? markdown : parseOpenAIContentParts(markdown);
@@ -541,13 +537,6 @@ export function MarkdownView({
copyTextToClipboard(markdownContent);
};
- const handleOnValueChange = () => {
- setIsMarkdownEnabled(false);
- capture("trace_detail:io_pretty_format_toggle_group", {
- renderMarkdown: false,
- });
- };
-
const inlineMediaReferenceStrings =
typeof markdown === "string"
? getStandaloneMediaReferenceStrings(markdown)
@@ -569,14 +558,14 @@ export function MarkdownView({
) : null;
return (
- <div className="overflow-hidden" key={theme}>
+ <div className="group/iosection overflow-hidden" key={theme}>
{title ? (
<>
<MarkdownJsonViewHeader
title={title}
titleIcon={titleIcon}
- handleOnValueChange={handleOnValueChange}
handleOnCopy={handleOnCopy}
+ hoverRevealControls
controlButtons={controlButtons}
collapseControl={
shouldBeCollapsible
diff --git a/web/src/components/ui/PrettyJsonView.expansion.clienttest.tsx b/web/src/components/ui/PrettyJsonView.expansion.clienttest.tsx
index 8a0d9a5c09..00dc695a9a 100644
--- a/web/src/components/ui/PrettyJsonView.expansion.clienttest.tsx
+++ b/web/src/components/ui/PrettyJsonView.expansion.clienttest.tsx
@@ -5,11 +5,10 @@ vi.mock("@/src/features/posthog-analytics/usePostHogClientCapture", () => ({
usePostHogClientCapture: () => vi.fn(),
}));
-import { MarkdownContextProvider } from "@/src/features/theming/useMarkdownContext";
import { PrettyJsonView } from "@/src/components/ui/PrettyJsonView";
function renderPrettyJson(ui: ReactNode) {
- return render(<MarkdownContextProvider>{ui}</MarkdownContextProvider>);
+ return render(ui);
}
function prettyTable() {
diff --git a/web/src/components/ui/PrettyJsonView.tsx b/web/src/components/ui/PrettyJsonView.tsx
index de571b9db9..7564af935c 100644
--- a/web/src/components/ui/PrettyJsonView.tsx
+++ b/web/src/components/ui/PrettyJsonView.tsx
@@ -772,6 +772,9 @@ export function PrettyJsonView(props: {
inset?: boolean;
/** Content to render between header and main content (e.g., thinking blocks) */
afterHeader?: React.ReactNode;
+ /** Titled sections (Input/Output/Metadata): header controls (copy,
+ expand-all) reveal on section hover instead of rendering always. */
+ hoverControls?: boolean;
/** When set, rows show an actions menu with copy + add-to-filter shortcuts
(metadata views only). */
metadataActions?: MetadataFilterActions;
@@ -1410,10 +1413,46 @@ export function PrettyJsonView(props: {
</>
);
+ const expandCollapseButton = (
+ <>
+ {shouldUseTableView && (
+ <Button
+ variant="ghost"
+ size="icon-xs"
+ onClick={() => expandAllRef.current?.()}
+ className="hover:bg-border -mr-2"
+ title={allRowsExpanded ? "Collapse all rows" : "Expand all rows"}
+ >
+ {allRowsExpanded ? (
+ <FoldVertical className="h-3 w-3" />
+ ) : (
+ <UnfoldVertical className="h-3 w-3" />
+ )}
+ </Button>
+ )}
+ {!shouldUseTableView && !isMarkdownMode && !largeStringValue && (
+ <Button
+ variant="ghost"
+ size="icon-xs"
+ onClick={handleJsonToggleCollapse}
+ className="hover:bg-border -mr-2"
+ title={jsonIsCollapsed ? "Expand all" : "Collapse all"}
+ >
+ {jsonIsCollapsed ? (
+ <UnfoldVertical className="h-3 w-3" />
+ ) : (
+ <FoldVertical className="h-3 w-3" />
+ )}
+ </Button>
+ )}
+ </>
+ );
+
return (
<div
className={cn(
"flex max-h-full min-h-0 flex-col",
+ props.hoverControls && "group/iosection",
props.inset && "[&_.io-message-content]:px-2",
props.className,
props.scrollable ? "overflow-hidden" : "",
@@ -1423,8 +1462,6 @@ export function PrettyJsonView(props: {
<MarkdownJsonViewHeader
title={props.title}
titleIcon={props.titleIcon}
- canEnableMarkdown={false}
- handleOnValueChange={() => {}} // No-op, parent handles state
handleOnCopy={handleOnCopy}
collapseControl={
shouldCollapseSystemPrompt &&
@@ -1437,40 +1474,10 @@ export function PrettyJsonView(props: {
: undefined
}
inset={props.inset}
+ hoverRevealControls={props.hoverControls}
controlButtons={
<>
- {shouldUseTableView && (
- <Button
- variant="ghost"
- size="icon-xs"
- onClick={() => expandAllRef.current?.()}
- className="hover:bg-border -mr-2"
- title={
- allRowsExpanded ? "Collapse all rows" : "Expand all rows"
- }
- >
- {allRowsExpanded ? (
- <FoldVertical className="h-3 w-3" />
- ) : (
- <UnfoldVertical className="h-3 w-3" />
- )}
- </Button>
- )}
- {!shouldUseTableView && !isMarkdownMode && !largeStringValue && (
- <Button
- variant="ghost"
- size="icon-xs"
- onClick={handleJsonToggleCollapse}
- className="hover:bg-border -mr-2"
- title={jsonIsCollapsed ? "Expand all" : "Collapse all"}
- >
- {jsonIsCollapsed ? (
- <UnfoldVertical className="h-3 w-3" />
- ) : (
- <FoldVertical className="h-3 w-3" />
- )}
- </Button>
- )}
+ {expandCollapseButton}
{props.controlButtons}
</>
}
diff --git a/web/src/components/ui/action-button-count-badge.tsx b/web/src/components/ui/action-button-count-badge.tsx
index d70c398fc2..afd902c2c2 100644
--- a/web/src/components/ui/action-button-count-badge.tsx
+++ b/web/src/components/ui/action-button-count-badge.tsx
@@ -1,6 +1,22 @@
-export function ActionButtonCountBadge({ count }: { count: number }) {
+import { cn } from "@/src/utils/tailwind";
+
+export function ActionButtonCountBadge({
+ count,
+ variant = "default",
+}: {
+ count: number;
+ /** "muted" for quiet contexts (e.g. tab labels) where the primary fill shouts. */
+ variant?: "default" | "muted";
+}) {
return (
- <span className="bg-primary/50 text-primary-foreground flex h-3.5 w-fit items-center justify-center rounded-sm px-1 text-xs shadow-xs">
+ <span
+ className={cn(
+ "flex h-3.5 w-fit items-center justify-center rounded-sm px-1 text-xs",
+ variant === "muted"
+ ? "bg-muted text-muted-foreground"
+ : "bg-primary/50 text-primary-foreground shadow-xs",
+ )}
+ >
{count > 99 ? "99+" : count}
</span>
);
diff --git a/web/src/features/in-app-agent/components/InAppAgentExecution.clienttest.tsx b/web/src/features/in-app-agent/components/InAppAgentExecution.clienttest.tsx
index 35bb883927..6e55f721a1 100644
--- a/web/src/features/in-app-agent/components/InAppAgentExecution.clienttest.tsx
+++ b/web/src/features/in-app-agent/components/InAppAgentExecution.clienttest.tsx
@@ -13,7 +13,6 @@ import {
} from "@langfuse/shared/in-app-agent";
import { TooltipProvider } from "@/src/components/ui/tooltip";
-import { MarkdownContextProvider } from "@/src/features/theming/useMarkdownContext";
import { ControlledInAppAgentWindow } from "./ControlledInAppAgentWindow";
import { InAppAiAgentProvider, useInAppAiAgent } from "./InAppAiAgentProvider";
import styles from "./InAppAgentWindow.module.css";
@@ -260,19 +259,17 @@ function renderExecutionUi({
includeReopenButton?: boolean;
} = {}) {
return render(
- <MarkdownContextProvider>
- <InAppAiAgentProvider defaultOpen={defaultOpen}>
- <TooltipProvider>
- {includeReopenButton ? <ReopenAssistantButton /> : null}
- <ControlledInAppAgentWindow
- isExpanded={false}
- onDeleteConversation={vi.fn()}
- onExpandedChange={vi.fn()}
- showCloseButton={false}
- />
- </TooltipProvider>
- </InAppAiAgentProvider>
- </MarkdownContextProvider>,
+ <InAppAiAgentProvider defaultOpen={defaultOpen}>
+ <TooltipProvider>
+ {includeReopenButton ? <ReopenAssistantButton /> : null}
+ <ControlledInAppAgentWindow
+ isExpanded={false}
+ onDeleteConversation={vi.fn()}
+ onExpandedChange={vi.fn()}
+ showCloseButton={false}
+ />
+ </TooltipProvider>
+ </InAppAiAgentProvider>,
);
}
diff --git a/web/src/features/in-app-agent/components/InAppAgentWindow.clienttest.tsx b/web/src/features/in-app-agent/components/InAppAgentWindow.clienttest.tsx
index 64f8c94f9f..db30420466 100644
--- a/web/src/features/in-app-agent/components/InAppAgentWindow.clienttest.tsx
+++ b/web/src/features/in-app-agent/components/InAppAgentWindow.clienttest.tsx
@@ -8,7 +8,6 @@ import {
import { ScanSearch } from "lucide-react";
import { InAppAgentRunStatus } from "@langfuse/shared/in-app-agent";
import { TooltipProvider } from "@/src/components/ui/tooltip";
-import { MarkdownContextProvider } from "@/src/features/theming/useMarkdownContext";
import {
InAppAgentWindow,
type InAppAgentWindowProps,
@@ -117,11 +116,9 @@ function windowElement(
};
return (
- <MarkdownContextProvider>
- <TooltipProvider>
- <InAppAgentWindow {...props} />
- </TooltipProvider>
- </MarkdownContextProvider>
+ <TooltipProvider>
+ <InAppAgentWindow {...props} />
+ </TooltipProvider>
);
}
diff --git a/web/src/features/posthog-analytics/usePostHogClientCapture.ts b/web/src/features/posthog-analytics/usePostHogClientCapture.ts
index 70333fb3c1..ab221d797f 100644
--- a/web/src/features/posthog-analytics/usePostHogClientCapture.ts
+++ b/web/src/features/posthog-analytics/usePostHogClientCapture.ts
@@ -27,7 +27,6 @@ const events = {
"observation_tree_toggle_metrics",
"io_mode_switch",
"io_parser_comparison",
- "io_pretty_format_toggle_group",
"test_in_playground_button_click",
"display_mode_switch",
"download_button_click",
@@ -61,6 +60,10 @@ const events = {
// target tab, `target` is trace vs observation. Answers whether the Log
// View and Scores tabs earn their place.
"detail_tab_switch",
+ // Row actions on the Attributes, Model parameters and Metadata tables in
+ // the detail panel: `table` is which of the three, `action` is copy,
+ // include_filter or exclude_filter. Never the key or value text.
+ "attribute_table_action",
// Controls used *inside* the Log View tab, so a removal decision can weigh
// what people actually do there. `target` is trace vs observation;
// `action` is one of (see `LogViewAction` in TraceLogView.tsx):
@@ -73,6 +76,10 @@ const events = {
// The JSON-view Beta switch (legacy JSON <-> virtualized json-beta).
// `enabled` is the new value. Decides whether json-beta graduates.
"json_beta_toggle",
+ // Whole-section collapse chevrons on Input/Output/Metadata/Corrected
+ // Output. `section` is a fixed enum (never content), `collapsed` the new
+ // state. Informs future default-collapsed decisions.
+ "io_section_collapse_toggle",
],
// The shared table peek panel (opened via the `peek` URL param). Props carry
// `routePattern` (the Next.js route pattern, never a concrete URL) so opens
diff --git a/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.clienttest.tsx b/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.clienttest.tsx
index 553b8a8ca1..e837ecb596 100644
--- a/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.clienttest.tsx
+++ b/web/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.clienttest.tsx
@@ -4,7 +4,6 @@ import { describe, expect, it, vi } from "vitest";
import { SessionConversationTimelineTrace } from "@/src/features/sessions/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace";
import { prepareSessionTimelineObservations } from "@/src/features/sessions/SessionConversationTimeline/fns/prepareSessionTimelineObservations";
-import { MarkdownContextProvider } from "@/src/features/theming/useMarkdownContext";
type TraceProps = ComponentProps<typeof SessionConversationTimelineTrace>;
type Observation = Extract<
@@ -150,16 +149,14 @@ describe("SessionConversationTimelineTrace", () => {
]);
render(
- <MarkdownContextProvider>
- <SessionConversationTimelineTrace
- trace={{ ...trace, observationCount: 1 }}
- turnNumber={1}
- state={{ type: "loaded", observations: truncated }}
- onOpenTrace={vi.fn()}
- onOpenObservation={vi.fn()}
- scrollTarget={null}
- />
- </MarkdownContextProvider>,
+ <SessionConversationTimelineTrace
+ trace={{ ...trace, observationCount: 1 }}
+ turnNumber={1}
+ state={{ type: "loaded", observations: truncated }}
+ onOpenTrace={vi.fn()}
+ onOpenObservation={vi.fn()}
+ scrollTarget={null}
+ />,
);
expect(screen.getAllByText(/你好/).length).toBeGreaterThan(0);
@@ -178,16 +175,14 @@ describe("SessionConversationTimelineTrace", () => {
]);
render(
- <MarkdownContextProvider>
- <SessionConversationTimelineTrace
- trace={{ ...trace, observationCount: 1 }}
- turnNumber={1}
- state={{ type: "loaded", observations: loaded }}
- onOpenTrace={vi.fn()}
- onOpenObservation={vi.fn()}
- scrollTarget={null}
- />
- </MarkdownContextProvider>,
+ <SessionConversationTimelineTrace
+ trace={{ ...trace, observationCount: 1 }}
+ turnNumber={1}
+ state={{ type: "loaded", observations: loaded }}
+ onOpenTrace={vi.fn()}
+ onOpenObservation={vi.fn()}
+ scrollTarget={null}
+ />,
);
expect(screen.getByText(/你好 world/)).toBeInTheDocument();
diff --git a/web/src/features/theming/useMarkdownContext.tsx b/web/src/features/theming/useMarkdownContext.tsx
deleted file mode 100644
index ab161543e6..0000000000
--- a/web/src/features/theming/useMarkdownContext.tsx
+++ /dev/null
@@ -1,40 +0,0 @@
-import useLocalStorage from "@/src/components/useLocalStorage";
-import React, {
- type PropsWithChildren,
- createContext,
- useContext,
-} from "react";
-
-interface MarkdownContextType {
- isMarkdownEnabled: boolean;
- setIsMarkdownEnabled: (value: boolean) => void;
-}
-
-const MarkdownContext = createContext<MarkdownContextType | undefined>(
- undefined,
-);
-
-export const useMarkdownContext = (): MarkdownContextType => {
- const context = useContext(MarkdownContext);
- if (!context) {
- throw new Error(
- "useMarkdownContext must be used within a MarkdownContextProvider",
- );
- }
- return context;
-};
-
-export const MarkdownContextProvider = (props: PropsWithChildren) => {
- const [isMarkdownEnabled, setIsMarkdownEnabled] = useLocalStorage(
- "shouldRenderMarkdown",
- true,
- );
-
- return (
- <MarkdownContext.Provider
- value={{ isMarkdownEnabled, setIsMarkdownEnabled }}
- >
- {props.children}
- </MarkdownContext.Provider>
- );
-};
diff --git a/web/src/features/traces/components/IOPreview/components/ChatMessage.clienttest.tsx b/web/src/features/traces/components/IOPreview/components/ChatMessage.clienttest.tsx
index 3264a6aa2e..e9a867fcec 100644
--- a/web/src/features/traces/components/IOPreview/components/ChatMessage.clienttest.tsx
+++ b/web/src/features/traces/components/IOPreview/components/ChatMessage.clienttest.tsx
@@ -38,7 +38,6 @@ import { ChatMlArraySchema } from "@langfuse/shared";
import { ChatMessage } from "./ChatMessage";
import { type ChatMlMessage } from "../../../fns/chatMessageUtils";
-import { MarkdownContextProvider } from "@/src/features/theming/useMarkdownContext";
import { type IOPreviewContentMode } from "../IOPreview";
function createMemoryStorage(): Storage {
@@ -78,14 +77,12 @@ function renderChatMessage(
} = {},
) {
return render(
- <MarkdownContextProvider>
- <ChatMessage
- message={message}
- shouldRenderMarkdown={shouldRenderMarkdown}
- currentView="pretty"
- contentMode={contentMode}
- />
- </MarkdownContextProvider>,
+ <ChatMessage
+ message={message}
+ shouldRenderMarkdown={shouldRenderMarkdown}
+ currentView="pretty"
+ contentMode={contentMode}
+ />,
);
}
diff --git a/web/src/features/traces/components/IOPreview/components/ChatMessage.tsx b/web/src/features/traces/components/IOPreview/components/ChatMessage.tsx
index 2eb1472006..23dab5a1b9 100644
--- a/web/src/features/traces/components/IOPreview/components/ChatMessage.tsx
+++ b/web/src/features/traces/components/IOPreview/components/ChatMessage.tsx
@@ -101,6 +101,7 @@ export function ChatMessage({
title="Placeholder"
json={message.name || "Unnamed placeholder"}
currentView={currentView}
+ hoverControls
/>
</div>
</div>
@@ -115,6 +116,7 @@ export function ChatMessage({
title={title || (isOutputMessage ? "Output" : "Input")}
json={message.json}
currentView={currentView}
+ hoverControls
/>
</div>
);
@@ -129,6 +131,7 @@ export function ChatMessage({
json={message.json}
currentView="pretty"
controlButtons={passthroughToggleButton}
+ hoverControls
/>
</div>
);
@@ -145,7 +148,6 @@ export function ChatMessage({
<div className="hover:bg-muted transition-colors">
<MarkdownJsonViewHeader
title={title}
- handleOnValueChange={() => {}}
handleOnCopy={() => {
// Shared stringify (not raw JSON.stringify) so \uXXXX escapes in
// string fields are copied as real characters, like the rendered
@@ -218,6 +220,7 @@ export function ChatMessage({
controlButtons={passthroughToggleButton}
afterHeader={thinkingBlocks}
isSystemPrompt={isSystemPrompt}
+ hoverControls
/>
{showData && toolCalls.length > 0 && (
<div className="mt-2">
@@ -240,6 +243,7 @@ export function ChatMessage({
title={title || (isOutputMessage ? "Output" : "Input")}
json={withoutUnsetFields(message)}
currentView={currentView}
+ hoverControls
/>
</div>
);
diff --git a/web/src/features/traces/components/IOPreview/components/StatusMessageSection.tsx b/web/src/features/traces/components/IOPreview/components/StatusMessageSection.tsx
index b75fe96578..915f588eb2 100644
--- a/web/src/features/traces/components/IOPreview/components/StatusMessageSection.tsx
+++ b/web/src/features/traces/components/IOPreview/components/StatusMessageSection.tsx
@@ -50,9 +50,7 @@ export function StatusMessageSection({
<div>
<MarkdownJsonViewHeader
title={presentation.title}
- handleOnValueChange={() => undefined}
handleOnCopy={() => copyTextToClipboard(status.message)}
- canEnableMarkdown={false}
inset
/>
<div
diff --git a/web/src/pages/_app.tsx b/web/src/pages/_app.tsx
index 827b88d4c8..872af9b87f 100644
--- a/web/src/pages/_app.tsx
+++ b/web/src/pages/_app.tsx
@@ -84,7 +84,6 @@ import { ResilientSessionProvider } from "@/src/features/auth/components/Resilie
import { DetailPageListsProvider } from "@/src/features/navigate-detail-pages/context";
import { env } from "@/src/env.mjs";
import { ThemeProvider } from "@/src/features/theming/ThemeProvider";
-import { MarkdownContextProvider } from "@/src/features/theming/useMarkdownContext";
import { MarkdownRenderCharacterLimitProvider } from "@/src/hooks/useMarkdownRenderCharacterLimit";
import { SupportDrawerProvider } from "@/src/features/support-chat/SupportDrawerProvider";
import { V4MigrationPanelProvider } from "@/src/features/v4-migration/V4MigrationPanelProvider";
@@ -203,31 +202,29 @@ const MyApp: AppType<{ session: Session | null }> = ({
>
<ResilientSessionProvider basePath={authBasePath}>
<DetailPageListsProvider>
- <MarkdownContextProvider>
- <MarkdownRenderCharacterLimitProvider>
- <ThemeProvider
- attribute="class"
- enableSystem
- disableTransitionOnChange
- >
- <ScoreCacheProvider>
- <CorrectionCacheProvider>
- <SupportDrawerProvider defaultOpen={false}>
- <V4MigrationPanelProvider defaultOpen={false}>
- <InAppAiAgentProvider defaultOpen={false}>
- {skipAppLayout ? (
- page
- ) : (
- <AppLayout>{page}</AppLayout>
- )}
- </InAppAiAgentProvider>
- </V4MigrationPanelProvider>
- </SupportDrawerProvider>
- </CorrectionCacheProvider>
- </ScoreCacheProvider>
- </ThemeProvider>
- </MarkdownRenderCharacterLimitProvider>
- </MarkdownContextProvider>
+ <MarkdownRenderCharacterLimitProvider>
+ <ThemeProvider
+ attribute="class"
+ enableSystem
+ disableTransitionOnChange
+ >
+ <ScoreCacheProvider>
+ <CorrectionCacheProvider>
+ <SupportDrawerProvider defaultOpen={false}>
+ <V4MigrationPanelProvider defaultOpen={false}>
+ <InAppAiAgentProvider defaultOpen={false}>
+ {skipAppLayout ? (
+ page
+ ) : (
+ <AppLayout>{page}</AppLayout>
+ )}
+ </InAppAiAgentProvider>
+ </V4MigrationPanelProvider>
+ </SupportDrawerProvider>
+ </CorrectionCacheProvider>
+ </ScoreCacheProvider>
+ </ThemeProvider>
+ </MarkdownRenderCharacterLimitProvider>
</DetailPageListsProvider>
</ResilientSessionProvider>
</SessionProvider>