Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Fix no-null-render: ObservationMetadataBadgesSimple.tsx (#18230)

Ben Bachem48fe88aca654
diff --git a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx
index 90b93e8937..d57690eafe 100644
--- a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx
+++ b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx
@@ -473,10 +473,14 @@ export const ObservationDetailViewHeader = memo(
) : (
<CollapsibleBadgeRow>
{timestampBadge}
- <LatencyBadge latencySeconds={latencySeconds} />
- <TimeToFirstTokenBadge
- timeToFirstToken={observation.timeToFirstToken}
- />
+ {latencySeconds != null && (
+ <LatencyBadge latencySeconds={latencySeconds} />
+ )}
+ {observation.timeToFirstToken != null && (
+ <TimeToFirstTokenBadge
+ timeToFirstToken={observation.timeToFirstToken}
+ />
+ )}
{evaluatorId &&
(observation.environment ===
LangfuseInternalTraceEnvironment.LLMJudge ||
diff --git a/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsx b/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsx
index 1887622510..47c56b2b7a 100644
--- a/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsx
+++ b/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsx
@@ -1,29 +1,15 @@
-/* eslint-disable @repo/no-null-render */
-/**
- * Simple metadata badges for ObservationDetailView
- * Each badge handles its own null checks and returns null when data is unavailable
- */
-
import { Badge } from "@/src/components/design-system/Badge/Badge";
import { formatIntervalSeconds } from "@/src/utils/dates";
-export function LatencyBadge({
- latencySeconds,
-}: {
- latencySeconds: number | null;
-}) {
- if (latencySeconds == null) return null;
-
+export function LatencyBadge({ latencySeconds }: { latencySeconds: number }) {
return <Badge color="ghost" text={formatIntervalSeconds(latencySeconds)} />;
}
export function TimeToFirstTokenBadge({
timeToFirstToken,
}: {
- timeToFirstToken: number | null | undefined;
+ timeToFirstToken: number;
}) {
- if (timeToFirstToken == null) return null;
-
return (
<Badge
color="ghost"
diff --git a/web/src/features/traces/components/TraceHeader.tsx b/web/src/features/traces/components/TraceHeader.tsx
index 47d90470fc..544eb9ac5c 100644
--- a/web/src/features/traces/components/TraceHeader.tsx
+++ b/web/src/features/traces/components/TraceHeader.tsx
@@ -50,7 +50,9 @@ export function TraceHeader() {
)}
>
<div className="flex flex-wrap items-center gap-4">
- <LatencyBadge latencySeconds={trace.latency ?? null} />
+ {trace.latency != null && (
+ <LatencyBadge latencySeconds={trace.latency} />
+ )}
{aggregatedMetrics.totalCost != null &&
aggregatedMetrics.costDetails && (
<CostBadge