🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
feat(topics): selection continuity in trace map (#19079)
Nimar5a24c7528cb2
diff --git a/web/src/components/table/data-table.tsx b/web/src/components/table/data-table.tsxindex d784f78be2..fc15cae62b 100644--- a/web/src/components/table/data-table.tsx+++ b/web/src/components/table/data-table.tsx@@ -937,6 +937,7 @@ function TableRowComponent<TData>({return (<TableRowdata-row-index={row.index}+ aria-selected={rowIsSelected || shouldHighlightAllRows || undefined}onClick={(e) => {if (shouldIgnoreRowClickTarget(e.target)) return;onRowClick?.(row.original, e);diff --git a/web/src/features/topics/CurrentTopics.tsx b/web/src/features/topics/CurrentTopics.tsxindex ae013ffbbb..bef71d536f 100644--- a/web/src/features/topics/CurrentTopics.tsx+++ b/web/src/features/topics/CurrentTopics.tsx@@ -41,7 +41,7 @@ export function CurrentTopics({{result.isLoading && <p className="text-sm">Loading topics…</p>}{selectedFacet && (<CurrentFacet- key={selectedFacet.facetId}+ key={JSON.stringify([projectId, selectedFacet.facetId])}projectId={projectId}facet={selectedFacet}timeRange={timeRange}diff --git a/web/src/features/topics/CurrentTopicsView.stories.tsx b/web/src/features/topics/CurrentTopicsView.stories.tsxindex ff3a6efac7..a1b660568e 100644--- a/web/src/features/topics/CurrentTopicsView.stories.tsx+++ b/web/src/features/topics/CurrentTopicsView.stories.tsx@@ -74,6 +74,11 @@ const meta = preview.meta({component: CurrentTopicsView,args: defaultArgs,render: (args) => <ControlledTopics {...args} />,+ beforeEach: () => {+ sessionStorage.removeItem("topics-selected-trace:storybook-topics");+ return () =>+ sessionStorage.removeItem("topics-selected-trace:storybook-topics");+ },});export const Default = meta.story({});@@ -420,3 +425,146 @@ function resetPanelSizes() {keys.forEach((key) => localStorage.removeItem(key));return () => keys.forEach((key) => localStorage.removeItem(key));}++export const TraceSelectionAcrossFacets = meta.story({+ name: "(Test) Map selection follows traces across facets without opening peek",+ args: {+ peekView: { ...defaultArgs.peekView, openPeek: fn() },+ },+ render: function Render(args) {+ const [facetId, setFacetId] = useState("intent");+ function switchFacet() {+ setFacetId((value) => (value === "intent" ? "sentiment" : "intent"));+ }+ return (+ <div>+ <Button text="Switch facet" onClick={switchFacet} />+ <ControlledTopics+ key={facetId}+ {...args}+ facet={{+ ...args.facet,+ facetId,+ rows: [...args.facet.rows].reverse(),+ }}+ />+ </div>+ );+ },+ play: async ({ canvasElement, args }) => {+ const canvas = within(canvasElement);+ const stage = canvas.getByRole("group", { name: /^Interactive topic map/ });+ await waitFor(() =>+ expect(stage.getBoundingClientRect().height).toBeGreaterThan(0),+ );+ const model = prepareTopicMap(mapData, [topic]);+ const rect = stage.getBoundingClientRect();+ const size = { width: rect.width, height: rect.height };+ const camera = fitCamera(model.bounds, model.bounds, size);+ const at = screenPoint(+ model.pointById.get("trace-0")!,+ camera,+ model.bounds,+ size,+ );+ function clickMap(x = at.x, y = at.y) {+ const map = canvas.getByRole("group", { name: /^Interactive topic map/ });+ const bounds = map.getBoundingClientRect();+ map.dispatchEvent(+ new MouseEvent("click", {+ bubbles: true,+ clientX: bounds.left + x,+ clientY: bounds.top + y,+ }),+ );+ }+ await afterPaint();+ clickMap();+ await expect(args.onOpenTrace).not.toHaveBeenCalled();+ await waitFor(() => {+ const row = canvas.getByRole("link", { name: "trace-0" }).closest("tr")!;+ expect(row).toHaveAttribute("aria-selected", "true");+ const panel = canvas.getByRole("region", { name: "Topic traces" });+ expect(row.getBoundingClientRect().bottom).toBeLessThanOrEqual(+ panel.getBoundingClientRect().bottom,+ );+ expect(+ JSON.parse(+ sessionStorage.getItem("topics-selected-trace:storybook-topics")!,+ ),+ ).toBe("trace-0");+ });+ const refresh = canvas.getByRole("button", {+ name: "Refresh unchanged results",+ });+ await userEvent.click(refresh);+ await expect(+ canvas.getByRole("link", { name: "trace-0" }).closest("tr"),+ ).toHaveAttribute("aria-selected", "true");+ await userEvent.click(+ canvas.getByRole("button", { name: "Go to next page" }),+ );+ await userEvent.click(refresh);+ await expect(canvas.getByRole("link", { name: "trace-99" })).toBeVisible();+ clickMap();+ await waitFor(() =>+ expect(canvas.getByRole("link", { name: "trace-0" })).toBeVisible(),+ );+ clickMap(5, 5);+ await waitFor(() =>+ expect(+ canvas.getByRole("link", { name: "trace-0" }).closest("tr"),+ ).not.toHaveAttribute("aria-selected"),+ );+ clickMap();+ await userEvent.click(canvas.getByRole("button", { name: "Switch facet" }));+ await expect(+ canvas.getByRole("link", { name: "trace-0" }).closest("tr"),+ ).toHaveAttribute("aria-selected", "true");+ for (+ let attempt = 0;+ attempt < 16 &&+ !canvas.queryByRole("button", {+ name: /^Select trace:.*Account setup 0/,+ });+ attempt+++ ) {+ await userEvent.click(+ canvas.getByRole("button", { name: "Zoom in (+)" }),+ );+ await afterPaint();+ }+ const selected = canvas.getByRole("button", {+ name: /^Select trace:.*Account setup 0/,+ });+ await expect(selected).toHaveAttribute("aria-pressed", "true");+ await userEvent.click(selected);+ await expect(args.onOpenTrace).not.toHaveBeenCalled();+ await userEvent.click(canvas.getByRole("link", { name: "trace-0" }));+ await expect(args.onOpenTrace).toHaveBeenCalledOnce();+ await expect(args.onOpenTrace).toHaveBeenCalledWith("trace-0");+ await userEvent.click(canvas.getByText("Account setup 1"));+ await expect(args.peekView.openPeek).toHaveBeenCalledOnce();+ await expect(+ canvas.getByRole("link", { name: "trace-1" }).closest("tr"),+ ).toHaveAttribute("aria-selected", "true");+ const search = canvas.getByRole("combobox", { name: "Search" });+ await replaceQuery(search, "invoice");+ await waitFor(() =>+ expect(+ canvas.queryByRole("link", { name: "trace-0" }),+ ).not.toBeInTheDocument(),+ );+ clickMap();+ await afterPaint();+ await expect(+ sessionStorage.getItem("topics-selected-trace:storybook-topics"),+ ).toBe(JSON.stringify("trace-1"));+ await replaceQuery(search, "");+ await waitFor(() =>+ expect(+ canvas.getByRole("link", { name: "trace-1" }).closest("tr"),+ ).toHaveAttribute("aria-selected", "true"),+ );+ },+});diff --git a/web/src/features/topics/CurrentTopicsView.tsx b/web/src/features/topics/CurrentTopicsView.tsxindex 1e174b3ced..7bafecfd9b 100644--- a/web/src/features/topics/CurrentTopicsView.tsx+++ b/web/src/features/topics/CurrentTopicsView.tsx@@ -1,8 +1,16 @@import { computeSelectedValues, type FilterState } from "@langfuse/shared";-import { useMemo, useState, type ComponentProps, type ReactNode } from "react";+import {+ useEffect,+ useMemo,+ useRef,+ useState,+ type ComponentProps,+ type ReactNode,+} from "react";import { useMediaQuery } from "react-responsive";import { type OnChangeFn, type PaginationState } from "@tanstack/react-table";import { DataTable } from "@/src/components/table/data-table";+import useSessionStorage from "@/src/components/useSessionStorage";import { type LangfuseColumnDef } from "@/src/components/table/types";import { type DataTablePeekViewProps } from "@/src/components/table/peek";import { type RouterOutputs } from "@/src/utils/api";@@ -40,16 +48,29 @@ export function CurrentTopicsView({onGenerateTopics,canGenerateTopics,}: CurrentTopicsViewProps) {- const [selectedTraceId, setSelectedTraceId] = useState<string | null>(null);+ const [selectedTraceId, setSelectedTraceId] = useSessionStorage<+ string | null+ >(`topics-selected-trace:${projectId}`, null);const isNarrow = useMediaQuery({ query: "(max-width: 1023px)" });const [mobilePanel, setMobilePanel] = useState("traces");const { filters, setFilters, searchQuery, setSearchQuery } = traceFilters;const filterKey = JSON.stringify([filters, searchQuery]);const [pageSize, setPageSize] = useState(20);+ const [pageRequest, setPageRequest] = useState({+ filterKey,+ pageIndex: 0,+ followSelection: true,+ });+ if (pageRequest.filterKey !== filterKey) {+ setPageRequest({ filterKey, pageIndex: 0, followSelection: true });+ }function selectTopic(topicId: string | null) {- setSelectedTraceId(null);setFilters(selectTopicTraceFilters(filters, topicId));}+ function openTrace(traceId: string) {+ selectTrace(traceId);+ onOpenTrace(traceId);+ }const { visible, matchingTraceKey } = useMemo(() => {const isFiltered = filters.length > 0 || Boolean(searchQuery?.trim());const visible = isFiltered@@ -62,6 +83,30 @@ export function CurrentTopicsView({: null,};}, [facet.rows, filters, searchQuery]);+ const selectedRowIndex = visible.findIndex(+ (row) => row.traceId === selectedTraceId,+ );+ const { followSelection } = pageRequest;+ const pageIndex = Math.min(+ followSelection && selectedRowIndex >= 0+ ? Math.floor(selectedRowIndex / pageSize)+ : pageRequest.pageIndex,+ Math.max(0, Math.ceil(visible.length / pageSize) - 1),+ );+ const pagination = { pageIndex, pageSize };+ function selectTrace(traceId: string | null) {+ setSelectedTraceId(traceId);+ setPageRequest({ filterKey, pageIndex, followSelection: traceId !== null });+ }+ const onPaginationChange: OnChangeFn<PaginationState> = (update) => {+ const next = typeof update === "function" ? update(pagination) : update;+ setPageRequest({+ filterKey,+ pageIndex: next.pageIndex,+ followSelection: false,+ });+ setPageSize(next.pageSize);+ };/** Frame identity changes only when matching IDs change, preserving hover and focus across refreshes. */const matchingTraceIds = useMemo(() =>@@ -101,13 +146,12 @@ export function CurrentTopicsView({<TopicEmbeddingMapkey={facet.map.runId}query={mapResult}- onOpenTrace={onOpenTrace}projectId={projectId}topics={facet.map.topics}selectedTopic={null}matchingTraceIds={matchingTraceIds}onSelectTopic={selectTopic}- onSelectTrace={setSelectedTraceId}+ onSelectTrace={selectTrace}selectedTraceId={selectedTraceId &&(!matchingTraceIds || matchingTraceIds.has(selectedTraceId))@@ -183,13 +227,16 @@ export function CurrentTopicsView({<CurrentTraceTablekey={filterKey}projectId={projectId}- onOpenTrace={onOpenTrace}+ onOpenTrace={openTrace}+ selectedTraceId={selectedTraceId}+ onSelectTrace={selectTrace}peekView={peekView}rows={visible}totalCount={facet.rows.length}topics={topics}- pageSize={pageSize}- onPageSizeChange={setPageSize}+ pagination={pagination}+ onPaginationChange={onPaginationChange}+ revealRowIndex={followSelection ? selectedRowIndex : -1}/></section>);@@ -335,28 +382,32 @@ function TopicsWorkspaceSplit({function CurrentTraceTable({projectId,onOpenTrace,+ selectedTraceId,+ onSelectTrace,peekView,rows,totalCount,topics,- pageSize,- onPageSizeChange,+ pagination,+ onPaginationChange,+ revealRowIndex,}: CurrentTraceTableProps) {- const [requestedPageIndex, setPageIndex] = useState(0);+ const tableRef = useRef<HTMLDivElement>(null);+ const { pageIndex } = pagination;+ useEffect(() => {+ if (revealRowIndex >= 0) {+ tableRef.current+ ?.querySelector('[aria-selected="true"]')+ ?.scrollIntoView({ block: "nearest" });+ }+ }, [selectedTraceId, revealRowIndex, pageIndex]);const isMobile = useIsMobile();const topicColors = new Map(topics.map((topic, index) => [topic.id, topicBadgeColor(index)]),);- const pageIndex = Math.min(- requestedPageIndex,- Math.max(0, Math.ceil(rows.length / pageSize) - 1),- );- const pagination = { pageIndex, pageSize };- const onPaginationChange: OnChangeFn<PaginationState> = (update) => {- const next = typeof update === "function" ? update(pagination) : update;- setPageIndex(next.pageIndex);- onPageSizeChange(next.pageSize);- };+ function selectRow(row: Facet["rows"][number]) {+ onSelectTrace(row.traceId);+ }const columns: LangfuseColumnDef<Facet["rows"][number]>[] = [{accessorKey: "traceId",@@ -426,7 +477,10 @@ function CurrentTraceTable({},];return (- <div className="flex min-h-0 min-w-0 flex-1 flex-col overflow-hidden">+ <div+ ref={tableRef}+ className="flex min-h-0 min-w-0 flex-1 flex-col overflow-hidden"+ ><DataTabletableName="topics-current-traces"columns={columns}@@ -452,6 +506,8 @@ function CurrentTraceTable({className="min-h-0 overscroll-contain"cellPadding="relaxed"noResultsMessage="No matches. Adjust or clear your filters."+ rowSelection={selectedTraceId ? { [selectedTraceId]: true } : {}}+ onRowClick={selectRow}peekView={peekView}/></div>@@ -482,12 +538,15 @@ type TopicsWorkspaceSplitProps = {type CurrentTraceTableProps = {projectId: string;onOpenTrace: (traceId: string) => void;+ selectedTraceId: string | null;+ onSelectTrace: (traceId: string) => void;peekView: DataTablePeekViewProps;rows: Facet["rows"];totalCount: number;topics: { id: string }[];- pageSize: number;- onPageSizeChange: (pageSize: number) => void;+ pagination: PaginationState;+ onPaginationChange: OnChangeFn<PaginationState>;+ revealRowIndex: number;};type CurrentTopicsViewProps = {diff --git a/web/src/features/topics/EmbeddingMapView.stories.tsx b/web/src/features/topics/EmbeddingMapView.stories.tsxindex 8b7fd07a84..ace0cb8034 100644--- a/web/src/features/topics/EmbeddingMapView.stories.tsx+++ b/web/src/features/topics/EmbeddingMapView.stories.tsx@@ -314,7 +314,6 @@ const meta = preview.meta({selectedTraceId: null,onSelectTopic: fn(),onSelectTrace: fn(),- onOpenTrace: fn(),},});@@ -398,7 +397,6 @@ export const ExploreZoneAndTrace = meta.story({selectedTraceId: null,onSelectTopic: fn(),onSelectTrace: fn(),- onOpenTrace: fn(),},render: (args) => <ControlledExplorer {...args} />,play: async ({ canvasElement, args }) => {@@ -432,7 +430,7 @@ export const ExploreZoneAndTrace = meta.story({const stage = canvas.getByRole("group", {name: /^Interactive topic map/,});- await expect(args.onOpenTrace).toHaveBeenCalledWith(trace.traceId);+ await expect(summaryButton).toHaveAttribute("aria-pressed", "true");stage.focus();await userEvent.keyboard("0");await expect(args.onSelectTopic).toHaveBeenLastCalledWith(null);@@ -690,7 +688,6 @@ export const HoverPreservesMapGeometry = meta.story({selectedTopic: null,selectedTraceId: null,onSelectTrace: fn(),- onOpenTrace: fn(),},render: (args) => (<div style={{ height: 680 }}>@@ -768,7 +765,6 @@ export const HoverPreservesMapGeometry = meta.story({}),);await expect(args.onSelectTrace).toHaveBeenLastCalledWith(trace.traceId);- await expect(args.onOpenTrace).toHaveBeenLastCalledWith(trace.traceId);await waitFor(assertStageBounds);stage.dispatchEvent(new MouseEvent("click", {diff --git a/web/src/features/topics/README.md b/web/src/features/topics/README.mdindex 8c41460f09..8fa860c1e0 100644--- a/web/src/features/topics/README.md+++ b/web/src/features/topics/README.md@@ -17,6 +17,13 @@ project permissions. Processing additionally requires the project allowlist.the resizable map above Topics/Traces tabs, with readablesummary rows on phones and all processing controls in the mobile overflowmenu. Selecting a group filters traces without changing the active tab.+ Map clicks select a trace without opening peek. `CurrentTopicsView` keeps+ that trace ID in project-scoped sessionStorage, shared across facets, and+ highlights its map point and table row. Selection changes reveal the trace's+ table page and follow it through result refreshes until the user paginates.+ Clearing selection preserves the current page. Filtered-out map points cannot+ replace selection; filters can hide a selection without discarding it. Table row+ and trace-link clicks select the trace and open peek.`useTopicTraceFilters.ts` owns URL-backed facet selection; filters and searchlive only in localStorage, scoped to each project/facet. Switching facetsrestores that facet's state, defaulting to unfiltered on first visit. Filterdiff --git a/web/src/features/topics/TopicEmbeddingMap.tsx b/web/src/features/topics/TopicEmbeddingMap.tsxindex 88a9819850..9ace910afc 100644--- a/web/src/features/topics/TopicEmbeddingMap.tsx+++ b/web/src/features/topics/TopicEmbeddingMap.tsx@@ -6,7 +6,6 @@ import { TopicMapLoading } from "./TopicMapLoading";export function TopicEmbeddingMap({projectId,query,- onOpenTrace,topics,selectedTopic,onSelectTopic,@@ -35,7 +34,6 @@ export function TopicEmbeddingMap({return (<EmbeddingMapViewprojectId={projectId}- onOpenTrace={onOpenTrace}data={query.data}topics={topics}selectedTopic={selectedTopic}@@ -54,7 +52,6 @@ type TopicEmbeddingMapProps = {data?: RouterOutputs["topics"]["map"];error: { message: string } | null;};- onOpenTrace: (traceId: string) => void;topics: Topic[];selectedTopic: string | null;onSelectTopic: (id: string | null) => void;diff --git a/web/src/features/topics/TopicMapLoading.stories.tsx b/web/src/features/topics/TopicMapLoading.stories.tsxindex ee03fbc470..30c1bb5907 100644--- a/web/src/features/topics/TopicMapLoading.stories.tsx+++ b/web/src/features/topics/TopicMapLoading.stories.tsx@@ -19,7 +19,6 @@ const meta = preview.meta({selectedTraceId={null}onSelectTopic={fn()}onSelectTrace={fn()}- onOpenTrace={fn()}fillContainer={args.fillContainer}/></div>diff --git a/web/src/features/topics/map/TopicMapExplorer.tsx b/web/src/features/topics/map/TopicMapExplorer.tsxindex fbec0e0086..7c615053ea 100644--- a/web/src/features/topics/map/TopicMapExplorer.tsx+++ b/web/src/features/topics/map/TopicMapExplorer.tsx@@ -71,7 +71,6 @@ export function TopicMapExplorer({onSelectTrace,selectedTraceId,matchingTraceIds,- onOpenTrace,fillContainer = false,}: TopicMapExplorerProps) {// Projection preparation is independent of the high-frequency camera store.@@ -217,15 +216,10 @@ export function TopicMapExplorer({store.setState({ fullscreenError: true });}};- const openTrace = async (id: string) => {+ const selectTrace = (id: string | null) => {+ if (id !== null && matchingTraceIds && !matchingTraceIds.has(id)) return;clearTopicMapHover(store);- try {- if (document.fullscreenElement === sectionRef.current)- await document.exitFullscreen();- onOpenTrace(id);- } catch {- store.setState({ fullscreenError: true });- }+ onSelectTrace(id);};const handlePointerMove = (event: ReactPointerEvent<HTMLDivElement>) => {gestures.pointerHandlers.onPointerMove(event);@@ -300,8 +294,7 @@ export function TopicMapExplorer({y: event.clientY - rect.top,}): null;- onSelectTrace(point?.traceId ?? null);- if (point) openTrace(point.traceId);+ selectTrace(point?.traceId ?? null);};const handleStageDoubleClick = (event: ReactMouseEvent<HTMLDivElement>) => {if (event.target !== event.currentTarget) return;@@ -359,10 +352,6 @@ export function TopicMapExplorer({const handleToggleFullscreen = () => {toggleFullscreen();};- const handleSelectTrace = (id: string) => {- onSelectTrace(id);- openTrace(id);- };return (<sectionref={sectionRef}@@ -446,7 +435,7 @@ export function TopicMapExplorer({selectedTopic={selectedTopic}selectedTraceId={selectedTraceId}matchingTraceIds={matchingTraceIds}- onSelectTrace={handleSelectTrace}+ onSelectTrace={selectTrace}/>{model.points.length === 0 && (<div className="text-muted-foreground pointer-events-none absolute inset-0 flex items-center justify-center p-6 text-center text-sm">@@ -771,7 +760,6 @@ export type TopicMapExplorerProps = {onSelectTrace: (traceId: string | null) => void;selectedTraceId: string | null;matchingTraceIds?: ReadonlySet<string>;- onOpenTrace: (traceId: string) => void;fillContainer?: boolean;};