🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(web): lock viewport scale so mobile focus does not zoom (#16001)
Nikita Kabardin5dc661a42848
diff --git a/web/src/components/movable-resizable-panel.clienttest.tsx b/web/src/components/movable-resizable-panel.clienttest.tsxindex 0c8c7b91d5..86cffc126d 100644--- a/web/src/components/movable-resizable-panel.clienttest.tsx+++ b/web/src/components/movable-resizable-panel.clienttest.tsx@@ -356,6 +356,44 @@ describe("MovableResizablePanel", () => {);});+ it("keeps clamping clear of the safe-area insets", () => {+ // Silent-failure guard: a wrong var name would just read 0 and place the+ // panel under the home indicator with nothing to notice.+ document.documentElement.style.setProperty(+ "--safe-area-inset-right",+ "20px",+ );+ document.documentElement.style.setProperty(+ "--safe-area-inset-bottom",+ "34px",+ );++ render(<TestPanel />);++ const panel = screen.getByTestId("movable-resizable-panel");+ const handle = screen.getByTestId("drag-handle");++ firePointerEvent(handle, "pointerdown", {+ pointerId: 1,+ clientX: 140,+ clientY: 150,+ });+ firePointerEvent(panel, "pointermove", {+ pointerId: 1,+ clientX: 5000,+ clientY: 5000,+ });+ firePointerEvent(panel, "pointerup", { pointerId: 1 });++ // 1024 - 10 padding - 20 inset - 300 wide, 768 - 10 - 34 - 240 tall.+ expect(screen.getByTestId("panel-state")).toHaveTextContent(+ "694,484,300,240",+ );++ document.documentElement.style.removeProperty("--safe-area-inset-right");+ document.documentElement.style.removeProperty("--safe-area-inset-bottom");+ });+it("does not start dragging from explicitly ignored elements inside a handle", () => {const onActionClick = vi.fn();diff --git a/web/src/components/movable-resizable-panel.tsx b/web/src/components/movable-resizable-panel.tsxindex bb985da111..544e5edde9 100644--- a/web/src/components/movable-resizable-panel.tsx+++ b/web/src/components/movable-resizable-panel.tsx@@ -233,6 +233,18 @@ function clamp(value: number, min: number, max: number) {return Math.min(Math.max(value, min), max);}+// The OS reserves the safe-area edges (home indicator, notch), and+// `viewport-fit=cover` means innerWidth/innerHeight now span them, so bounds+// have to subtract them or the panel places and clamps under system UI.+// globals.css mirrors each `env()` inset into a var for this; 0 without a notch.+function getSafeAreaInset(edge: "top" | "right" | "bottom" | "left"): number {+ const value = getComputedStyle(document.documentElement).getPropertyValue(+ `--safe-area-inset-${edge}`,+ );++ return Number.parseFloat(value) || 0;+}+function getViewportBounds(boundsPadding: number,): MovableResizablePanelViewportBounds {@@ -246,10 +258,10 @@ function getViewportBounds(}return {- minLeft: boundsPadding,- minTop: boundsPadding,- maxRight: window.innerWidth - boundsPadding,- maxBottom: window.innerHeight - boundsPadding,+ minLeft: boundsPadding + getSafeAreaInset("left"),+ minTop: boundsPadding + getSafeAreaInset("top"),+ maxRight: window.innerWidth - boundsPadding - getSafeAreaInset("right"),+ maxBottom: window.innerHeight - boundsPadding - getSafeAreaInset("bottom"),};}diff --git a/web/src/features/in-app-agent/components/InAppAgentWindowShell.tsx b/web/src/features/in-app-agent/components/InAppAgentWindowShell.tsxindex 417230d4de..4b493b81fb 100644--- a/web/src/features/in-app-agent/components/InAppAgentWindowShell.tsx+++ b/web/src/features/in-app-agent/components/InAppAgentWindowShell.tsx@@ -82,9 +82,12 @@ export function InAppAgentWindowShell({// layer ORDER stacks the whole `agent` layer below every transient overlay.if (isExpanded) {return (+ // `--banner-offset` carries the top inset; the other three edges add+ // theirs here, because the viewport meta's `viewport-fit=cover` extends+ // layout under the home indicator and, in landscape, the notch.<divref={panelRef}- className="pointer-events-auto fixed inset-x-3 top-[calc(var(--banner-offset)+0.75rem)] bottom-3 origin-top-left"+ className="pointer-events-auto fixed top-[calc(var(--banner-offset)+0.75rem)] right-[calc(0.75rem+env(safe-area-inset-right,0px))] bottom-[calc(0.75rem+env(safe-area-inset-bottom,0px))] left-[calc(0.75rem+env(safe-area-inset-left,0px))] origin-top-left"data-ignore-outside-interaction><divdiff --git a/web/src/pages/_app.tsx b/web/src/pages/_app.tsxindex 2b49c8196e..e9ea6ec9c1 100644--- a/web/src/pages/_app.tsx+++ b/web/src/pages/_app.tsx@@ -4,6 +4,7 @@import "@/src/polyfills/crypto-random-uuid";import { type AppType } from "next/app";+import Head from "next/head";import { type Session } from "next-auth";import { SessionProvider } from "next-auth/react";import { setUser } from "@sentry/nextjs";@@ -144,49 +145,63 @@ const MyApp: AppType<{ session: Session | null }> = ({);return (- <QueryParamProvider- adapter={NextAdapterPagesWithReadyGuard}- options={{ enableBatching: true }}- >- <TooltipProvider>- <CommandMenuProvider>- <PostHogProvider client={posthog}>- <SessionProvider- session={session}- refetchOnWindowFocus={true}- refetchInterval={5 * 60} // 5 minutes- basePath={`${env.NEXT_PUBLIC_BASE_PATH ?? ""}/api/auth`}- >- <DetailPageListsProvider>- <MarkdownContextProvider>- <ThemeProvider- attribute="class"- enableSystem- disableTransitionOnChange- >- <ScoreCacheProvider>- <CorrectionCacheProvider>- <SupportDrawerProvider defaultOpen={false}>- <V4MigrationPanelProvider defaultOpen={false}>- <InAppAiAgentProvider defaultOpen={false}>- {skipAppLayout ? (- page- ) : (- <AppLayout>{page}</AppLayout>- )}- </InAppAiAgentProvider>- </V4MigrationPanelProvider>- </SupportDrawerProvider>- </CorrectionCacheProvider>- </ScoreCacheProvider>- </ThemeProvider>- </MarkdownContextProvider>- </DetailPageListsProvider>- </SessionProvider>- </PostHogProvider>- </CommandMenuProvider>- </TooltipProvider>- </QueryParamProvider>+ <>+ {/* Replaces Next's default `width=device-width` (next/head dedupes by+ name). `maximum-scale=1` stops iOS Safari auto-zooming a focused+ sub-16px field; iOS ignores `user-scalable=no` for user gestures, so+ the engine-level zoom block is `touch-action` on html/body+ (styles/globals.css). `viewport-fit=cover` is what makes+ `env(safe-area-inset-*)` non-zero. */}+ <Head>+ <meta+ name="viewport"+ content="width=device-width, height=device-height, initial-scale=1, maximum-scale=1, user-scalable=no, shrink-to-fit=no, viewport-fit=cover"+ />+ </Head>+ <QueryParamProvider+ adapter={NextAdapterPagesWithReadyGuard}+ options={{ enableBatching: true }}+ >+ <TooltipProvider>+ <CommandMenuProvider>+ <PostHogProvider client={posthog}>+ <SessionProvider+ session={session}+ refetchOnWindowFocus={true}+ refetchInterval={5 * 60} // 5 minutes+ basePath={`${env.NEXT_PUBLIC_BASE_PATH ?? ""}/api/auth`}+ >+ <DetailPageListsProvider>+ <MarkdownContextProvider>+ <ThemeProvider+ attribute="class"+ enableSystem+ disableTransitionOnChange+ >+ <ScoreCacheProvider>+ <CorrectionCacheProvider>+ <SupportDrawerProvider defaultOpen={false}>+ <V4MigrationPanelProvider defaultOpen={false}>+ <InAppAiAgentProvider defaultOpen={false}>+ {skipAppLayout ? (+ page+ ) : (+ <AppLayout>{page}</AppLayout>+ )}+ </InAppAiAgentProvider>+ </V4MigrationPanelProvider>+ </SupportDrawerProvider>+ </CorrectionCacheProvider>+ </ScoreCacheProvider>+ </ThemeProvider>+ </MarkdownContextProvider>+ </DetailPageListsProvider>+ </SessionProvider>+ </PostHogProvider>+ </CommandMenuProvider>+ </TooltipProvider>+ </QueryParamProvider>+ </>);};diff --git a/web/src/styles/globals.css b/web/src/styles/globals.cssindex 567e26a960..9d3bfd9b9d 100644--- a/web/src/styles/globals.css+++ b/web/src/styles/globals.css@@ -397,6 +397,14 @@--banner-offset: calc(env(safe-area-inset-top, 0px) + var(--banner-height, 0px));++ /* `env()` is CSS-only, so mirror the insets into custom properties that JS+ can read (getComputedStyle resolves them to px). Non-zero only because+ the viewport meta sets `viewport-fit=cover` — see pages/_app.tsx. */+ --safe-area-inset-top: env(safe-area-inset-top, 0px);+ --safe-area-inset-right: env(safe-area-inset-right, 0px);+ --safe-area-inset-bottom: env(safe-area-inset-bottom, 0px);+ --safe-area-inset-left: env(safe-area-inset-left, 0px);}.dark {@@ -572,6 +580,11 @@body {/* Prevent pull-to-refresh and rubber-banding on the page level only */overscroll-behavior-y: none;+ /* Omitting `pinch-zoom` blocks pinch and double-tap zoom at the engine+ level, which modern iOS honors where it ignores `user-scalable=no`+ (viewport meta lives in pages/_app.tsx). Elements that own their own+ gestures set their own `touch-action`. */+ touch-action: pan-x pan-y;}body {