Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Use `createStatusTableColumn` more (#16951)

Ben Bachem5dd4bfb4dd77
diff --git a/web/src/components/design-system/table/columns/createStatusTableColumn.stories.tsx b/web/src/components/design-system/table/columns/createStatusTableColumn.stories.tsx
index 313a1f764f..3b779b9e6a 100644
--- a/web/src/components/design-system/table/columns/createStatusTableColumn.stories.tsx
+++ b/web/src/components/design-system/table/columns/createStatusTableColumn.stories.tsx
@@ -8,21 +8,28 @@ import { createStatusTableColumn } from "./createStatusTableColumn";
type Row = {
status: string | null;
+ isStatusLoading?: boolean;
};
function StatusTableColumnStory({
data,
isLive = true,
+ emptyValue,
}: {
data: AsyncTableData<Row[]>;
isLive?: boolean;
+ emptyValue?: string;
}) {
const columns = [
createStatusTableColumn<Row, string>({
accessorKey: "status",
header: "Status",
- getStatus: (status) => status ?? undefined,
+ getStatus: (status, { row }) =>
+ row.original.isStatusLoading
+ ? { type: "loading" }
+ : (status ?? undefined),
isLive,
+ emptyValue,
}),
];
@@ -74,6 +81,7 @@ export const EmptyValue = meta.story({
isError: false,
data: [{ status: null }],
},
+ emptyValue: "-",
},
});
@@ -96,3 +104,17 @@ export const Loading = meta.story({
},
},
});
+
+export const MappedValueLoading = meta.story({
+ name: "Mapped Value Loading",
+ args: {
+ data: {
+ isLoading: false,
+ isError: false,
+ data: [
+ { status: "pending-metrics", isStatusLoading: true },
+ { status: "error" },
+ ],
+ },
+ },
+});
diff --git a/web/src/components/design-system/table/columns/createStatusTableColumn.tsx b/web/src/components/design-system/table/columns/createStatusTableColumn.tsx
index f70118f5a0..60548c67ee 100644
--- a/web/src/components/design-system/table/columns/createStatusTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createStatusTableColumn.tsx
@@ -11,26 +11,36 @@ import {
type TableColumnOptions,
} from "./utils/createTableColumn";
+type StatusCell = Status | (string & {}) | { type: "loading" } | undefined;
+
export function createStatusTableColumn<
TData extends RowData,
TValue = Status,
>({
getStatus,
isLive,
+ emptyValue,
...options
}: TableColumnOptions<TData, TValue> & {
getStatus: (
value: TValue | null | undefined,
context: CellContext<TData, TValue | null | undefined>,
- ) => Status | (string & {}) | undefined;
+ ) => StatusCell;
isLive?: boolean;
+ emptyValue?: string;
}) {
+ const loadingCell = <Skeleton className="h-5 w-16 shrink-0 rounded-sm" />;
+
return createTableColumn<TData, TValue>({
...options,
- loadingCell: <Skeleton className="h-5 w-16 shrink-0 rounded-sm" />,
+ loadingCell,
renderCell: (value, context) => {
const status = getStatus(value, context);
- return status ? <StatusBadge type={status} isLive={isLive} /> : null;
+
+ if (status === undefined) return emptyValue ?? null;
+ if (typeof status !== "string") return loadingCell;
+
+ return <StatusBadge type={status} isLive={isLive} />;
},
});
}
diff --git a/web/src/components/level-colors.tsx b/web/src/components/level-colors.tsx
index 9074985bc0..92d9bc84af 100644
--- a/web/src/components/level-colors.tsx
+++ b/web/src/components/level-colors.tsx
@@ -2,6 +2,19 @@ import type React from "react";
import { type ObservationLevelType } from "@langfuse/shared";
import { cn } from "@/src/utils/tailwind";
+const observationLevelToStatus = {
+ ERROR: "error",
+ WARNING: "warning",
+ DEBUG: "debug",
+ DEFAULT: "default",
+} as const satisfies Record<ObservationLevelType, string>;
+
+export function getObservationLevelStatus(level: string): string {
+ return Object.hasOwn(observationLevelToStatus, level)
+ ? observationLevelToStatus[level as ObservationLevelType]
+ : level;
+}
+
export const LevelColors = {
DEFAULT: { text: "", bg: "" },
DEBUG: { text: "text-muted-foreground", bg: "bg-tertiary" },
diff --git a/web/src/components/table/use-cases/observations.tsx b/web/src/components/table/use-cases/observations.tsx
index 698eab16e5..9638de733f 100644
--- a/web/src/components/table/use-cases/observations.tsx
+++ b/web/src/components/table/use-cases/observations.tsx
@@ -49,8 +49,7 @@ import { formatIntervalSeconds } from "@/src/utils/dates";
import useColumnVisibility from "@/src/features/column-visibility/hooks/useColumnVisibility";
import { Skeleton } from "@/src/components/ui/skeleton";
import { type LangfuseColumnDef } from "@/src/components/table/types";
-import { cn } from "@/src/utils/tailwind";
-import { getLevelColors } from "@/src/components/level-colors";
+import { getObservationLevelStatus } from "@/src/components/level-colors";
import { numberFormatter, usdFormatter } from "@/src/utils/numbers";
import {
formatObservationCost,
@@ -80,6 +79,7 @@ import { createNumberTableColumn } from "@/src/components/design-system/table/co
import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
import { createDurationTableColumn } from "@/src/components/design-system/table/columns/createDurationTableColumn";
import { createItemBadgeTableColumn } from "@/src/components/design-system/table/columns/createItemBadgeTableColumn";
+import { createStatusTableColumn } from "@/src/components/design-system/table/columns/createStatusTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
import { createTagsTableColumn } from "@/src/components/design-system/table/columns/createTagsTableColumn";
import { createTokenUsageTableColumn } from "@/src/components/design-system/table/columns/createTokenUsageTableColumn";
@@ -774,9 +774,8 @@ export default function ObservationsTable({
},
enableHiding: true,
},
- {
+ createStatusTableColumn<ObservationsTableRow, ObservationLevelType>({
accessorKey: "level",
- id: "level",
header: "Status",
size: 100,
headerTooltip: {
@@ -785,22 +784,11 @@ export default function ObservationsTable({
href: "https://langfuse.com/docs/observability/features/log-levels",
},
enableHiding: true,
- cell({ row }) {
- const value: ObservationLevelType | undefined = row.getValue("level");
- return value ? (
- <span
- className={cn(
- "rounded-sm p-0.5 text-xs",
- getLevelColors(value).bg,
- getLevelColors(value).text,
- )}
- >
- {value}
- </span>
- ) : undefined;
- },
enableSorting,
- },
+ isLive: false,
+ getStatus: (level) =>
+ level ? getObservationLevelStatus(level) : undefined,
+ }),
createTextTableColumn<ObservationsTableRow>({
accessorKey: "statusMessage",
header: "Status Message",
diff --git a/web/src/components/table/use-cases/score-configs.tsx b/web/src/components/table/use-cases/score-configs.tsx
index 892baa9642..77eca64e6e 100644
--- a/web/src/components/table/use-cases/score-configs.tsx
+++ b/web/src/components/table/use-cases/score-configs.tsx
@@ -141,17 +141,13 @@ export function ScoreConfigsTable({ projectId }: { projectId: string }) {
enableHiding: true,
defaultHidden: true,
}),
- {
+ createTextTableColumn<ScoreConfigTableRow, boolean>({
accessorKey: "isArchived",
- id: "isArchived",
header: "Status",
size: 80,
enableHiding: true,
- cell: ({ row }) => {
- const { isArchived } = row.original;
- return isArchived ? "Archived" : "Active";
- },
- },
+ mapValue: (isArchived) => (isArchived ? "Archived" : "Active"),
+ }),
{
accessorKey: "action",
header: "Action",
diff --git a/web/src/components/table/use-cases/traces.tsx b/web/src/components/table/use-cases/traces.tsx
index 86db92d244..be6bab58eb 100644
--- a/web/src/components/table/use-cases/traces.tsx
+++ b/web/src/components/table/use-cases/traces.tsx
@@ -10,6 +10,7 @@ import { createDateTableColumn } from "@/src/components/design-system/table/colu
import { createDropdownTableColumn } from "@/src/components/design-system/table/columns/createDropdownTableColumn";
import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
+import { createStatusTableColumn } from "@/src/components/design-system/table/columns/createStatusTableColumn";
import { createTagsTableColumn } from "@/src/components/design-system/table/columns/createTagsTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
import { createTokenUsageTableColumn } from "@/src/components/design-system/table/columns/createTokenUsageTableColumn";
@@ -37,10 +38,9 @@ import {
import { DeleteTraceButton } from "@/src/components/deleteButton";
import {
formatAsLabel,
- getLevelColors,
LevelSymbols,
+ getObservationLevelStatus,
} from "@/src/components/level-colors";
-import { cn } from "@/src/utils/tailwind";
import {
detailPageListKeys,
useDetailPageLists,
@@ -981,35 +981,22 @@ export default function TracesTable({
getValue: (value, { row }) =>
isMetricPending(row.original.id) ? { type: "loading" } : (value ?? 0n),
}),
- {
+ createStatusTableColumn<TracesTableRow, ObservationLevelType>({
accessorKey: "level",
- id: "level",
header: "Status",
size: 75,
- loadingCell: <Skeleton className="h-4 w-1/2" />,
- cell: ({ row }) => {
- const value: TracesTableRow["level"] = row.getValue("level");
- if (isMetricPending(row.original.id)) {
- return <Skeleton className="h-4 w-1/2" />;
- }
- return value ? (
- <span
- className={cn(
- "rounded-sm p-0.5 text-xs",
- getLevelColors(value).bg,
- getLevelColors(value).text,
- )}
- >
- {value}
- </span>
- ) : (
- <span>-</span>
- );
- },
defaultHidden: true,
enableHiding: true,
enableSorting,
- },
+ isLive: false,
+ emptyValue: "-",
+ getStatus: (level, { row }) =>
+ isMetricPending(row.original.id)
+ ? { type: "loading" }
+ : level
+ ? getObservationLevelStatus(level)
+ : undefined,
+ }),
createTextTableColumn<TracesTableRow>({
accessorKey: "version",
header: "Version",
diff --git a/web/src/components/ui/StatusBadge/StatusBadge.tsx b/web/src/components/ui/StatusBadge/StatusBadge.tsx
index e12567c4c8..e051734818 100644
--- a/web/src/components/ui/StatusBadge/StatusBadge.tsx
+++ b/web/src/components/ui/StatusBadge/StatusBadge.tsx
@@ -21,11 +21,11 @@ const statusCategories = {
active: ["production", "live", "active", "public"],
pending: ["pending", "waiting", "queued", "running", "processing"],
delayed: ["delayed"],
- inactive: ["disabled", "inactive", "archived", "cancelled"],
+ inactive: ["disabled", "inactive", "archived", "cancelled", "debug"],
paused: ["paused"],
completed: ["completed", "done", "finished"],
- error: ["error", "failed"],
- partial: ["partial"],
+ error: ["error", "failed", "triggered"],
+ partial: ["partial", "warning"],
} as const;
export type Status =
diff --git a/web/src/ee/features/billing/components/SpendAlerts/SpendAlertsTable.tsx b/web/src/ee/features/billing/components/SpendAlerts/SpendAlertsTable.tsx
index 5c8a1ab18f..4767ffec13 100644
--- a/web/src/ee/features/billing/components/SpendAlerts/SpendAlertsTable.tsx
+++ b/web/src/ee/features/billing/components/SpendAlerts/SpendAlertsTable.tsx
@@ -1,5 +1,4 @@
import { useMemo, useState } from "react";
-import { Badge } from "@/src/components/ui/badge";
import { DropdownMenuItem } from "@/src/components/ui/dropdown-menu";
import { Edit, Trash2 } from "lucide-react";
import { api } from "@/src/utils/api";
@@ -12,6 +11,7 @@ import { DataTableToolbar } from "@/src/components/table/data-table-toolbar";
import { type LangfuseColumnDef } from "@/src/components/table/types";
import { createDropdownTableColumn } from "@/src/components/design-system/table/columns/createDropdownTableColumn";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
+import { createStatusTableColumn } from "@/src/components/design-system/table/columns/createStatusTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
import { costFormatter } from "@/src/utils/numbers";
@@ -80,17 +80,14 @@ export function SpendAlertsTable({ orgId }: SpendAlertsTableProps) {
size: 140,
formatter: costFormatter,
}),
- {
- accessorKey: "status",
+ createStatusTableColumn<AlertRow, Date>({
id: "status",
+ accessorFn: (row) => row.triggeredAt,
header: "Status",
size: 110,
- cell: ({ row }) => (
- <Badge variant={row.original.triggeredAt ? "destructive" : "secondary"}>
- {row.original.triggeredAt ? "Triggered" : "Active"}
- </Badge>
- ),
- },
+ isLive: false,
+ getStatus: (triggeredAt) => (triggeredAt ? "triggered" : "active"),
+ }),
{
accessorKey: "lastTriggered",
id: "lastTriggered",
diff --git a/web/src/features/evals/components/evaluator-table.tsx b/web/src/features/evals/components/evaluator-table.tsx
index 4216a8c281..ed80aaed1e 100644
--- a/web/src/features/evals/components/evaluator-table.tsx
+++ b/web/src/features/evals/components/evaluator-table.tsx
@@ -1,4 +1,3 @@
-import { StatusBadge } from "@/src/components/ui/StatusBadge/StatusBadge";
import { encodeFiltersGeneric } from "@langfuse/shared";
import { LevelCountsDisplay } from "@/src/components/level-counts-display";
import { DataTable } from "@/src/components/table/data-table";
@@ -49,6 +48,7 @@ import { usdFormatter } from "@/src/utils/numbers";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
+import { createStatusTableColumn } from "@/src/components/design-system/table/columns/createStatusTableColumn";
import {
type EvaluatorDataRow,
useEvaluatorTableData,
@@ -209,20 +209,12 @@ export default function EvaluatorTable({ projectId }: { projectId: string }) {
);
},
}),
- columnHelper.accessor("status", {
+ createStatusTableColumn<EvaluatorDataRow, string>({
+ accessorKey: "status",
header: "Status",
- id: "status",
enableSorting: true,
size: 80,
- loadingCell: <Skeleton className="h-5 w-16 shrink-0 rounded-sm" />,
- cell: (row) => {
- const status = row.getValue();
- return (
- <div className={status === "FINISHED" ? "pl-3" : undefined}>
- <StatusBadge type={status.toLowerCase()} />
- </div>
- );
- },
+ getStatus: (status) => status?.toLowerCase(),
}),
createNumberTableColumn<EvaluatorDataRow>({
accessorKey: "totalCost",
diff --git a/web/src/features/events/components/EventsTable.tsx b/web/src/features/events/components/EventsTable.tsx
index 23ce6504c4..3160588be8 100644
--- a/web/src/features/events/components/EventsTable.tsx
+++ b/web/src/features/events/components/EventsTable.tsx
@@ -46,12 +46,13 @@ import { createIdTableColumn } from "@/src/components/design-system/table/column
import { createItemBadgeTableColumn } from "@/src/components/design-system/table/columns/createItemBadgeTableColumn";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
import { createIOTableColumn } from "@/src/components/design-system/table/columns/createIOTableColumn";
+import { createStatusTableColumn } from "@/src/components/design-system/table/columns/createStatusTableColumn";
import { createTagsTableColumn } from "@/src/components/design-system/table/columns/createTagsTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
import { type LangfuseColumnDef } from "@/src/components/table/types";
import { filterStateToQueryText } from "@/src/features/search-bar/lib/filter-state-to-query";
import { cn } from "@/src/utils/tailwind";
-import { getLevelColors } from "@/src/components/level-colors";
+import { getObservationLevelStatus } from "@/src/components/level-colors";
import {
compactNumberFormatter,
numberFormatter,
@@ -1183,9 +1184,8 @@ export default function ObservationsEventsTable({
singleLine: rowHeight === "s",
enableHiding: true,
}),
- {
+ createStatusTableColumn<EventsTableRow, ObservationLevelType>({
accessorKey: "level",
- id: "level",
header: getEventsColumnName("level"),
size: 100,
headerTooltip: {
@@ -1194,22 +1194,11 @@ export default function ObservationsEventsTable({
href: "https://langfuse.com/docs/observability/features/log-levels",
},
enableHiding: true,
- cell: ({ row }) => {
- const value: ObservationLevelType | undefined = row.getValue("level");
- return value ? (
- <span
- className={cn(
- "rounded-sm p-0.5 text-xs",
- getLevelColors(value).bg,
- getLevelColors(value).text,
- )}
- >
- {value}
- </span>
- ) : undefined;
- },
enableSorting,
- },
+ isLive: false,
+ getStatus: (level) =>
+ level ? getObservationLevelStatus(level) : undefined,
+ }),
createIOTableColumn<EventsTableRow>({
accessorKey: "statusMessage",
header: getEventsColumnName("statusMessage"),