🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
feat(experiments): colour-code the compared runs, align a score cell's icons, and lighten the dark-mode red (#17277)
Nikita Kabardin5f90110f3b4a
diff --git a/web/src/components/scores-table-cell.tsx b/web/src/components/scores-table-cell.tsxindex c58427304c..41a03180e2 100644--- a/web/src/components/scores-table-cell.tsx+++ b/web/src/components/scores-table-cell.tsx@@ -87,9 +87,13 @@ export const ScoresTableCell = ({: aggregate.values[0];return (+ // The value and its icons are one line, so they are centred as one:+ // `inline-flex` triggers keep each icon's box the size of the icon, which+ // the row then centres. Left to stretch, a trigger's box grows with the+ // row and pins the icon to its top, off the value's centre.<spanclassName={cn(- "flex min-w-0 flex-row gap-0.5 rounded-sm",+ "flex min-w-0 flex-row items-center gap-0.5 rounded-sm",COLOR_MAP.get(value),)}>@@ -101,7 +105,7 @@ export const ScoresTableCell = ({</span>{aggregate.comment && (<HoverCard>- <HoverCardTrigger className="inline-block shrink-0 cursor-pointer">+ <HoverCardTrigger className="inline-flex shrink-0 cursor-pointer items-center"><MessageCircleMore size={12} /></HoverCardTrigger><HoverCardContent className="flex flex-col p-0 text-xs break-normal whitespace-normal">@@ -212,7 +216,7 @@ function AggregateScoreMetadataPeek({return (<HoverCard onOpenChange={setIsOpen}>- <HoverCardTrigger className="inline-block cursor-pointer">+ <HoverCardTrigger className="inline-flex shrink-0 cursor-pointer items-center"><BracesIcon size={12} /></HoverCardTrigger><HoverCardContent className="overflow-hidden rounded-md border-none p-0 text-xs break-normal whitespace-normal">diff --git a/web/src/features/experiments/components/ExperimentComparisonSelector.clienttest.tsx b/web/src/features/experiments/components/ExperimentComparisonSelector.clienttest.tsxindex 813418eb75..963c81aac6 100644--- a/web/src/features/experiments/components/ExperimentComparisonSelector.clienttest.tsx+++ b/web/src/features/experiments/components/ExperimentComparisonSelector.clienttest.tsx@@ -1,6 +1,12 @@-import { fireEvent, render, screen } from "@testing-library/react";+import { fireEvent, render, screen, within } from "@testing-library/react";import { beforeEach, describe, expect, it, vi } from "vitest";+import { TooltipProvider } from "@/src/components/ui/tooltip";import { ExperimentComparisonSelector } from "./ExperimentComparisonSelector";+import { ExperimentScoreMatrix } from "./table/ExperimentScoreMatrix";+import {+ getExperimentColorStyles,+ type ExperimentItemsTableRow,+} from "./table/types";const h = vi.hoisted(() => ({capture: vi.fn(),@@ -65,6 +71,7 @@ describe("ExperimentComparisonSelector analytics", () => {projectId="p1"baselineExperimentId="exp-a"selectedIds={[]}+ colorExperimentIds={[]}selectedExperimentCount={1}onSelectedIdsChange={h.onSelectedIdsChange}isAutoSelectEnabled={true}@@ -97,6 +104,7 @@ describe("ExperimentComparisonSelector analytics", () => {projectId="p1"baselineExperimentId="exp-a"selectedIds={[]}+ colorExperimentIds={[]}selectedExperimentCount={1}onSelectedIdsChange={h.onSelectedIdsChange}isAutoSelectEnabled={true}@@ -123,3 +131,104 @@ describe("ExperimentComparisonSelector analytics", () => {);});});++// The invariant: every surface that paints a run's colour resolves it from the+// one order the selection publishes, so the run pickers and the layouts agree+// in every layout, with and without a baseline. The matrix stands in for the+// layouts here: it is the one that reached the colour through its own list.+describe("run colours agree across surfaces", () => {+ const scoreKey = "groundedness-EVAL-NUMERIC";+ const matrixColumns = h.searchResults.map((experiment, index) => ({+ experimentId: experiment.experimentId,+ experimentName: experiment.experimentName,+ isBaseline: index === 0,+ }));+ const matrixRows = [+ {+ id: "item-1",+ experiments: matrixColumns.map((column) => ({+ experimentId: column.experimentId,+ traceScores: { [scoreKey]: { type: "NUMERIC", average: 0.5 } },+ })),+ },+ ] as unknown as ExperimentItemsTableRow[];++ const renderChips = (colorExperimentIds: string[]) =>+ render(+ <ExperimentComparisonSelector+ projectId="p1"+ baselineExperimentId="exp-a"+ selectedIds={["exp-b", "exp-c"]}+ colorExperimentIds={colorExperimentIds}+ selectedExperimentCount={3}+ onSelectedIdsChange={h.onSelectedIdsChange}+ isAutoSelectEnabled={true}+ onAutoSelectEnabledChange={h.onAutoSelectEnabledChange}+ />,+ ).container;++ const renderMatrix = (colorExperimentIds: string[]) =>+ render(+ <TooltipProvider>+ <ExperimentScoreMatrix+ rows={matrixRows}+ scoreRows={[+ {+ scoreKey,+ level: "trace",+ dataType: "NUMERIC",+ label: "# groundedness",+ },+ ]}+ experiments={matrixColumns}+ colorExperimentIds={colorExperimentIds}+ isLoading={false}+ pagination={{+ totalCount: 1,+ onChange: vi.fn(),+ state: { pageIndex: 0, pageSize: 50 },+ }}+ />+ </TooltipProvider>,+ ).container;++ const markerOf = (container: HTMLElement, experimentName: string) =>+ within(container)+ .getByText(experimentName)+ .parentElement?.querySelector("span.rounded-full");++ it("gives a run the same colour in the pickers and in the matrix", () => {+ // Baseline first, then the comparisons in selection order — the list the+ // table's cells index into.+ const colorExperimentIds = ["exp-a", "exp-b", "exp-c"];+ const chips = renderChips(colorExperimentIds);+ const matrix = renderMatrix(colorExperimentIds);++ for (const [id, name] of [+ ["exp-b", "My Experiment B"],+ ["exp-c", "My Experiment C"],+ ]) {+ const expected = getExperimentColorStyles(+ id,+ colorExperimentIds,+ ).markerClass;+ expect(markerOf(chips, name)?.className).toContain(expected);+ expect(markerOf(matrix, name)?.className).toContain(expected);+ }+ expect(markerOf(matrix, "My Experiment B")?.className).not.toEqual(+ markerOf(matrix, "My Experiment C")?.className,+ );+ });++ it("stays plain everywhere with no baseline to colour against", () => {+ const chips = renderChips([]);+ const matrix = renderMatrix([]);++ for (const name of ["My Experiment B", "My Experiment C"]) {+ expect(markerOf(chips, name)).toBeNull();+ expect(markerOf(matrix, name)).toBeNull();+ // The colour goes, the run does not: a column keeps its name.+ expect(within(matrix).getByText(name)).toBeTruthy();+ }+ });+});diff --git a/web/src/features/experiments/components/ExperimentComparisonSelector.tsx b/web/src/features/experiments/components/ExperimentComparisonSelector.tsxindex 10716c5498..fca3721f3a 100644--- a/web/src/features/experiments/components/ExperimentComparisonSelector.tsx+++ b/web/src/features/experiments/components/ExperimentComparisonSelector.tsx@@ -23,6 +23,8 @@ import {NO_DATASET_LABEL,UNNAMED_DATASET_LABEL,} from "@/src/features/experiments/constants/comparison";+import { getExperimentColorStyles } from "./table/types";+import { cn } from "@/src/utils/tailwind";export type ExperimentOption = Omit<ExperimentNameOption, "startTime"> & {/** null when an id in the URL no longer resolves to a run. */@@ -73,6 +75,8 @@ type ExperimentComparisonSelectorProps = {projectId: string;baselineExperimentId?: string;selectedIds: string[];+ /** The run order the table's cells colour by. See `useExperimentResultsState`. */+ colorExperimentIds: string[];selectedExperimentCount: number;onSelectedIdsChange: (ids: string[]) => void;isAutoSelectEnabled: boolean;@@ -83,6 +87,7 @@ export function ExperimentComparisonSelector({projectId,baselineExperimentId,selectedIds,+ colorExperimentIds,selectedExperimentCount,onSelectedIdsChange,isAutoSelectEnabled,@@ -482,11 +487,29 @@ export function ExperimentComparisonSelector({.filter(Boolean).join("\n");+ // Same run, same colour as its values in the table — resolved from the+ // order the cells use, never from this chip's own position. Absent when+ // the cells show no colour at all (no baseline to compare against).+ const colorStyles = colorExperimentIds.includes(option.experimentId)+ ? getExperimentColorStyles(option.experimentId, colorExperimentIds)+ : undefined;+return (<Badgevariant="secondary"- className="flex shrink-0 items-center gap-1 px-2 py-0.5"+ className={cn(+ "flex shrink-0 items-center gap-1 px-2 py-0.5",+ colorStyles?.badgeClass,+ )}>+ {colorStyles && (+ <span+ className={cn(+ "block h-3 w-0.5 shrink-0 rounded-full",+ colorStyles.markerClass,+ )}+ />+ )}<span className="max-w-40 truncate text-xs" title={chipTitle}>{option.experimentName}</span>diff --git a/web/src/features/experiments/components/ExperimentSelectionControls.tsx b/web/src/features/experiments/components/ExperimentSelectionControls.tsxindex 4638cb08df..29a1528540 100644--- a/web/src/features/experiments/components/ExperimentSelectionControls.tsx+++ b/web/src/features/experiments/components/ExperimentSelectionControls.tsx@@ -10,12 +10,16 @@ import {} from "@/src/features/experiments/lib/analytics";import { ExperimentBaselineControls } from "./ExperimentBaselineControls";import { ExperimentComparisonSelector } from "./ExperimentComparisonSelector";+import { getExperimentColorStyles } from "./table/types";+import { cn } from "@/src/utils/tailwind";type ExperimentSelectionControlsProps = {projectId: string;baselineId?: string;baselineName?: string;comparisonIds: string[];+ /** The run order the table's cells colour by. See `useExperimentResultsState`. */+ colorExperimentIds: string[];selectedExperimentCount: number;onBaselineChange: (id: string) => void;onBaselineClear: () => void;@@ -30,6 +34,7 @@ export function ExperimentSelectionControls({baselineId,baselineName,comparisonIds,+ colorExperimentIds,selectedExperimentCount,onBaselineChange,onBaselineClear,@@ -112,10 +117,26 @@ export function ExperimentSelectionControls({captureComparisonChanged,]);+ // The same marker the cells put in front of a value, so the run whose values+ // are plain is named as the baseline here. Absent when the cells show no+ // colour at all, which is what an empty colour order means.+ const baselineMarkerClass =+ baselineId && colorExperimentIds.includes(baselineId)+ ? getExperimentColorStyles(baselineId, colorExperimentIds).markerClass+ : undefined;+return (<div className="flex w-[56dvw] min-w-0 flex-row gap-3"><div className="flex min-w-0 items-center">- <div className="border-input bg-muted/30 flex h-8 w-auto shrink-0 items-center rounded-l-md border px-3 text-xs">+ <div className="border-input bg-muted/30 flex h-8 w-auto shrink-0 items-center gap-1.5 rounded-l-md border px-3 text-xs">+ {baselineMarkerClass && (+ <span+ className={cn(+ "block h-3 w-0.5 shrink-0 rounded-full",+ baselineMarkerClass,+ )}+ />+ )}Baseline</div><div className="w-full max-w-64 min-w-0 flex-1">@@ -134,6 +155,7 @@ export function ExperimentSelectionControls({projectId={projectId}baselineExperimentId={baselineId}selectedIds={comparisonIds}+ colorExperimentIds={colorExperimentIds}selectedExperimentCount={selectedExperimentCount}onSelectedIdsChange={onComparisonIdsChange}isAutoSelectEnabled={isAutoSelectEnabled}diff --git a/web/src/features/experiments/components/table/ExperimentItemsTable.tsx b/web/src/features/experiments/components/table/ExperimentItemsTable.tsxindex 6d4448d0a7..341c45b4dc 100644--- a/web/src/features/experiments/components/table/ExperimentItemsTable.tsx+++ b/web/src/features/experiments/components/table/ExperimentItemsTable.tsx@@ -539,6 +539,7 @@ export default function ExperimentItemsTable({hasBaseline,comparisonIds,allExperimentIds,+ colorExperimentIds,layout,diffMode,itemVisibility,@@ -846,11 +847,6 @@ export default function ExperimentItemsTable({},);- const colorExperimentIds = useMemo(- () => (hasBaseline ? allExperimentIds : []),- [hasBaseline, allExperimentIds],- );-// A score column that is empty for every item in view is noise, so only keep// the keys the items query actually returned. Undefined while items load, so// columns don't disappear and come back on each fetch.@@ -2160,6 +2156,7 @@ export default function ExperimentItemsTable({rows={unfilteredRows}scoreRows={matrixScoreRows}experiments={matrixExperiments}+ colorExperimentIds={colorExperimentIds}isLoading={items.status === "loading" || isViewLoading}pagination={pagination}/>diff --git a/web/src/features/experiments/components/table/ExperimentScoreMatrix.clienttest.tsx b/web/src/features/experiments/components/table/ExperimentScoreMatrix.clienttest.tsxindex ebe7c4e273..51602f9d72 100644--- a/web/src/features/experiments/components/table/ExperimentScoreMatrix.clienttest.tsx+++ b/web/src/features/experiments/components/table/ExperimentScoreMatrix.clienttest.tsx@@ -49,6 +49,7 @@ const renderMatrix = ({rows={rows}scoreRows={scoreRows}experiments={experiments}+ colorExperimentIds={experiments.map((exp) => exp.experimentId)}isLoading={false}pagination={{ totalCount, onChange, state }}/>@@ -82,6 +83,7 @@ describe("ExperimentScoreMatrix pagination", () => {rows={[itemRow("a", 0.5)]}scoreRows={[]}experiments={experiments}+ colorExperimentIds={experiments.map((exp) => exp.experimentId)}isLoading={false}pagination={{totalCount: 6,diff --git a/web/src/features/experiments/components/table/ExperimentScoreMatrix.tsx b/web/src/features/experiments/components/table/ExperimentScoreMatrix.tsxindex 65c3c69008..ce115dd719 100644--- a/web/src/features/experiments/components/table/ExperimentScoreMatrix.tsx+++ b/web/src/features/experiments/components/table/ExperimentScoreMatrix.tsx@@ -116,12 +116,15 @@ export const ExperimentScoreMatrix = ({rows,scoreRows,experiments,+ colorExperimentIds,isLoading,pagination,}: {rows: ExperimentItemsTableRow[];scoreRows: ScoreMatrixRow[];experiments: ScoreMatrixColumn[];+ /** The run order every surface colours by. See `useExperimentResultsState`. */+ colorExperimentIds: string[];isLoading: boolean;pagination: {totalCount: number | null;@@ -209,8 +212,6 @@ export const ExperimentScoreMatrix = ({</div>);- const allExperimentIds = experiments.map((exp) => exp.experimentId);-// The empty state shares the footer, so the page controls stay reachable// when the items on this page happen to carry none of the visible scores.if (scoreRows.length === 0)@@ -242,22 +243,31 @@ export const ExperimentScoreMatrix = ({Score</th>{experiments.map((experiment) => {- const colorStyles = getExperimentColorStyles(+ // Same run, same colour as everywhere else — and no marker at+ // all when the colour order is empty, so this layout cannot+ // show a colour the run pickers do not name.+ const colorStyles = colorExperimentIds.includes(experiment.experimentId,- allExperimentIds,- );+ )+ ? getExperimentColorStyles(+ experiment.experimentId,+ colorExperimentIds,+ )+ : undefined;return (<thkey={experiment.experimentId}className="bg-background sticky top-0 z-10 min-w-[150px] border-b p-2 text-left font-normal"><span className="flex min-w-0 items-center gap-1">- <span- className={cn(- "block h-3 w-0.5 shrink-0 rounded-full",- colorStyles.markerClass,- )}- />+ {colorStyles && (+ <span+ className={cn(+ "block h-3 w-0.5 shrink-0 rounded-full",+ colorStyles.markerClass,+ )}+ />+ )}{/* No `baseline` badge: this column is already thefirst one and the only one whose cells carry nodelta, and a 150px header has room for the run'sdiff --git a/web/src/features/experiments/hooks/useExperimentResultsState.ts b/web/src/features/experiments/hooks/useExperimentResultsState.tsindex d4ce999cd7..c104cf1fb2 100644--- a/web/src/features/experiments/hooks/useExperimentResultsState.ts+++ b/web/src/features/experiments/hooks/useExperimentResultsState.ts@@ -182,6 +182,12 @@ export function useExperimentResultsState() {selectedExperimentIds,allExperimentIds: selectedExperimentIds,+ // The list `getExperimentColorStyles` indexes into, so the cells and the run+ // pickers cannot drift into two mappings. Empty without a baseline: colour+ // separates comparisons from the run they are measured against, and with no+ // baseline there is nothing to separate.+ colorExperimentIds: hasBaseline ? selectedExperimentIds : [],+// Layoutlayout,setLayout,diff --git a/web/src/pages/project/[projectId]/experiments/results.tsx b/web/src/pages/project/[projectId]/experiments/results.tsxindex 44f9032714..53a6f99ce9 100644--- a/web/src/pages/project/[projectId]/experiments/results.tsx+++ b/web/src/pages/project/[projectId]/experiments/results.tsx@@ -44,6 +44,7 @@ export default function ExperimentResults() {itemVisibility,setItemVisibility,allExperimentIds,+ colorExperimentIds,} = useExperimentResultsState();const [ioRenderMode, setIoRenderMode] = useIoRenderModeLocalStorage("experiment-items",@@ -139,6 +140,7 @@ export default function ExperimentResults() {baselineId={baselineId}baselineName={experiment?.name}comparisonIds={comparisonIds}+ colorExperimentIds={colorExperimentIds}selectedExperimentCount={allExperimentIds.length}onBaselineChange={setBaseline}onBaselineClear={clearBaseline}diff --git a/web/src/styles/globals.css b/web/src/styles/globals.cssindex f7874a8d16..6284ff2974 100644--- a/web/src/styles/globals.css+++ b/web/src/styles/globals.css@@ -528,7 +528,10 @@/* Status pairs: light-* are dark tinted backgrounds (alpha baked in),dark-* the readable text/icon color on them. */--light-red: oklch(39.6% 0.141 25.723 / 0.7);- --dark-red: oklch(57.7% 0.245 27.325);+ /* Lightened for dark mode like its green and yellow siblings below — left+ at the light-mode step it was darker than the fill it sits on (2.74:1;+ 5.35:1 here, against green's 6.49 and yellow's 6.43). */+ --dark-red: oklch(76.5% 0.177 27.325);--light-yellow: oklch(55.4% 0.135 66.442 / 0.4);--dark-yellow: oklch(79.5% 0.184 86.047);