🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(media): preserve dataset upload errors (#17674)
Max Deichmann6198f1932709
diff --git a/web/src/__tests__/server/dataset-item-media-references.servertest.ts b/web/src/__tests__/server/dataset-item-media-references.servertest.tsindex 72da0cfbf6..638a37dd83 100644--- a/web/src/__tests__/server/dataset-item-media-references.servertest.ts+++ b/web/src/__tests__/server/dataset-item-media-references.servertest.ts@@ -386,9 +386,12 @@ describe("Dataset item media tRPC procedures", () => {},);- it("rejects an upload for a dataset in another project", async () => {+ it("returns not found for a dataset outside the project", async () => {// datasetId is not a dataset in this project- await expect(requestUploadUrl({ datasetId: v4() })).rejects.toThrow();+ await expect(requestUploadUrl({ datasetId: v4() })).rejects.toMatchObject({+ code: "NOT_FOUND",+ message: expect.stringContaining("not found in project"),+ });});it("rejects uploads above the media size limit", async () => {diff --git a/web/src/features/media/server/mediaService.ts b/web/src/features/media/server/mediaService.tsindex e918ed400f..e7bbc8d0cc 100644--- a/web/src/features/media/server/mediaService.ts+++ b/web/src/features/media/server/mediaService.ts@@ -9,6 +9,7 @@ import {import {type DatasetItemMediaField,InternalServerError,+ isBaseError,LangfuseNotFoundError,MediaAssociationOrigin,} from "@langfuse/shared";@@ -128,11 +129,9 @@ export async function createMediaUploadUrl(params: {return GetMediaUploadUrlResponseSchema.parse({ mediaId, uploadUrl });} catch (error) {- if (error instanceof InternalServerError) throw error;+ if (isBaseError(error)) throw error;- logger.error(- `Failed to get media upload URL for trace ${traceId} and observation ${observationId}.`,- );+ logger.error("Failed to get media upload URL", error);throw new InternalServerError("Failed to get media upload URL");}}