🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(evals): escape LIKE wildcards in exact-match string filters (#19077)
Niklas Semmler625645eab28f
diff --git a/packages/shared/src/server/prismaFilter.test.ts b/packages/shared/src/server/prismaFilter.test.tsindex 7e04f53dfe..a35ffb2500 100644--- a/packages/shared/src/server/prismaFilter.test.ts+++ b/packages/shared/src/server/prismaFilter.test.ts@@ -66,6 +66,18 @@ describe("compilePrismaFilters", () => {});it("escapes LIKE wildcards in stringFilterToPrisma", () => {+ expect(+ stringFilterToPrisma({+ column: "name",+ type: "string",+ operator: "=",+ value: "gpt_4",+ }),+ ).toEqual({+ equals: "gpt\\_4",+ mode: "insensitive",+ });+expect(stringFilterToPrisma({column: "name",diff --git a/packages/shared/src/server/prismaFilter.ts b/packages/shared/src/server/prismaFilter.tsindex b70b9527bb..00474cb5fa 100644--- a/packages/shared/src/server/prismaFilter.ts+++ b/packages/shared/src/server/prismaFilter.ts@@ -35,11 +35,12 @@ export function stringFilterToPrisma(filter: StringFilter,): Prisma.StringFilter {const insensitive = { mode: "insensitive" as const };+ // Postgres runs every insensitive string filter, `equals` included, as an unescaped ILIKE.const escapedValue = escapeSqlLikePattern(filter.value);switch (filter.operator) {case "=":- return { equals: filter.value, ...insensitive };+ return { equals: escapedValue, ...insensitive };case "contains":return { contains: escapedValue, ...insensitive };case "does not contain":diff --git a/web/src/__tests__/server/evaluator-v2-repository.servertest.ts b/web/src/__tests__/server/evaluator-v2-repository.servertest.tsindex 3d1d5c9bab..1070a39edf 100644--- a/web/src/__tests__/server/evaluator-v2-repository.servertest.ts+++ b/web/src/__tests__/server/evaluator-v2-repository.servertest.ts@@ -1,5 +1,9 @@import { randomUUID } from "crypto";-import { getCodeEvalVariableMapping, LLMAdapter } from "@langfuse/shared";+import {+ getCodeEvalVariableMapping,+ LLMAdapter,+ type FilterState,+} from "@langfuse/shared";import { encrypt } from "@langfuse/shared/encryption";import { Prisma, prisma } from "@langfuse/shared/src/db";import { createOrgProjectAndApiKey } from "@langfuse/shared/src/server";@@ -282,6 +286,61 @@ describe("evaluator v2 repository", () => {expect(await searchNames("100%")).toEqual(["save 100% now"]);});+ it("matches LIKE wildcards literally in exact creator filters", async () => {+ const [literalCreator, wildcardMatch] = await Promise.all([+ prisma.user.create({+ data: { name: "creator_1", email: `${randomUUID()}@example.com` },+ }),+ prisma.user.create({+ data: { name: "creator-1", email: `${randomUUID()}@example.com` },+ }),+ ]);++ try {+ const matching = await createEvaluator({+ createdByUserId: literalCreator.id,+ });+ await createEvaluator({ createdByUserId: wildcardMatch.id });++ const listIds = async (filter: FilterState) => {+ const res = await evaluatorRepository.listEvaluators({+ prisma,+ projectId,+ page: 1,+ limit: 50,+ filter,+ });+ return res.evaluators.map((e) => e.id);+ };++ expect(+ await listIds([+ {+ column: "creator",+ type: "string",+ operator: "=",+ value: "creator_1",+ },+ ]),+ ).toEqual([matching.id]);+ expect(+ await listIds([+ {+ column: "creator",+ type: "stringOptions",+ operator: "any of",+ value: ["creator_1"],+ },+ ]),+ ).toEqual([matching.id]);+ } finally {+ await prisma.evaluator.deleteMany({ where: { projectId } });+ await prisma.user.deleteMany({+ where: { id: { in: [literalCreator.id, wildcardMatch.id] } },+ });+ }+ });+it("preserves default update order and supports explicit creation order", async () => {const [recentlyUpdated, newerButUnchanged] = await Promise.all([createEvaluator(),diff --git a/web/src/features/evals/v2/server/creatorFilterPrisma.ts b/web/src/features/evals/v2/server/creatorFilterPrisma.tsindex 9c5c8108bc..64068835a1 100644--- a/web/src/features/evals/v2/server/creatorFilterPrisma.ts+++ b/web/src/features/evals/v2/server/creatorFilterPrisma.ts@@ -1,5 +1,8 @@import type { FilterState } from "@langfuse/shared";-import { stringFilterToPrisma } from "@langfuse/shared/src/server";+import {+ escapeSqlLikePattern,+ stringFilterToPrisma,+} from "@langfuse/shared/src/server";type StringFilter = Extract<FilterState[number], { type: "string" }>;type StringOptionsFilter = Extract<@@ -48,10 +51,18 @@ export function creatorOptionsWhere(filter: StringOptionsFilter) {createdByUser: {is: {OR: [- { name: { equals: value, mode: "insensitive" as const } },+ {+ name: {+ equals: escapeSqlLikePattern(value),+ mode: "insensitive" as const,+ },+ },{name: null,- email: { equals: value, mode: "insensitive" as const },+ email: {+ equals: escapeSqlLikePattern(value),+ mode: "insensitive" as const,+ },},],},