🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(topics): allow large number of items on map (#18716)
Nimar65fdd26b9eca
diff --git a/packages/shared/AGENTS.md b/packages/shared/AGENTS.mdindex 2c3232990f..f749432c0e 100644--- a/packages/shared/AGENTS.md+++ b/packages/shared/AGENTS.md@@ -83,6 +83,8 @@Facet versions use `(projectId, facetId, version)`. Reads require a timerange; replacement includes the source minute, with run/origin suffixesfor assignments. Definition bounds retain original creation dates on reuse.+ `getLatestFacetSummaries` returns display fields; processing reads use+ `listTopicSummaries` or `getTopicClusteringSummaries` for complete summaries.- `execution-store.ts`: one BatchAction per request, compact counters and run references.Writes accept progress only; immutable settings stay in the stored request.Trace inputs and paid outputs belong outside the execution store.diff --git a/packages/shared/src/server/topics/clickhouse.ts b/packages/shared/src/server/topics/clickhouse.tsindex 8ce66060ca..c589c9b120 100644--- a/packages/shared/src/server/topics/clickhouse.ts+++ b/packages/shared/src/server/topics/clickhouse.ts@@ -303,21 +303,32 @@ const numberMap = (values: Record<string, number>) =>Object.fromEntries(Object.entries(values).map(([key, value]) => [key, Number(value)]),);-function summaryResult(row: SummaryRow): TopicSummary {- const { metadataJson, unitStartTimeMs, processedAtMs, ...rest } = row;+function summarySourceAndTimestamps(+ row: Pick<+ SummaryRow,+ "traceId" | "sessionId" | "unitStartTimeMs" | "processedAtMs"+ >,+) {return {- ...rest,...topicSourceSchema.parse({traceId: row.traceId || null,sessionId: row.sessionId || null,}),+ unitStartTime: new Date(Number(row.unitStartTimeMs)).toISOString(),+ processedAt: new Date(Number(row.processedAtMs)).toISOString(),+ };+}++function summaryResult(row: SummaryRow): TopicSummary {+ const { metadataJson, unitStartTimeMs, processedAtMs, ...rest } = row;+ return {+ ...rest,+ ...summarySourceAndTimestamps(row),providedUsageDetails: numberMap(row.providedUsageDetails),usageDetails: numberMap(row.usageDetails),providedCostDetails: numberMap(row.providedCostDetails),costDetails: numberMap(row.costDetails),metadata: JSON.parse(metadataJson),- unitStartTime: new Date(Number(unitStartTimeMs)).toISOString(),- processedAt: new Date(Number(processedAtMs)).toISOString(),};}@@ -361,17 +372,34 @@ export async function listTopicSummaries(.filter((row) => !isInternalEvalEnvironment(row.environment)).map(summaryResult);}-/** Without a version filter, use each source's newest processed facet version. */+/** Display fields only. Without a version filter, use each source's newest processed facet version. */export async function getLatestFacetSummaries(projectId: string,facetId: string,facetVersion: number | undefined,timeRange: TopicTimeRange,-): Promise<TopicSummary[]> {+) {const scopeSql = `facet_id = {facetId:String}${facetVersion ? "AND facet_version = {facetVersion:UInt32}" : ""}`;- const rows = await queryClickhouse<SummaryRow>({- query: `SELECT ${summaryColumns} FROM topic_facet_summaries+ const rows = await queryClickhouse<+ Pick<+ TopicSummary,+ | "projectId"+ | "facetId"+ | "facetVersion"+ | "traceId"+ | "sessionId"+ | "state"+ | "summary"+ | "environment"+ > & { unitStartTimeMs: string; processedAtMs: string }+ >({+ query: `SELECT project_id AS projectId, facet_id AS facetId,+ facet_version AS facetVersion, trace_id AS traceId, session_id AS sessionId,+ processing_state AS state, summary, environment,+ toUnixTimestamp64Milli(unit_start_time) AS unitStartTimeMs,+ toUnixTimestamp64Milli(processed_at) AS processedAtMs+ FROM topic_facet_summariesWHERE project_id = {projectId:String} AND ${unitTimeFilterSql} AND ${scopeSql}AND ${latestSummaryFilterSql(scopeSql, facetVersion ? sourceKeySql : summarySourceKeySql)}ORDER BY ${facetVersion ? "" : "facet_version DESC, "}processed_at DESC@@ -386,7 +414,14 @@ export async function getLatestFacetSummaries(});return rows.filter((row) => !isInternalEvalEnvironment(row.environment))- .map(summaryResult);+ .map((row) => ({+ projectId: row.projectId,+ facetId: row.facetId,+ facetVersion: row.facetVersion,+ state: row.state,+ summary: row.summary,+ ...summarySourceAndTimestamps(row),+ }));}export async function getTopicClusteringSummaries(diff --git a/web/src/features/topics/CurrentTopicsView.tsx b/web/src/features/topics/CurrentTopicsView.tsxindex 69645a7c11..62ad724a81 100644--- a/web/src/features/topics/CurrentTopicsView.tsx+++ b/web/src/features/topics/CurrentTopicsView.tsx@@ -41,11 +41,18 @@ export function CurrentTopicsView({setSelectedTraceId(null);setFilters(selectTopicTraceFilters(filters, topicId));}- const visible = filterTopicTraces(facet.rows, filters, searchQuery);- const isFiltered = filters.length > 0 || Boolean(searchQuery?.trim());- const matchingTraceKey = isFiltered- ? JSON.stringify([...new Set(visible.map((row) => row.traceId))].sort())- : null;+ const { visible, matchingTraceKey } = useMemo(() => {+ const isFiltered = filters.length > 0 || Boolean(searchQuery?.trim());+ const visible = isFiltered+ ? filterTopicTraces(facet.rows, filters, searchQuery)+ : facet.rows;+ return {+ visible,+ matchingTraceKey: isFiltered+ ? JSON.stringify([...new Set(visible.map((row) => row.traceId))].sort())+ : null,+ };+ }, [facet.rows, filters, searchQuery]);/** Frame identity changes only when matching IDs change, preserving hover and focus across refreshes. */const matchingTraceIds = useMemo(() =>diff --git a/web/src/features/topics/map/TopicMapCanvas.tsx b/web/src/features/topics/map/TopicMapCanvas.tsxindex 1407c9beaf..920ee3bf84 100644--- a/web/src/features/topics/map/TopicMapCanvas.tsx+++ b/web/src/features/topics/map/TopicMapCanvas.tsx@@ -244,13 +244,17 @@ function drawMap(context.globalAlpha = opacity;context.fillStyle = point.color;context.fill();- context.globalAlpha = node.backgroundOpacity * Math.min(1, opacity + 0.2);- context.fillStyle = surface;- context.fill();- context.globalAlpha = (node.strokeOpacity * 0.4 + active * 0.6) * opacity;- context.strokeStyle = point.color;- context.lineWidth = 1 + active;- context.stroke();+ if (node.backgroundOpacity > 0) {+ context.globalAlpha = node.backgroundOpacity * Math.min(1, opacity + 0.2);+ context.fillStyle = surface;+ context.fill();+ }+ if (node.strokeOpacity > 0 || active > 0) {+ context.globalAlpha = (node.strokeOpacity * 0.4 + active * 0.6) * opacity;+ context.strokeStyle = point.color;+ context.lineWidth = 1 + active;+ context.stroke();+ }if (active > 0.001) {context.globalAlpha = active * 0.7;context.lineWidth = 1.5;diff --git a/web/src/features/topics/server/currentResults.ts b/web/src/features/topics/server/currentResults.tsindex bb873cdabb..94e59ca48b 100644--- a/web/src/features/topics/server/currentResults.ts+++ b/web/src/features/topics/server/currentResults.ts@@ -11,7 +11,19 @@ import {readLatestTopicAssignments,} from "@langfuse/shared/topics/server";-function resolveTopicResult(summary: TopicSummary, stored?: TopicAssignment) {+function resolveTopicResult(+ summary: Pick<+ TopicSummary,+ | "projectId"+ | "facetId"+ | "facetVersion"+ | "traceId"+ | "unitStartTime"+ | "processedAt"+ | "state"+ >,+ stored?: TopicAssignment,+) {const assignment =summary.state === "complete" &&stored?.projectId === summary.projectId &&diff --git a/worker/src/features/topics/storage.integration.test.ts b/worker/src/features/topics/storage.integration.test.tsindex 994eef2cf3..6008c45a5e 100644--- a/worker/src/features/topics/storage.integration.test.ts+++ b/worker/src/features/topics/storage.integration.test.ts@@ -548,10 +548,28 @@ describe("Topics definition persistence", () => {},{ ...latest, facetId: "other-facet", facetVersion: 2 },]);+ const displaySummary = {+ projectId: summary.projectId,+ facetId: summary.facetId,+ facetVersion: summary.facetVersion,+ traceId: summary.traceId,+ sessionId: summary.sessionId,+ state: summary.state,+ summary: summary.summary,+ unitStartTime: summary.unitStartTime,+ processedAt: summary.processedAt,+ };for (const version of [1, undefined])expect(await getLatestFacetSummaries(projectId, "facet", version, oldRange),- ).toEqual([latest]);+ ).toEqual([+ {+ ...displaySummary,+ summary: latest.summary,+ sessionId: latest.sessionId,+ processedAt: latest.processedAt,+ },+ ]);const moved: TopicSummary = {...summary,@@ -588,13 +606,27 @@ describe("Topics definition persistence", () => {await writeTopicSummaries([newerVersion]);expect(await getLatestFacetSummaries(projectId, "facet", undefined, oldRange),- ).toEqual([newerVersion]);+ ).toEqual([+ {+ ...displaySummary,+ facetVersion: newerVersion.facetVersion,+ processedAt: newerVersion.processedAt,+ },+ ]);expect(await getLatestFacetSummaries(projectId, "facet", undefined, newRange),).toEqual([]);expect(await getLatestFacetSummaries(projectId, "facet", 1, newRange),- ).toEqual([moved]);+ ).toEqual([+ {+ ...displaySummary,+ unitStartTime: moved.unitStartTime,+ processedAt: moved.processedAt,+ state: moved.state,+ summary: moved.summary,+ },+ ]);const internalFacet = "internal-environments";const internalTraces = [